mbox series

[v2,0/6] dpdk-devbind: python lint cleanups

Message ID 20201104070350.28224-1-stephen@networkplumber.org (mailing list archive)
Headers
Series dpdk-devbind: python lint cleanups |

Message

Stephen Hemminger Nov. 4, 2020, 7:03 a.m. UTC 
  This addresses several warnings from python3 lint.
Split out from earlier patchset

Stephen Hemminger (6):
  dpdk-devbind: use argparse instead of getopt
  dpdk-devbind: fix indentation
  dpdk-devbind: fix python lint warnings for imports
  dpdk-devbind: do not use len(x) to test for empty
  dpdk-devbind: fix unnecessary else after return
  dpdk-devbind: use in to test for multiple strings

 usertools/dpdk-devbind.py | 315 +++++++++++++++++---------------------
 1 file changed, 142 insertions(+), 173 deletions(-)

Comments

Bruce Richardson Nov. 4, 2020, 9:28 a.m. UTC | #1 
On Tue, Nov 03, 2020 at 11:03:44PM -0800, Stephen Hemminger wrote:
> This addresses several warnings from python3 lint.
> Split out from earlier patchset
> 
> Stephen Hemminger (6):
>   dpdk-devbind: use argparse instead of getopt
>   dpdk-devbind: fix indentation
>   dpdk-devbind: fix python lint warnings for imports
>   dpdk-devbind: do not use len(x) to test for empty
>   dpdk-devbind: fix unnecessary else after return
>   dpdk-devbind: use in to test for multiple strings
> 
>  usertools/dpdk-devbind.py | 315 +++++++++++++++++---------------------
>  1 file changed, 142 insertions(+), 173 deletions(-)
> 
Series-acked-by: Bruce Richardson <bruce.richardson@intel.com>
Stephen Hemminger Nov. 4, 2020, 4:57 p.m. UTC | #2 
On Tue,  3 Nov 2020 23:03:44 -0800
Stephen Hemminger <stephen@networkplumber.org> wrote:

> This addresses several warnings from python3 lint.
> Split out from earlier patchset
> 
> Stephen Hemminger (6):
>   dpdk-devbind: use argparse instead of getopt
>   dpdk-devbind: fix indentation
>   dpdk-devbind: fix python lint warnings for imports
>   dpdk-devbind: do not use len(x) to test for empty
>   dpdk-devbind: fix unnecessary else after return
>   dpdk-devbind: use in to test for multiple strings
> 
>  usertools/dpdk-devbind.py | 315 +++++++++++++++++---------------------
>  1 file changed, 142 insertions(+), 173 deletions(-)
> 

There are some typos in the commit messages.
Can send new version, or you can fix/leave them
Thomas Monjalon Nov. 22, 2020, 9:03 p.m. UTC | #3 
04/11/2020 10:28, Bruce Richardson:
> On Tue, Nov 03, 2020 at 11:03:44PM -0800, Stephen Hemminger wrote:
> > This addresses several warnings from python3 lint.
> > Split out from earlier patchset
> > 
> > Stephen Hemminger (6):
> >   dpdk-devbind: use argparse instead of getopt
> >   dpdk-devbind: fix indentation
> >   dpdk-devbind: fix python lint warnings for imports
> >   dpdk-devbind: do not use len(x) to test for empty
> >   dpdk-devbind: fix unnecessary else after return
> >   dpdk-devbind: use in to test for multiple strings
> > 
> >  usertools/dpdk-devbind.py | 315 +++++++++++++++++---------------------
> >  1 file changed, 142 insertions(+), 173 deletions(-)
> > 
> Series-acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks