[v2] test: fix GMAC SGL test
Checks
Commit Message
This patch fixes the GMAC SGL test that fails to bypass
unsupported PMDs.
Fixes: dcdd01691f39 ("test/crypto: add GMAC SGL")
Cc: pablo.de.lara.guarch@intel.com
Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
v2:
- fix typo
app/test/test_cryptodev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
Tested-by: JiangYuX <yux.jiang@intel.com>
Best Regards
Jiang yu
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Fan Zhang
> Sent: Thursday, October 29, 2020 10:47 PM
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; Zhang, Roy Fan <roy.fan.zhang@intel.com>; De
> Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [dpdk-dev] [dpdk-dev v2] test: fix GMAC SGL test
>
> This patch fixes the GMAC SGL test that fails to bypass unsupported PMDs.
>
> Fixes: dcdd01691f39 ("test/crypto: add GMAC SGL")
> Cc: pablo.de.lara.guarch@intel.com
>
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
> v2:
> - fix typo
> app/test/test_cryptodev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index
> 0fed124d3..130719d67 100644
> --- a/app/test/test_cryptodev.c
> +++ b/app/test/test_cryptodev.c
> @@ -11069,8 +11069,8 @@ test_AES_GMAC_authentication_SGL(const
> struct gmac_test_data *tdata,
> rte_cryptodev_info_get(ts_params->valid_devs[0], &dev_info);
> feature_flags = dev_info.feature_flags;
>
> - if ((!(feature_flags & RTE_CRYPTODEV_FF_IN_PLACE_SGL)) &&
> - (!(feature_flags &
> RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT)) &&
> + if ((!(feature_flags & RTE_CRYPTODEV_FF_IN_PLACE_SGL)) ||
> + (!(feature_flags &
> RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT)) ||
> (!(feature_flags &
> RTE_CRYPTODEV_FF_OOP_SGL_IN_SGL_OUT)))
> return -ENOTSUP;
>
> --
> 2.26.2
> -----Original Message-----
> From: Zhang, Roy Fan <roy.fan.zhang@intel.com>
> Sent: Thursday, October 29, 2020 2:47 PM
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; Zhang, Roy Fan <roy.fan.zhang@intel.com>; De Lara
> Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [dpdk-dev v2] test: fix GMAC SGL test
>
> This patch fixes the GMAC SGL test that fails to bypass unsupported PMDs.
>
> Fixes: dcdd01691f39 ("test/crypto: add GMAC SGL")
> Cc: pablo.de.lara.guarch@intel.com
>
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
Commit message can be changed to "test/crypto: fix GMAC SGL", but I think it can be changed when applying the patch.
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > Subject: [dpdk-dev v2] test: fix GMAC SGL test
> >
> > This patch fixes the GMAC SGL test that fails to bypass unsupported PMDs.
> >
> > Fixes: dcdd01691f39 ("test/crypto: add GMAC SGL")
> > Cc: pablo.de.lara.guarch@intel.com
> >
> > Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
>
> Commit message can be changed to "test/crypto: fix GMAC SGL", but I think it
> can be changed when applying the patch.
>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Applied to dpdk-next-crypto
Thanks.
@@ -11069,8 +11069,8 @@ test_AES_GMAC_authentication_SGL(const struct gmac_test_data *tdata,
rte_cryptodev_info_get(ts_params->valid_devs[0], &dev_info);
feature_flags = dev_info.feature_flags;
- if ((!(feature_flags & RTE_CRYPTODEV_FF_IN_PLACE_SGL)) &&
- (!(feature_flags & RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT)) &&
+ if ((!(feature_flags & RTE_CRYPTODEV_FF_IN_PLACE_SGL)) ||
+ (!(feature_flags & RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT)) ||
(!(feature_flags & RTE_CRYPTODEV_FF_OOP_SGL_IN_SGL_OUT)))
return -ENOTSUP;