examples/vm_power: fix resource leak on error path
Checks
Commit Message
From: Yunjian Wang <wangyunjian@huawei.com>
This patch fixes the resource leaks reported by coverity.
Coverity issue: 337674
Fixes: 95f648ff9eed ("examples/vm_power: make branch ratio threshold per core")
Cc: stable@dpdk.org
Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
---
examples/vm_power_manager/main.c | 1 +
1 file changed, 1 insertion(+)
Comments
Hi wangyunjian,
On 19/8/2020 1:54 PM, wangyunjian wrote:
> From: Yunjian Wang <wangyunjian@huawei.com>
>
> This patch fixes the resource leaks reported by coverity.
>
> Coverity issue: 337674
> Fixes: 95f648ff9eed ("examples/vm_power: make branch ratio threshold per core")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> ---
> examples/vm_power_manager/main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/examples/vm_power_manager/main.c b/examples/vm_power_manager/main.c
> index 3a8958058..6422d7b99 100644
> --- a/examples/vm_power_manager/main.c
> +++ b/examples/vm_power_manager/main.c
> @@ -206,6 +206,7 @@ parse_args(int argc, char **argv)
> }
> if (branch_ratio <= 0.0 || branch_ratio > 100.0) {
> printf("invalid branch ratio specified\n");
> + free(oob_enable);
> return -1;
> }
> for (i = 0; i < ci->core_count; i++) {
Acked-by: David Hunt <david.hunt@intel.com>
On Wed, Aug 19, 2020 at 2:55 PM wangyunjian <wangyunjian@huawei.com> wrote:
>
> From: Yunjian Wang <wangyunjian@huawei.com>
>
> This patch fixes the resource leaks reported by coverity.
>
> Coverity issue: 337674
> Fixes: 95f648ff9eed ("examples/vm_power: make branch ratio threshold per core")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
This is a duplicate of https://patchwork.dpdk.org/patch/74985/.
Took the patch from Rory as it predates this one.
@@ -206,6 +206,7 @@ parse_args(int argc, char **argv)
}
if (branch_ratio <= 0.0 || branch_ratio > 100.0) {
printf("invalid branch ratio specified\n");
+ free(oob_enable);
return -1;
}
for (i = 0; i < ci->core_count; i++) {