net/ice: fix SCTP RSS configuration

Message ID 20201020085051.47073-1-junyux.jiang@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Qi Zhang
Headers
Series net/ice: fix SCTP RSS configuration |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/travis-robot success Travis build: passed

Commit Message

Junyu Jiang Oct. 20, 2020, 8:50 a.m. UTC
  This patch configured RSS for sctp with IP address
and port as input set.

Fixes: 4717a12cfaf1 ("net/ice: initialize and update RSS based on user config")
Cc: stable@dpdk.org

Signed-off-by: Junyu Jiang <junyux.jiang@intel.com>
---
 drivers/net/ice/ice_ethdev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
  

Comments

Qi Zhang Oct. 20, 2020, 10:25 a.m. UTC | #1
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Junyu Jiang
> Sent: Tuesday, October 20, 2020 4:51 PM
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Su, Simei <simei.su@intel.com>;
> Jiang, JunyuX <junyux.jiang@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/ice: fix SCTP RSS configuration
> 
> This patch configured RSS for sctp with IP address and port as input set.
> 
> Fixes: 4717a12cfaf1 ("net/ice: initialize and update RSS based on user config")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Junyu Jiang <junyux.jiang@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi
  
Xie, WeiX Oct. 23, 2020, 8:04 a.m. UTC | #2
Tested-by:  Xie,WeiX < weix.xie@intel.com>

Regards,
Xie Wei

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Junyu Jiang
> Sent: Tuesday, October 20, 2020 4:51 PM
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Su, Simei <simei.su@intel.com>;
> Jiang, JunyuX <junyux.jiang@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/ice: fix SCTP RSS configuration
> 
> This patch configured RSS for sctp with IP address and port as input set.
> 
> Fixes: 4717a12cfaf1 ("net/ice: initialize and update RSS based on user config")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Junyu Jiang <junyux.jiang@intel.com>
> ---
>  drivers/net/ice/ice_ethdev.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
> index 0056da78a..63138d3b9 100644
> --- a/drivers/net/ice/ice_ethdev.c
> +++ b/drivers/net/ice/ice_ethdev.c
> @@ -2987,7 +2987,7 @@ ice_rss_hash_set(struct ice_pf *pf, uint64_t rss_hf)
> 
>  	/* Configure RSS for sctp4 with src/dst addr and port as input set */
>  	if (rss_hf & ETH_RSS_NONFRAG_IPV4_SCTP) {
> -		ret = ice_add_rss_cfg_wrap(pf, vsi->idx,
> ICE_FLOW_HASH_IPV4,
> +		ret = ice_add_rss_cfg_wrap(pf, vsi->idx,
> ICE_HASH_SCTP_IPV4,
>  				      ICE_FLOW_SEG_HDR_SCTP |
>  				      ICE_FLOW_SEG_HDR_IPV4 |
>  				      ICE_FLOW_SEG_HDR_IPV_OTHER, 0); @@
> -2998,7 +2998,7 @@ ice_rss_hash_set(struct ice_pf *pf, uint64_t rss_hf)
> 
>  	/* Configure RSS for sctp6 with src/dst addr and port as input set */
>  	if (rss_hf & ETH_RSS_NONFRAG_IPV6_SCTP) {
> -		ret = ice_add_rss_cfg_wrap(pf, vsi->idx,
> ICE_FLOW_HASH_IPV6,
> +		ret = ice_add_rss_cfg_wrap(pf, vsi->idx,
> ICE_HASH_SCTP_IPV6,
>  				      ICE_FLOW_SEG_HDR_SCTP |
>  				      ICE_FLOW_SEG_HDR_IPV6 |
>  				      ICE_FLOW_SEG_HDR_IPV_OTHER, 0);
> --
> 2.17.1
  

Patch

diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index 0056da78a..63138d3b9 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -2987,7 +2987,7 @@  ice_rss_hash_set(struct ice_pf *pf, uint64_t rss_hf)
 
 	/* Configure RSS for sctp4 with src/dst addr and port as input set */
 	if (rss_hf & ETH_RSS_NONFRAG_IPV4_SCTP) {
-		ret = ice_add_rss_cfg_wrap(pf, vsi->idx, ICE_FLOW_HASH_IPV4,
+		ret = ice_add_rss_cfg_wrap(pf, vsi->idx, ICE_HASH_SCTP_IPV4,
 				      ICE_FLOW_SEG_HDR_SCTP |
 				      ICE_FLOW_SEG_HDR_IPV4 |
 				      ICE_FLOW_SEG_HDR_IPV_OTHER, 0);
@@ -2998,7 +2998,7 @@  ice_rss_hash_set(struct ice_pf *pf, uint64_t rss_hf)
 
 	/* Configure RSS for sctp6 with src/dst addr and port as input set */
 	if (rss_hf & ETH_RSS_NONFRAG_IPV6_SCTP) {
-		ret = ice_add_rss_cfg_wrap(pf, vsi->idx, ICE_FLOW_HASH_IPV6,
+		ret = ice_add_rss_cfg_wrap(pf, vsi->idx, ICE_HASH_SCTP_IPV6,
 				      ICE_FLOW_SEG_HDR_SCTP |
 				      ICE_FLOW_SEG_HDR_IPV6 |
 				      ICE_FLOW_SEG_HDR_IPV_OTHER, 0);