Message ID | 20200929102224.440322-1-kevin.laatz@intel.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 49A4FA04C0; Tue, 29 Sep 2020 12:27:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2FA581D15F; Tue, 29 Sep 2020 12:27:12 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 598C71BED3 for <dev@dpdk.org>; Tue, 29 Sep 2020 12:27:10 +0200 (CEST) IronPort-SDR: 7CDWBt0shq1ppcAuHWShKJRwBWi4EJSb0BfeUFBtW6O84nmvHH120i+XPd+Uk0KQ6SALAGMTXP Q9D4Fel9tUUw== X-IronPort-AV: E=McAfee;i="6000,8403,9758"; a="149817648" X-IronPort-AV: E=Sophos;i="5.77,318,1596524400"; d="scan'208";a="149817648" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2020 03:27:05 -0700 IronPort-SDR: r0XtOgCcqO3OdGH49/AuqzDo4t12Z8mYl4amepMuCFf+jGfD89kaCOM9056Kxr2uBfoJ32h63T 4+aWnsmwljzQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,318,1596524400"; d="scan'208";a="514628357" Received: from silpixa00399838.ir.intel.com ([10.237.213.224]) by fmsmga005.fm.intel.com with ESMTP; 29 Sep 2020 03:27:03 -0700 From: Kevin Laatz <kevin.laatz@intel.com> To: dev@dpdk.org Cc: bruce.richardson@intel.com, anatoly.burakov@intel.com, robin.jarry@6wind.com, david.marchand@redhat.com, Kevin Laatz <kevin.laatz@intel.com> Date: Tue, 29 Sep 2020 11:22:13 +0100 Message-Id: <20200929102224.440322-1-kevin.laatz@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200928104328.409055-1-kevin.laatz@intel.com> References: <20200928104328.409055-1-kevin.laatz@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v9 00/11] adding support for python 3 only X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
adding support for python 3 only
|
|
Message
Kevin Laatz
Sept. 29, 2020, 10:22 a.m. UTC
This patch set converts all python scripts in the project to use python3 only and removes all deprecation notices associated with these changes. This is due to python2 being EOL in January 2020. --- v6: - rebased, removing conflict with make removal patchset. - added changes to buildtools/map_to_win.py v7: - typo in email Cc'ing David Marchand - added maintainers for buildtools patch v8: - removed unrelated cleanup - replaced integer cast with integer division operator v9: - include documentation updates Kevin Laatz (4): app/test-cmdline: support python3 only app/test: support python3 only buildtools: support python3 only doc: support python3 only Louise Kilheeney (7): usertools/dpdk-telemetry-client: support python3 only usertools/dpdk-devbind: support python3 only usertools/dpdk-pmdinfo: support python3 only usertools/cpu_layout: support python3 only devtools: support python3 only config/arm: support python3 only app/test-bbdev: support python3 only app/test-bbdev/test-bbdev.py | 7 +------ app/test-cmdline/cmdline_test.py | 9 ++------- app/test-cmdline/cmdline_test_data.py | 1 + app/test/autotest.py | 7 +------ app/test/autotest_data.py | 1 + app/test/autotest_runner.py | 21 ++++++++------------- app/test/autotest_test_funcs.py | 1 + buildtools/map_to_win.py | 3 +-- config/arm/armv8_machine.py | 2 +- devtools/update_version_map_abi.py | 7 +------ doc/guides/contributing/coding_style.rst | 2 +- doc/guides/linux_gsg/sys_reqs.rst | 2 +- doc/guides/rel_notes/deprecation.rst | 6 ------ doc/guides/rel_notes/release_20_11.rst | 2 ++ usertools/cpu_layout.py | 13 ++----------- usertools/dpdk-devbind.py | 22 ++++------------------ usertools/dpdk-pmdinfo.py | 7 +------ usertools/dpdk-telemetry-client.py | 18 +++--------------- 18 files changed, 32 insertions(+), 99 deletions(-)
Comments
Hello Kevin, On Tue, Sep 29, 2020 at 12:27 PM Kevin Laatz <kevin.laatz@intel.com> wrote: > > This patch set converts all python scripts in the project to use > python3 only and removes all deprecation notices associated with these > changes. This is due to python2 being EOL in January 2020. > > --- > v6: > - rebased, removing conflict with make removal patchset. > - added changes to buildtools/map_to_win.py > > v7: > - typo in email Cc'ing David Marchand > - added maintainers for buildtools patch > > v8: > - removed unrelated cleanup > - replaced integer cast with integer division operator > > v9: > - include documentation updates > > Kevin Laatz (4): > app/test-cmdline: support python3 only > app/test: support python3 only > buildtools: support python3 only > doc: support python3 only > > Louise Kilheeney (7): > usertools/dpdk-telemetry-client: support python3 only > usertools/dpdk-devbind: support python3 only > usertools/dpdk-pmdinfo: support python3 only > usertools/cpu_layout: support python3 only > devtools: support python3 only > config/arm: support python3 only > app/test-bbdev: support python3 only I can still see one issue in doc/guides/conf.py as you mentioned yesterday. There is also a script that directly calls /usr/bin/python3, worth fixing from my pov. $ for file in $(find app/ buildtools/ config/ devtools/ doc/ drivers/ examples/ kernel/ lib/ license/ usertools/ -name "*.py"); do head -1 $file |grep -q env.*python3 || echo $file; done doc/guides/conf.py usertools/dpdk-telemetry.py
On Tue, 29 Sep 2020 11:22:13 +0100 Kevin Laatz <kevin.laatz@intel.com> wrote: > This patch set converts all python scripts in the project to use > python3 only and removes all deprecation notices associated with these > changes. This is due to python2 being EOL in January 2020. > > --- > v6: > - rebased, removing conflict with make removal patchset. > - added changes to buildtools/map_to_win.py > > v7: > - typo in email Cc'ing David Marchand > - added maintainers for buildtools patch > > v8: > - removed unrelated cleanup > - replaced integer cast with integer division operator > > v9: > - include documentation updates > > Kevin Laatz (4): > app/test-cmdline: support python3 only > app/test: support python3 only > buildtools: support python3 only > doc: support python3 only > > Louise Kilheeney (7): > usertools/dpdk-telemetry-client: support python3 only > usertools/dpdk-devbind: support python3 only > usertools/dpdk-pmdinfo: support python3 only > usertools/cpu_layout: support python3 only > devtools: support python3 only > config/arm: support python3 only > app/test-bbdev: support python3 only > > app/test-bbdev/test-bbdev.py | 7 +------ > app/test-cmdline/cmdline_test.py | 9 ++------- > app/test-cmdline/cmdline_test_data.py | 1 + > app/test/autotest.py | 7 +------ > app/test/autotest_data.py | 1 + > app/test/autotest_runner.py | 21 ++++++++------------- > app/test/autotest_test_funcs.py | 1 + > buildtools/map_to_win.py | 3 +-- > config/arm/armv8_machine.py | 2 +- > devtools/update_version_map_abi.py | 7 +------ > doc/guides/contributing/coding_style.rst | 2 +- > doc/guides/linux_gsg/sys_reqs.rst | 2 +- > doc/guides/rel_notes/deprecation.rst | 6 ------ > doc/guides/rel_notes/release_20_11.rst | 2 ++ > usertools/cpu_layout.py | 13 ++----------- > usertools/dpdk-devbind.py | 22 ++++------------------ > usertools/dpdk-pmdinfo.py | 7 +------ > usertools/dpdk-telemetry-client.py | 18 +++--------------- > 18 files changed, 32 insertions(+), 99 deletions(-) Looks good Ack for whole series Acked-by: Stephen Hemminger <stephen@networkplumber.org>
On 29/09/2020 13:22, David Marchand wrote: > Hello Kevin, > > On Tue, Sep 29, 2020 at 12:27 PM Kevin Laatz <kevin.laatz@intel.com> wrote: >> This patch set converts all python scripts in the project to use >> python3 only and removes all deprecation notices associated with these >> changes. This is due to python2 being EOL in January 2020. >> >> --- >> v6: >> - rebased, removing conflict with make removal patchset. >> - added changes to buildtools/map_to_win.py >> >> v7: >> - typo in email Cc'ing David Marchand >> - added maintainers for buildtools patch >> >> v8: >> - removed unrelated cleanup >> - replaced integer cast with integer division operator >> >> v9: >> - include documentation updates >> >> Kevin Laatz (4): >> app/test-cmdline: support python3 only >> app/test: support python3 only >> buildtools: support python3 only >> doc: support python3 only >> >> Louise Kilheeney (7): >> usertools/dpdk-telemetry-client: support python3 only >> usertools/dpdk-devbind: support python3 only >> usertools/dpdk-pmdinfo: support python3 only >> usertools/cpu_layout: support python3 only >> devtools: support python3 only >> config/arm: support python3 only >> app/test-bbdev: support python3 only Hi David, > I can still see one issue in doc/guides/conf.py as you mentioned yesterday. > There is also a script that directly calls /usr/bin/python3, worth > fixing from my pov. > > $ for file in $(find app/ buildtools/ config/ devtools/ doc/ drivers/ > examples/ kernel/ lib/ license/ usertools/ -name "*.py"); do head -1 > $file |grep -q env.*python3 || echo $file; done > doc/guides/conf.py > usertools/dpdk-telemetry.py doc/guides/conf.py is indirectly called from sphinx which potentially causes some compatibilty issues when we make conf.py only support python3 (if sphinx in using python2) - this is why I left this out of the patchset, otherwise the doc build will be broken :-( I can change direct call to /usr/bin/python3. -Kevin
On Tue, Sep 29, 2020 at 04:25:40PM +0100, Kevin Laatz wrote: > On 29/09/2020 13:22, David Marchand wrote: > > Hello Kevin, > > > > On Tue, Sep 29, 2020 at 12:27 PM Kevin Laatz <kevin.laatz@intel.com> wrote: > > > This patch set converts all python scripts in the project to use > > > python3 only and removes all deprecation notices associated with these > > > changes. This is due to python2 being EOL in January 2020. > > > > > > --- > > > v6: > > > - rebased, removing conflict with make removal patchset. > > > - added changes to buildtools/map_to_win.py > > > > > > v7: > > > - typo in email Cc'ing David Marchand > > > - added maintainers for buildtools patch > > > > > > v8: > > > - removed unrelated cleanup > > > - replaced integer cast with integer division operator > > > > > > v9: > > > - include documentation updates > > > > > > Kevin Laatz (4): > > > app/test-cmdline: support python3 only > > > app/test: support python3 only > > > buildtools: support python3 only > > > doc: support python3 only > > > > > > Louise Kilheeney (7): > > > usertools/dpdk-telemetry-client: support python3 only > > > usertools/dpdk-devbind: support python3 only > > > usertools/dpdk-pmdinfo: support python3 only > > > usertools/cpu_layout: support python3 only > > > devtools: support python3 only > > > config/arm: support python3 only > > > app/test-bbdev: support python3 only > > Hi David, > > > I can still see one issue in doc/guides/conf.py as you mentioned yesterday. > > There is also a script that directly calls /usr/bin/python3, worth > > fixing from my pov. > > > > $ for file in $(find app/ buildtools/ config/ devtools/ doc/ drivers/ > > examples/ kernel/ lib/ license/ usertools/ -name "*.py"); do head -1 > > $file |grep -q env.*python3 || echo $file; done > > doc/guides/conf.py > > usertools/dpdk-telemetry.py > > doc/guides/conf.py is indirectly called from sphinx which potentially causes some compatibilty issues when we make conf.py only support python3 (if sphinx in using python2) - this is why I left this out of the patchset, otherwise the doc build will be broken :-( > > I can change direct call to /usr/bin/python3. > I think we should err on the side of caution for the doc one - it can always be changed by a later patch anyway. Cleaning up the dpdk-telemetry one is probably worth doing though, I agree. /Bruce
2020-09-29, Bruce Richardson: > I think we should err on the side of caution for the doc one - it can > always be changed by a later patch anyway. Cleaning up the > dpdk-telemetry one is probably worth doing though, I agree. I'm not sure I agree. Since python 2 support is officially dropped in 20.11. Why bother with preserving it only for the docs?
On Tue, Sep 29, 2020 at 05:54:53PM +0200, Robin Jarry wrote: > 2020-09-29, Bruce Richardson: > > I think we should err on the side of caution for the doc one - it can > > always be changed by a later patch anyway. Cleaning up the > > dpdk-telemetry one is probably worth doing though, I agree. > > I'm not sure I agree. Since python 2 support is officially dropped in > 20.11. Why bother with preserving it only for the docs? > Because we are not building the docs directly, sphinx is, and some systems may still have a python2 version of sphinx installed. While I think it's ok to say that to use DPDK you need to have python3 available, I don't like telling users that their entire toolset needs to be updated to python3 too. From what I can see, Centos/Redhat 7, which we still support, appears to only have a python2 version of sphinx-build. /Bruce