diff mbox series

[07/12] net/bnxt: increase max burst size for vector mode

Message ID	20200909155302.28656-8-lance.richardson@broadcom.com (mailing list archive)
State	Accepted, archived
Delegated to:	Ajit Khaparde
Headers	From: Lance Richardson <lance.richardson@broadcom.com> To: Ajit Khaparde <ajit.khaparde@broadcom.com>, Somnath Kotur <somnath.kotur@broadcom.com> Cc: dev@dpdk.org, Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com> Date: Wed, 9 Sep 2020 11:53:00 -0400 Message-Id: <20200909155302.28656-8-lance.richardson@broadcom.com> In-Reply-To: <20200909155302.28656-1-lance.richardson@broadcom.com> References: <20200909155302.28656-1-lance.richardson@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 07/12] net/bnxt: increase max burst size for vector mode Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	net/bnxt: vector PMD improvements \| [00/12] net/bnxt: vector PMD improvements [01/12] net/bnxt: fix burst mode get for Arm [02/12] net/bnxt: fix rxq/txq get information [03/12] net/bnxt: use appropriate type for Rx mbuf ring [04/12] net/bnxt: require async cq for vector mode [05/12] net/bnxt: improve support for small ring sizes [06/12] net/bnxt: use smaller cq when agg ring not needed [07/12] net/bnxt: increase max burst size for vector mode [08/12] net/bnxt: use table-based packet type translation [09/12] net/bnxt: table-based handling for ol flags [10/12] net/bnxt: optimize vector mode mbuf allocation [11/12] net/bnxt: handle multiple packets per loop in vector PMD [12/12] net/bnxt: transmit vector mode improvements

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Lance Richardson Sept. 9, 2020, 3:53 p.m. UTC

  Increase the maximum supported burst size for the bnxt vector
mode PMD from 32 to 64.

Reviewed-by: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
---
 drivers/net/bnxt/bnxt_rxtx_vec_common.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Ferruh Yigit Sept. 11, 2020, 3:19 p.m. UTC | #1

On 9/9/2020 4:53 PM, Lance Richardson wrote:
> Increase the maximum supported burst size for the bnxt vector
> mode PMD from 32 to 64.

What is the motivation here? Like does it improve the performance? If so in
which conditions etc.. It would be nice to describe the why & impact.

> 
> Reviewed-by: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>
> Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
> Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
> ---
>  drivers/net/bnxt/bnxt_rxtx_vec_common.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/bnxt/bnxt_rxtx_vec_common.h b/drivers/net/bnxt/bnxt_rxtx_vec_common.h
> index 2f28759d06..fc2a12272b 100644
> --- a/drivers/net/bnxt/bnxt_rxtx_vec_common.h
> +++ b/drivers/net/bnxt/bnxt_rxtx_vec_common.h
> @@ -9,8 +9,8 @@
>  #include "bnxt_rxq.h"
>  #include "bnxt_rxr.h"
>  
> -#define RTE_BNXT_MAX_RX_BURST		32U
> -#define RTE_BNXT_MAX_TX_BURST		32U
> +#define RTE_BNXT_MAX_RX_BURST		64U
> +#define RTE_BNXT_MAX_TX_BURST		64U
>  #define RTE_BNXT_DESCS_PER_LOOP		4U
>  
>  #define TX_BD_FLAGS_CMPL ((1 << TX_BD_LONG_FLAGS_BD_CNT_SFT) | \
>

Lance Richardson Sept. 11, 2020, 3:38 p.m. UTC | #2

On Fri, Sep 11, 2020 at 11:19 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 9/9/2020 4:53 PM, Lance Richardson wrote:
> > Increase the maximum supported burst size for the bnxt vector
> > mode PMD from 32 to 64.
>
> What is the motivation here? Like does it improve the performance? If so in
> which conditions etc.. It would be nice to describe the why & impact.
>

How about this:

    net/bnxt: increase max burst size for vector mode

    Increase the maximum supported burst size for the bnxt vector
    mode PMD from 32 to 64. With larger burst sizes, per-burst
    overhead is amortized over more packets, improving overall
    performance. For small packets this has been measured to
    provide a 4-10% increase in single-core throughput with
    testpmd iofwd.

Thanks,
    Lance

Ferruh Yigit Sept. 11, 2020, 3:56 p.m. UTC | #3

On 9/11/2020 4:38 PM, Lance Richardson wrote:
> On Fri, Sep 11, 2020 at 11:19 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>
>> On 9/9/2020 4:53 PM, Lance Richardson wrote:
>>> Increase the maximum supported burst size for the bnxt vector
>>> mode PMD from 32 to 64.
>>
>> What is the motivation here? Like does it improve the performance? If so in
>> which conditions etc.. It would be nice to describe the why & impact.
>>
> 
> How about this:
> 
>     net/bnxt: increase max burst size for vector mode
> 
>     Increase the maximum supported burst size for the bnxt vector
>     mode PMD from 32 to 64. With larger burst sizes, per-burst
>     overhead is amortized over more packets, improving overall
>     performance. For small packets this has been measured to
>     provide a 4-10% increase in single-core throughput with
>     testpmd iofwd.
> 

Will update while merging, thanks.

diff mbox series

Patch

diff --git a/drivers/net/bnxt/bnxt_rxtx_vec_common.h b/drivers/net/bnxt/bnxt_rxtx_vec_common.h
index 2f28759d06..fc2a12272b 100644
--- a/drivers/net/bnxt/bnxt_rxtx_vec_common.h
+++ b/drivers/net/bnxt/bnxt_rxtx_vec_common.h
@@ -9,8 +9,8 @@ 
 #include "bnxt_rxq.h"
 #include "bnxt_rxr.h"
 
-#define RTE_BNXT_MAX_RX_BURST		32U
-#define RTE_BNXT_MAX_TX_BURST		32U
+#define RTE_BNXT_MAX_RX_BURST		64U
+#define RTE_BNXT_MAX_TX_BURST		64U
 #define RTE_BNXT_DESCS_PER_LOOP		4U
 
 #define TX_BD_FLAGS_CMPL ((1 << TX_BD_LONG_FLAGS_BD_CNT_SFT) | \