diff mbox series

doc/prog_guide: fix missing SPDX license tag header

Message ID 20200910113205.984384-1-bruce.richardson@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series doc/prog_guide: fix missing SPDX license tag header |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/travis-robot success Travis build: passed

Commit Message

Bruce Richardson Sept. 10, 2020, 11:32 a.m. UTC 
  The build-sdk-meson.rst file originates from the short plain-text meson
instructions added in 2018. Add SPDX tag and copyright notice based on the
original commit.

Fixes: 9c3adc289c5e ("doc: add instructions on build using meson")
Cc: stable@dpdk.org

Reported-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 doc/guides/prog_guide/build-sdk-meson.rst | 3 +++
 1 file changed, 3 insertions(+)

Comments

Ferruh Yigit Sept. 10, 2020, 12:19 p.m. UTC | #1 
On 9/10/2020 12:32 PM, Bruce Richardson wrote:
> The build-sdk-meson.rst file originates from the short plain-text meson
> instructions added in 2018. Add SPDX tag and copyright notice based on the
> original commit.
> 
> Fixes: 9c3adc289c5e ("doc: add instructions on build using meson")
> Cc: stable@dpdk.org
> 
> Reported-by: Stephen Hemminger <stephen@networkplumber.org>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  doc/guides/prog_guide/build-sdk-meson.rst | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/doc/guides/prog_guide/build-sdk-meson.rst b/doc/guides/prog_guide/build-sdk-meson.rst
> index 44d1cafdf..c23ed65d7 100644
> --- a/doc/guides/prog_guide/build-sdk-meson.rst
> +++ b/doc/guides/prog_guide/build-sdk-meson.rst
> @@ -1,3 +1,6 @@
> +..  SPDX-License-Identifier: BSD-3-Clause
> +    Copyright(c) 2018 Intel Corporation.

Should copyright year be "2018 - 2020"? not sure. Other from that,

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Bruce Richardson Sept. 10, 2020, 12:23 p.m. UTC | #2 
On Thu, Sep 10, 2020 at 01:19:55PM +0100, Ferruh Yigit wrote:
> On 9/10/2020 12:32 PM, Bruce Richardson wrote:
> > The build-sdk-meson.rst file originates from the short plain-text meson
> > instructions added in 2018. Add SPDX tag and copyright notice based on the
> > original commit.
> > 
> > Fixes: 9c3adc289c5e ("doc: add instructions on build using meson")
> > Cc: stable@dpdk.org
> > 
> > Reported-by: Stephen Hemminger <stephen@networkplumber.org>
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> >  doc/guides/prog_guide/build-sdk-meson.rst | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/doc/guides/prog_guide/build-sdk-meson.rst b/doc/guides/prog_guide/build-sdk-meson.rst
> > index 44d1cafdf..c23ed65d7 100644
> > --- a/doc/guides/prog_guide/build-sdk-meson.rst
> > +++ b/doc/guides/prog_guide/build-sdk-meson.rst
> > @@ -1,3 +1,6 @@
> > +..  SPDX-License-Identifier: BSD-3-Clause
> > +    Copyright(c) 2018 Intel Corporation.
> 
> Should copyright year be "2018 - 2020"? not sure. Other from that,
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Neither am I, but no major updates have been made to the file since 2018,
so I'll keep it as-is.
Thomas Monjalon Oct. 19, 2020, 4:40 p.m. UTC | #3 
10/09/2020 14:23, Bruce Richardson:
> On Thu, Sep 10, 2020 at 01:19:55PM +0100, Ferruh Yigit wrote:
> > On 9/10/2020 12:32 PM, Bruce Richardson wrote:
> > > The build-sdk-meson.rst file originates from the short plain-text meson
> > > instructions added in 2018. Add SPDX tag and copyright notice based on the
> > > original commit.
> > > 
> > > Fixes: 9c3adc289c5e ("doc: add instructions on build using meson")
> > > Cc: stable@dpdk.org
> > > 
> > > Reported-by: Stephen Hemminger <stephen@networkplumber.org>
> > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > > ---
> > > --- a/doc/guides/prog_guide/build-sdk-meson.rst
> > > +++ b/doc/guides/prog_guide/build-sdk-meson.rst
> > > @@ -1,3 +1,6 @@
> > > +..  SPDX-License-Identifier: BSD-3-Clause
> > > +    Copyright(c) 2018 Intel Corporation.
> > 
> > Should copyright year be "2018 - 2020"? not sure. Other from that,
> > 
> > Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Neither am I, but no major updates have been made to the file since 2018,
> so I'll keep it as-is.

Applied, thanks
diff mbox series

Patch

diff --git a/doc/guides/prog_guide/build-sdk-meson.rst b/doc/guides/prog_guide/build-sdk-meson.rst
index 44d1cafdf..c23ed65d7 100644
--- a/doc/guides/prog_guide/build-sdk-meson.rst
+++ b/doc/guides/prog_guide/build-sdk-meson.rst
@@ -1,3 +1,6 @@ 
+..  SPDX-License-Identifier: BSD-3-Clause
+    Copyright(c) 2018 Intel Corporation.
+
 Installing DPDK Using the meson build system
 ============================================