diff mbox series

[11/22] Updated Source and Project files to use Clang toolset

Message ID 1597360905-74106-12-git-send-email-navasile@linux.microsoft.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series windows/netuio: add netuio driver for Windows |

Checks

Context Check Description
ci/checkpatch warning coding style issues

Commit Message

Narcisa Ana Maria Vasile Aug. 13, 2020, 11:21 p.m. UTC 
  From: Anand Rawat <anand.rawat@intel.com>

Updated the code for using LLVM toolset. The code still uses
msbuild and VS2017. Some header files and windows specific
utility functions are removed due to conflicts with Clang
intrinsic functions. Project files have been updated to use
LLVM and additional project settings for Clang.

Change-Id: I274de21379287c664e072f58e94271c654afe603
Signed-off-by: Anand Rawat <anand.rawat@intel.com>
---
 kernel/windows/netuio/netuio_queue.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Dmitry Kozlyuk Aug. 14, 2020, 8:02 p.m. UTC | #1 
On Thu, 13 Aug 2020 16:21:34 -0700, Narcisa Ana Maria Vasile wrote:
> From: Anand Rawat <anand.rawat@intel.com>
> 
> Updated the code for using LLVM toolset. The code still uses
> msbuild and VS2017. Some header files and windows specific
> utility functions are removed due to conflicts with Clang
> intrinsic functions. Project files have been updated to use
> LLVM and additional project settings for Clang.
> 
> Change-Id: I274de21379287c664e072f58e94271c654afe603

Not sure what this means for DPDK.

> Signed-off-by: Anand Rawat <anand.rawat@intel.com>
> ---
>  kernel/windows/netuio/netuio_queue.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/windows/netuio/netuio_queue.c b/kernel/windows/netuio/netuio_queue.c
> index 929192880..760b4a7e5 100644
> --- a/kernel/windows/netuio/netuio_queue.c
> +++ b/kernel/windows/netuio/netuio_queue.c
> @@ -156,8 +156,8 @@ netuio_evt_IO_device_control(_In_ WDFQUEUE Queue, _In_ WDFREQUEST Request,
>              break;
>          }
>  
> -        // Zero out the physically contiguous block
> -        RtlZeroMemory(netuio_contextdata->dpdk_seg.mem.virt_addr, netuio_contextdata->dpdk_seg.mem.size);
> +		// Zero out the physically contiguous block
> +		RtlZeroMemory(netuio_contextdata->dpdk_seg.mem.virt_addr, netuio_contextdata->dpdk_seg.mem.size);
>  
>          // Return relevant data to the caller
>          status = WdfRequestRetrieveOutputBuffer(Request, sizeof(struct dpdk_private_info), &output_buf, &output_buf_size);

Subject does not match content. Is this commit needed as standalone?
diff mbox series

Patch

diff --git a/kernel/windows/netuio/netuio_queue.c b/kernel/windows/netuio/netuio_queue.c
index 929192880..760b4a7e5 100644
--- a/kernel/windows/netuio/netuio_queue.c
+++ b/kernel/windows/netuio/netuio_queue.c
@@ -156,8 +156,8 @@  netuio_evt_IO_device_control(_In_ WDFQUEUE Queue, _In_ WDFREQUEST Request,
             break;
         }
 
-        // Zero out the physically contiguous block
-        RtlZeroMemory(netuio_contextdata->dpdk_seg.mem.virt_addr, netuio_contextdata->dpdk_seg.mem.size);
+		// Zero out the physically contiguous block
+		RtlZeroMemory(netuio_contextdata->dpdk_seg.mem.virt_addr, netuio_contextdata->dpdk_seg.mem.size);
 
         // Return relevant data to the caller
         status = WdfRequestRetrieveOutputBuffer(Request, sizeof(struct dpdk_private_info), &output_buf, &output_buf_size);