diff mbox series

[06/27] event/dlb: add dynamic logging

Message ID	1596138614-17409-7-git-send-email-timothy.mcdaniel@intel.com (mailing list archive)
State	Superseded, archived
Delegated to:	Jerin Jacob
Headers	IronPort-SDR: o2E/gbC9H1wuznMk4z3nbJs7eheAxHBUTk81UWIfmXpH82p48FjBJrGzdh8sMfk2pX3ulsnWun DioeOwNhy4Kg== IronPort-SDR: FkpCKxV5jRQKo8tbGr8LN1bYBeIibCjtlCHESLEfpwCrzoHlM4wVuNAr+86JYpS8C8+K7OB5sh WtsCzpJ5v3lA== From: "McDaniel, Timothy" <timothy.mcdaniel@intel.com> To: jerinj@marvell.com Cc: mattias.ronnblom@ericsson.com, dev@dpdk.org, gage.eads@intel.com, harry.van.haaren@intel.com, "McDaniel, Timothy" <timothy.mcdaniel@intel.com> Date: Thu, 30 Jul 2020 14:49:53 -0500 Message-Id: <1596138614-17409-7-git-send-email-timothy.mcdaniel@intel.com> In-Reply-To: <1596138614-17409-1-git-send-email-timothy.mcdaniel@intel.com> References: <1593232671-5690-0-git-send-email-timothy.mcdaniel@intel.com> <1596138614-17409-1-git-send-email-timothy.mcdaniel@intel.com> Subject: [dpdk-dev] [PATCH 06/27] event/dlb: add dynamic logging Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	Add Intel DLM PMD to 20.11 \| [00/27] Add Intel DLM PMD to 20.11 [01/27] eventdev: dlb upstream prerequisites [02/27] eventdev: do not pass disable_implicit_release bit to trace macro [03/27] event/dlb: add shared code version 10.7.9 [04/27] event/dlb: add make and meson build infrastructure [05/27] event/dlb: add DLB documentation [06/27] event/dlb: add dynamic logging [07/27] event/dlb: add private data structures and constants [08/27] event/dlb: add definitions shared with LKM or shared code [09/27] event/dlb: add inline functions used in multiple files [10/27] event/dlb: add PFPMD-specific interface layer to shared code [11/27] event/dlb: add flexible PMD to device interfaces [12/27] event/dlb: add the PMD's public interfaces [13/27] event/dlb: add xstats support [14/27] event/dlb: add PMD self-tests [15/27] event/dlb: add probe [16/27] event/dlb: add infos_get and configure [17/27] event/dlb: add queue_def_conf and port_def_conf [18/27] event/dlb: add queue setup [19/27] event/dlb: add port_setup [20/27] event/dlb: add port_link [21/27] event/dlb: add queue_release and port_release [22/27] event/dlb: add port_unlink and port_unlinks_in_progress [23/27] event/dlb: add eventdev_start [24/27] event/dlb: add timeout_ticks, dump, xstats, and selftest [25/27] event/dlb: add enqueue and its burst variants [26/27] event/dlb: add dequeue, dequeue_burst, and variants [27/27] event/dlb: add eventdev_stop and eventdev_close

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK
ci/Intel-compilation	fail	apply issues

Commit Message

Timothy McDaniel July 30, 2020, 7:49 p.m. UTC

  From: "McDaniel, Timothy" <timothy.mcdaniel@intel.com>

Signed-off-by: McDaniel, Timothy <timothy.mcdaniel@intel.com>
---
 drivers/event/dlb/dlb_log.h |   25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)
 create mode 100644 drivers/event/dlb/dlb_log.h

Comments

Jerin Jacob Aug. 11, 2020, 6:27 p.m. UTC | #1

On Fri, Jul 31, 2020 at 1:24 AM McDaniel, Timothy
<timothy.mcdaniel@intel.com> wrote:
>
> From: "McDaniel, Timothy" <timothy.mcdaniel@intel.com>

Please avoid empty comments.

>
> Signed-off-by: McDaniel, Timothy <timothy.mcdaniel@intel.com>
> ---
>  drivers/event/dlb/dlb_log.h |   25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>  create mode 100644 drivers/event/dlb/dlb_log.h
>
> diff --git a/drivers/event/dlb/dlb_log.h b/drivers/event/dlb/dlb_log.h
> new file mode 100644
> index 0000000..c69c9e5
> --- /dev/null
> +++ b/drivers/event/dlb/dlb_log.h
> @@ -0,0 +1,25 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2016-2020 Intel Corporation
> + */
> +
> +#ifndef _DLB_EVDEV_LOG_H_
> +#define _DLB_EVDEV_LOG_H_
> +
> +extern int eventdev_dlb_log_level;

RTE_LOG_REGISTER is missing. Use real dynamic logging.


> +
> +/* Dynamic logging */
> +#define DLB_LOG_IMPL(level, fmt, args...) \
> +       rte_log(RTE_LOG_ ## level, eventdev_dlb_log_level, "%s" fmt "\n", \
> +               __func__, ##args)
> +
> +#define DLB_LOG_INFO(fmt, args...) \
> +       DLB_LOG_IMPL(INFO, fmt, ## args)
> +
> +#define DLB_LOG_ERR(fmt, args...) \
> +       DLB_LOG_IMPL(ERR, fmt, ## args)
> +
> +/* remove debug logs at compile time unless actually debugging */
> +#define DLB_LOG_DBG(fmt, args...) \
> +       RTE_LOG_DP(DEBUG, PMD, fmt, ## args)
> +
> +#endif /* _DLB_EVDEV_LOG_H_ */
> --
> 1.7.10
>

diff mbox series

Patch

diff --git a/drivers/event/dlb/dlb_log.h b/drivers/event/dlb/dlb_log.h
new file mode 100644
index 0000000..c69c9e5
--- /dev/null
+++ b/drivers/event/dlb/dlb_log.h
@@ -0,0 +1,25 @@ 
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2016-2020 Intel Corporation
+ */
+
+#ifndef _DLB_EVDEV_LOG_H_
+#define _DLB_EVDEV_LOG_H_
+
+extern int eventdev_dlb_log_level;
+
+/* Dynamic logging */
+#define DLB_LOG_IMPL(level, fmt, args...) \
+	rte_log(RTE_LOG_ ## level, eventdev_dlb_log_level, "%s" fmt "\n", \
+		__func__, ##args)
+
+#define DLB_LOG_INFO(fmt, args...) \
+	DLB_LOG_IMPL(INFO, fmt, ## args)
+
+#define DLB_LOG_ERR(fmt, args...) \
+	DLB_LOG_IMPL(ERR, fmt, ## args)
+
+/* remove debug logs at compile time unless actually debugging */
+#define DLB_LOG_DBG(fmt, args...) \
+	RTE_LOG_DP(DEBUG, PMD, fmt, ## args)
+
+#endif /* _DLB_EVDEV_LOG_H_ */