[2/4] bus/vmbus: remove vmbus_send_interrupt

Message ID 1597113194-90208-2-git-send-email-longli@linuxonhyperv.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series [1/4] net/netvsc: move rxbuf_info from per-device to per-queue |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Long Li Aug. 11, 2020, 2:33 a.m. UTC
  From: Long Li <longli@microsoft.com>

netvsc is a high speed VMBus device that uses monitor bit to signal the
host. It's not necessary to send interrupts via INT bit.

Signed-off-by: Long Li <longli@microsoft.com>
---
 drivers/bus/vmbus/vmbus_channel.c | 13 -------------
 1 file changed, 13 deletions(-)
  

Comments

Stephen Hemminger Aug. 11, 2020, 3:31 p.m. UTC | #1
On Mon, 10 Aug 2020 19:33:12 -0700
longli@linuxonhyperv.com wrote:

> From: Long Li <longli@microsoft.com>
> 
> netvsc is a high speed VMBus device that uses monitor bit to signal the
> host. It's not necessary to send interrupts via INT bit.
> 
> Signed-off-by: Long Li <longli@microsoft.com>

Acked-by: Stephen Hemminger <stephen@networplumber.org>
  

Patch

diff --git a/drivers/bus/vmbus/vmbus_channel.c b/drivers/bus/vmbus/vmbus_channel.c
index 4f5578e2c..f67f1c438 100644
--- a/drivers/bus/vmbus/vmbus_channel.c
+++ b/drivers/bus/vmbus/vmbus_channel.c
@@ -26,18 +26,6 @@  vmbus_sync_set_bit(volatile uint32_t *addr, uint32_t mask)
 	__sync_or_and_fetch(addr, mask);
 }
 
-static inline void
-vmbus_send_interrupt(const struct rte_vmbus_device *dev, uint32_t relid)
-{
-	uint32_t *int_addr;
-	uint32_t int_mask;
-
-	int_addr = dev->int_page + relid / 32;
-	int_mask = 1u << (relid % 32);
-
-	vmbus_sync_set_bit(int_addr, int_mask);
-}
-
 static inline void
 vmbus_set_monitor(const struct rte_vmbus_device *dev, uint32_t monitor_id)
 {
@@ -55,7 +43,6 @@  static void
 vmbus_set_event(const struct rte_vmbus_device *dev,
 		const struct vmbus_channel *chan)
 {
-	vmbus_send_interrupt(dev, chan->relid);
 	vmbus_set_monitor(dev, chan->monitor_id);
 }