Message ID | 20200724053235.71069-10-ajit.khaparde@broadcom.com (mailing list archive) |
---|---|
State | Superseded, archived |
Delegated to: | Ajit Khaparde |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BEA6DA0518; Fri, 24 Jul 2020 07:34:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8119C1C0D7; Fri, 24 Jul 2020 07:33:32 +0200 (CEST) Received: from mail-vs1-f97.google.com (mail-vs1-f97.google.com [209.85.217.97]) by dpdk.org (Postfix) with ESMTP id 311851C0BC for <dev@dpdk.org>; Fri, 24 Jul 2020 07:33:19 +0200 (CEST) Received: by mail-vs1-f97.google.com with SMTP id b77so4284556vsd.8 for <dev@dpdk.org>; Thu, 23 Jul 2020 22:33:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7G5oIOjEh/WGkHmNfJjsvoi6ggVwtJzmEzNeK/a208c=; b=hhiGc52k3kH7XtQjfT3MRp8l/fU0FohXqQYCGXi4kYgP2NXu56AIc9EWwamMhnkz97 4K2JfTC5EsZITixw+z3hTEDvm/MocpoRHQOZVXxdGTXoJ3bks+o+1bYOUKiBU5eX7wBM GHYp9TmbmM7PtExwEtJLm/me1FFSGKsUSDfyU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7G5oIOjEh/WGkHmNfJjsvoi6ggVwtJzmEzNeK/a208c=; b=uBEoSthOi0i2zqnbXf53wKfDnWMTb70Q9X++CGxvd7FHmVJX6ylfriu0wmjTo116Cd gCSv4M/G5IHBSqJ1/rJFLI1qqgjZrFrRclDbGArzVfa/3lZ1vFGUDc+WG09rzMvAp7vp 87QhzG3rJgkJM2VVV8zmr8siqi7hrJCKeI8BHjgLJVjt48HyEnBViU114q13/umawVwE LJAOAZ5KtmSyh8za8GfvQYSmsv4iax3BuUapzW9q7AlUslsUazrOCOzAnpMYAzGAbs2c dHca1EhjsxaKAQ18rsVEKlcU7qIpy/M00gctyAvMxhbo0msQoTmkNTZ25ruCkalwn9eU IMPQ== X-Gm-Message-State: AOAM530rsAQ9XwvgTo0YCeV6fjgpfbfxdbRABENJVgGjLxJmMtpYvaST KMKTZPrFz2H7SdQ36RwvZm3ELcn0f6WI/nfs4QYQl78HILPt1dvreybFli5eYJaHyVuxw33WwX/ GVHIIwaDadCQIekRXH5hQB0nPn0GsV37CRZdFe/gS6W17wHjFNQkg/WhYA5BIzChhNF/+dNND5D z+ag== X-Google-Smtp-Source: ABdhPJwrWEVB/afGtUQHUokarELJGHz6AF+uBqoVpv7t4zRojW99t7isRtWbiTWJMIfD3K/9mT7Z2/+hVylQ X-Received: by 2002:a67:fe8e:: with SMTP id b14mr7042132vsr.133.1595568798520; Thu, 23 Jul 2020 22:33:18 -0700 (PDT) Received: from localhost.localdomain ([192.19.223.252]) by smtp-relay.gmail.com with ESMTPS id h17sm592840vsk.0.2020.07.23.22.33.15 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Jul 2020 22:33:18 -0700 (PDT) X-Relaying-Domain: broadcom.com From: Ajit Khaparde <ajit.khaparde@broadcom.com> To: dev@dpdk.org Cc: ferruh.yigit@intel.com, Kishore Padmanabha <kishore.padmanabha@broadcom.com>, Michael Baucom <michael.baucom@broadcom.com> Date: Thu, 23 Jul 2020 22:32:22 -0700 Message-Id: <20200724053235.71069-10-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.21.1 (Apple Git-122.3) In-Reply-To: <20200724053235.71069-1-ajit.khaparde@broadcom.com> References: <20200723115639.22357-1-somnath.kotur@broadcom.com> <20200724053235.71069-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v3 09/22] net/bnxt: ignore VLAN priority mask X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
bnxt patches
|
|
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | warning | coding style issues |
ci/Intel-compilation | success | Compilation OK |
Commit Message
Ajit Khaparde
July 24, 2020, 5:32 a.m. UTC
From: Kishore Padmanabha <kishore.padmanabha@broadcom.com> This is a work around for the OVS setting offload rules that are passing vlan priority mask as wild card and currently we do not support it. Signed-off-by: Kishore Padmanabha <kishore.padmanabha@broadcom.com> Reviewed-by: Michael Baucom <michael.baucom@broadcom.com> --- drivers/net/bnxt/tf_ulp/ulp_rte_parser.c | 9 +++++++++ 1 file changed, 9 insertions(+)
Comments
On 7/24/2020 6:32 AM, Ajit Khaparde wrote: > From: Kishore Padmanabha <kishore.padmanabha@broadcom.com> > > This is a work around for the OVS setting offload rules that > are passing vlan priority mask as wild card and currently we > do not support it. > > Signed-off-by: Kishore Padmanabha <kishore.padmanabha@broadcom.com> > Reviewed-by: Michael Baucom <michael.baucom@broadcom.com> > --- > drivers/net/bnxt/tf_ulp/ulp_rte_parser.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c b/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c > index 67f9319d6..665f5d381 100644 > --- a/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c > +++ b/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c > @@ -709,8 +709,17 @@ ulp_rte_vlan_hdr_handler(const struct rte_flow_item *item, > vlan_tag |= ~ULP_VLAN_TAG_MASK; > vlan_tag = htons(vlan_tag); > > +#ifdef ULP_DONT_IGNORE_TOS > ulp_rte_prsr_mask_copy(params, &idx, &priority, > sizeof(priority)); > +#else > + /* > + * The priority field is ignored since OVS is setting it as > + * wild card match and it is not supported. This is a work > + * around and shall be addressed in the future. > + */ > + idx += 1; > +#endif > ulp_rte_prsr_mask_copy(params, &idx, &vlan_tag, > sizeof(vlan_tag)); > ulp_rte_prsr_mask_copy(params, &idx, &vlan_mask->inner_type, > Hi Ajit, What sets the 'ULP_DONT_IGNORE_TOS', I don't see it in our build system. If ways 'else' leg is taken, why not drop the macro completely?
On Mon, Jul 27, 2020 at 3:30 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote: > On 7/24/2020 6:32 AM, Ajit Khaparde wrote: > > From: Kishore Padmanabha <kishore.padmanabha@broadcom.com> > > > > This is a work around for the OVS setting offload rules that > > are passing vlan priority mask as wild card and currently we > > do not support it. > > > > Signed-off-by: Kishore Padmanabha <kishore.padmanabha@broadcom.com> > > Reviewed-by: Michael Baucom <michael.baucom@broadcom.com> > > --- > > drivers/net/bnxt/tf_ulp/ulp_rte_parser.c | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c > b/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c > > index 67f9319d6..665f5d381 100644 > > --- a/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c > > +++ b/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c > > @@ -709,8 +709,17 @@ ulp_rte_vlan_hdr_handler(const struct rte_flow_item > *item, > > vlan_tag |= ~ULP_VLAN_TAG_MASK; > > vlan_tag = htons(vlan_tag); > > > > +#ifdef ULP_DONT_IGNORE_TOS > > ulp_rte_prsr_mask_copy(params, &idx, &priority, > > sizeof(priority)); > > +#else > > + /* > > + * The priority field is ignored since OVS is setting it as > > + * wild card match and it is not supported. This is a work > > + * around and shall be addressed in the future. > > + */ > > + idx += 1; > > +#endif > > ulp_rte_prsr_mask_copy(params, &idx, &vlan_tag, > > sizeof(vlan_tag)); > > ulp_rte_prsr_mask_copy(params, &idx, > &vlan_mask->inner_type, > > > > Hi Ajit, > > What sets the 'ULP_DONT_IGNORE_TOS', I don't see it in our build system. > If ways > 'else' leg is taken, why not drop the macro completely? > Ferruh, Yes. I will submit a v4 to take care of that. Thanks Ajit
diff --git a/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c b/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c index 67f9319d6..665f5d381 100644 --- a/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c +++ b/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c @@ -709,8 +709,17 @@ ulp_rte_vlan_hdr_handler(const struct rte_flow_item *item, vlan_tag |= ~ULP_VLAN_TAG_MASK; vlan_tag = htons(vlan_tag); +#ifdef ULP_DONT_IGNORE_TOS ulp_rte_prsr_mask_copy(params, &idx, &priority, sizeof(priority)); +#else + /* + * The priority field is ignored since OVS is setting it as + * wild card match and it is not supported. This is a work + * around and shall be addressed in the future. + */ + idx += 1; +#endif ulp_rte_prsr_mask_copy(params, &idx, &vlan_tag, sizeof(vlan_tag)); ulp_rte_prsr_mask_copy(params, &idx, &vlan_mask->inner_type,