mbox series

[v3,00/22] bnxt patches

Message ID 20200724053235.71069-1-ajit.khaparde@broadcom.com (mailing list archive)
Headers
Series bnxt patches |

Message

Ajit Khaparde July 24, 2020, 5:32 a.m. UTC 
  Some fixes, cleanups and changes to augment pre-existing
support in infrastructure

Please apply

v1->v2:
 - Fixed some typos in patch [9/20].
v2->v3:
 - Fixed coding style issues in patch [15/20] to use __rte_attribute.
 - Updated commit messages.
 - Added a patch to fix a logic error [21/22].
 - Added a patch to fix compilation issue with -O and -g CFLAGS [22/22].

Ajit Khaparde (2):
  net/bnxt: fix if condition
  net/bnxt: fix build error with extra cflags

Kishore Padmanabha (7):
  net/bnxt: add access to nat global register
  net/bnxt: configure parif for offload miss rules
  net/bnxt: update nat template
  net/bnxt: configure parif for the egress rules
  net/bnxt: ignore VLAN priority mask
  net/bnxt: add egress template with VLAN tag match
  net/bnxt: add tcam table processing for search and alloc

Mike Baucom (9):
  net/bnxt: add shadow and search capability to tcam
  net/bnxt: modify ulp mapper to use tcam search
  net/bnxt: add tf hash API
  net/bnxt: modify tf shadow tcam to use tf hash
  net/bnxt: add shadow table capability with search
  net/bnxt: modify ulp mapper to use tbl search
  net/bnxt: modify shadow tcam and tbl reference count logic
  net/bnxt: add templates for search before alloc
  net/bnxt: enable shadow tables during session open

Somnath Kotur (1):
  net/bnxt: cleanup VF-representor dev ops

Venkat Duvvuru (3):
  net/bnxt: skip mark id injection into mbuf
  net/bnxt: fix port default rule create and destroy
  net/bnxt: delete VF FW rules on representor create

 drivers/net/bnxt/bnxt.h                       |   6 +-
 drivers/net/bnxt/bnxt_ethdev.c                |  83 +-
 drivers/net/bnxt/bnxt_hwrm.c                  |  49 ++
 drivers/net/bnxt/bnxt_hwrm.h                  |   2 +
 drivers/net/bnxt/bnxt_reps.c                  |  94 +-
 drivers/net/bnxt/bnxt_rxr.c                   |   3 +
 drivers/net/bnxt/bnxt_txq.h                   |   1 -
 drivers/net/bnxt/bnxt_txr.c                   |  19 +-
 drivers/net/bnxt/hsi_struct_def_dpdk.h        | 138 +++
 drivers/net/bnxt/meson.build                  |   1 +
 drivers/net/bnxt/tf_core/Makefile             |   1 +
 drivers/net/bnxt/tf_core/tf_core.c            | 139 ++-
 drivers/net/bnxt/tf_core/tf_core.h            | 174 ++++
 drivers/net/bnxt/tf_core/tf_device_p4.c       |   4 +-
 drivers/net/bnxt/tf_core/tf_hash.c            | 106 +++
 drivers/net/bnxt/tf_core/tf_hash.h            |  27 +
 drivers/net/bnxt/tf_core/tf_shadow_tbl.c      | 766 +++++++++++++++-
 drivers/net/bnxt/tf_core/tf_shadow_tbl.h      | 124 +--
 drivers/net/bnxt/tf_core/tf_shadow_tcam.c     | 818 +++++++++++++++++-
 drivers/net/bnxt/tf_core/tf_shadow_tcam.h     | 258 +++---
 drivers/net/bnxt/tf_core/tf_tbl.c             | 246 +++++-
 drivers/net/bnxt/tf_core/tf_tbl.h             |  22 +-
 drivers/net/bnxt/tf_core/tf_tcam.c            | 300 ++++++-
 drivers/net/bnxt/tf_core/tf_tcam.h            |  31 +-
 drivers/net/bnxt/tf_ulp/bnxt_ulp.c            |  97 ++-
 drivers/net/bnxt/tf_ulp/bnxt_ulp.h            |  18 +-
 drivers/net/bnxt/tf_ulp/ulp_def_rules.c       | 127 ++-
 drivers/net/bnxt/tf_ulp/ulp_flow_db.c         |   2 +-
 drivers/net/bnxt/tf_ulp/ulp_flow_db.h         |   2 +-
 drivers/net/bnxt/tf_ulp/ulp_mapper.c          | 505 +++++++----
 drivers/net/bnxt/tf_ulp/ulp_port_db.c         |   2 +
 drivers/net/bnxt/tf_ulp/ulp_port_db.h         |   1 +
 drivers/net/bnxt/tf_ulp/ulp_rte_parser.c      |  81 ++
 drivers/net/bnxt/tf_ulp/ulp_template_db_act.c | 434 ++++++----
 .../net/bnxt/tf_ulp/ulp_template_db_class.c   | 556 +++++++++++-
 .../net/bnxt/tf_ulp/ulp_template_db_enum.h    |  73 +-
 drivers/net/bnxt/tf_ulp/ulp_template_db_tbl.c |   4 +-
 drivers/net/bnxt/tf_ulp/ulp_template_struct.h |   8 +-
 38 files changed, 4462 insertions(+), 860 deletions(-)
 create mode 100644 drivers/net/bnxt/tf_core/tf_hash.c
 create mode 100644 drivers/net/bnxt/tf_core/tf_hash.h

Comments

Ajit Khaparde July 24, 2020, 4:48 p.m. UTC | #1 
On Thu, Jul 23, 2020 at 10:32 PM Ajit Khaparde <ajit.khaparde@broadcom.com>
wrote:

> Some fixes, cleanups and changes to augment pre-existing
> support in infrastructure
>
> Please apply
>
> v1->v2:
>  - Fixed some typos in patch [9/20].
> v2->v3:
>  - Fixed coding style issues in patch [15/20] to use __rte_attribute.
>  - Updated commit messages.
>  - Added a patch to fix a logic error [21/22].
>  - Added a patch to fix compilation issue with -O and -g CFLAGS [22/22].
>
Patchset applied to dpdk-next-net-brcm.



>
> Ajit Khaparde (2):
>   net/bnxt: fix if condition
>   net/bnxt: fix build error with extra cflags
>
> Kishore Padmanabha (7):
>   net/bnxt: add access to nat global register
>   net/bnxt: configure parif for offload miss rules
>   net/bnxt: update nat template
>   net/bnxt: configure parif for the egress rules
>   net/bnxt: ignore VLAN priority mask
>   net/bnxt: add egress template with VLAN tag match
>   net/bnxt: add tcam table processing for search and alloc
>
> Mike Baucom (9):
>   net/bnxt: add shadow and search capability to tcam
>   net/bnxt: modify ulp mapper to use tcam search
>   net/bnxt: add tf hash API
>   net/bnxt: modify tf shadow tcam to use tf hash
>   net/bnxt: add shadow table capability with search
>   net/bnxt: modify ulp mapper to use tbl search
>   net/bnxt: modify shadow tcam and tbl reference count logic
>   net/bnxt: add templates for search before alloc
>   net/bnxt: enable shadow tables during session open
>
> Somnath Kotur (1):
>   net/bnxt: cleanup VF-representor dev ops
>
> Venkat Duvvuru (3):
>   net/bnxt: skip mark id injection into mbuf
>   net/bnxt: fix port default rule create and destroy
>   net/bnxt: delete VF FW rules on representor create
>
>  drivers/net/bnxt/bnxt.h                       |   6 +-
>  drivers/net/bnxt/bnxt_ethdev.c                |  83 +-
>  drivers/net/bnxt/bnxt_hwrm.c                  |  49 ++
>  drivers/net/bnxt/bnxt_hwrm.h                  |   2 +
>  drivers/net/bnxt/bnxt_reps.c                  |  94 +-
>  drivers/net/bnxt/bnxt_rxr.c                   |   3 +
>  drivers/net/bnxt/bnxt_txq.h                   |   1 -
>  drivers/net/bnxt/bnxt_txr.c                   |  19 +-
>  drivers/net/bnxt/hsi_struct_def_dpdk.h        | 138 +++
>  drivers/net/bnxt/meson.build                  |   1 +
>  drivers/net/bnxt/tf_core/Makefile             |   1 +
>  drivers/net/bnxt/tf_core/tf_core.c            | 139 ++-
>  drivers/net/bnxt/tf_core/tf_core.h            | 174 ++++
>  drivers/net/bnxt/tf_core/tf_device_p4.c       |   4 +-
>  drivers/net/bnxt/tf_core/tf_hash.c            | 106 +++
>  drivers/net/bnxt/tf_core/tf_hash.h            |  27 +
>  drivers/net/bnxt/tf_core/tf_shadow_tbl.c      | 766 +++++++++++++++-
>  drivers/net/bnxt/tf_core/tf_shadow_tbl.h      | 124 +--
>  drivers/net/bnxt/tf_core/tf_shadow_tcam.c     | 818 +++++++++++++++++-
>  drivers/net/bnxt/tf_core/tf_shadow_tcam.h     | 258 +++---
>  drivers/net/bnxt/tf_core/tf_tbl.c             | 246 +++++-
>  drivers/net/bnxt/tf_core/tf_tbl.h             |  22 +-
>  drivers/net/bnxt/tf_core/tf_tcam.c            | 300 ++++++-
>  drivers/net/bnxt/tf_core/tf_tcam.h            |  31 +-
>  drivers/net/bnxt/tf_ulp/bnxt_ulp.c            |  97 ++-
>  drivers/net/bnxt/tf_ulp/bnxt_ulp.h            |  18 +-
>  drivers/net/bnxt/tf_ulp/ulp_def_rules.c       | 127 ++-
>  drivers/net/bnxt/tf_ulp/ulp_flow_db.c         |   2 +-
>  drivers/net/bnxt/tf_ulp/ulp_flow_db.h         |   2 +-
>  drivers/net/bnxt/tf_ulp/ulp_mapper.c          | 505 +++++++----
>  drivers/net/bnxt/tf_ulp/ulp_port_db.c         |   2 +
>  drivers/net/bnxt/tf_ulp/ulp_port_db.h         |   1 +
>  drivers/net/bnxt/tf_ulp/ulp_rte_parser.c      |  81 ++
>  drivers/net/bnxt/tf_ulp/ulp_template_db_act.c | 434 ++++++----
>  .../net/bnxt/tf_ulp/ulp_template_db_class.c   | 556 +++++++++++-
>  .../net/bnxt/tf_ulp/ulp_template_db_enum.h    |  73 +-
>  drivers/net/bnxt/tf_ulp/ulp_template_db_tbl.c |   4 +-
>  drivers/net/bnxt/tf_ulp/ulp_template_struct.h |   8 +-
>  38 files changed, 4462 insertions(+), 860 deletions(-)
>  create mode 100644 drivers/net/bnxt/tf_core/tf_hash.c
>  create mode 100644 drivers/net/bnxt/tf_core/tf_hash.h
>
> --
> 2.21.1 (Apple Git-122.3)
>
>
Ferruh Yigit July 27, 2020, 10:42 a.m. UTC | #2 
On 7/24/2020 5:48 PM, Ajit Khaparde wrote:
> 
> 
> On Thu, Jul 23, 2020 at 10:32 PM Ajit Khaparde <ajit.khaparde@broadcom.com
> <mailto:ajit.khaparde@broadcom.com>> wrote:
> 
>     Some fixes, cleanups and changes to augment pre-existing
>     support in infrastructure
> 
>     Please apply
> 
>     v1->v2:
>      - Fixed some typos in patch [9/20].
>     v2->v3:
>      - Fixed coding style issues in patch [15/20] to use __rte_attribute.
>      - Updated commit messages.
>      - Added a patch to fix a logic error [21/22].
>      - Added a patch to fix compilation issue with -O and -g CFLAGS [22/22].
> 
> Patchset applied to dpdk-next-net-brcm.
> 

Hi Ajit,

Is a release note update required for the changes in this set, since not all
patches are fixes?

If so can you please add release notes update and distribute it to the patches
that adds the feature, instead of having a separate doc patch later?

Thanks,
ferruh

>  
> 
> 
>     Ajit Khaparde (2):
>       net/bnxt: fix if condition
>       net/bnxt: fix build error with extra cflags
> 
>     Kishore Padmanabha (7):
>       net/bnxt: add access to nat global register
>       net/bnxt: configure parif for offload miss rules
>       net/bnxt: update nat template
>       net/bnxt: configure parif for the egress rules
>       net/bnxt: ignore VLAN priority mask
>       net/bnxt: add egress template with VLAN tag match
>       net/bnxt: add tcam table processing for search and alloc
> 
>     Mike Baucom (9):
>       net/bnxt: add shadow and search capability to tcam
>       net/bnxt: modify ulp mapper to use tcam search
>       net/bnxt: add tf hash API
>       net/bnxt: modify tf shadow tcam to use tf hash
>       net/bnxt: add shadow table capability with search
>       net/bnxt: modify ulp mapper to use tbl search
>       net/bnxt: modify shadow tcam and tbl reference count logic
>       net/bnxt: add templates for search before alloc
>       net/bnxt: enable shadow tables during session open
> 
>     Somnath Kotur (1):
>       net/bnxt: cleanup VF-representor dev ops
> 
>     Venkat Duvvuru (3):
>       net/bnxt: skip mark id injection into mbuf
>       net/bnxt: fix port default rule create and destroy
>       net/bnxt: delete VF FW rules on representor create
> 

<...>
Ajit Khaparde July 28, 2020, 5:20 a.m. UTC | #3 
On Mon, Jul 27, 2020 at 3:42 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> On 7/24/2020 5:48 PM, Ajit Khaparde wrote:
> >
> >
> > On Thu, Jul 23, 2020 at 10:32 PM Ajit Khaparde <
> ajit.khaparde@broadcom.com
> > <mailto:ajit.khaparde@broadcom.com>> wrote:
> >
> >     Some fixes, cleanups and changes to augment pre-existing
> >     support in infrastructure
> >
> >     Please apply
> >
> >     v1->v2:
> >      - Fixed some typos in patch [9/20].
> >     v2->v3:
> >      - Fixed coding style issues in patch [15/20] to use __rte_attribute.
> >      - Updated commit messages.
> >      - Added a patch to fix a logic error [21/22].
> >      - Added a patch to fix compilation issue with -O and -g CFLAGS
> [22/22].
> >
> > Patchset applied to dpdk-next-net-brcm.
> >
>
> Hi Ajit,
>
> Is a release note update required for the changes in this set, since not
> all
> patches are fixes?
>
Most likely not.
We had to change the implementation of some of the code
to extend scalability and add support for more actions.
But I will go through the patches and update the doc if needed.

Thanks
Ajit


>
> If so can you please add release notes update and distribute it to the
> patches
> that adds the feature, instead of having a separate doc patch later?
>
> Thanks,
> ferruh
>
> >
> >
> >
> >     Ajit Khaparde (2):
> >       net/bnxt: fix if condition
> >       net/bnxt: fix build error with extra cflags
> >
> >     Kishore Padmanabha (7):
> >       net/bnxt: add access to nat global register
> >       net/bnxt: configure parif for offload miss rules
> >       net/bnxt: update nat template
> >       net/bnxt: configure parif for the egress rules
> >       net/bnxt: ignore VLAN priority mask
> >       net/bnxt: add egress template with VLAN tag match
> >       net/bnxt: add tcam table processing for search and alloc
> >
> >     Mike Baucom (9):
> >       net/bnxt: add shadow and search capability to tcam
> >       net/bnxt: modify ulp mapper to use tcam search
> >       net/bnxt: add tf hash API
> >       net/bnxt: modify tf shadow tcam to use tf hash
> >       net/bnxt: add shadow table capability with search
> >       net/bnxt: modify ulp mapper to use tbl search
> >       net/bnxt: modify shadow tcam and tbl reference count logic
> >       net/bnxt: add templates for search before alloc
> >       net/bnxt: enable shadow tables during session open
> >
> >     Somnath Kotur (1):
> >       net/bnxt: cleanup VF-representor dev ops
> >
> >     Venkat Duvvuru (3):
> >       net/bnxt: skip mark id injection into mbuf
> >       net/bnxt: fix port default rule create and destroy
> >       net/bnxt: delete VF FW rules on representor create
> >
>
> <...>
>
>