[v4,2/3] examples/vm_power_manager: Allowing power managing of idle cores
Checks
Commit Message
This change is required to allow the branch ratio algorithm to
power manage cores with no workload running on them. This is
useful both when idle cores don't use C-states and for a number of
hyperthreading scenarios.
Signed-off-by: Rory Sexton <rory.sexton@intel.com>
Reviewed-by: David Hunt <david.hunt@intel.com>
---
v4: no changes
---
examples/vm_power_manager/oob_monitor_x86.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
Comments
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Rory Sexton
> Sent: Tuesday, July 14, 2020 5:02 PM
> To: dev@dpdk.org; Hunt, David <david.hunt@intel.com>
> Subject: [dpdk-dev] [v4 2/3] examples/vm_power_manager: Allowing power
> managing of idle cores
>
> This change is required to allow the branch ratio algorithm to power manage
> cores with no workload running on them. This is useful both when idle cores
> don't use C-states and for a number of hyperthreading scenarios.
>
> Signed-off-by: Rory Sexton <rory.sexton@intel.com>
> Reviewed-by: David Hunt <david.hunt@intel.com>
>
> ---
> v4: no changes
> ---
Acked-by: Reshma pattan <reshma.pattan@intel.com>
@@ -96,12 +96,12 @@ apply_policy(int core)
g_branch_misses = miss_diff;
if (hits_diff < (INTERVAL*100)) {
- /* Likely no workload running on this core. Skip. */
- return -1.0;
+ /* Likely no workload running on this core. */
+ ratio = 0.0;
+ } else {
+ ratio = (float)miss_diff * (float)100 / (float)hits_diff;
}
- ratio = (float)miss_diff * (float)100 / (float)hits_diff;
-
/*
* Store the last few directions that the ratio indicates
* we should take. If there's on 'up', then we scale up