diff mbox series

[v2,13/14] vhost: remove vDPA device count API

Message ID	20200624122701.1369327-17-maxime.coquelin@redhat.com (mailing list archive)
State	Superseded, archived
Delegated to:	Maxime Coquelin
Headers	From: Maxime Coquelin <maxime.coquelin@redhat.com> To: matan@mellanox.com, xiao.w.wang@intel.com, zhihong.wang@intel.com, chenbo.xia@intel.com, david.marchand@redhat.com, amorenoz@redhat.com, viacheslavo@mellanox.com, hemant.agrawal@nxp.com, sachin.saxena@nxp.com, grive@u256.net, dev@dpdk.org Cc: Maxime Coquelin <maxime.coquelin@redhat.com> Date: Wed, 24 Jun 2020 14:27:00 +0200 Message-Id: <20200624122701.1369327-17-maxime.coquelin@redhat.com> In-Reply-To: <20200624122701.1369327-1-maxime.coquelin@redhat.com> References: <20200624122701.1369327-1-maxime.coquelin@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2 13/14] vhost: remove vDPA device count API Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	vDPA API and framework rework \| [v2,00/14] vDPA API and framework rework [v2,01/14] bus/dpaa: fix null pointer dereference [v2,02/14] bus/fslmc: fix null pointer dereference [v2,03/14] vhost: introduce vDPA devices class [v2,04/14] vhost: make vDPA framework bus agnostic [v2,05/14] vhost: replace device ID in vDPA ops [v2,06/14] vhost: replace vDPA device ID in Vhost [v2,07/14] vhost: replace device ID in applications [v2,08/14] vhost: remove useless vDPA API [v2,09/14] vhost: use linked-list for vDPA devices [v2,10/12] examples/vdpa: use new wrappers instead of ops [v2,11/12] examples/vdpa: remove useless device count [v2,12/14] examples/vdpa: remove useless device count [v2,13/14] vhost: remove vDPA device count API [v2,14/14] vhost: split vDPA header file

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Maxime Coquelin June 24, 2020, 12:27 p.m. UTC

  This API is no more useful, this patch removes it.

Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
 lib/librte_vhost/rte_vdpa.h            | 13 -------------
 lib/librte_vhost/rte_vhost_version.map |  1 -
 lib/librte_vhost/vdpa.c                |  9 ---------
 3 files changed, 23 deletions(-)

Comments

Adrian Moreno June 26, 2020, 11:16 a.m. UTC | #1

On 6/24/20 2:27 PM, Maxime Coquelin wrote:
> This API is no more useful, this patch removes it.
> 
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
>  lib/librte_vhost/rte_vdpa.h            | 13 -------------
>  lib/librte_vhost/rte_vhost_version.map |  1 -
>  lib/librte_vhost/vdpa.c                |  9 ---------
>  3 files changed, 23 deletions(-)
> 
> diff --git a/lib/librte_vhost/rte_vdpa.h b/lib/librte_vhost/rte_vdpa.h
> index eda56dd556..776ed67c16 100644
> --- a/lib/librte_vhost/rte_vdpa.h
> +++ b/lib/librte_vhost/rte_vdpa.h
> @@ -175,19 +175,6 @@ __rte_experimental
>  struct rte_device *
>  rte_vdpa_get_rte_device(struct rte_vdpa_device *vdpa_dev);
>  
> -/**
> - * @warning
> - * @b EXPERIMENTAL: this API may change without prior notice
> - *
> - * Get current available vdpa device number
> - *
> - * @return
> - *  available vdpa device number
> - */
> -__rte_experimental
> -int
> -rte_vdpa_get_device_num(void);
> -
>  /**
>   * @warning
>   * @b EXPERIMENTAL: this API may change without prior notice
> diff --git a/lib/librte_vhost/rte_vhost_version.map b/lib/librte_vhost/rte_vhost_version.map
> index 7a919102cf..299576a494 100644
> --- a/lib/librte_vhost/rte_vhost_version.map
> +++ b/lib/librte_vhost/rte_vhost_version.map
> @@ -36,7 +36,6 @@ EXPERIMENTAL {
>  	rte_vdpa_register_device;
>  	rte_vdpa_unregister_device;
>  	rte_vdpa_find_device_id;
> -	rte_vdpa_get_device_num;
>  	rte_vdpa_get_stats_names;
>  	rte_vdpa_get_stats;
>  	rte_vdpa_reset_stats;
> diff --git a/lib/librte_vhost/vdpa.c b/lib/librte_vhost/vdpa.c
> index d7f9839eb2..864770d506 100644
> --- a/lib/librte_vhost/vdpa.c
> +++ b/lib/librte_vhost/vdpa.c
> @@ -25,7 +25,6 @@ TAILQ_HEAD(vdpa_device_list, rte_vdpa_device);
>  static struct vdpa_device_list vdpa_device_list =
>  		TAILQ_HEAD_INITIALIZER(vdpa_device_list);
>  static rte_spinlock_t vdpa_device_list_lock = RTE_SPINLOCK_INITIALIZER;
> -static uint32_t vdpa_device_num;
>  
>  
>  /* Unsafe, needs to be called with vdpa_device_list_lock held */
> @@ -92,7 +91,6 @@ rte_vdpa_register_device(struct rte_device *rte_dev,
>  	dev->device = rte_dev;
>  	dev->ops = ops;
>  	TAILQ_INSERT_TAIL(&vdpa_device_list, dev, next);
> -	vdpa_device_num++;
>  out_unlock:
>  	rte_spinlock_unlock(&vdpa_device_list_lock);
>  
> @@ -112,7 +110,6 @@ rte_vdpa_unregister_device(struct rte_vdpa_device *dev)
>  
>  		TAILQ_REMOVE(&vdpa_device_list, dev, next);
>  		rte_free(dev);
> -		vdpa_device_num--;
>  		ret = 0;
>  		break;
>  	}
> @@ -121,12 +118,6 @@ rte_vdpa_unregister_device(struct rte_vdpa_device *dev)
>  	return ret;
>  }
>  
> -int
> -rte_vdpa_get_device_num(void)
> -{
> -	return vdpa_device_num;
> -}
> -
>  int
>  rte_vdpa_relay_vring_used(int vid, uint16_t qid, void *vring_m)
>  {
> 

Acked-by: Adrián Moreno <amorenoz@redhat.com>

diff mbox series

Patch

diff --git a/lib/librte_vhost/rte_vdpa.h b/lib/librte_vhost/rte_vdpa.h
index eda56dd556..776ed67c16 100644
--- a/lib/librte_vhost/rte_vdpa.h
+++ b/lib/librte_vhost/rte_vdpa.h
@@ -175,19 +175,6 @@  __rte_experimental
 struct rte_device *
 rte_vdpa_get_rte_device(struct rte_vdpa_device *vdpa_dev);
 
-/**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
- * Get current available vdpa device number
- *
- * @return
- *  available vdpa device number
- */
-__rte_experimental
-int
-rte_vdpa_get_device_num(void);
-
 /**
  * @warning
  * @b EXPERIMENTAL: this API may change without prior notice
diff --git a/lib/librte_vhost/rte_vhost_version.map b/lib/librte_vhost/rte_vhost_version.map
index 7a919102cf..299576a494 100644
--- a/lib/librte_vhost/rte_vhost_version.map
+++ b/lib/librte_vhost/rte_vhost_version.map
@@ -36,7 +36,6 @@  EXPERIMENTAL {
 	rte_vdpa_register_device;
 	rte_vdpa_unregister_device;
 	rte_vdpa_find_device_id;
-	rte_vdpa_get_device_num;
 	rte_vdpa_get_stats_names;
 	rte_vdpa_get_stats;
 	rte_vdpa_reset_stats;
diff --git a/lib/librte_vhost/vdpa.c b/lib/librte_vhost/vdpa.c
index d7f9839eb2..864770d506 100644
--- a/lib/librte_vhost/vdpa.c
+++ b/lib/librte_vhost/vdpa.c
@@ -25,7 +25,6 @@  TAILQ_HEAD(vdpa_device_list, rte_vdpa_device);
 static struct vdpa_device_list vdpa_device_list =
 		TAILQ_HEAD_INITIALIZER(vdpa_device_list);
 static rte_spinlock_t vdpa_device_list_lock = RTE_SPINLOCK_INITIALIZER;
-static uint32_t vdpa_device_num;
 
 
 /* Unsafe, needs to be called with vdpa_device_list_lock held */
@@ -92,7 +91,6 @@  rte_vdpa_register_device(struct rte_device *rte_dev,
 	dev->device = rte_dev;
 	dev->ops = ops;
 	TAILQ_INSERT_TAIL(&vdpa_device_list, dev, next);
-	vdpa_device_num++;
 out_unlock:
 	rte_spinlock_unlock(&vdpa_device_list_lock);
 
@@ -112,7 +110,6 @@  rte_vdpa_unregister_device(struct rte_vdpa_device *dev)
 
 		TAILQ_REMOVE(&vdpa_device_list, dev, next);
 		rte_free(dev);
-		vdpa_device_num--;
 		ret = 0;
 		break;
 	}
@@ -121,12 +118,6 @@  rte_vdpa_unregister_device(struct rte_vdpa_device *dev)
 	return ret;
 }
 
-int
-rte_vdpa_get_device_num(void)
-{
-	return vdpa_device_num;
-}
-
 int
 rte_vdpa_relay_vring_used(int vid, uint16_t qid, void *vring_m)
 {