diff mbox series

examples/packet_ordering: Use rte_exit in case of invalid EAL or application arguments

Message ID 20200605114828.20372-1-sarosh.arif@emumba.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series examples/packet_ordering: Use rte_exit in case of invalid EAL or application arguments |

Checks

Context Check Description
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-nxp-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/iol-testing warning Testing issues
ci/checkpatch success coding style OK

Commit Message

Sarosh Arif June 5, 2020, 11:48 a.m. UTC 
  rte_exit should be called when the application exits due to
invalid EAL or application arguments.

Fixes: 850f3733f840 ("examples/packet_ordering: new sample app")
Cc: sergio.gonzalez.monroy@intel.com

Signed-off-by: Sarosh Arif <sarosh.arif@emumba.com>
---
 examples/packet_ordering/main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Sarosh Arif June 23, 2020, 9:19 a.m. UTC | #1 
Hello,

This patch has been sitting around for more than 3 weeks. Is there
something that needs to be done further for acceptance?

Regards,
Sarosh

On Fri, Jun 5, 2020 at 4:49 PM Sarosh Arif <sarosh.arif@emumba.com> wrote:

> rte_exit should be called when the application exits due to
> invalid EAL or application arguments.
>
> Fixes: 850f3733f840 ("examples/packet_ordering: new sample app")
> Cc: sergio.gonzalez.monroy@intel.com
>
> Signed-off-by: Sarosh Arif <sarosh.arif@emumba.com>
> ---
>  examples/packet_ordering/main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/examples/packet_ordering/main.c
> b/examples/packet_ordering/main.c
> index b397b318e..edaf810d9 100644
> --- a/examples/packet_ordering/main.c
> +++ b/examples/packet_ordering/main.c
> @@ -675,7 +675,7 @@ main(int argc, char **argv)
>         /* Initialize EAL */
>         ret = rte_eal_init(argc, argv);
>         if (ret < 0)
> -               return -1;
> +               rte_exit(EXIT_FAILURE, "Invalid EAL arguments\n");
>
>         argc -= ret;
>         argv += ret;
> @@ -683,7 +683,7 @@ main(int argc, char **argv)
>         /* Parse the application specific arguments */
>         ret = parse_args(argc, argv);
>         if (ret < 0)
> -               return -1;
> +               rte_exit(EXIT_FAILURE, "Invalid packet_ordering
> arguments\n");
>
>         /* Check if we have enought cores */
>         if (rte_lcore_count() < 3)
> --
> 2.17.1
>
>
Pattan, Reshma June 23, 2020, 9:22 a.m. UTC | #2 
From: Sarosh Arif <sarosh.arif@emumba.com>
Sent: Tuesday, June 23, 2020 10:19 AM
To: dev@dpdk.org; Pattan, Reshma <reshma.pattan@intel.com>
Subject: Re: [PATCH] examples/packet_ordering: Use rte_exit in case of invalid EAL or application arguments

Hello,
This patch has been sitting around for more than 3 weeks. Is there something that needs to be done further for acceptance?

Regards,
Sarosh

On Fri, Jun 5, 2020 at 4:49 PM Sarosh Arif <sarosh.arif@emumba.com<mailto:sarosh.arif@emumba.com>> wrote:
rte_exit should be called when the application exits due to
invalid EAL or application arguments.

Fixes: 850f3733f840 ("examples/packet_ordering: new sample app")
Cc: sergio.gonzalez.monroy@intel.com<mailto:sergio.gonzalez.monroy@intel.com>

Signed-off-by: Sarosh Arif <sarosh.arif@emumba.com<mailto:sarosh.arif@emumba.com>>
---

I will review it.
Sarosh Arif July 13, 2020, 1:28 p.m. UTC | #3 
Did you get the time to review it?

On Tue, Jun 23, 2020 at 2:22 PM Pattan, Reshma <reshma.pattan@intel.com>
wrote:

>
>
>
>
> *From:* Sarosh Arif <sarosh.arif@emumba.com>
> *Sent:* Tuesday, June 23, 2020 10:19 AM
> *To:* dev@dpdk.org; Pattan, Reshma <reshma.pattan@intel.com>
> *Subject:* Re: [PATCH] examples/packet_ordering: Use rte_exit in case of
> invalid EAL or application arguments
>
>
>
> Hello,
>
> This patch has been sitting around for more than 3 weeks. Is there
> something that needs to be done further for acceptance?
>
>
>
> Regards,
>
> Sarosh
>
>
>
> On Fri, Jun 5, 2020 at 4:49 PM Sarosh Arif <sarosh.arif@emumba.com> wrote:
>
> rte_exit should be called when the application exits due to
> invalid EAL or application arguments.
>
> Fixes: 850f3733f840 ("examples/packet_ordering: new sample app")
> Cc: sergio.gonzalez.monroy@intel.com
>
> Signed-off-by: Sarosh Arif <sarosh.arif@emumba.com>
> ---
>
> I will review it.
>
>
Thomas Monjalon July 30, 2020, 9:21 p.m. UTC | #4 
13/07/2020 15:28, Sarosh Arif:
> Did you get the time to review it?
> 
> On Tue, Jun 23, 2020 at 2:22 PM Pattan, Reshma <reshma.pattan@intel.com>
> wrote:
> > *From:* Sarosh Arif <sarosh.arif@emumba.com>
> >
> > > Hello,
> > > 
> > > This patch has been sitting around for more than 3 weeks. Is there
> > > something that needs to be done further for acceptance?
> > > 
> > > Regards,
> > > 
> > > Sarosh
> > > 
> > > On Fri, Jun 5, 2020 at 4:49 PM Sarosh Arif <sarosh.arif@emumba.com>
> > > wrote:
> > > 
> > > > rte_exit should be called when the application exits due to
> > > > invalid EAL or application arguments.
> > > > 
> > > > Fixes: 850f3733f840 ("examples/packet_ordering: new sample app")
> > > > Cc: sergio.gonzalez.monroy@intel.com
> > > > 
> > > > Signed-off-by: Sarosh Arif <sarosh.arif@emumba.com>
> >
> > I will review it.

Not reviewed, but applied anyway.
diff mbox series

Patch

diff --git a/examples/packet_ordering/main.c b/examples/packet_ordering/main.c
index b397b318e..edaf810d9 100644
--- a/examples/packet_ordering/main.c
+++ b/examples/packet_ordering/main.c
@@ -675,7 +675,7 @@  main(int argc, char **argv)
 	/* Initialize EAL */
 	ret = rte_eal_init(argc, argv);
 	if (ret < 0)
-		return -1;
+		rte_exit(EXIT_FAILURE, "Invalid EAL arguments\n");
 
 	argc -= ret;
 	argv += ret;
@@ -683,7 +683,7 @@  main(int argc, char **argv)
 	/* Parse the application specific arguments */
 	ret = parse_args(argc, argv);
 	if (ret < 0)
-		return -1;
+		rte_exit(EXIT_FAILURE, "Invalid packet_ordering arguments\n");
 
 	/* Check if we have enought cores */
 	if (rte_lcore_count() < 3)