[v1] net/ice: fix PCI DSN to be lowercase values

Message ID 20200528053913.98113-1-haiyue.wang@intel.com (mailing list archive)
State Accepted, archived
Delegated to: xiaolong ye
Headers
Series [v1] net/ice: fix PCI DSN to be lowercase values |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-nxp-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-testing warning Testing issues
ci/Intel-compilation success Compilation OK

Commit Message

Wang, Haiyue May 28, 2020, 5:39 a.m. UTC
  The PCI DSN (device serial number) to format package file name should be
lowercase values.

Fixes: d1c91179e952 ("net/ice: check DSN package file firstly")

Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
---
 drivers/net/ice/ice_dcf_parent.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
  

Comments

Xiaolong Ye May 29, 2020, 1:11 a.m. UTC | #1
On 05/28, Haiyue Wang wrote:
>The PCI DSN (device serial number) to format package file name should be
>lowercase values.
>
>Fixes: d1c91179e952 ("net/ice: check DSN package file firstly")
>
>Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
>---
> drivers/net/ice/ice_dcf_parent.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/net/ice/ice_dcf_parent.c b/drivers/net/ice/ice_dcf_parent.c
>index bdfc7d430..d13e19d78 100644
>--- a/drivers/net/ice/ice_dcf_parent.c
>+++ b/drivers/net/ice/ice_dcf_parent.c
>@@ -242,13 +242,13 @@ ice_dcf_request_pkg_name(struct ice_hw *hw, char *pkg_name)
> 	rte_memcpy(&dsn, pkg_info.dsn, sizeof(dsn));
> 
> 	snprintf(pkg_name, ICE_MAX_PKG_FILENAME_SIZE,
>-		 ICE_PKG_FILE_SEARCH_PATH_UPDATES "ice-%016llX.pkg",
>+		 ICE_PKG_FILE_SEARCH_PATH_UPDATES "ice-%016llx.pkg",
> 		 (unsigned long long)dsn);
> 	if (!access(pkg_name, 0))
> 		return 0;
> 
> 	snprintf(pkg_name, ICE_MAX_PKG_FILENAME_SIZE,
>-		 ICE_PKG_FILE_SEARCH_PATH_DEFAULT "ice-%016llX.pkg",
>+		 ICE_PKG_FILE_SEARCH_PATH_DEFAULT "ice-%016llx.pkg",
> 		 (unsigned long long)dsn);
> 	if (!access(pkg_name, 0))
> 		return 0;
>-- 
>2.26.2
>

Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>

Applied to dpdk-next-net-intel, Thanks.
  

Patch

diff --git a/drivers/net/ice/ice_dcf_parent.c b/drivers/net/ice/ice_dcf_parent.c
index bdfc7d430..d13e19d78 100644
--- a/drivers/net/ice/ice_dcf_parent.c
+++ b/drivers/net/ice/ice_dcf_parent.c
@@ -242,13 +242,13 @@  ice_dcf_request_pkg_name(struct ice_hw *hw, char *pkg_name)
 	rte_memcpy(&dsn, pkg_info.dsn, sizeof(dsn));
 
 	snprintf(pkg_name, ICE_MAX_PKG_FILENAME_SIZE,
-		 ICE_PKG_FILE_SEARCH_PATH_UPDATES "ice-%016llX.pkg",
+		 ICE_PKG_FILE_SEARCH_PATH_UPDATES "ice-%016llx.pkg",
 		 (unsigned long long)dsn);
 	if (!access(pkg_name, 0))
 		return 0;
 
 	snprintf(pkg_name, ICE_MAX_PKG_FILENAME_SIZE,
-		 ICE_PKG_FILE_SEARCH_PATH_DEFAULT "ice-%016llX.pkg",
+		 ICE_PKG_FILE_SEARCH_PATH_DEFAULT "ice-%016llx.pkg",
 		 (unsigned long long)dsn);
 	if (!access(pkg_name, 0))
 		return 0;