app: fix usage help of options separated by dashes
Checks
Commit Message
The EAL options and app-specific options are separated
with double dashes.
The help of testpmd, test-acl and pdump were missing
the dashes after EAL options.
Note: testpmd was completely missing the EAL options.
Fixes: af75078fece3 ("first public release")
Fixes: 26c057ab6c45 ("acl: new test-acl application")
Fixes: b2854d5317e8 ("app/pdump: support multi-core capture")
Cc: vipin.varghese@intel.com
Cc: stable@dpdk.org
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
app/pdump/main.c | 2 +-
app/test-acl/main.c | 2 +-
app/test-pmd/parameters.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
Comments
On Tue, Apr 21, 2020 at 01:25:31AM +0200, Thomas Monjalon wrote:
> The EAL options and app-specific options are separated
> with double dashes.
>
> The help of testpmd, test-acl and pdump were missing
> the dashes after EAL options.
> Note: testpmd was completely missing the EAL options.
>
> Fixes: af75078fece3 ("first public release")
> Fixes: 26c057ab6c45 ("acl: new test-acl application")
> Fixes: b2854d5317e8 ("app/pdump: support multi-core capture")
> Cc: vipin.varghese@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
On Tue, Apr 21, 2020 at 01:25:31AM +0200, Thomas Monjalon wrote:
> The EAL options and app-specific options are separated
> with double dashes.
>
> The help of testpmd, test-acl and pdump were missing
> the dashes after EAL options.
> Note: testpmd was completely missing the EAL options.
>
> Fixes: af75078fece3 ("first public release")
> Fixes: 26c057ab6c45 ("acl: new test-acl application")
> Fixes: b2854d5317e8 ("app/pdump: support multi-core capture")
> Cc: vipin.varghese@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
On Tue, Apr 21, 2020 at 1:26 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> The EAL options and app-specific options are separated
> with double dashes.
>
> The help of testpmd, test-acl and pdump were missing
> the dashes after EAL options.
> Note: testpmd was completely missing the EAL options.
>
> Fixes: af75078fece3 ("first public release")
> Fixes: 26c057ab6c45 ("acl: new test-acl application")
> Fixes: b2854d5317e8 ("app/pdump: support multi-core capture")
> Cc: stable@dpdk.org
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks.
@@ -151,7 +151,7 @@ static uint8_t multiple_core_capture;
static void
pdump_usage(const char *prgname)
{
- printf("usage: %s [EAL options]"
+ printf("usage: %s [EAL options] --"
" --["CMD_LINE_OPT_MULTI"]\n"
" --"CMD_LINE_OPT_PDUMP" "
"'(port=<port id> | device_id=<pci id or vdev name>),"
@@ -12,7 +12,7 @@
#include <rte_lcore.h>
#include <rte_ip.h>
-#define PRINT_USAGE_START "%s [EAL options]\n"
+#define PRINT_USAGE_START "%s [EAL options] --\n"
#define RTE_LOGTYPE_TESTACL RTE_LOGTYPE_USER1
@@ -49,7 +49,7 @@
static void
usage(char* progname)
{
- printf("usage: %s "
+ printf("usage: %s [EAL options] -- "
#ifdef RTE_LIBRTE_CMDLINE
"[--interactive|-i] "
"[--cmdline-file=FILENAME] "