devtools: skip ABI check in static builds
Checks
Commit Message
When running make with CONFIG_RTE_BUILD_SHARED_LIB=n,
no shared library is built.
In this case, no need to run ABI check.
With meson, both shared and static libraries are always built.
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
devtools/test-build.sh | 1 +
1 file changed, 1 insertion(+)
Comments
On 21/04/2020 02:33, Thomas Monjalon wrote:
> When running make with CONFIG_RTE_BUILD_SHARED_LIB=n,
> no shared library is built.
> In this case, no need to run ABI check.
>
> With meson, both shared and static libraries are always built.
You can easily do the same thing for meson, by checking the 3rd parameter to build() in test-meson-build.sh,
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> devtools/test-build.sh | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/devtools/test-build.sh b/devtools/test-build.sh
> index a298115002..6e53f86fc8 100755
> --- a/devtools/test-build.sh
> +++ b/devtools/test-build.sh
> @@ -262,6 +262,7 @@ for conf in $configs ; do
> EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \
> O=$(readlink -f $dir)/examples
> unset RTE_TARGET
> + grep -q 'SHARED_LIB=n' $dir/.config || # skip ABI check with static libs
> if [ -n "$DPDK_ABI_REF_VERSION" ]; then
> abirefdir=${DPDK_ABI_REF_DIR:-reference}/$DPDK_ABI_REF_VERSION
> if [ ! -d $abirefdir/$conf ]; then
>
Reviewed-by: Ray Kinsella <mdr@ashroe.eu>
On Tue, Apr 21, 2020 at 3:33 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> When running make with CONFIG_RTE_BUILD_SHARED_LIB=n,
> no shared library is built.
> In this case, no need to run ABI check.
>
> With meson, both shared and static libraries are always built.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: David Marchand <david.marchand@redhat.com>
21/04/2020 08:11, Ray Kinsella:
>
> On 21/04/2020 02:33, Thomas Monjalon wrote:
> > When running make with CONFIG_RTE_BUILD_SHARED_LIB=n,
> > no shared library is built.
> > In this case, no need to run ABI check.
> >
> > With meson, both shared and static libraries are always built.
>
> You can easily do the same thing for meson, by checking the 3rd parameter to build() in test-meson-build.sh,
No, both library types are always compiled.
The only option is to choose which library to link in built-in apps.
21/04/2020 10:02, David Marchand:
> On Tue, Apr 21, 2020 at 3:33 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > When running make with CONFIG_RTE_BUILD_SHARED_LIB=n,
> > no shared library is built.
> > In this case, no need to run ABI check.
> >
> > With meson, both shared and static libraries are always built.
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>
> Acked-by: David Marchand <david.marchand@redhat.com>
Reviewed-by: Ray Kinsella <mdr@ashroe.eu>
Applied
@@ -262,6 +262,7 @@ for conf in $configs ; do
EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \
O=$(readlink -f $dir)/examples
unset RTE_TARGET
+ grep -q 'SHARED_LIB=n' $dir/.config || # skip ABI check with static libs
if [ -n "$DPDK_ABI_REF_VERSION" ]; then
abirefdir=${DPDK_ABI_REF_DIR:-reference}/$DPDK_ABI_REF_VERSION
if [ ! -d $abirefdir/$conf ]; then