[v3,1/4] build: port arm32 options from make to meson
Checks
Commit Message
config/defconfig_arm-armv7a-linux-gcc contains a number of
CONFIG_RTE_LIBRTE_ options. Implement those in applicable meson.build
files.
Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
---
drivers/net/ark/meson.build | 6 ++++++
drivers/net/avp/meson.build | 5 +++++
drivers/net/cxgbe/meson.build | 6 ++++++
drivers/net/e1000/meson.build | 6 ++++++
drivers/net/enic/meson.build | 6 ++++++
drivers/net/fm10k/meson.build | 6 ++++++
drivers/net/hinic/meson.build | 6 ++++++
drivers/net/i40e/meson.build | 6 ++++++
drivers/net/ionic/meson.build | 6 ++++++
drivers/net/ixgbe/meson.build | 6 ++++++
drivers/net/qede/meson.build | 6 ++++++
drivers/net/vmxnet3/meson.build | 6 ++++++
lib/librte_vhost/meson.build | 2 +-
13 files changed, 72 insertions(+), 1 deletion(-)
Comments
On Wed, 2020-04-15 at 11:03 +0200, Juraj Linkeš wrote:
> config/defconfig_arm-armv7a-linux-gcc contains a number of
> CONFIG_RTE_LIBRTE_ options. Implement those in applicable meson.build
> files.
>
> Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> ---
> drivers/net/ark/meson.build | 6 ++++++
> drivers/net/avp/meson.build | 5 +++++
> drivers/net/cxgbe/meson.build | 6 ++++++
> drivers/net/e1000/meson.build | 6 ++++++
> drivers/net/enic/meson.build | 6 ++++++
> drivers/net/fm10k/meson.build | 6 ++++++
> drivers/net/hinic/meson.build | 6 ++++++
> drivers/net/i40e/meson.build | 6 ++++++
> drivers/net/ionic/meson.build | 6 ++++++
> drivers/net/ixgbe/meson.build | 6 ++++++
> drivers/net/qede/meson.build | 6 ++++++
> drivers/net/vmxnet3/meson.build | 6 ++++++
> lib/librte_vhost/meson.build | 2 +-
> 13 files changed, 72 insertions(+), 1 deletion(-)
This is disabling a lot of drivers that are building just fine on armv7
at the moment, and thus it is a backward-incomaptible change.
Eg:
https://packages.debian.org/sid/armhf/librte-pmd-cxgbe20.0/filelist
Hi Luca,
> -----Original Message-----
> From: Luca Boccassi <bluca@debian.org>
> Sent: Wednesday, April 15, 2020 1:45 PM
> To: Juraj Linkeš <juraj.linkes@pantheon.tech>; bruce.richardson@intel.com;
> aconole@redhat.com; maicolgabriel@hotmail.com; Ruifeng.Wang@arm.com
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 1/4] build: port arm32 options from make to
> meson
>
> On Wed, 2020-04-15 at 11:03 +0200, Juraj Linkeš wrote:
> > config/defconfig_arm-armv7a-linux-gcc contains a number of
> > CONFIG_RTE_LIBRTE_ options. Implement those in applicable meson.build
> > files.
> >
> > Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> > ---
> > drivers/net/ark/meson.build | 6 ++++++
> > drivers/net/avp/meson.build | 5 +++++
> > drivers/net/cxgbe/meson.build | 6 ++++++
> > drivers/net/e1000/meson.build | 6 ++++++
> > drivers/net/enic/meson.build | 6 ++++++
> > drivers/net/fm10k/meson.build | 6 ++++++
> > drivers/net/hinic/meson.build | 6 ++++++
> > drivers/net/i40e/meson.build | 6 ++++++
> > drivers/net/ionic/meson.build | 6 ++++++
> > drivers/net/ixgbe/meson.build | 6 ++++++
> > drivers/net/qede/meson.build | 6 ++++++
> > drivers/net/vmxnet3/meson.build | 6 ++++++
> > lib/librte_vhost/meson.build | 2 +-
> > 13 files changed, 72 insertions(+), 1 deletion(-)
>
> This is disabling a lot of drivers that are building just fine on armv7 at the
> moment, and thus it is a backward-incomaptible change.
>
> Eg:
>
> https://packages.debian.org/sid/armhf/librte-pmd-cxgbe20.0/filelist
>
> --
> Luca Boccassi <bluca@debian.org>
I guess that means config/defconfig_arm-armv7a-linux-gcc is outdated? I've tried to build all of the drivers and they build except for ixgbe. Seeing as https://packages.debian.org/sid/armhf/libs/librte-pmd-ixgbe20.0 exists, would disabling ixgbe be also a backwards incompatible change?
Thanks,
Juraj
On Thu, 2020-04-16 at 06:16 +0000, Juraj Linkeš wrote:
> Hi Luca,
>
> > -----Original Message-----
> > From: Luca Boccassi <bluca@debian.org>
> > Sent: Wednesday, April 15, 2020 1:45 PM
> > To: Juraj Linkeš <juraj.linkes@pantheon.tech>; bruce.richardson@intel.com;
> > aconole@redhat.com; maicolgabriel@hotmail.com; Ruifeng.Wang@arm.com
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH v3 1/4] build: port arm32 options from make to
> > meson
> >
> > On Wed, 2020-04-15 at 11:03 +0200, Juraj Linkeš wrote:
> > > config/defconfig_arm-armv7a-linux-gcc contains a number of
> > > CONFIG_RTE_LIBRTE_ options. Implement those in applicable meson.build
> > > files.
> > >
> > > Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> > > ---
> > > drivers/net/ark/meson.build | 6 ++++++
> > > drivers/net/avp/meson.build | 5 +++++
> > > drivers/net/cxgbe/meson.build | 6 ++++++
> > > drivers/net/e1000/meson.build | 6 ++++++
> > > drivers/net/enic/meson.build | 6 ++++++
> > > drivers/net/fm10k/meson.build | 6 ++++++
> > > drivers/net/hinic/meson.build | 6 ++++++
> > > drivers/net/i40e/meson.build | 6 ++++++
> > > drivers/net/ionic/meson.build | 6 ++++++
> > > drivers/net/ixgbe/meson.build | 6 ++++++
> > > drivers/net/qede/meson.build | 6 ++++++
> > > drivers/net/vmxnet3/meson.build | 6 ++++++
> > > lib/librte_vhost/meson.build | 2 +-
> > > 13 files changed, 72 insertions(+), 1 deletion(-)
> >
> > This is disabling a lot of drivers that are building just fine on armv7 at the
> > moment, and thus it is a backward-incomaptible change.
> >
> > Eg:
> >
> > https://packages.debian.org/sid/armhf/librte-pmd-cxgbe20.0/filelist
> >
> > --
> > Luca Boccassi <bluca@debian.org>
>
> I guess that means config/defconfig_arm-armv7a-linux-gcc is outdated? I've tried to build all of the drivers and they build except for ixgbe. Seeing as https://packages.debian.org/sid/armhf/libs/librte-pmd-ixgbe20.0 exists, would disabling ixgbe be also a backwards incompatible change?
>
> Thanks,
> Juraj
Yes. That defconfig is specific to the deprecated GNU Make build
system, which I haven't used in a long time. I do not know if anybody
keeps it updated.
What is the issue you are seeing with ixgbe?
> -----Original Message-----
> From: Luca Boccassi <bluca@debian.org>
> Sent: Thursday, April 16, 2020 10:53 AM
> To: Juraj Linkeš <juraj.linkes@pantheon.tech>; bruce.richardson@intel.com;
> aconole@redhat.com; maicolgabriel@hotmail.com; Ruifeng.Wang@arm.com
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 1/4] build: port arm32 options from make to
> meson
>
> On Thu, 2020-04-16 at 06:16 +0000, Juraj Linkeš wrote:
> > Hi Luca,
> >
> > > -----Original Message-----
> > > From: Luca Boccassi <bluca@debian.org>
> > > Sent: Wednesday, April 15, 2020 1:45 PM
> > > To: Juraj Linkeš <juraj.linkes@pantheon.tech>;
> > > bruce.richardson@intel.com; aconole@redhat.com;
> > > maicolgabriel@hotmail.com; Ruifeng.Wang@arm.com
> > > Cc: dev@dpdk.org
> > > Subject: Re: [dpdk-dev] [PATCH v3 1/4] build: port arm32 options
> > > from make to meson
> > >
> > > On Wed, 2020-04-15 at 11:03 +0200, Juraj Linkeš wrote:
> > > > config/defconfig_arm-armv7a-linux-gcc contains a number of
> > > > CONFIG_RTE_LIBRTE_ options. Implement those in applicable
> > > > meson.build files.
> > > >
> > > > Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> > > > ---
> > > > drivers/net/ark/meson.build | 6 ++++++
> > > > drivers/net/avp/meson.build | 5 +++++
> > > > drivers/net/cxgbe/meson.build | 6 ++++++
> > > > drivers/net/e1000/meson.build | 6 ++++++
> > > > drivers/net/enic/meson.build | 6 ++++++
> > > > drivers/net/fm10k/meson.build | 6 ++++++
> > > > drivers/net/hinic/meson.build | 6 ++++++
> > > > drivers/net/i40e/meson.build | 6 ++++++
> > > > drivers/net/ionic/meson.build | 6 ++++++
> > > > drivers/net/ixgbe/meson.build | 6 ++++++
> > > > drivers/net/qede/meson.build | 6 ++++++
> > > > drivers/net/vmxnet3/meson.build | 6 ++++++
> > > > lib/librte_vhost/meson.build | 2 +-
> > > > 13 files changed, 72 insertions(+), 1 deletion(-)
> > >
> > > This is disabling a lot of drivers that are building just fine on
> > > armv7 at the moment, and thus it is a backward-incomaptible change.
> > >
> > > Eg:
> > >
> > > https://packages.debian.org/sid/armhf/librte-pmd-cxgbe20.0/filelist
> > >
> > > --
> > > Luca Boccassi <bluca@debian.org>
> >
> > I guess that means config/defconfig_arm-armv7a-linux-gcc is outdated? I've
> tried to build all of the drivers and they build except for ixgbe. Seeing as
> https://packages.debian.org/sid/armhf/libs/librte-pmd-ixgbe20.0 exists, would
> disabling ixgbe be also a backwards incompatible change?
> >
> > Thanks,
> > Juraj
>
> Yes. That defconfig is specific to the deprecated GNU Make build system, which
> I haven't used in a long time. I do not know if anybody keeps it updated.
>
> What is the issue you are seeing with ixgbe?
There are a lot of issues, please have a look here: https://travis-ci.com/github/jlinkes/dpdk/jobs/319965296#L1932
Juraj
On Thu, 2020-04-16 at 11:25 +0000, Juraj Linkeš wrote:
> > -----Original Message-----
> > From: Luca Boccassi <bluca@debian.org>
> > Sent: Thursday, April 16, 2020 10:53 AM
> > To: Juraj Linkeš <juraj.linkes@pantheon.tech>; bruce.richardson@intel.com;
> > aconole@redhat.com; maicolgabriel@hotmail.com; Ruifeng.Wang@arm.com
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH v3 1/4] build: port arm32 options from make to
> > meson
> >
> > On Thu, 2020-04-16 at 06:16 +0000, Juraj Linkeš wrote:
> > > Hi Luca,
> > >
> > > > -----Original Message-----
> > > > From: Luca Boccassi <bluca@debian.org>
> > > > Sent: Wednesday, April 15, 2020 1:45 PM
> > > > To: Juraj Linkeš <juraj.linkes@pantheon.tech>;
> > > > bruce.richardson@intel.com; aconole@redhat.com;
> > > > maicolgabriel@hotmail.com; Ruifeng.Wang@arm.com
> > > > Cc: dev@dpdk.org
> > > > Subject: Re: [dpdk-dev] [PATCH v3 1/4] build: port arm32 options
> > > > from make to meson
> > > >
> > > > On Wed, 2020-04-15 at 11:03 +0200, Juraj Linkeš wrote:
> > > > > config/defconfig_arm-armv7a-linux-gcc contains a number of
> > > > > CONFIG_RTE_LIBRTE_ options. Implement those in applicable
> > > > > meson.build files.
> > > > >
> > > > > Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> > > > > ---
> > > > > drivers/net/ark/meson.build | 6 ++++++
> > > > > drivers/net/avp/meson.build | 5 +++++
> > > > > drivers/net/cxgbe/meson.build | 6 ++++++
> > > > > drivers/net/e1000/meson.build | 6 ++++++
> > > > > drivers/net/enic/meson.build | 6 ++++++
> > > > > drivers/net/fm10k/meson.build | 6 ++++++
> > > > > drivers/net/hinic/meson.build | 6 ++++++
> > > > > drivers/net/i40e/meson.build | 6 ++++++
> > > > > drivers/net/ionic/meson.build | 6 ++++++
> > > > > drivers/net/ixgbe/meson.build | 6 ++++++
> > > > > drivers/net/qede/meson.build | 6 ++++++
> > > > > drivers/net/vmxnet3/meson.build | 6 ++++++
> > > > > lib/librte_vhost/meson.build | 2 +-
> > > > > 13 files changed, 72 insertions(+), 1 deletion(-)
> > > >
> > > > This is disabling a lot of drivers that are building just fine on
> > > > armv7 at the moment, and thus it is a backward-incomaptible change.
> > > >
> > > > Eg:
> > > >
> > > > https://packages.debian.org/sid/armhf/librte-pmd-cxgbe20.0/filelist
> > > >
> > > > --
> > > > Luca Boccassi <bluca@debian.org>
> > >
> > > I guess that means config/defconfig_arm-armv7a-linux-gcc is outdated? I've
> > tried to build all of the drivers and they build except for ixgbe. Seeing as
> > https://packages.debian.org/sid/armhf/libs/librte-pmd-ixgbe20.0 exists, would
> > disabling ixgbe be also a backwards incompatible change?
> > > Thanks,
> > > Juraj
> >
> > Yes. That defconfig is specific to the deprecated GNU Make build system, which
> > I haven't used in a long time. I do not know if anybody keeps it updated.
> >
> > What is the issue you are seeing with ixgbe?
>
> There are a lot of issues, please have a look here: https://travis-ci.com/github/jlinkes/dpdk/jobs/319965296#L1932
>
> Juraj
Given it worked fine in 19.11, I'd say they are either regressions or
issues in the travis setup itself.
> -----Original Message-----
> From: Luca Boccassi <bluca@debian.org>
> Sent: Thursday, April 16, 2020 2:01 PM
> To: Juraj Linkeš <juraj.linkes@pantheon.tech>; bruce.richardson@intel.com;
> aconole@redhat.com; maicolgabriel@hotmail.com; Ruifeng.Wang@arm.com
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 1/4] build: port arm32 options from make to
> meson
>
> On Thu, 2020-04-16 at 11:25 +0000, Juraj Linkeš wrote:
> > > -----Original Message-----
> > > From: Luca Boccassi <bluca@debian.org>
> > > Sent: Thursday, April 16, 2020 10:53 AM
> > > To: Juraj Linkeš <juraj.linkes@pantheon.tech>;
> > > bruce.richardson@intel.com; aconole@redhat.com;
> > > maicolgabriel@hotmail.com; Ruifeng.Wang@arm.com
> > > Cc: dev@dpdk.org
> > > Subject: Re: [dpdk-dev] [PATCH v3 1/4] build: port arm32 options
> > > from make to meson
> > >
> > > On Thu, 2020-04-16 at 06:16 +0000, Juraj Linkeš wrote:
> > > > Hi Luca,
> > > >
> > > > > -----Original Message-----
> > > > > From: Luca Boccassi <bluca@debian.org>
> > > > > Sent: Wednesday, April 15, 2020 1:45 PM
> > > > > To: Juraj Linkeš <juraj.linkes@pantheon.tech>;
> > > > > bruce.richardson@intel.com; aconole@redhat.com;
> > > > > maicolgabriel@hotmail.com; Ruifeng.Wang@arm.com
> > > > > Cc: dev@dpdk.org
> > > > > Subject: Re: [dpdk-dev] [PATCH v3 1/4] build: port arm32 options
> > > > > from make to meson
> > > > >
> > > > > On Wed, 2020-04-15 at 11:03 +0200, Juraj Linkeš wrote:
> > > > > > config/defconfig_arm-armv7a-linux-gcc contains a number of
> > > > > > CONFIG_RTE_LIBRTE_ options. Implement those in applicable
> > > > > > meson.build files.
> > > > > >
> > > > > > Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> > > > > > ---
> > > > > > drivers/net/ark/meson.build | 6 ++++++
> > > > > > drivers/net/avp/meson.build | 5 +++++
> > > > > > drivers/net/cxgbe/meson.build | 6 ++++++
> > > > > > drivers/net/e1000/meson.build | 6 ++++++
> > > > > > drivers/net/enic/meson.build | 6 ++++++
> > > > > > drivers/net/fm10k/meson.build | 6 ++++++
> > > > > > drivers/net/hinic/meson.build | 6 ++++++
> > > > > > drivers/net/i40e/meson.build | 6 ++++++
> > > > > > drivers/net/ionic/meson.build | 6 ++++++
> > > > > > drivers/net/ixgbe/meson.build | 6 ++++++
> > > > > > drivers/net/qede/meson.build | 6 ++++++
> > > > > > drivers/net/vmxnet3/meson.build | 6 ++++++
> > > > > > lib/librte_vhost/meson.build | 2 +-
> > > > > > 13 files changed, 72 insertions(+), 1 deletion(-)
> > > > >
> > > > > This is disabling a lot of drivers that are building just fine
> > > > > on
> > > > > armv7 at the moment, and thus it is a backward-incomaptible change.
> > > > >
> > > > > Eg:
> > > > >
> > > > > https://packages.debian.org/sid/armhf/librte-pmd-cxgbe20.0/filel
> > > > > ist
> > > > >
> > > > > --
> > > > > Luca Boccassi <bluca@debian.org>
> > > >
> > > > I guess that means config/defconfig_arm-armv7a-linux-gcc is
> > > > outdated? I've
> > > tried to build all of the drivers and they build except for ixgbe.
> > > Seeing as
> > > https://packages.debian.org/sid/armhf/libs/librte-pmd-ixgbe20.0
> > > exists, would disabling ixgbe be also a backwards incompatible change?
> > > > Thanks,
> > > > Juraj
> > >
> > > Yes. That defconfig is specific to the deprecated GNU Make build
> > > system, which I haven't used in a long time. I do not know if anybody keeps it
> updated.
> > >
> > > What is the issue you are seeing with ixgbe?
> >
> > There are a lot of issues, please have a look here:
> > https://travis-ci.com/github/jlinkes/dpdk/jobs/319965296#L1932
> >
> > Juraj
>
> Given it worked fine in 19.11, I'd say they are either regressions or issues in the
> travis setup itself.
I'd wager it's because of https://github.com/DPDK/dpdk/commit/41b059a20215284e8aa618d2ce1e2a803e64c1d0#diff-f44e12b03243963c21a46a37392568db
When I don't build with ixgbe_rxtx_vec_neon.c it builds fine, indicating real problems with the code.
Ruifeng, would you please take a look at the failures here? https://travis-ci.com/github/jlinkes/dpdk/jobs/319965296#L1932
Juraj
> -----Original Message-----
> From: Juraj Linkeš <juraj.linkes@pantheon.tech>
> Sent: Thursday, April 16, 2020 8:22 PM
> To: Luca Boccassi <bluca@debian.org>; bruce.richardson@intel.com;
> aconole@redhat.com; maicolgabriel@hotmail.com; Ruifeng Wang
> <Ruifeng.Wang@arm.com>
> Cc: dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v3 1/4] build: port arm32 options from make
> to meson
>
>
>
> > -----Original Message-----
> > From: Luca Boccassi <bluca@debian.org>
> > Sent: Thursday, April 16, 2020 2:01 PM
> > To: Juraj Linkeš <juraj.linkes@pantheon.tech>;
> > bruce.richardson@intel.com; aconole@redhat.com;
> > maicolgabriel@hotmail.com; Ruifeng.Wang@arm.com
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH v3 1/4] build: port arm32 options from
> > make to meson
> >
> > On Thu, 2020-04-16 at 11:25 +0000, Juraj Linkeš wrote:
> > > > -----Original Message-----
> > > > From: Luca Boccassi <bluca@debian.org>
> > > > Sent: Thursday, April 16, 2020 10:53 AM
> > > > To: Juraj Linkeš <juraj.linkes@pantheon.tech>;
> > > > bruce.richardson@intel.com; aconole@redhat.com;
> > > > maicolgabriel@hotmail.com; Ruifeng.Wang@arm.com
> > > > Cc: dev@dpdk.org
> > > > Subject: Re: [dpdk-dev] [PATCH v3 1/4] build: port arm32 options
> > > > from make to meson
> > > >
> > > > On Thu, 2020-04-16 at 06:16 +0000, Juraj Linkeš wrote:
> > > > > Hi Luca,
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: Luca Boccassi <bluca@debian.org>
> > > > > > Sent: Wednesday, April 15, 2020 1:45 PM
> > > > > > To: Juraj Linkeš <juraj.linkes@pantheon.tech>;
> > > > > > bruce.richardson@intel.com; aconole@redhat.com;
> > > > > > maicolgabriel@hotmail.com; Ruifeng.Wang@arm.com
> > > > > > Cc: dev@dpdk.org
> > > > > > Subject: Re: [dpdk-dev] [PATCH v3 1/4] build: port arm32
> > > > > > options from make to meson
> > > > > >
> > > > > > On Wed, 2020-04-15 at 11:03 +0200, Juraj Linkeš wrote:
> > > > > > > config/defconfig_arm-armv7a-linux-gcc contains a number of
> > > > > > > CONFIG_RTE_LIBRTE_ options. Implement those in applicable
> > > > > > > meson.build files.
> > > > > > >
> > > > > > > Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> > > > > > > ---
> > > > > > > drivers/net/ark/meson.build | 6 ++++++
> > > > > > > drivers/net/avp/meson.build | 5 +++++
> > > > > > > drivers/net/cxgbe/meson.build | 6 ++++++
> > > > > > > drivers/net/e1000/meson.build | 6 ++++++
> > > > > > > drivers/net/enic/meson.build | 6 ++++++
> > > > > > > drivers/net/fm10k/meson.build | 6 ++++++
> > > > > > > drivers/net/hinic/meson.build | 6 ++++++
> > > > > > > drivers/net/i40e/meson.build | 6 ++++++
> > > > > > > drivers/net/ionic/meson.build | 6 ++++++
> > > > > > > drivers/net/ixgbe/meson.build | 6 ++++++
> > > > > > > drivers/net/qede/meson.build | 6 ++++++
> > > > > > > drivers/net/vmxnet3/meson.build | 6 ++++++
> > > > > > > lib/librte_vhost/meson.build | 2 +-
> > > > > > > 13 files changed, 72 insertions(+), 1 deletion(-)
> > > > > >
> > > > > > This is disabling a lot of drivers that are building just fine
> > > > > > on
> > > > > > armv7 at the moment, and thus it is a backward-incomaptible
> change.
> > > > > >
> > > > > > Eg:
> > > > > >
> > > > > > https://packages.debian.org/sid/armhf/librte-pmd-cxgbe20.0/fil
> > > > > > el
> > > > > > ist
> > > > > >
> > > > > > --
> > > > > > Luca Boccassi <bluca@debian.org>
> > > > >
> > > > > I guess that means config/defconfig_arm-armv7a-linux-gcc is
> > > > > outdated? I've
> > > > tried to build all of the drivers and they build except for ixgbe.
> > > > Seeing as
> > > > https://packages.debian.org/sid/armhf/libs/librte-pmd-ixgbe20.0
> > > > exists, would disabling ixgbe be also a backwards incompatible change?
> > > > > Thanks,
> > > > > Juraj
> > > >
> > > > Yes. That defconfig is specific to the deprecated GNU Make build
> > > > system, which I haven't used in a long time. I do not know if
> > > > anybody keeps it
> > updated.
> > > >
> > > > What is the issue you are seeing with ixgbe?
> > >
> > > There are a lot of issues, please have a look here:
> > > https://travis-ci.com/github/jlinkes/dpdk/jobs/319965296#L1932
> > >
> > > Juraj
> >
> > Given it worked fine in 19.11, I'd say they are either regressions or
> > issues in the travis setup itself.
>
> I'd wager it's because of
> https://github.com/DPDK/dpdk/commit/41b059a20215284e8aa618d2ce1e2a
> 803e64c1d0#diff-f44e12b03243963c21a46a37392568db
>
> When I don't build with ixgbe_rxtx_vec_neon.c it builds fine, indicating real
> problems with the code.
>
> Ruifeng, would you please take a look at the failures here? https://travis-
> ci.com/github/jlinkes/dpdk/jobs/319965296#L1932
>
Yes. I see couple of problems with ixgbe_rxtx_vec_neon.c when building for AArch32.
I will submit patches to fix these.
Thanks.
/Ruifeng
> Juraj
@@ -1,6 +1,12 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2018 Intel Corporation
+if dpdk_conf.has('RTE_ARCH_ARMv7')
+ build = false
+ reason = 'Not supported on 32-bit arm'
+ subdir_done()
+endif
+
sources = files('ark_ddm.c',
'ark_ethdev.c',
'ark_ethdev_rx.c',
@@ -4,7 +4,12 @@
if not is_linux
build = false
reason = 'only supported on linux'
+elif dpdk_conf.has('RTE_ARCH_ARMv7')
+ build = false
+ reason = 'Not supported on 32-bit arm'
+ subdir_done()
endif
+
allow_experimental_apis = true
sources = files('avp_ethdev.c')
install_headers('rte_avp_common.h', 'rte_avp_fifo.h')
@@ -1,6 +1,12 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2018 Intel Corporation
+if dpdk_conf.has('RTE_ARCH_ARMv7')
+ build = false
+ reason = 'Not supported on 32-bit arm'
+ subdir_done()
+endif
+
sources = files('cxgbe_ethdev.c',
'cxgbe_main.c',
'cxgbevf_ethdev.c',
@@ -1,6 +1,12 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2017 Intel Corporation
+if dpdk_conf.has('RTE_ARCH_ARMv7')
+ build = false
+ reason = 'Not supported on 32-bit arm'
+ subdir_done()
+endif
+
allow_experimental_apis = true
subdir('base')
@@ -1,6 +1,12 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2018 Cisco Systems, Inc.
+if dpdk_conf.has('RTE_ARCH_ARMv7')
+ build = false
+ reason = 'Not supported on 32-bit arm'
+ subdir_done()
+endif
+
# Experimental APIs used: rte_intr_ack
cflags += ['-DALLOW_EXPERIMENTAL_API']
sources = files(
@@ -1,6 +1,12 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2017 Intel Corporation
+if dpdk_conf.has('RTE_ARCH_ARMv7')
+ build = false
+ reason = 'Not supported on 32-bit arm'
+ subdir_done()
+endif
+
allow_experimental_apis = true
subdir('base')
@@ -1,6 +1,12 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2017 Huawei Technologies Co., Ltd
+if dpdk_conf.has('RTE_ARCH_ARMv7')
+ build = false
+ reason = 'Not supported on 32-bit arm'
+ subdir_done()
+endif
+
subdir('base')
objs = [base_objs]
@@ -1,6 +1,12 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2017 Intel Corporation
+if dpdk_conf.has('RTE_ARCH_ARMv7')
+ build = false
+ reason = 'Not supported on 32-bit arm'
+ subdir_done()
+endif
+
cflags += ['-DPF_DRIVER',
'-DVF_DRIVER',
'-DINTEGRATED_VF',
@@ -1,6 +1,12 @@
# SPDX-License-Identifier: (BSD-3-Clause OR GPL-2.0)
# Copyright(c) 2019 Pensando
+if dpdk_conf.has('RTE_ARCH_ARMv7')
+ build = false
+ reason = 'Not supported on 32-bit arm'
+ subdir_done()
+endif
+
sources = files(
'ionic_mac_api.c',
'ionic_rx_filter.c',
@@ -1,6 +1,12 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2017 Intel Corporation
+if dpdk_conf.has('RTE_ARCH_ARMv7')
+ build = false
+ reason = 'Not supported on 32-bit arm'
+ subdir_done()
+endif
+
cflags += ['-DRTE_LIBRTE_IXGBE_BYPASS']
allow_experimental_apis = true
@@ -1,6 +1,12 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2018 Luca Boccassi <bluca@debian.org>
+if dpdk_conf.has('RTE_ARCH_ARMv7')
+ build = false
+ reason = 'Not supported on 32-bit arm'
+ subdir_done()
+endif
+
allow_experimental_apis = true
subdir('base')
@@ -1,6 +1,12 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2018 Luca Boccassi <bluca@debian.org>
+if dpdk_conf.has('RTE_ARCH_ARMv7')
+ build = false
+ reason = 'Not supported on 32-bit arm'
+ subdir_done()
+endif
+
allow_experimental_apis = true
sources += files(
'vmxnet3_ethdev.c',
@@ -5,7 +5,7 @@ if not is_linux
build = false
reason = 'only supported on linux'
endif
-if has_libnuma == 1
+if has_libnuma == 1 and not dpdk_conf.has('RTE_ARCH_ARMv7')
dpdk_conf.set10('RTE_LIBRTE_VHOST_NUMA', true)
endif
if (toolchain == 'gcc' and cc.version().version_compare('>=8.3.0'))