mbox series

[0/2] Fix Vhost PMD setup

Message ID 20200218172240.558516-1-maxime.coquelin@redhat.com (mailing list archive)
Headers
Series Fix Vhost PMD setup |

Message

Maxime Coquelin Feb. 18, 2020, 5:22 p.m. UTC 
  This series fixes regression introduced in v20.02-rc3.
First patch fixes the error path, and second one fix
Vhost device reconfigure issue reported by Yinan.

v2:
---
- Fix error path order (David)

Maxime Coquelin (2):
  net/vhost: fix Vhost setup error path
  net/vhost: prevent multiple setup on reconfig

 drivers/net/vhost/rte_eth_vhost.c | 26 +++++++++++++++++++-------
 1 file changed, 19 insertions(+), 7 deletions(-)

Comments

Maxime Coquelin Feb. 18, 2020, 5:25 p.m. UTC | #1 
Sorry, just see I missed the v2 prefix.

On 2/18/20 6:22 PM, Maxime Coquelin wrote:
> This series fixes regression introduced in v20.02-rc3.
> First patch fixes the error path, and second one fix
> Vhost device reconfigure issue reported by Yinan.
> 
> v2:
> ---
> - Fix error path order (David)
> 
> Maxime Coquelin (2):
>   net/vhost: fix Vhost setup error path
>   net/vhost: prevent multiple setup on reconfig
> 
>  drivers/net/vhost/rte_eth_vhost.c | 26 +++++++++++++++++++-------
>  1 file changed, 19 insertions(+), 7 deletions(-)
>
Itsuro Oda Feb. 18, 2020, 10:37 p.m. UTC | #2 
Hi Yinan, Maxime, David,

Thank you for quick test, fix and review.
It looks good to me.

The original fix has been queued to stable 19.11.1.
It should be rejected or applied this fix too.

Thanks.
Itsuto Oda

On Tue, 18 Feb 2020 18:22:38 +0100
Maxime Coquelin <maxime.coquelin@redhat.com> wrote:

> This series fixes regression introduced in v20.02-rc3.
> First patch fixes the error path, and second one fix
> Vhost device reconfigure issue reported by Yinan.
> 
> v2:
> ---
> - Fix error path order (David)
> 
> Maxime Coquelin (2):
>   net/vhost: fix Vhost setup error path
>   net/vhost: prevent multiple setup on reconfig
> 
>  drivers/net/vhost/rte_eth_vhost.c | 26 +++++++++++++++++++-------
>  1 file changed, 19 insertions(+), 7 deletions(-)
> 
> -- 
> 2.24.1
Maxime Coquelin Feb. 19, 2020, 10:16 a.m. UTC | #3 
On 2/18/20 11:37 PM, Itsuro ODA wrote:
> Hi Yinan, Maxime, David,
> 
> Thank you for quick test, fix and review.
> It looks good to me.
> 
> The original fix has been queued to stable 19.11.1.
> It should be rejected or applied this fix too.

Thanks for the heads-up.
I added Cc: stable@dpdk.org in the commit messages.

Maxime

> Thanks.
> Itsuto Oda
> 
> On Tue, 18 Feb 2020 18:22:38 +0100
> Maxime Coquelin <maxime.coquelin@redhat.com> wrote:
> 
>> This series fixes regression introduced in v20.02-rc3.
>> First patch fixes the error path, and second one fix
>> Vhost device reconfigure issue reported by Yinan.
>>
>> v2:
>> ---
>> - Fix error path order (David)
>>
>> Maxime Coquelin (2):
>>   net/vhost: fix Vhost setup error path
>>   net/vhost: prevent multiple setup on reconfig
>>
>>  drivers/net/vhost/rte_eth_vhost.c | 26 +++++++++++++++++++-------
>>  1 file changed, 19 insertions(+), 7 deletions(-)
>>
>> -- 
>> 2.24.1
>
Maxime Coquelin Feb. 19, 2020, 10:18 a.m. UTC | #4 
Cc'ing stable as the commit it fixes was backported to v19.11 stable
branch.

On 2/18/20 6:22 PM, Maxime Coquelin wrote:
> This series fixes regression introduced in v20.02-rc3.
> First patch fixes the error path, and second one fix
> Vhost device reconfigure issue reported by Yinan.
> 
> v2:
> ---
> - Fix error path order (David)
> 
> Maxime Coquelin (2):
>   net/vhost: fix Vhost setup error path
>   net/vhost: prevent multiple setup on reconfig
> 
>  drivers/net/vhost/rte_eth_vhost.c | 26 +++++++++++++++++++-------
>  1 file changed, 19 insertions(+), 7 deletions(-)
>
Maxime Coquelin Feb. 19, 2020, 10:23 a.m. UTC | #5 
On 2/18/20 6:22 PM, Maxime Coquelin wrote:
> This series fixes regression introduced in v20.02-rc3.
> First patch fixes the error path, and second one fix
> Vhost device reconfigure issue reported by Yinan.
> 
> v2:
> ---
> - Fix error path order (David)
> 
> Maxime Coquelin (2):
>   net/vhost: fix Vhost setup error path
>   net/vhost: prevent multiple setup on reconfig
> 
>  drivers/net/vhost/rte_eth_vhost.c | 26 +++++++++++++++++++-------
>  1 file changed, 19 insertions(+), 7 deletions(-)
> 

Applied to dpdk-next-virtio/master

Thanks,
Maxime
Kevin Traynor Feb. 19, 2020, 11:17 a.m. UTC | #6 
On 19/02/2020 10:18, Maxime Coquelin wrote:
> Cc'ing stable as the commit it fixes was backported to v19.11 stable
> branch.
> 

fyi - it is relevant to 18.11 also as 3d01b759d is fixing something
introduced in 18.11. I skipped 3d01b759d for now and will take the full
set together when available.

> On 2/18/20 6:22 PM, Maxime Coquelin wrote:
>> This series fixes regression introduced in v20.02-rc3.
>> First patch fixes the error path, and second one fix
>> Vhost device reconfigure issue reported by Yinan.
>>
>> v2:
>> ---
>> - Fix error path order (David)
>>
>> Maxime Coquelin (2):
>>   net/vhost: fix Vhost setup error path
>>   net/vhost: prevent multiple setup on reconfig
>>
>>  drivers/net/vhost/rte_eth_vhost.c | 26 +++++++++++++++++++-------
>>  1 file changed, 19 insertions(+), 7 deletions(-)
>>
>