Message ID | 20200218172240.558516-1-maxime.coquelin@redhat.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1A5AA054F; Tue, 18 Feb 2020 18:24:05 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9C3941BF8C; Tue, 18 Feb 2020 18:24:04 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id E9B9C1BF84 for <dev@dpdk.org>; Tue, 18 Feb 2020 18:24:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582046643; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3Zv+Ec8/ryXG03PBPfx7k2aaSv1H5ZF4GouV42j8ov4=; b=YobA95achZJYaA27ognLP4uvRZ3RI1xbIRkkSTtaurpFn60jvg4ldpMDYJ6UJbTywzwY6z lcMAaTZHuMY7JEQA29mTlp2mndLO/92WYBhGWx6eZzfwNA+z+IWo6YegP0PeAIV7r/wjDo m7OwtIqIMOcTglD0pSnmYkw5xyfvK2k= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-39-9abAsqD1NxuI4_12TEcdTQ-1; Tue, 18 Feb 2020 12:24:01 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2B6D3100550E; Tue, 18 Feb 2020 17:24:00 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-45.ams2.redhat.com [10.36.112.45]) by smtp.corp.redhat.com (Postfix) with ESMTP id E66DD5C13B; Tue, 18 Feb 2020 17:23:52 +0000 (UTC) From: Maxime Coquelin <maxime.coquelin@redhat.com> To: dev@dpdk.org, oda@valinux.co.jp, yinan.wang@intel.com, tiwei.bie@intel.com, amorenoz@redhat.com, david.marchand@redhat.com Cc: Maxime Coquelin <maxime.coquelin@redhat.com> Date: Tue, 18 Feb 2020 18:22:38 +0100 Message-Id: <20200218172240.558516-1-maxime.coquelin@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: 9abAsqD1NxuI4_12TEcdTQ-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: [dpdk-dev] [PATCH 0/2] Fix Vhost PMD setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
Fix Vhost PMD setup
|
|
Message
Maxime Coquelin
Feb. 18, 2020, 5:22 p.m. UTC
This series fixes regression introduced in v20.02-rc3. First patch fixes the error path, and second one fix Vhost device reconfigure issue reported by Yinan. v2: --- - Fix error path order (David) Maxime Coquelin (2): net/vhost: fix Vhost setup error path net/vhost: prevent multiple setup on reconfig drivers/net/vhost/rte_eth_vhost.c | 26 +++++++++++++++++++------- 1 file changed, 19 insertions(+), 7 deletions(-)
Comments
Sorry, just see I missed the v2 prefix. On 2/18/20 6:22 PM, Maxime Coquelin wrote: > This series fixes regression introduced in v20.02-rc3. > First patch fixes the error path, and second one fix > Vhost device reconfigure issue reported by Yinan. > > v2: > --- > - Fix error path order (David) > > Maxime Coquelin (2): > net/vhost: fix Vhost setup error path > net/vhost: prevent multiple setup on reconfig > > drivers/net/vhost/rte_eth_vhost.c | 26 +++++++++++++++++++------- > 1 file changed, 19 insertions(+), 7 deletions(-) >
Hi Yinan, Maxime, David, Thank you for quick test, fix and review. It looks good to me. The original fix has been queued to stable 19.11.1. It should be rejected or applied this fix too. Thanks. Itsuto Oda On Tue, 18 Feb 2020 18:22:38 +0100 Maxime Coquelin <maxime.coquelin@redhat.com> wrote: > This series fixes regression introduced in v20.02-rc3. > First patch fixes the error path, and second one fix > Vhost device reconfigure issue reported by Yinan. > > v2: > --- > - Fix error path order (David) > > Maxime Coquelin (2): > net/vhost: fix Vhost setup error path > net/vhost: prevent multiple setup on reconfig > > drivers/net/vhost/rte_eth_vhost.c | 26 +++++++++++++++++++------- > 1 file changed, 19 insertions(+), 7 deletions(-) > > -- > 2.24.1
On 2/18/20 11:37 PM, Itsuro ODA wrote: > Hi Yinan, Maxime, David, > > Thank you for quick test, fix and review. > It looks good to me. > > The original fix has been queued to stable 19.11.1. > It should be rejected or applied this fix too. Thanks for the heads-up. I added Cc: stable@dpdk.org in the commit messages. Maxime > Thanks. > Itsuto Oda > > On Tue, 18 Feb 2020 18:22:38 +0100 > Maxime Coquelin <maxime.coquelin@redhat.com> wrote: > >> This series fixes regression introduced in v20.02-rc3. >> First patch fixes the error path, and second one fix >> Vhost device reconfigure issue reported by Yinan. >> >> v2: >> --- >> - Fix error path order (David) >> >> Maxime Coquelin (2): >> net/vhost: fix Vhost setup error path >> net/vhost: prevent multiple setup on reconfig >> >> drivers/net/vhost/rte_eth_vhost.c | 26 +++++++++++++++++++------- >> 1 file changed, 19 insertions(+), 7 deletions(-) >> >> -- >> 2.24.1 >
Cc'ing stable as the commit it fixes was backported to v19.11 stable branch. On 2/18/20 6:22 PM, Maxime Coquelin wrote: > This series fixes regression introduced in v20.02-rc3. > First patch fixes the error path, and second one fix > Vhost device reconfigure issue reported by Yinan. > > v2: > --- > - Fix error path order (David) > > Maxime Coquelin (2): > net/vhost: fix Vhost setup error path > net/vhost: prevent multiple setup on reconfig > > drivers/net/vhost/rte_eth_vhost.c | 26 +++++++++++++++++++------- > 1 file changed, 19 insertions(+), 7 deletions(-) >
On 2/18/20 6:22 PM, Maxime Coquelin wrote: > This series fixes regression introduced in v20.02-rc3. > First patch fixes the error path, and second one fix > Vhost device reconfigure issue reported by Yinan. > > v2: > --- > - Fix error path order (David) > > Maxime Coquelin (2): > net/vhost: fix Vhost setup error path > net/vhost: prevent multiple setup on reconfig > > drivers/net/vhost/rte_eth_vhost.c | 26 +++++++++++++++++++------- > 1 file changed, 19 insertions(+), 7 deletions(-) > Applied to dpdk-next-virtio/master Thanks, Maxime
On 19/02/2020 10:18, Maxime Coquelin wrote: > Cc'ing stable as the commit it fixes was backported to v19.11 stable > branch. > fyi - it is relevant to 18.11 also as 3d01b759d is fixing something introduced in 18.11. I skipped 3d01b759d for now and will take the full set together when available. > On 2/18/20 6:22 PM, Maxime Coquelin wrote: >> This series fixes regression introduced in v20.02-rc3. >> First patch fixes the error path, and second one fix >> Vhost device reconfigure issue reported by Yinan. >> >> v2: >> --- >> - Fix error path order (David) >> >> Maxime Coquelin (2): >> net/vhost: fix Vhost setup error path >> net/vhost: prevent multiple setup on reconfig >> >> drivers/net/vhost/rte_eth_vhost.c | 26 +++++++++++++++++++------- >> 1 file changed, 19 insertions(+), 7 deletions(-) >> >