app/pdump: fix build with clang

Message ID 20200126010438.30687-1-stephen@networkplumber.org (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series app/pdump: fix build with clang |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/travis-robot success Travis build: passed
ci/Intel-compilation success Compilation OK
ci/iol-testing success Testing PASS
ci/iol-nxp-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS

Commit Message

Stephen Hemminger Jan. 26, 2020, 1:04 a.m. UTC
  Clang checks indentation and found incorrect indentation in pdump.

app/pdump/main.c:598:3: error: misleading indentation; statement is not part of the previous 'if' [-Werror,-Wmisleading-indentation]

Cc: reshma.pattan@intel.com
Cc: stable@dpdk.org
Fixes: caa7028276b8 ("app/pdump: add tool for packet capturing")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 app/pdump/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Thomas Monjalon Feb. 6, 2020, 2:31 a.m. UTC | #1
26/01/2020 02:04, Stephen Hemminger:
> Clang checks indentation and found incorrect indentation in pdump.
> 
> app/pdump/main.c:598:3: error: misleading indentation; statement is not part of the previous 'if' [-Werror,-Wmisleading-indentation]
> 
> Cc: reshma.pattan@intel.com
> Cc: stable@dpdk.org
> Fixes: caa7028276b8 ("app/pdump: add tool for packet capturing")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Applied, thanks
  

Patch

diff --git a/app/pdump/main.c b/app/pdump/main.c
index 903d02f48233..d05a0236670a 100644
--- a/app/pdump/main.c
+++ b/app/pdump/main.c
@@ -595,7 +595,7 @@  configure_vdev(uint16_t port_id)
 	if (ret != 0)
 		rte_exit(EXIT_FAILURE, "dev config failed\n");
 
-	 for (q = 0; q < txRings; q++) {
+	for (q = 0; q < txRings; q++) {
 		ret = rte_eth_tx_queue_setup(port_id, q, TX_DESC_PER_QUEUE,
 				rte_eth_dev_socket_id(port_id), NULL);
 		if (ret < 0)