diff mbox series

config: disable all kmods by default from v20.02

Message ID 20191212131302.1626130-1-jerinj@marvell.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series config: disable all kmods by default from v20.02 |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/travis-robot warning Travis build: failed
ci/Intel-compilation fail apply issues

Commit Message

Jerin Jacob Kollanukkaran Dec. 12, 2019, 1:13 p.m. UTC 
  From: Jerin Jacob <jerinj@marvell.com>

Based on the techboard meeting held on 2019-11-06,
It's been decided to disable all kmods by default from v20.02.

http://mails.dpdk.org/archives/dev/2019-November/151763.html

Signed-off-by: Jerin Jacob <jerinj@marvell.com>
---
 config/common_linux | 2 --
 1 file changed, 2 deletions(-)

Comments

Jerin Jacob Jan. 16, 2020, 1:11 p.m. UTC | #1 
Ping.

On Thu, Dec 12, 2019 at 6:42 PM <jerinj@marvell.com> wrote:
>
> From: Jerin Jacob <jerinj@marvell.com>
>
> Based on the techboard meeting held on 2019-11-06,
> It's been decided to disable all kmods by default from v20.02.
>
> http://mails.dpdk.org/archives/dev/2019-November/151763.html
>
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> ---
>  config/common_linux | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/config/common_linux b/config/common_linux
> index c5cf3d662..583efadc7 100644
> --- a/config/common_linux
> +++ b/config/common_linux
> @@ -8,9 +8,7 @@ CONFIG_RTE_EXEC_ENV_LINUX=y
>  CONFIG_RTE_EXEC_ENV_LINUXAPP=y
>
>  CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=y
> -CONFIG_RTE_EAL_IGB_UIO=y
>  CONFIG_RTE_EAL_VFIO=y
> -CONFIG_RTE_KNI_KMOD=y
>  CONFIG_RTE_LIBRTE_KNI=y
>  CONFIG_RTE_LIBRTE_PMD_KNI=y
>  CONFIG_RTE_LIBRTE_VHOST=y
> --
> 2.24.0
>
Maxime Coquelin Jan. 16, 2020, 6:33 p.m. UTC | #2 
On 1/16/20 2:11 PM, Jerin Jacob wrote:
> Ping.
> 
> On Thu, Dec 12, 2019 at 6:42 PM <jerinj@marvell.com> wrote:
>>
>> From: Jerin Jacob <jerinj@marvell.com>
>>
>> Based on the techboard meeting held on 2019-11-06,
>> It's been decided to disable all kmods by default from v20.02.
>>
>> http://mails.dpdk.org/archives/dev/2019-November/151763.html
>>
>> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
>> ---
>>  config/common_linux | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/config/common_linux b/config/common_linux
>> index c5cf3d662..583efadc7 100644
>> --- a/config/common_linux
>> +++ b/config/common_linux
>> @@ -8,9 +8,7 @@ CONFIG_RTE_EXEC_ENV_LINUX=y
>>  CONFIG_RTE_EXEC_ENV_LINUXAPP=y
>>
>>  CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=y
>> -CONFIG_RTE_EAL_IGB_UIO=y
>>  CONFIG_RTE_EAL_VFIO=y
>> -CONFIG_RTE_KNI_KMOD=y
>>  CONFIG_RTE_LIBRTE_KNI=y
>>  CONFIG_RTE_LIBRTE_PMD_KNI=y
>>  CONFIG_RTE_LIBRTE_VHOST=y
>> --
>> 2.24.0
>>
> 

Looks good for make build system, but what about Meson?
as per meson_options.txt, isn't it enabled by default?
$ grep -rn enable_kmods meson_options.txt
7:option('enable_kmods', type: 'boolean', value: true,

Thanks,
Maxime
Jerin Jacob Jan. 16, 2020, 6:43 p.m. UTC | #3 
On Fri, Jan 17, 2020 at 12:04 AM Maxime Coquelin
<maxime.coquelin@redhat.com> wrote:
>
>
>
> On 1/16/20 2:11 PM, Jerin Jacob wrote:
> > Ping.
> >
> > On Thu, Dec 12, 2019 at 6:42 PM <jerinj@marvell.com> wrote:
> >>
> >> From: Jerin Jacob <jerinj@marvell.com>
> >>
> >> Based on the techboard meeting held on 2019-11-06,
> >> It's been decided to disable all kmods by default from v20.02.
> >>
> >> http://mails.dpdk.org/archives/dev/2019-November/151763.html
> >>
> >> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> >> ---
> >>  config/common_linux | 2 --
> >>  1 file changed, 2 deletions(-)
> >>
> >> diff --git a/config/common_linux b/config/common_linux
> >> index c5cf3d662..583efadc7 100644
> >> --- a/config/common_linux
> >> +++ b/config/common_linux
> >> @@ -8,9 +8,7 @@ CONFIG_RTE_EXEC_ENV_LINUX=y
> >>  CONFIG_RTE_EXEC_ENV_LINUXAPP=y
> >>
> >>  CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=y
> >> -CONFIG_RTE_EAL_IGB_UIO=y
> >>  CONFIG_RTE_EAL_VFIO=y
> >> -CONFIG_RTE_KNI_KMOD=y
> >>  CONFIG_RTE_LIBRTE_KNI=y
> >>  CONFIG_RTE_LIBRTE_PMD_KNI=y
> >>  CONFIG_RTE_LIBRTE_VHOST=y
> >> --
> >> 2.24.0
> >>
> >
>
> Looks good for make build system, but what about Meson?
> as per meson_options.txt, isn't it enabled by default?
> $ grep -rn enable_kmods meson_options.txt
> 7:option('enable_kmods', type: 'boolean', value: true,

+ Bruce,

Since meson autodetect the presence of Linux kernel dependency for the
kmod build,
I thought of keeping as it is as there is no harm. I am fine with
either way, let me the
know the feedback, I will send the v2 based on the comment.



>
> Thanks,
> Maxime
>
Honnappa Nagarahalli Jan. 16, 2020, 10:38 p.m. UTC | #4 
<snip>

> >
> > On 1/16/20 2:11 PM, Jerin Jacob wrote:
> > > Ping.
> > >
> > > On Thu, Dec 12, 2019 at 6:42 PM <jerinj@marvell.com> wrote:
> > >>
> > >> From: Jerin Jacob <jerinj@marvell.com>
> > >>
> > >> Based on the techboard meeting held on 2019-11-06, It's been
> > >> decided to disable all kmods by default from v20.02.
> > >>
> > >> http://mails.dpdk.org/archives/dev/2019-November/151763.html
> > >>
> > >> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> > >> ---
> > >>  config/common_linux | 2 --
> > >>  1 file changed, 2 deletions(-)
> > >>
> > >> diff --git a/config/common_linux b/config/common_linux index
> > >> c5cf3d662..583efadc7 100644
> > >> --- a/config/common_linux
> > >> +++ b/config/common_linux
> > >> @@ -8,9 +8,7 @@ CONFIG_RTE_EXEC_ENV_LINUX=y
> > >> CONFIG_RTE_EXEC_ENV_LINUXAPP=y
> > >>
> > >>  CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=y
> > >> -CONFIG_RTE_EAL_IGB_UIO=y
> > >>  CONFIG_RTE_EAL_VFIO=y
> > >> -CONFIG_RTE_KNI_KMOD=y
Suggest to keep the lines, but set them to 'n'. It will be easier to enable.
Does this require update to release notes?

> > >>  CONFIG_RTE_LIBRTE_KNI=y
> > >>  CONFIG_RTE_LIBRTE_PMD_KNI=y
> > >>  CONFIG_RTE_LIBRTE_VHOST=y
> > >> --
> > >> 2.24.0
> > >>
> > >
> >
> > Looks good for make build system, but what about Meson?
> > as per meson_options.txt, isn't it enabled by default?
> > $ grep -rn enable_kmods meson_options.txt 7:option('enable_kmods',
> > type: 'boolean', value: true,
> 
> + Bruce,
> 
> Since meson autodetect the presence of Linux kernel dependency for the kmod
> build, I thought of keeping as it is as there is no harm. I am fine with either way,
> let me the know the feedback, I will send the v2 based on the comment.
> 
> 
> 
> >
> > Thanks,
> > Maxime
> >
Jerin Jacob Jan. 17, 2020, 4:07 a.m. UTC | #5 
On Fri, Jan 17, 2020 at 4:08 AM Honnappa Nagarahalli
<Honnappa.Nagarahalli@arm.com> wrote:
>
> <snip>
>
> > >
> > > On 1/16/20 2:11 PM, Jerin Jacob wrote:
> > > > Ping.
> > > >
> > > > On Thu, Dec 12, 2019 at 6:42 PM <jerinj@marvell.com> wrote:
> > > >>
> > > >> From: Jerin Jacob <jerinj@marvell.com>
> > > >>
> > > >> Based on the techboard meeting held on 2019-11-06, It's been
> > > >> decided to disable all kmods by default from v20.02.
> > > >>
> > > >> http://mails.dpdk.org/archives/dev/2019-November/151763.html
> > > >>
> > > >> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> > > >> ---
> > > >>  config/common_linux | 2 --
> > > >>  1 file changed, 2 deletions(-)
> > > >>
> > > >> diff --git a/config/common_linux b/config/common_linux index
> > > >> c5cf3d662..583efadc7 100644
> > > >> --- a/config/common_linux
> > > >> +++ b/config/common_linux
> > > >> @@ -8,9 +8,7 @@ CONFIG_RTE_EXEC_ENV_LINUX=y
> > > >> CONFIG_RTE_EXEC_ENV_LINUXAPP=y
> > > >>
> > > >>  CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=y
> > > >> -CONFIG_RTE_EAL_IGB_UIO=y
> > > >>  CONFIG_RTE_EAL_VFIO=y
> > > >> -CONFIG_RTE_KNI_KMOD=y
> Suggest to keep the lines, but set them to 'n'. It will be easier to enable.

In config/common_base it is set as =n. it can be enabled there just
like other config.
I just did this way to have symmetry with other configs.
Thoughts?


> Does this require update to release notes?

I will send the next version with updating the release notes if there
is no objection.

>
> > > >>  CONFIG_RTE_LIBRTE_KNI=y
> > > >>  CONFIG_RTE_LIBRTE_PMD_KNI=y
> > > >>  CONFIG_RTE_LIBRTE_VHOST=y
> > > >> --
> > > >> 2.24.0
> > > >>
> > > >
> > >
> > > Looks good for make build system, but what about Meson?
> > > as per meson_options.txt, isn't it enabled by default?
> > > $ grep -rn enable_kmods meson_options.txt 7:option('enable_kmods',
> > > type: 'boolean', value: true,
> >
> > + Bruce,
> >
> > Since meson autodetect the presence of Linux kernel dependency for the kmod
> > build, I thought of keeping as it is as there is no harm. I am fine with either way,
> > let me the know the feedback, I will send the v2 based on the comment.
> >
> >
> >
> > >
> > > Thanks,
> > > Maxime
> > >
Maxime Coquelin Jan. 17, 2020, 8:29 a.m. UTC | #6 
On 1/16/20 7:43 PM, Jerin Jacob wrote:
> On Fri, Jan 17, 2020 at 12:04 AM Maxime Coquelin
> <maxime.coquelin@redhat.com> wrote:
>>
>>
>>
>> On 1/16/20 2:11 PM, Jerin Jacob wrote:
>>> Ping.
>>>
>>> On Thu, Dec 12, 2019 at 6:42 PM <jerinj@marvell.com> wrote:
>>>>
>>>> From: Jerin Jacob <jerinj@marvell.com>
>>>>
>>>> Based on the techboard meeting held on 2019-11-06,
>>>> It's been decided to disable all kmods by default from v20.02.
>>>>
>>>> http://mails.dpdk.org/archives/dev/2019-November/151763.html
>>>>
>>>> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
>>>> ---
>>>>  config/common_linux | 2 --
>>>>  1 file changed, 2 deletions(-)
>>>>
>>>> diff --git a/config/common_linux b/config/common_linux
>>>> index c5cf3d662..583efadc7 100644
>>>> --- a/config/common_linux
>>>> +++ b/config/common_linux
>>>> @@ -8,9 +8,7 @@ CONFIG_RTE_EXEC_ENV_LINUX=y
>>>>  CONFIG_RTE_EXEC_ENV_LINUXAPP=y
>>>>
>>>>  CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=y
>>>> -CONFIG_RTE_EAL_IGB_UIO=y
>>>>  CONFIG_RTE_EAL_VFIO=y
>>>> -CONFIG_RTE_KNI_KMOD=y
>>>>  CONFIG_RTE_LIBRTE_KNI=y
>>>>  CONFIG_RTE_LIBRTE_PMD_KNI=y
>>>>  CONFIG_RTE_LIBRTE_VHOST=y
>>>> --
>>>> 2.24.0
>>>>
>>>
>>
>> Looks good for make build system, but what about Meson?
>> as per meson_options.txt, isn't it enabled by default?
>> $ grep -rn enable_kmods meson_options.txt
>> 7:option('enable_kmods', type: 'boolean', value: true,
> 
> + Bruce,
> 
> Since meson autodetect the presence of Linux kernel dependency for the
> kmod build,
> I thought of keeping as it is as there is no harm. I am fine with
> either way, let me the
> know the feedback, I will send the v2 based on the comment.

Actually, it would defeat the main reason I pushed for the kmods to be
disabled by default. Indeed, even if the kernel dependencies are
installed, build can break if internal kernel API changes, e.g.:

commit c128a4e6317d49362e2158edc29887c844067c65
Author: David Zeng <zengxhsh@cn.ibm.com>
Date:   Sat Dec 22 00:27:33 2018 +0800

    kni: fix build on RHEL8 for arm and Power9

    [ upstream commit 3d5501d568aacbcf71832691278f5656d3a9b649 ]

    Signed-off-by: David Zeng <zengxhsh@cn.ibm.com>
    Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Kevin Traynor Jan. 17, 2020, 9:19 a.m. UTC | #7 
On 17/01/2020 08:29, Maxime Coquelin wrote:
> 
> 
> On 1/16/20 7:43 PM, Jerin Jacob wrote:
>> On Fri, Jan 17, 2020 at 12:04 AM Maxime Coquelin
>> <maxime.coquelin@redhat.com> wrote:
>>>
>>>
>>>
>>> On 1/16/20 2:11 PM, Jerin Jacob wrote:
>>>> Ping.
>>>>
>>>> On Thu, Dec 12, 2019 at 6:42 PM <jerinj@marvell.com> wrote:
>>>>>
>>>>> From: Jerin Jacob <jerinj@marvell.com>
>>>>>
>>>>> Based on the techboard meeting held on 2019-11-06,
>>>>> It's been decided to disable all kmods by default from v20.02.
>>>>>
>>>>> http://mails.dpdk.org/archives/dev/2019-November/151763.html
>>>>>
>>>>> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
>>>>> ---
>>>>>  config/common_linux | 2 --
>>>>>  1 file changed, 2 deletions(-)
>>>>>
>>>>> diff --git a/config/common_linux b/config/common_linux
>>>>> index c5cf3d662..583efadc7 100644
>>>>> --- a/config/common_linux
>>>>> +++ b/config/common_linux
>>>>> @@ -8,9 +8,7 @@ CONFIG_RTE_EXEC_ENV_LINUX=y
>>>>>  CONFIG_RTE_EXEC_ENV_LINUXAPP=y
>>>>>
>>>>>  CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=y
>>>>> -CONFIG_RTE_EAL_IGB_UIO=y
>>>>>  CONFIG_RTE_EAL_VFIO=y
>>>>> -CONFIG_RTE_KNI_KMOD=y
>>>>>  CONFIG_RTE_LIBRTE_KNI=y
>>>>>  CONFIG_RTE_LIBRTE_PMD_KNI=y
>>>>>  CONFIG_RTE_LIBRTE_VHOST=y
>>>>> --
>>>>> 2.24.0
>>>>>
>>>>
>>>
>>> Looks good for make build system, but what about Meson?
>>> as per meson_options.txt, isn't it enabled by default?
>>> $ grep -rn enable_kmods meson_options.txt
>>> 7:option('enable_kmods', type: 'boolean', value: true,
>>
>> + Bruce,
>>
>> Since meson autodetect the presence of Linux kernel dependency for the
>> kmod build,
>> I thought of keeping as it is as there is no harm. I am fine with
>> either way, let me the
>> know the feedback, I will send the v2 based on the comment.
> 
> Actually, it would defeat the main reason I pushed for the kmods to be
> disabled by default. Indeed, even if the kernel dependencies are
> installed, build can break if internal kernel API changes, e.g.:
> 
> commit c128a4e6317d49362e2158edc29887c844067c65
> Author: David Zeng <zengxhsh@cn.ibm.com>
> Date:   Sat Dec 22 00:27:33 2018 +0800
> 
>     kni: fix build on RHEL8 for arm and Power9
> 
>     [ upstream commit 3d5501d568aacbcf71832691278f5656d3a9b649 ]
> 
>     Signed-off-by: David Zeng <zengxhsh@cn.ibm.com>
>     Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 

That's a good point. We take these types of patches into stable, but
there would be a few months delay between a new kernel causing breakage
and the time when stable releases containing the fix are released.
Disabling would at least avoid non-kmod interested user being impacted
by default.
Jerin Jacob Jan. 17, 2020, 9:55 a.m. UTC | #8 
On Fri, Jan 17, 2020 at 1:59 PM Maxime Coquelin
<maxime.coquelin@redhat.com> wrote:
>
>
>
> On 1/16/20 7:43 PM, Jerin Jacob wrote:
> > On Fri, Jan 17, 2020 at 12:04 AM Maxime Coquelin
> > <maxime.coquelin@redhat.com> wrote:
> >>
> >>
> >>
> >> On 1/16/20 2:11 PM, Jerin Jacob wrote:
> >>> Ping.
> >>>
> >>> On Thu, Dec 12, 2019 at 6:42 PM <jerinj@marvell.com> wrote:
> >>>>
> >>>> From: Jerin Jacob <jerinj@marvell.com>
> >>>>
> >>>> Based on the techboard meeting held on 2019-11-06,
> >>>> It's been decided to disable all kmods by default from v20.02.
> >>>>
> >>>> http://mails.dpdk.org/archives/dev/2019-November/151763.html
> >>>>
> >>>> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> >>>> ---
> >>>>  config/common_linux | 2 --
> >>>>  1 file changed, 2 deletions(-)
> >>>>
> >>>> diff --git a/config/common_linux b/config/common_linux
> >>>> index c5cf3d662..583efadc7 100644
> >>>> --- a/config/common_linux
> >>>> +++ b/config/common_linux
> >>>> @@ -8,9 +8,7 @@ CONFIG_RTE_EXEC_ENV_LINUX=y
> >>>>  CONFIG_RTE_EXEC_ENV_LINUXAPP=y
> >>>>
> >>>>  CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=y
> >>>> -CONFIG_RTE_EAL_IGB_UIO=y
> >>>>  CONFIG_RTE_EAL_VFIO=y
> >>>> -CONFIG_RTE_KNI_KMOD=y
> >>>>  CONFIG_RTE_LIBRTE_KNI=y
> >>>>  CONFIG_RTE_LIBRTE_PMD_KNI=y
> >>>>  CONFIG_RTE_LIBRTE_VHOST=y
> >>>> --
> >>>> 2.24.0
> >>>>
> >>>
> >>
> >> Looks good for make build system, but what about Meson?
> >> as per meson_options.txt, isn't it enabled by default?
> >> $ grep -rn enable_kmods meson_options.txt
> >> 7:option('enable_kmods', type: 'boolean', value: true,
> >
> > + Bruce,
> >
> > Since meson autodetect the presence of Linux kernel dependency for the
> > kmod build,
> > I thought of keeping as it is as there is no harm. I am fine with
> > either way, let me the
> > know the feedback, I will send the v2 based on the comment.
>
> Actually, it would defeat the main reason I pushed for the kmods to be
> disabled by default. Indeed, even if the kernel dependencies are
> installed, build can break if internal kernel API changes, e.g.:

Agree. I will send the next version with disabling kmod in meson by default.


> commit c128a4e6317d49362e2158edc29887c844067c65
> Author: David Zeng <zengxhsh@cn.ibm.com>
> Date:   Sat Dec 22 00:27:33 2018 +0800
>
>     kni: fix build on RHEL8 for arm and Power9
>
>     [ upstream commit 3d5501d568aacbcf71832691278f5656d3a9b649 ]
>
>     Signed-off-by: David Zeng <zengxhsh@cn.ibm.com>
>     Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
Honnappa Nagarahalli Jan. 17, 2020, 3:48 p.m. UTC | #9 
> > <snip>
> >
> > > >
> > > > On 1/16/20 2:11 PM, Jerin Jacob wrote:
> > > > > Ping.
> > > > >
> > > > > On Thu, Dec 12, 2019 at 6:42 PM <jerinj@marvell.com> wrote:
> > > > >>
> > > > >> From: Jerin Jacob <jerinj@marvell.com>
> > > > >>
> > > > >> Based on the techboard meeting held on 2019-11-06, It's been
> > > > >> decided to disable all kmods by default from v20.02.
> > > > >>
> > > > >> http://mails.dpdk.org/archives/dev/2019-November/151763.html
> > > > >>
> > > > >> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> > > > >> ---
> > > > >>  config/common_linux | 2 --
> > > > >>  1 file changed, 2 deletions(-)
> > > > >>
> > > > >> diff --git a/config/common_linux b/config/common_linux index
> > > > >> c5cf3d662..583efadc7 100644
> > > > >> --- a/config/common_linux
> > > > >> +++ b/config/common_linux
> > > > >> @@ -8,9 +8,7 @@ CONFIG_RTE_EXEC_ENV_LINUX=y
> > > > >> CONFIG_RTE_EXEC_ENV_LINUXAPP=y
> > > > >>
> > > > >>  CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=y
> > > > >> -CONFIG_RTE_EAL_IGB_UIO=y
> > > > >>  CONFIG_RTE_EAL_VFIO=y
> > > > >> -CONFIG_RTE_KNI_KMOD=y
> > Suggest to keep the lines, but set them to 'n'. It will be easier to enable.
> 
> In config/common_base it is set as =n. it can be enabled there just like other
> config.
> I just did this way to have symmetry with other configs.
> Thoughts?
Sounds good.
CONFIG_RTE_LIBRTE_PMD_IFPGA_RAWDEV=n can also be removed as it is set in common_base.
CONFIG_RTE_LIBRTE_VHOST_POSTCOPY is set to 'n' in common_linux, but it is not present in common_base.

> 
> 
> > Does this require update to release notes?
> 
> I will send the next version with updating the release notes if there is no
> objection.
> 
> >
> > > > >>  CONFIG_RTE_LIBRTE_KNI=y
> > > > >>  CONFIG_RTE_LIBRTE_PMD_KNI=y
> > > > >>  CONFIG_RTE_LIBRTE_VHOST=y
> > > > >> --
> > > > >> 2.24.0
> > > > >>
> > > > >
> > > >
> > > > Looks good for make build system, but what about Meson?
> > > > as per meson_options.txt, isn't it enabled by default?
> > > > $ grep -rn enable_kmods meson_options.txt 7:option('enable_kmods',
> > > > type: 'boolean', value: true,
> > >
> > > + Bruce,
> > >
> > > Since meson autodetect the presence of Linux kernel dependency for
> > > the kmod build, I thought of keeping as it is as there is no harm. I
> > > am fine with either way, let me the know the feedback, I will send the v2
> based on the comment.
> > >
> > >
> > >
> > > >
> > > > Thanks,
> > > > Maxime
> > > >
Thomas Monjalon Jan. 18, 2020, 12:06 a.m. UTC | #10 
17/01/2020 16:48, Honnappa Nagarahalli:
> > > > > On 1/16/20 2:11 PM, Jerin Jacob wrote:
> > > > > > On Thu, Dec 12, 2019 at 6:42 PM <jerinj@marvell.com> wrote:
> > > > > >> --- a/config/common_linux
> > > > > >> +++ b/config/common_linux
> > > > > >> @@ -8,9 +8,7 @@ CONFIG_RTE_EXEC_ENV_LINUX=y
> > > > > >> CONFIG_RTE_EXEC_ENV_LINUXAPP=y
> > > > > >>
> > > > > >>  CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=y
> > > > > >> -CONFIG_RTE_EAL_IGB_UIO=y
> > > > > >>  CONFIG_RTE_EAL_VFIO=y
> > > > > >> -CONFIG_RTE_KNI_KMOD=y
> > > Suggest to keep the lines, but set them to 'n'. It will be easier to enable.

Configs should be enabled in the generated .config,
not in the versioned template.

> > In config/common_base it is set as =n. it can be enabled there just like other
> > config.
> > I just did this way to have symmetry with other configs.
> > Thoughts?
> Sounds good.
> CONFIG_RTE_LIBRTE_PMD_IFPGA_RAWDEV=n can also be removed as it is set in common_base.
> CONFIG_RTE_LIBRTE_VHOST_POSTCOPY is set to 'n' in common_linux, but it is not present in common_base.

Good catch.
All options should be in common_base.
Stephen Hemminger Jan. 22, 2020, 6:34 a.m. UTC | #11 
On Thu, 12 Dec 2019 18:43:02 +0530
<jerinj@marvell.com> wrote:

> From: Jerin Jacob <jerinj@marvell.com>
> 
> Based on the techboard meeting held on 2019-11-06,
> It's been decided to disable all kmods by default from v20.02.
> 
> http://mails.dpdk.org/archives/dev/2019-November/151763.html
> 
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> ---
>  config/common_linux | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/config/common_linux b/config/common_linux
> index c5cf3d662..583efadc7 100644
> --- a/config/common_linux
> +++ b/config/common_linux
> @@ -8,9 +8,7 @@ CONFIG_RTE_EXEC_ENV_LINUX=y
>  CONFIG_RTE_EXEC_ENV_LINUXAPP=y
>  
>  CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=y
> -CONFIG_RTE_EAL_IGB_UIO=y
>  CONFIG_RTE_EAL_VFIO=y
> -CONFIG_RTE_KNI_KMOD=y
>  CONFIG_RTE_LIBRTE_KNI=y
>  CONFIG_RTE_LIBRTE_PMD_KNI=y
>  CONFIG_RTE_LIBRTE_VHOST=y

On a related topic. All the documented examples should be changed to use vfio.
Everyone just cut and paste from the documentation and expects igb_uio.
Thomas Monjalon Jan. 22, 2020, 9:08 a.m. UTC | #12 
22/01/2020 07:34, Stephen Hemminger:
> On a related topic. All the documented examples should be changed to use vfio.
> Everyone just cut and paste from the documentation and expects igb_uio.

Yes, good catch Stephen.
Who is volunteer?
diff mbox series

Patch

diff --git a/config/common_linux b/config/common_linux
index c5cf3d662..583efadc7 100644
--- a/config/common_linux
+++ b/config/common_linux
@@ -8,9 +8,7 @@  CONFIG_RTE_EXEC_ENV_LINUX=y
 CONFIG_RTE_EXEC_ENV_LINUXAPP=y
 
 CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=y
-CONFIG_RTE_EAL_IGB_UIO=y
 CONFIG_RTE_EAL_VFIO=y
-CONFIG_RTE_KNI_KMOD=y
 CONFIG_RTE_LIBRTE_KNI=y
 CONFIG_RTE_LIBRTE_PMD_KNI=y
 CONFIG_RTE_LIBRTE_VHOST=y