net/nfp: use macro PCI_PRI_FMT for PCI log format
Checks
Commit Message
Use PCI_PRI_FMT instead of "%04d:%02d:%02d:%d" print format.
Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
---
drivers/net/nfp/nfp_net.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Comments
> Use PCI_PRI_FMT instead of "%04d:%02d:%02d:%d" print format.
>
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> ---
> drivers/net/nfp/nfp_net.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
> index 3aafa7f80..64d9d218d 100644
> --- a/drivers/net/nfp/nfp_net.c
> +++ b/drivers/net/nfp/nfp_net.c
> @@ -1377,9 +1377,9 @@ nfp_net_dev_link_status_print(struct rte_eth_dev *dev)
> PMD_DRV_LOG(INFO, " Port %d: Link Down",
> dev->data->port_id);
>
> - PMD_DRV_LOG(INFO, "PCI Address: %04d:%02d:%02d:%d",
> - pci_dev->addr.domain, pci_dev->addr.bus,
> - pci_dev->addr.devid, pci_dev->addr.function);
> + PMD_DRV_LOG(INFO, "PCI Address: " PCI_PRI_FMT,
> + pci_dev->addr.domain, pci_dev->addr.bus,
> + pci_dev->addr.devid, pci_dev->addr.function);
> }
>
> /* Interrupt configuration and handling */
>
Acked-by: Heinrich Kuhn <heinrich.kuhn@netronome.com>
On 1/16/2020 8:12 AM, Heinrich Kuhn wrote:
>
>> Use PCI_PRI_FMT instead of "%04d:%02d:%02d:%d" print format.
>>
>> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
>> ---
>> drivers/net/nfp/nfp_net.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
>> index 3aafa7f80..64d9d218d 100644
>> --- a/drivers/net/nfp/nfp_net.c
>> +++ b/drivers/net/nfp/nfp_net.c
>> @@ -1377,9 +1377,9 @@ nfp_net_dev_link_status_print(struct rte_eth_dev *dev)
>> PMD_DRV_LOG(INFO, " Port %d: Link Down",
>> dev->data->port_id);
>>
>> - PMD_DRV_LOG(INFO, "PCI Address: %04d:%02d:%02d:%d",
>> - pci_dev->addr.domain, pci_dev->addr.bus,
>> - pci_dev->addr.devid, pci_dev->addr.function);
>> + PMD_DRV_LOG(INFO, "PCI Address: " PCI_PRI_FMT,
>> + pci_dev->addr.domain, pci_dev->addr.bus,
>> + pci_dev->addr.devid, pci_dev->addr.function);
>> }
>>
>> /* Interrupt configuration and handling */
>>
>
> Acked-by: Heinrich Kuhn <heinrich.kuhn@netronome.com>
>
Applied to dpdk-next-net/master, thanks.
@@ -1377,9 +1377,9 @@ nfp_net_dev_link_status_print(struct rte_eth_dev *dev)
PMD_DRV_LOG(INFO, " Port %d: Link Down",
dev->data->port_id);
- PMD_DRV_LOG(INFO, "PCI Address: %04d:%02d:%02d:%d",
- pci_dev->addr.domain, pci_dev->addr.bus,
- pci_dev->addr.devid, pci_dev->addr.function);
+ PMD_DRV_LOG(INFO, "PCI Address: " PCI_PRI_FMT,
+ pci_dev->addr.domain, pci_dev->addr.bus,
+ pci_dev->addr.devid, pci_dev->addr.function);
}
/* Interrupt configuration and handling */