net/ixgbe: enable jumbo frame for VF

Message ID 20191202200327.38509-1-junyux.jiang@intel.com (mailing list archive)
State Accepted, archived
Delegated to: xiaolong ye
Headers
Series net/ixgbe: enable jumbo frame for VF |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-compilation success Compile Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS

Commit Message

Junyu Jiang Dec. 2, 2019, 8:03 p.m. UTC
  Enable jumbo frame for VF by configuring DPDK PF.

Signed-off-by: Junyu Jiang <junyux.jiang@intel.com>
---
 drivers/net/ixgbe/ixgbe_pf.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)
  

Comments

Zhao1, Wei Dec. 18, 2019, 6:28 a.m. UTC | #1
Acked-by: Wei Zhao <wei.zhao1@intel.com>

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Junyu Jiang
> Sent: Tuesday, December 3, 2019 4:03 AM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>; Jiang, JunyuX <junyux.jiang@intel.com>
> Subject: [dpdk-dev] [PATCH] net/ixgbe: enable jumbo frame for VF
> 
> Enable jumbo frame for VF by configuring DPDK PF.
> 
> Signed-off-by: Junyu Jiang <junyux.jiang@intel.com>
> ---
>  drivers/net/ixgbe/ixgbe_pf.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_pf.c b/drivers/net/ixgbe/ixgbe_pf.c index
> d0d85e138..66b856e11 100644
> --- a/drivers/net/ixgbe/ixgbe_pf.c
> +++ b/drivers/net/ixgbe/ixgbe_pf.c
> @@ -544,6 +544,7 @@ ixgbe_set_vf_lpe(struct rte_eth_dev *dev,
> __rte_unused uint32_t vf, uint32_t *ms
>  	struct ixgbe_hw *hw =
> IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
>  	uint32_t new_mtu = msgbuf[1];
>  	uint32_t max_frs;
> +	uint32_t hlreg0;
>  	int max_frame = new_mtu + RTE_ETHER_HDR_LEN +
> RTE_ETHER_CRC_LEN;
> 
>  	/* X540 and X550 support jumbo frames in IOV mode */ @@ -560,6
> +561,18 @@ ixgbe_set_vf_lpe(struct rte_eth_dev *dev, __rte_unused
> uint32_t vf, uint32_t *ms
>  	max_frs = (IXGBE_READ_REG(hw, IXGBE_MAXFRS) &
>  		   IXGBE_MHADD_MFS_MASK) >> IXGBE_MHADD_MFS_SHIFT;
>  	if (max_frs < new_mtu) {
> +		hlreg0 = IXGBE_READ_REG(hw, IXGBE_HLREG0);
> +		if (new_mtu > RTE_ETHER_MAX_LEN) {
> +			dev->data->dev_conf.rxmode.offloads |=
> +				DEV_RX_OFFLOAD_JUMBO_FRAME;
> +			hlreg0 |= IXGBE_HLREG0_JUMBOEN;
> +		} else {
> +			dev->data->dev_conf.rxmode.offloads &=
> +				~DEV_RX_OFFLOAD_JUMBO_FRAME;
> +			hlreg0 &= ~IXGBE_HLREG0_JUMBOEN;
> +		}
> +		IXGBE_WRITE_REG(hw, IXGBE_HLREG0, hlreg0);
> +
>  		max_frs = new_mtu << IXGBE_MHADD_MFS_SHIFT;
>  		IXGBE_WRITE_REG(hw, IXGBE_MAXFRS, max_frs);
>  	}
> --
> 2.17.1
  
Xiaolong Ye Dec. 19, 2019, 8:17 a.m. UTC | #2
On 12/02, Junyu Jiang wrote:
>Enable jumbo frame for VF by configuring DPDK PF.
>
>Signed-off-by: Junyu Jiang <junyux.jiang@intel.com>
>---
> drivers/net/ixgbe/ixgbe_pf.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
>diff --git a/drivers/net/ixgbe/ixgbe_pf.c b/drivers/net/ixgbe/ixgbe_pf.c
>index d0d85e138..66b856e11 100644
>--- a/drivers/net/ixgbe/ixgbe_pf.c
>+++ b/drivers/net/ixgbe/ixgbe_pf.c
>@@ -544,6 +544,7 @@ ixgbe_set_vf_lpe(struct rte_eth_dev *dev, __rte_unused uint32_t vf, uint32_t *ms
> 	struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> 	uint32_t new_mtu = msgbuf[1];
> 	uint32_t max_frs;
>+	uint32_t hlreg0;
> 	int max_frame = new_mtu + RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN;
> 
> 	/* X540 and X550 support jumbo frames in IOV mode */
>@@ -560,6 +561,18 @@ ixgbe_set_vf_lpe(struct rte_eth_dev *dev, __rte_unused uint32_t vf, uint32_t *ms
> 	max_frs = (IXGBE_READ_REG(hw, IXGBE_MAXFRS) &
> 		   IXGBE_MHADD_MFS_MASK) >> IXGBE_MHADD_MFS_SHIFT;
> 	if (max_frs < new_mtu) {
>+		hlreg0 = IXGBE_READ_REG(hw, IXGBE_HLREG0);
>+		if (new_mtu > RTE_ETHER_MAX_LEN) {
>+			dev->data->dev_conf.rxmode.offloads |=
>+				DEV_RX_OFFLOAD_JUMBO_FRAME;
>+			hlreg0 |= IXGBE_HLREG0_JUMBOEN;
>+		} else {
>+			dev->data->dev_conf.rxmode.offloads &=
>+				~DEV_RX_OFFLOAD_JUMBO_FRAME;
>+			hlreg0 &= ~IXGBE_HLREG0_JUMBOEN;
>+		}
>+		IXGBE_WRITE_REG(hw, IXGBE_HLREG0, hlreg0);
>+
> 		max_frs = new_mtu << IXGBE_MHADD_MFS_SHIFT;
> 		IXGBE_WRITE_REG(hw, IXGBE_MAXFRS, max_frs);
> 	}
>-- 
>2.17.1
>


Applied to dpdk-next-net-intel with wei's ack, Thanks.
  

Patch

diff --git a/drivers/net/ixgbe/ixgbe_pf.c b/drivers/net/ixgbe/ixgbe_pf.c
index d0d85e138..66b856e11 100644
--- a/drivers/net/ixgbe/ixgbe_pf.c
+++ b/drivers/net/ixgbe/ixgbe_pf.c
@@ -544,6 +544,7 @@  ixgbe_set_vf_lpe(struct rte_eth_dev *dev, __rte_unused uint32_t vf, uint32_t *ms
 	struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
 	uint32_t new_mtu = msgbuf[1];
 	uint32_t max_frs;
+	uint32_t hlreg0;
 	int max_frame = new_mtu + RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN;
 
 	/* X540 and X550 support jumbo frames in IOV mode */
@@ -560,6 +561,18 @@  ixgbe_set_vf_lpe(struct rte_eth_dev *dev, __rte_unused uint32_t vf, uint32_t *ms
 	max_frs = (IXGBE_READ_REG(hw, IXGBE_MAXFRS) &
 		   IXGBE_MHADD_MFS_MASK) >> IXGBE_MHADD_MFS_SHIFT;
 	if (max_frs < new_mtu) {
+		hlreg0 = IXGBE_READ_REG(hw, IXGBE_HLREG0);
+		if (new_mtu > RTE_ETHER_MAX_LEN) {
+			dev->data->dev_conf.rxmode.offloads |=
+				DEV_RX_OFFLOAD_JUMBO_FRAME;
+			hlreg0 |= IXGBE_HLREG0_JUMBOEN;
+		} else {
+			dev->data->dev_conf.rxmode.offloads &=
+				~DEV_RX_OFFLOAD_JUMBO_FRAME;
+			hlreg0 &= ~IXGBE_HLREG0_JUMBOEN;
+		}
+		IXGBE_WRITE_REG(hw, IXGBE_HLREG0, hlreg0);
+
 		max_frs = new_mtu << IXGBE_MHADD_MFS_SHIFT;
 		IXGBE_WRITE_REG(hw, IXGBE_MAXFRS, max_frs);
 	}