[v2,1/5] drivers/octeontx2: allow experimental symbols
Checks
Commit Message
Multiple experimental symbols are used. They must be allowed
to avoid compilation error.
Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
---
drivers/common/octeontx2/Makefile | 2 ++
drivers/common/octeontx2/meson.build | 2 ++
drivers/net/octeontx2/Makefile | 2 ++
drivers/net/octeontx2/meson.build | 2 ++
drivers/raw/octeontx2_dma/Makefile | 2 ++
drivers/raw/octeontx2_dma/meson.build | 2 ++
6 files changed, 12 insertions(+)
Comments
26/11/2019 07:15, Sunil Kumar Kori:
> Multiple experimental symbols are used. They must be allowed
> to avoid compilation error.
If there was an error,
1/ I would see it in my compilation test
2/ There would be some "Fixes:" tag to point the root cause
I guess this patch is not critical.
Where are patches 2, 3, 4, 5?
>
> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
> ---
> drivers/common/octeontx2/Makefile | 2 ++
> drivers/common/octeontx2/meson.build | 2 ++
> drivers/net/octeontx2/Makefile | 2 ++
> drivers/net/octeontx2/meson.build | 2 ++
> drivers/raw/octeontx2_dma/Makefile | 2 ++
> drivers/raw/octeontx2_dma/meson.build | 2 ++
> 6 files changed, 12 insertions(+)
Regards
Sunil Kumar Kori
>-----Original Message-----
>From: Thomas Monjalon <thomas@monjalon.net>
>Sent: Tuesday, November 26, 2019 9:51 PM
>To: dev@dpdk.org
>Cc: Sunil Kumar Kori <skori@marvell.com>; Jerin Jacob Kollanukkaran
><jerinj@marvell.com>; Nithin Kumar Dabilpuram
><ndabilpuram@marvell.com>; Vamsi Krishna Attunuru
><vattunuru@marvell.com>; Kiran Kumar Kokkilagadda
><kirankumark@marvell.com>; Satha Koteswara Rao Kottidi
><skoteshwar@marvell.com>
>Subject: [EXT] Re: [dpdk-dev] [PATCH v2 1/5] drivers/octeontx2: allow
>experimental symbols
>
>External Email
>
>----------------------------------------------------------------------
>26/11/2019 07:15, Sunil Kumar Kori:
>> Multiple experimental symbols are used. They must be allowed to avoid
>> compilation error.
>
>If there was an error,
>1/ I would see it in my compilation test 2/ There would be some "Fixes:" tag to
>point the root cause
Actually change is part of below series which is started using experimental symbols in mentioned driver.
Apart of these drivers, FLAGs are already present in other drivers so that there is no error found.
Error occurs when applying below series.
So I had two options to get it done. Either I can do Makefile changes along with the corresponding changes or
make them as a separate patch. I have chosen second option.
And because of this is new change, it does not contain any "Fixes" tag.
>
>I guess this patch is not critical.
>Where are patches 2, 3, 4, 5?
Following are the series of patches:
http://patches.dpdk.org/patch/63299/
http://patches.dpdk.org/patch/63271/
http://patches.dpdk.org/patch/63272/
http://patches.dpdk.org/patch/63273/
http://patches.dpdk.org/patch/63274/
Not all the patches are reworked for next versions that's why same is not reflected in subject line.
>
>>
>> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
>> ---
>> drivers/common/octeontx2/Makefile | 2 ++
>> drivers/common/octeontx2/meson.build | 2 ++
>> drivers/net/octeontx2/Makefile | 2 ++
>> drivers/net/octeontx2/meson.build | 2 ++
>> drivers/raw/octeontx2_dma/Makefile | 2 ++
>> drivers/raw/octeontx2_dma/meson.build | 2 ++
>> 6 files changed, 12 insertions(+)
>
>
27/11/2019 09:34, Sunil Kumar Kori:
> From: Thomas Monjalon <thomas@monjalon.net>
> >26/11/2019 07:15, Sunil Kumar Kori:
> >> Multiple experimental symbols are used. They must be allowed to avoid
> >> compilation error.
> >
> >If there was an error,
> >1/ I would see it in my compilation test 2/ There would be some "Fixes:" tag to
> >point the root cause
>
> Actually change is part of below series which is started using experimental symbols in mentioned driver.
> Apart of these drivers, FLAGs are already present in other drivers so that there is no error found.
> Error occurs when applying below series.
>
> So I had two options to get it done. Either I can do Makefile changes along with the corresponding changes or
> make them as a separate patch. I have chosen second option.
This is the wrong choice :)
When you do a change, it should be atomic, i.e. includes changes which are dependent.
> And because of this is new change, it does not contain any "Fixes" tag.
> >
> >I guess this patch is not critical.
> >Where are patches 2, 3, 4, 5?
> Following are the series of patches:
> http://patches.dpdk.org/patch/63299/
> http://patches.dpdk.org/patch/63271/
> http://patches.dpdk.org/patch/63272/
> http://patches.dpdk.org/patch/63273/
> http://patches.dpdk.org/patch/63274/
> Not all the patches are reworked for next versions that's why same is not reflected in subject line.
When you send a new version, you should send the whole series again.
And please don't forget changelogs and --in-reply-to.
Thanks
@@ -22,6 +22,8 @@ CFLAGS += -diag-disable 2259
endif
endif
+CFLAGS += -DALLOW_EXPERIMENTAL_API
+
EXPORT_MAP := rte_common_octeontx2_version.map
#
@@ -8,6 +8,8 @@ sources= files('otx2_dev.c',
'otx2_common.c',
)
+allow_experimental_apis = true
+
extra_flags = []
# This integrated controller runs only on a arm64 machine, remove 32bit warnings
if not dpdk_conf.get('RTE_ARCH_64')
@@ -26,6 +26,8 @@ CFLAGS += -diag-disable 2259
endif
endif
+CFLAGS += -DALLOW_EXPERIMENTAL_API
+
EXPORT_MAP := rte_pmd_octeontx2_version.map
#
@@ -24,6 +24,8 @@ sources = files('otx2_rx.c',
'otx2_ethdev_devargs.c'
)
+allow_experimental_apis = true
+
deps += ['bus_pci', 'common_octeontx2', 'mempool_octeontx2']
cflags += ['-flax-vector-conversions']
@@ -22,6 +22,8 @@ CFLAGS += -diag-disable 2259
endif
endif
+CFLAGS += -DALLOW_EXPERIMENTAL_API
+
EXPORT_MAP := rte_rawdev_octeontx2_dma_version.map
#
@@ -5,6 +5,8 @@
deps += ['bus_pci', 'common_octeontx2', 'rawdev']
sources = files('otx2_dpi_rawdev.c', 'otx2_dpi_msg.c', 'otx2_dpi_test.c')
+allow_experimental_apis = true
+
extra_flags = []
# This integrated controller runs only on a arm64 machine, remove 32bit warnings
if not dpdk_conf.get('RTE_ARCH_64')