[v3,00/22] add hns3 ethernet PMD driver

Message ID	1569506528-60464-1-git-send-email-xavier.huwei@huawei.com (mailing list archive)
Headers	From: "Wei Hu (Xavier)" <xavier.huwei@huawei.com> To: <dev@dpdk.org> CC: <linuxarm@huawei.com>, <xavier_huwei@163.com>, <xavier.huwei@tom.com>, <forest.zhouchang@huawei.com> Date: Thu, 26 Sep 2019 22:01:46 +0800 Message-ID: <1569506528-60464-1-git-send-email-xavier.huwei@huawei.com> MIME-Version: 1.0 Content-Type: text/plain Subject: [dpdk-dev] [PATCH v3 00/22] add hns3 ethernet PMD driver Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	add hns3 ethernet PMD driver \| [v3,00/22] add hns3 ethernet PMD driver [v3,01/22] net/hns3: add build and doc infrastructure [v3,02/22] net/hns3: add hardware registers definition [v3,03/22] net/hns3: add some definitions for data structure and macro [v3,04/22] net/hns3: register hns3 PMD driver and add the log interface definition [v3,05/22] net/hns3: add support for cmd of hns3 PMD driver [v3,06/22] net/hns3: add the initialization of hns3 PMD driver [v3,07/22] net/hns3: add support for MAC address related operations [v3,08/22] net/hns3: add support for some misc operations [v3,09/22] net/hns3: add support for link_update operation [v3,10/22] net/hns3: add support for flow directory of hns3 PMD driver [v3,11/22] net/hns3: add support for RSS of hns3 PMD driver [v3,12/22] net/hns3: add support for flow control of hns3 PMD driver [v3,13/22] net/hns3: add support for vlan of hns3 PMD driver [v3,14/22] net/hns3: add support for mailbox of hns3 PMD driver [v3,15/22] net/hns3: add support for hns3 VF PMD driver [v3,16/22] net/hns3: add RX/TX package burst and queue related operation [v3,17/22] net/hns3: add start stop configure promiscuous ops [v3,18/22] net/hns3: add dump register ops for hns3 PMD driver [v3,19/22] net/hns3: add abnormal interrupt process for hns3 PMD driver [v3,20/22] net/hns3: add stats related ops for hns3 PMD driver [v3,21/22] net/hns3: add reset related process for hns3 PMD driver [v3,22/22] net/hns3: add multiple process support for hns3 PMD driver

Message ID

1569506528-60464-1-git-send-email-xavier.huwei@huawei.com (mailing list archive)

Headers

From: "Wei Hu (Xavier)" <xavier.huwei@huawei.com>
To: <dev@dpdk.org>
CC: <linuxarm@huawei.com>, <xavier_huwei@163.com>, <xavier.huwei@tom.com>,
	<forest.zhouchang@huawei.com>
Date: Thu, 26 Sep 2019 22:01:46 +0800
Message-ID: <1569506528-60464-1-git-send-email-xavier.huwei@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain
Subject: [dpdk-dev] [PATCH v3 00/22] add hns3 ethernet PMD driver
Precedence: list
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Series

add hns3 ethernet PMD driver |

Message

Wei Hu (Xavier) Sept. 26, 2019, 2:01 p.m. UTC

  The Hisilicon Network Subsystem is a long term evolution IP which is
supposed to be used in Hisilicon ICT SoCs such as Kunpeng 920.

This series add DPDK rte_ethdev poll mode driver for Hisilicon
Network Subsystem 3(hns3) network engine.

v2 -> v3:
	1. Resolve the conflict problem when performing git operation
	   based on the current repository. The conflict occurs in
	   doc/guides/rel_notes/release_19_11.rst.

v1 -> v2:
	1. Address some comments from Jerin Jacob Kollanukkaran,
	   Stephen Hemminger and Ferruh Yigit.

Wei Hu (Xavier) (22):
  net/hns3: add build and doc infrastructure
  net/hns3: add hardware registers definition
  net/hns3: add some definitions for data structure and macro
  net/hns3: register hns3 PMD driver and add the log interface
    definition
  net/hns3: add support for cmd of hns3 PMD driver
  net/hns3: add the initialization of hns3 PMD driver
  net/hns3: add support for MAC address related operations
  net/hns3: add support for some misc operations
  net/hns3: add support for link_update operation
  net/hns3: add support for flow directory of hns3 PMD driver
  net/hns3: add support for RSS of hns3 PMD driver
  net/hns3: add support for flow control of hns3 PMD driver
  net/hns3: add support for vlan of hns3 PMD driver
  net/hns3: add support for mailbox of hns3 PMD driver
  net/hns3: add support for hns3 VF PMD driver
  net/hns3: add RX/TX package burst and queue related operation
  net/hns3: add start stop configure promiscuous ops
  net/hns3: add dump register ops for hns3 PMD driver
  net/hns3: add abnormal interrupt process for hns3 PMD driver
  net/hns3: add stats related ops for hns3 PMD driver
  net/hns3: add reset related process for hns3 PMD driver
  net/hns3: add multiple process support for hns3 PMD driver

 MAINTAINERS                                  |    8 +
 config/common_base                           |    5 +
 config/common_linux                          |    5 +
 config/defconfig_arm-armv7a-linuxapp-gcc     |    1 +
 config/defconfig_i686-native-linuxapp-gcc    |    5 +
 config/defconfig_i686-native-linuxapp-icc    |    5 +
 config/defconfig_ppc_64-power8-linuxapp-gcc  |    1 +
 config/defconfig_x86_64-native-linuxapp-icc  |    5 +
 config/defconfig_x86_x32-native-linuxapp-gcc |    5 +
 doc/guides/nics/features/hns3.ini            |   34 +
 doc/guides/nics/features/hns3_vf.ini         |   29 +
 doc/guides/nics/hns3.rst                     |   60 +
 doc/guides/nics/index.rst                    |    1 +
 doc/guides/rel_notes/release_19_11.rst       |    6 +
 drivers/net/Makefile                         |    1 +
 drivers/net/hns3/Makefile                    |   45 +
 drivers/net/hns3/hns3_cmd.c                  |  565 +++
 drivers/net/hns3/hns3_cmd.h                  |  761 ++++
 drivers/net/hns3/hns3_dcb.c                  | 1642 +++++++++
 drivers/net/hns3/hns3_dcb.h                  |  166 +
 drivers/net/hns3/hns3_ethdev.c               | 4947 ++++++++++++++++++++++++++
 drivers/net/hns3/hns3_ethdev.h               |  645 ++++
 drivers/net/hns3/hns3_ethdev_vf.c            | 1725 +++++++++
 drivers/net/hns3/hns3_fdir.c                 | 1059 ++++++
 drivers/net/hns3/hns3_fdir.h                 |  205 ++
 drivers/net/hns3/hns3_flow.c                 | 1903 ++++++++++
 drivers/net/hns3/hns3_intr.c                 | 1166 ++++++
 drivers/net/hns3/hns3_intr.h                 |   79 +
 drivers/net/hns3/hns3_logs.h                 |   34 +
 drivers/net/hns3/hns3_mbx.c                  |  353 ++
 drivers/net/hns3/hns3_mbx.h                  |  136 +
 drivers/net/hns3/hns3_mp.c                   |  214 ++
 drivers/net/hns3/hns3_mp.h                   |   14 +
 drivers/net/hns3/hns3_regs.c                 |  368 ++
 drivers/net/hns3/hns3_regs.h                 |   99 +
 drivers/net/hns3/hns3_rss.c                  |  584 +++
 drivers/net/hns3/hns3_rss.h                  |  124 +
 drivers/net/hns3/hns3_rxtx.c                 | 1676 +++++++++
 drivers/net/hns3/hns3_rxtx.h                 |  317 ++
 drivers/net/hns3/hns3_stats.c                |  975 +++++
 drivers/net/hns3/hns3_stats.h                |  152 +
 drivers/net/hns3/meson.build                 |   37 +
 drivers/net/hns3/rte_pmd_hns3_version.map    |    3 +
 drivers/net/meson.build                      |    1 +
 mk/rte.app.mk                                |    1 +
 45 files changed, 20167 insertions(+)
 create mode 100644 doc/guides/nics/features/hns3.ini
 create mode 100644 doc/guides/nics/features/hns3_vf.ini
 create mode 100644 doc/guides/nics/hns3.rst
 create mode 100644 drivers/net/hns3/Makefile
 create mode 100644 drivers/net/hns3/hns3_cmd.c
 create mode 100644 drivers/net/hns3/hns3_cmd.h
 create mode 100644 drivers/net/hns3/hns3_dcb.c
 create mode 100644 drivers/net/hns3/hns3_dcb.h
 create mode 100644 drivers/net/hns3/hns3_ethdev.c
 create mode 100644 drivers/net/hns3/hns3_ethdev.h
 create mode 100644 drivers/net/hns3/hns3_ethdev_vf.c
 create mode 100644 drivers/net/hns3/hns3_fdir.c
 create mode 100644 drivers/net/hns3/hns3_fdir.h
 create mode 100644 drivers/net/hns3/hns3_flow.c
 create mode 100644 drivers/net/hns3/hns3_intr.c
 create mode 100644 drivers/net/hns3/hns3_intr.h
 create mode 100644 drivers/net/hns3/hns3_logs.h
 create mode 100644 drivers/net/hns3/hns3_mbx.c
 create mode 100644 drivers/net/hns3/hns3_mbx.h
 create mode 100644 drivers/net/hns3/hns3_mp.c
 create mode 100644 drivers/net/hns3/hns3_mp.h
 create mode 100644 drivers/net/hns3/hns3_regs.c
 create mode 100644 drivers/net/hns3/hns3_regs.h
 create mode 100644 drivers/net/hns3/hns3_rss.c
 create mode 100644 drivers/net/hns3/hns3_rss.h
 create mode 100644 drivers/net/hns3/hns3_rxtx.c
 create mode 100644 drivers/net/hns3/hns3_rxtx.h
 create mode 100644 drivers/net/hns3/hns3_stats.c
 create mode 100644 drivers/net/hns3/hns3_stats.h
 create mode 100644 drivers/net/hns3/meson.build
 create mode 100644 drivers/net/hns3/rte_pmd_hns3_version.map

Comments

Wei Hu (Xavier) Sept. 27, 2019, 6:52 a.m. UTC | #1

Hi, Ferruh Yigit

  I sent out PATCH V3 to fix the conflict that occurs in
doc/guides/rel_notes/release_19_11.rst when performing
'git am patch(PATCH V2 series)' operation based on the latest
dpdk-next-net because of the recent change in the repository.

  The page in patches.dpdk.org indicates that CI checking
against this series failed and terminated, the content of 'S/W/F' field is '---', the page as follows:
http://patches.dpdk.org/project/dpdk/list/?series=&submitter=1405&state=*&q=&archive=&delegate=

  The information of CI building as follows, and in fact
there was non incompatible pointer type error based on
the latest repo in my local server.
http://mails.dpdk.org/archives/test-report/2019-September/099170.html

/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4723:24: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
  .promiscuous_enable = hns3_dev_promiscuous_enable,
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4723:24: note: (near initialization for ‘hns3_eth_dev_ops.promiscuous_enable’)
/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4724:25: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
  .promiscuous_disable = hns3_dev_promiscuous_disable,
                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4724:25: note: (near initialization for ‘hns3_eth_dev_ops.promiscuous_disable’)
/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4725:26: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
  .allmulticast_enable  = hns3_dev_allmulticast_enable,
                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4725:26: note: (near initialization for ‘hns3_eth_dev_ops.allmulticast_enable’)
/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4726:26: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
  .allmulticast_disable = hns3_dev_allmulticast_disable,
                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4726:26: note: (near initialization for ‘hns3_eth_dev_ops.allmulticast_disable’)
/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4729:24: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
  .stats_reset        = hns3_stats_reset,
                        ^~~~~~~~~~~~~~~~
/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4729:24: note: (near initialization for ‘hns3_eth_dev_ops.stats_reset’)
/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4732:24: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
  .xstats_reset       = hns3_dev_xstats_reset,
                        ^~~~~~~~~~~~~~~~~~~~~
/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4732:24: note: (near initialization for ‘hns3_eth_dev_ops.xstats_reset’)
/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4735:28: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
  .dev_infos_get          = hns3_dev_infos_get,
                            ^~~~~~~~~~~~~~~~~~
/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4735:28: note: (near initialization for ‘hns3_eth_dev_ops.dev_infos_get’)
cc1: error: unrecognized command line option ‘-Wno-address-of-packed-member’ [-Werror]
cc1: all warnings being treated as errors
/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/mk/internal/rte.compile-pre.mk:114: recipe for target 'hns3_ethdev.o' failed
make[6]: *** [hns3_ethdev.o] Error 1


  The detail information of the repository when making PATCH V3 on as follows: 

repo: http://dpdk.org/git/next/dpdk-next-net
branch: master

git log --oneline
3be6962 app/testpmd: fix unused variable compile error
5453153 app/testpmd: fix crash on port reset
944ee10 net/ipn3ke: setup MTU during HW init
52e3ab3 net/ice: remove Rx legacy descriptor definition
d27982e net/ice: switch to Rx flexible descriptor in AVX path
0973c28 net/ice: switch to flexible descriptor in SSE path
98ed8c1 net/ice: add protocol extraction support for per Rx queue
03ff0d1 net/ice: handle the Rx flex descriptor
2962f75 net/ice: add Rx flex descriptor definition
a03e11f net/i40e: limit the number of VF messages
644032b net/ice/base: remove unused code
c02031f net/ice/base: add switch support for IPv6 tc field
05859a5 net/ice/base: fix PTYPE bitmap
4f07dc0 net/ice/base: fix alignment
9d1c626 net/ice/base: use bitmap copy where appropriate
3efd0a4 net/ice/base: remove unnecessary error log
82c1c29 net/ice/base: fix 4 bytes alignment for PPPoE dummy packet
17db50c net/ice/base: search field vector indices for result slots
9ef53fb net/ice/base: remove unused DDP package macros
665293f net/ice/base: fix segment in remove existing RSS rule
079ca8c net/ice/base: fix the bitmap for TCP in RSS
d3e1ebd net/ice/base: add FDIR support for GTPU QFI field

  
  Is there a way to reconstruct PATCH V3 in CI? Do we
resend PATCH V3 to trigger CI reconstruct them again?
Thanks for your suggestion.

  Regards
Xavier


On 2019/9/26 22:01, Wei Hu (Xavier) wrote:
> The Hisilicon Network Subsystem is a long term evolution IP which is
> supposed to be used in Hisilicon ICT SoCs such as Kunpeng 920.
>
> This series add DPDK rte_ethdev poll mode driver for Hisilicon
> Network Subsystem 3(hns3) network engine.
>
> v2 -> v3:
> 	1. Resolve the conflict problem when performing git operation
> 	   based on the current repository. The conflict occurs in
> 	   doc/guides/rel_notes/release_19_11.rst.
>
> v1 -> v2:
> 	1. Address some comments from Jerin Jacob Kollanukkaran,
> 	   Stephen Hemminger and Ferruh Yigit.
>
> Wei Hu (Xavier) (22):
>   net/hns3: add build and doc infrastructure
>   net/hns3: add hardware registers definition
>   net/hns3: add some definitions for data structure and macro
>   net/hns3: register hns3 PMD driver and add the log interface
>     definition
>   net/hns3: add support for cmd of hns3 PMD driver
>   net/hns3: add the initialization of hns3 PMD driver
>   net/hns3: add support for MAC address related operations
>   net/hns3: add support for some misc operations
>   net/hns3: add support for link_update operation
>   net/hns3: add support for flow directory of hns3 PMD driver
>   net/hns3: add support for RSS of hns3 PMD driver
>   net/hns3: add support for flow control of hns3 PMD driver
>   net/hns3: add support for vlan of hns3 PMD driver
>   net/hns3: add support for mailbox of hns3 PMD driver
>   net/hns3: add support for hns3 VF PMD driver
>   net/hns3: add RX/TX package burst and queue related operation
>   net/hns3: add start stop configure promiscuous ops
>   net/hns3: add dump register ops for hns3 PMD driver
>   net/hns3: add abnormal interrupt process for hns3 PMD driver
>   net/hns3: add stats related ops for hns3 PMD driver
>   net/hns3: add reset related process for hns3 PMD driver
>   net/hns3: add multiple process support for hns3 PMD driver
>
>  MAINTAINERS                                  |    8 +
>  config/common_base                           |    5 +
>  config/common_linux                          |    5 +
>  config/defconfig_arm-armv7a-linuxapp-gcc     |    1 +
>  config/defconfig_i686-native-linuxapp-gcc    |    5 +
>  config/defconfig_i686-native-linuxapp-icc    |    5 +
>  config/defconfig_ppc_64-power8-linuxapp-gcc  |    1 +
>  config/defconfig_x86_64-native-linuxapp-icc  |    5 +
>  config/defconfig_x86_x32-native-linuxapp-gcc |    5 +
>  doc/guides/nics/features/hns3.ini            |   34 +
>  doc/guides/nics/features/hns3_vf.ini         |   29 +
>  doc/guides/nics/hns3.rst                     |   60 +
>  doc/guides/nics/index.rst                    |    1 +
>  doc/guides/rel_notes/release_19_11.rst       |    6 +
>  drivers/net/Makefile                         |    1 +
>  drivers/net/hns3/Makefile                    |   45 +
>  drivers/net/hns3/hns3_cmd.c                  |  565 +++
>  drivers/net/hns3/hns3_cmd.h                  |  761 ++++
>  drivers/net/hns3/hns3_dcb.c                  | 1642 +++++++++
>  drivers/net/hns3/hns3_dcb.h                  |  166 +
>  drivers/net/hns3/hns3_ethdev.c               | 4947 ++++++++++++++++++++++++++
>  drivers/net/hns3/hns3_ethdev.h               |  645 ++++
>  drivers/net/hns3/hns3_ethdev_vf.c            | 1725 +++++++++
>  drivers/net/hns3/hns3_fdir.c                 | 1059 ++++++
>  drivers/net/hns3/hns3_fdir.h                 |  205 ++
>  drivers/net/hns3/hns3_flow.c                 | 1903 ++++++++++
>  drivers/net/hns3/hns3_intr.c                 | 1166 ++++++
>  drivers/net/hns3/hns3_intr.h                 |   79 +
>  drivers/net/hns3/hns3_logs.h                 |   34 +
>  drivers/net/hns3/hns3_mbx.c                  |  353 ++
>  drivers/net/hns3/hns3_mbx.h                  |  136 +
>  drivers/net/hns3/hns3_mp.c                   |  214 ++
>  drivers/net/hns3/hns3_mp.h                   |   14 +
>  drivers/net/hns3/hns3_regs.c                 |  368 ++
>  drivers/net/hns3/hns3_regs.h                 |   99 +
>  drivers/net/hns3/hns3_rss.c                  |  584 +++
>  drivers/net/hns3/hns3_rss.h                  |  124 +
>  drivers/net/hns3/hns3_rxtx.c                 | 1676 +++++++++
>  drivers/net/hns3/hns3_rxtx.h                 |  317 ++
>  drivers/net/hns3/hns3_stats.c                |  975 +++++
>  drivers/net/hns3/hns3_stats.h                |  152 +
>  drivers/net/hns3/meson.build                 |   37 +
>  drivers/net/hns3/rte_pmd_hns3_version.map    |    3 +
>  drivers/net/meson.build                      |    1 +
>  mk/rte.app.mk                                |    1 +
>  45 files changed, 20167 insertions(+)
>  create mode 100644 doc/guides/nics/features/hns3.ini
>  create mode 100644 doc/guides/nics/features/hns3_vf.ini
>  create mode 100644 doc/guides/nics/hns3.rst
>  create mode 100644 drivers/net/hns3/Makefile
>  create mode 100644 drivers/net/hns3/hns3_cmd.c
>  create mode 100644 drivers/net/hns3/hns3_cmd.h
>  create mode 100644 drivers/net/hns3/hns3_dcb.c
>  create mode 100644 drivers/net/hns3/hns3_dcb.h
>  create mode 100644 drivers/net/hns3/hns3_ethdev.c
>  create mode 100644 drivers/net/hns3/hns3_ethdev.h
>  create mode 100644 drivers/net/hns3/hns3_ethdev_vf.c
>  create mode 100644 drivers/net/hns3/hns3_fdir.c
>  create mode 100644 drivers/net/hns3/hns3_fdir.h
>  create mode 100644 drivers/net/hns3/hns3_flow.c
>  create mode 100644 drivers/net/hns3/hns3_intr.c
>  create mode 100644 drivers/net/hns3/hns3_intr.h
>  create mode 100644 drivers/net/hns3/hns3_logs.h
>  create mode 100644 drivers/net/hns3/hns3_mbx.c
>  create mode 100644 drivers/net/hns3/hns3_mbx.h
>  create mode 100644 drivers/net/hns3/hns3_mp.c
>  create mode 100644 drivers/net/hns3/hns3_mp.h
>  create mode 100644 drivers/net/hns3/hns3_regs.c
>  create mode 100644 drivers/net/hns3/hns3_regs.h
>  create mode 100644 drivers/net/hns3/hns3_rss.c
>  create mode 100644 drivers/net/hns3/hns3_rss.h
>  create mode 100644 drivers/net/hns3/hns3_rxtx.c
>  create mode 100644 drivers/net/hns3/hns3_rxtx.h
>  create mode 100644 drivers/net/hns3/hns3_stats.c
>  create mode 100644 drivers/net/hns3/hns3_stats.h
>  create mode 100644 drivers/net/hns3/meson.build
>  create mode 100644 drivers/net/hns3/rte_pmd_hns3_version.map
>

Ferruh Yigit Sept. 27, 2019, 8:47 a.m. UTC | #2

On 9/27/2019 7:52 AM, Wei Hu (Xavier) wrote:
> Hi, Ferruh Yigit
> 
>   I sent out PATCH V3 to fix the conflict that occurs in
> doc/guides/rel_notes/release_19_11.rst when performing
> 'git am patch(PATCH V2 series)' operation based on the latest
> dpdk-next-net because of the recent change in the repository.
> 
>   The page in patches.dpdk.org indicates that CI checking
> against this series failed and terminated, the content of 'S/W/F' field is '---', the page as follows:
> http://patches.dpdk.org/project/dpdk/list/?series=&submitter=1405&state=*&q=&archive=&delegate=
> 
>   The information of CI building as follows, and in fact
> there was non incompatible pointer type error based on
> the latest repo in my local server.
> http://mails.dpdk.org/archives/test-report/2019-September/099170.html
> 
> /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4723:24: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
>   .promiscuous_enable = hns3_dev_promiscuous_enable,
>                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4723:24: note: (near initialization for ‘hns3_eth_dev_ops.promiscuous_enable’)
> /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4724:25: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
>   .promiscuous_disable = hns3_dev_promiscuous_disable,
>                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4724:25: note: (near initialization for ‘hns3_eth_dev_ops.promiscuous_disable’)
> /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4725:26: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
>   .allmulticast_enable  = hns3_dev_allmulticast_enable,
>                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4725:26: note: (near initialization for ‘hns3_eth_dev_ops.allmulticast_enable’)
> /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4726:26: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
>   .allmulticast_disable = hns3_dev_allmulticast_disable,
>                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4726:26: note: (near initialization for ‘hns3_eth_dev_ops.allmulticast_disable’)
> /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4729:24: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
>   .stats_reset        = hns3_stats_reset,
>                         ^~~~~~~~~~~~~~~~
> /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4729:24: note: (near initialization for ‘hns3_eth_dev_ops.stats_reset’)
> /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4732:24: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
>   .xstats_reset       = hns3_dev_xstats_reset,
>                         ^~~~~~~~~~~~~~~~~~~~~
> /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4732:24: note: (near initialization for ‘hns3_eth_dev_ops.xstats_reset’)
> /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4735:28: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
>   .dev_infos_get          = hns3_dev_infos_get,
>                             ^~~~~~~~~~~~~~~~~~
> /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4735:28: note: (near initialization for ‘hns3_eth_dev_ops.dev_infos_get’)
> cc1: error: unrecognized command line option ‘-Wno-address-of-packed-member’ [-Werror]
> cc1: all warnings being treated as errors
> /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/mk/internal/rte.compile-pre.mk:114: recipe for target 'hns3_ethdev.o' failed
> make[6]: *** [hns3_ethdev.o] Error 1
> 
> 
>   The detail information of the repository when making PATCH V3 on as follows: 
> 
> repo: http://dpdk.org/git/next/dpdk-next-net
> branch: master

Hi Xavier,

Above repo and the branch is correct, also with a quick check your code seems
correct too.

CI is using wrong tree for the build test [1], @Ali, @Aaron and @Jeremy are on
cc for long term investigation.

Hopefully there will be a merge from next-net to main repo, that should fix the
false positives in CI.
Can you please follow the merge and ping us, so we can ask to Jeremy to re-run
the test?

Thanks,
ferruh


[1]
Metadata from test:
"
Test-Label: Performance-Testing
Test-Status: FAILURE
http://dpdk.org/patch/59882

_build patch failure_

Submitter: Wei Hu (Xavier) <xavier.huwei at huawei.com>
Date: Thursday, September 26 2019 14:01:47
Applied on: CommitID:bd253daa7717835f88bbc58b09a94d0060380396
Apply patch set 59882-59901 failed:
"

Commit is from the main tree, that is why causing the build error.

> 
> git log --oneline
> 3be6962 app/testpmd: fix unused variable compile error
> 5453153 app/testpmd: fix crash on port reset
> 944ee10 net/ipn3ke: setup MTU during HW init
> 52e3ab3 net/ice: remove Rx legacy descriptor definition
> d27982e net/ice: switch to Rx flexible descriptor in AVX path
> 0973c28 net/ice: switch to flexible descriptor in SSE path
> 98ed8c1 net/ice: add protocol extraction support for per Rx queue
> 03ff0d1 net/ice: handle the Rx flex descriptor
> 2962f75 net/ice: add Rx flex descriptor definition
> a03e11f net/i40e: limit the number of VF messages
> 644032b net/ice/base: remove unused code
> c02031f net/ice/base: add switch support for IPv6 tc field
> 05859a5 net/ice/base: fix PTYPE bitmap
> 4f07dc0 net/ice/base: fix alignment
> 9d1c626 net/ice/base: use bitmap copy where appropriate
> 3efd0a4 net/ice/base: remove unnecessary error log
> 82c1c29 net/ice/base: fix 4 bytes alignment for PPPoE dummy packet
> 17db50c net/ice/base: search field vector indices for result slots
> 9ef53fb net/ice/base: remove unused DDP package macros
> 665293f net/ice/base: fix segment in remove existing RSS rule
> 079ca8c net/ice/base: fix the bitmap for TCP in RSS
> d3e1ebd net/ice/base: add FDIR support for GTPU QFI field
> 
>   
>   Is there a way to reconstruct PATCH V3 in CI? Do we
> resend PATCH V3 to trigger CI reconstruct them again?
> Thanks for your suggestion.
> 
>   Regards
> Xavier
> 
> 
> On 2019/9/26 22:01, Wei Hu (Xavier) wrote:
>> The Hisilicon Network Subsystem is a long term evolution IP which is
>> supposed to be used in Hisilicon ICT SoCs such as Kunpeng 920.
>>
>> This series add DPDK rte_ethdev poll mode driver for Hisilicon
>> Network Subsystem 3(hns3) network engine.
>>
>> v2 -> v3:
>> 	1. Resolve the conflict problem when performing git operation
>> 	   based on the current repository. The conflict occurs in
>> 	   doc/guides/rel_notes/release_19_11.rst.
>>
>> v1 -> v2:
>> 	1. Address some comments from Jerin Jacob Kollanukkaran,
>> 	   Stephen Hemminger and Ferruh Yigit.
>>
>> Wei Hu (Xavier) (22):
>>   net/hns3: add build and doc infrastructure
>>   net/hns3: add hardware registers definition
>>   net/hns3: add some definitions for data structure and macro
>>   net/hns3: register hns3 PMD driver and add the log interface
>>     definition
>>   net/hns3: add support for cmd of hns3 PMD driver
>>   net/hns3: add the initialization of hns3 PMD driver
>>   net/hns3: add support for MAC address related operations
>>   net/hns3: add support for some misc operations
>>   net/hns3: add support for link_update operation
>>   net/hns3: add support for flow directory of hns3 PMD driver
>>   net/hns3: add support for RSS of hns3 PMD driver
>>   net/hns3: add support for flow control of hns3 PMD driver
>>   net/hns3: add support for vlan of hns3 PMD driver
>>   net/hns3: add support for mailbox of hns3 PMD driver
>>   net/hns3: add support for hns3 VF PMD driver
>>   net/hns3: add RX/TX package burst and queue related operation
>>   net/hns3: add start stop configure promiscuous ops
>>   net/hns3: add dump register ops for hns3 PMD driver
>>   net/hns3: add abnormal interrupt process for hns3 PMD driver
>>   net/hns3: add stats related ops for hns3 PMD driver
>>   net/hns3: add reset related process for hns3 PMD driver
>>   net/hns3: add multiple process support for hns3 PMD driver
>>
>>  MAINTAINERS                                  |    8 +
>>  config/common_base                           |    5 +
>>  config/common_linux                          |    5 +
>>  config/defconfig_arm-armv7a-linuxapp-gcc     |    1 +
>>  config/defconfig_i686-native-linuxapp-gcc    |    5 +
>>  config/defconfig_i686-native-linuxapp-icc    |    5 +
>>  config/defconfig_ppc_64-power8-linuxapp-gcc  |    1 +
>>  config/defconfig_x86_64-native-linuxapp-icc  |    5 +
>>  config/defconfig_x86_x32-native-linuxapp-gcc |    5 +
>>  doc/guides/nics/features/hns3.ini            |   34 +
>>  doc/guides/nics/features/hns3_vf.ini         |   29 +
>>  doc/guides/nics/hns3.rst                     |   60 +
>>  doc/guides/nics/index.rst                    |    1 +
>>  doc/guides/rel_notes/release_19_11.rst       |    6 +
>>  drivers/net/Makefile                         |    1 +
>>  drivers/net/hns3/Makefile                    |   45 +
>>  drivers/net/hns3/hns3_cmd.c                  |  565 +++
>>  drivers/net/hns3/hns3_cmd.h                  |  761 ++++
>>  drivers/net/hns3/hns3_dcb.c                  | 1642 +++++++++
>>  drivers/net/hns3/hns3_dcb.h                  |  166 +
>>  drivers/net/hns3/hns3_ethdev.c               | 4947 ++++++++++++++++++++++++++
>>  drivers/net/hns3/hns3_ethdev.h               |  645 ++++
>>  drivers/net/hns3/hns3_ethdev_vf.c            | 1725 +++++++++
>>  drivers/net/hns3/hns3_fdir.c                 | 1059 ++++++
>>  drivers/net/hns3/hns3_fdir.h                 |  205 ++
>>  drivers/net/hns3/hns3_flow.c                 | 1903 ++++++++++
>>  drivers/net/hns3/hns3_intr.c                 | 1166 ++++++
>>  drivers/net/hns3/hns3_intr.h                 |   79 +
>>  drivers/net/hns3/hns3_logs.h                 |   34 +
>>  drivers/net/hns3/hns3_mbx.c                  |  353 ++
>>  drivers/net/hns3/hns3_mbx.h                  |  136 +
>>  drivers/net/hns3/hns3_mp.c                   |  214 ++
>>  drivers/net/hns3/hns3_mp.h                   |   14 +
>>  drivers/net/hns3/hns3_regs.c                 |  368 ++
>>  drivers/net/hns3/hns3_regs.h                 |   99 +
>>  drivers/net/hns3/hns3_rss.c                  |  584 +++
>>  drivers/net/hns3/hns3_rss.h                  |  124 +
>>  drivers/net/hns3/hns3_rxtx.c                 | 1676 +++++++++
>>  drivers/net/hns3/hns3_rxtx.h                 |  317 ++
>>  drivers/net/hns3/hns3_stats.c                |  975 +++++
>>  drivers/net/hns3/hns3_stats.h                |  152 +
>>  drivers/net/hns3/meson.build                 |   37 +
>>  drivers/net/hns3/rte_pmd_hns3_version.map    |    3 +
>>  drivers/net/meson.build                      |    1 +
>>  mk/rte.app.mk                                |    1 +
>>  45 files changed, 20167 insertions(+)
>>  create mode 100644 doc/guides/nics/features/hns3.ini
>>  create mode 100644 doc/guides/nics/features/hns3_vf.ini
>>  create mode 100644 doc/guides/nics/hns3.rst
>>  create mode 100644 drivers/net/hns3/Makefile
>>  create mode 100644 drivers/net/hns3/hns3_cmd.c
>>  create mode 100644 drivers/net/hns3/hns3_cmd.h
>>  create mode 100644 drivers/net/hns3/hns3_dcb.c
>>  create mode 100644 drivers/net/hns3/hns3_dcb.h
>>  create mode 100644 drivers/net/hns3/hns3_ethdev.c
>>  create mode 100644 drivers/net/hns3/hns3_ethdev.h
>>  create mode 100644 drivers/net/hns3/hns3_ethdev_vf.c
>>  create mode 100644 drivers/net/hns3/hns3_fdir.c
>>  create mode 100644 drivers/net/hns3/hns3_fdir.h
>>  create mode 100644 drivers/net/hns3/hns3_flow.c
>>  create mode 100644 drivers/net/hns3/hns3_intr.c
>>  create mode 100644 drivers/net/hns3/hns3_intr.h
>>  create mode 100644 drivers/net/hns3/hns3_logs.h
>>  create mode 100644 drivers/net/hns3/hns3_mbx.c
>>  create mode 100644 drivers/net/hns3/hns3_mbx.h
>>  create mode 100644 drivers/net/hns3/hns3_mp.c
>>  create mode 100644 drivers/net/hns3/hns3_mp.h
>>  create mode 100644 drivers/net/hns3/hns3_regs.c
>>  create mode 100644 drivers/net/hns3/hns3_regs.h
>>  create mode 100644 drivers/net/hns3/hns3_rss.c
>>  create mode 100644 drivers/net/hns3/hns3_rss.h
>>  create mode 100644 drivers/net/hns3/hns3_rxtx.c
>>  create mode 100644 drivers/net/hns3/hns3_rxtx.h
>>  create mode 100644 drivers/net/hns3/hns3_stats.c
>>  create mode 100644 drivers/net/hns3/hns3_stats.h
>>  create mode 100644 drivers/net/hns3/meson.build
>>  create mode 100644 drivers/net/hns3/rte_pmd_hns3_version.map
>>
> 
>

Ferruh Yigit Sept. 27, 2019, 6:30 p.m. UTC | #3

On 9/26/2019 3:01 PM, Wei Hu (Xavier) wrote:
> The Hisilicon Network Subsystem is a long term evolution IP which is
> supposed to be used in Hisilicon ICT SoCs such as Kunpeng 920.
> 
> This series add DPDK rte_ethdev poll mode driver for Hisilicon
> Network Subsystem 3(hns3) network engine.
> 
> v2 -> v3:
> 	1. Resolve the conflict problem when performing git operation
> 	   based on the current repository. The conflict occurs in
> 	   doc/guides/rel_notes/release_19_11.rst.
> 
> v1 -> v2:
> 	1. Address some comments from Jerin Jacob Kollanukkaran,
> 	   Stephen Hemminger and Ferruh Yigit.
> 
> Wei Hu (Xavier) (22):
>   net/hns3: add build and doc infrastructure
>   net/hns3: add hardware registers definition
>   net/hns3: add some definitions for data structure and macro
>   net/hns3: register hns3 PMD driver and add the log interface
>     definition
>   net/hns3: add support for cmd of hns3 PMD driver
>   net/hns3: add the initialization of hns3 PMD driver
>   net/hns3: add support for MAC address related operations
>   net/hns3: add support for some misc operations
>   net/hns3: add support for link_update operation
>   net/hns3: add support for flow directory of hns3 PMD driver
>   net/hns3: add support for RSS of hns3 PMD driver
>   net/hns3: add support for flow control of hns3 PMD driver
>   net/hns3: add support for vlan of hns3 PMD driver
>   net/hns3: add support for mailbox of hns3 PMD driver
>   net/hns3: add support for hns3 VF PMD driver
>   net/hns3: add RX/TX package burst and queue related operation
>   net/hns3: add start stop configure promiscuous ops
>   net/hns3: add dump register ops for hns3 PMD driver
>   net/hns3: add abnormal interrupt process for hns3 PMD driver
>   net/hns3: add stats related ops for hns3 PMD driver
>   net/hns3: add reset related process for hns3 PMD driver
>   net/hns3: add multiple process support for hns3 PMD driver

For series,
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Series applied to dpdk-next-net/master, thanks.

Please send a web patch to document new device as supported:
http://core.dpdk.org/supported/
https://git.dpdk.org/tools/dpdk-web/
(btw, 'hinic' is also missing there, can you please reach out correct people there)


(I did minor update for 32-bits build, please verify, more details on the patch)

Jeremy Plsek Sept. 27, 2019, 7:16 p.m. UTC | #4

On Fri, Sep 27, 2019 at 4:47 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 9/27/2019 7:52 AM, Wei Hu (Xavier) wrote:
> > Hi, Ferruh Yigit
> >
> >   I sent out PATCH V3 to fix the conflict that occurs in
> > doc/guides/rel_notes/release_19_11.rst when performing
> > 'git am patch(PATCH V2 series)' operation based on the latest
> > dpdk-next-net because of the recent change in the repository.
> >
> >   The page in patches.dpdk.org indicates that CI checking
> > against this series failed and terminated, the content of 'S/W/F' field is '---', the page as follows:
> > http://patches.dpdk.org/project/dpdk/list/?series=&submitter=1405&state=*&q=&archive=&delegate=
> >
> >   The information of CI building as follows, and in fact
> > there was non incompatible pointer type error based on
> > the latest repo in my local server.
> > http://mails.dpdk.org/archives/test-report/2019-September/099170.html
> >
> > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4723:24: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
> >   .promiscuous_enable = hns3_dev_promiscuous_enable,
> >                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4723:24: note: (near initialization for ‘hns3_eth_dev_ops.promiscuous_enable’)
> > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4724:25: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
> >   .promiscuous_disable = hns3_dev_promiscuous_disable,
> >                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4724:25: note: (near initialization for ‘hns3_eth_dev_ops.promiscuous_disable’)
> > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4725:26: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
> >   .allmulticast_enable  = hns3_dev_allmulticast_enable,
> >                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4725:26: note: (near initialization for ‘hns3_eth_dev_ops.allmulticast_enable’)
> > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4726:26: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
> >   .allmulticast_disable = hns3_dev_allmulticast_disable,
> >                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4726:26: note: (near initialization for ‘hns3_eth_dev_ops.allmulticast_disable’)
> > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4729:24: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
> >   .stats_reset        = hns3_stats_reset,
> >                         ^~~~~~~~~~~~~~~~
> > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4729:24: note: (near initialization for ‘hns3_eth_dev_ops.stats_reset’)
> > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4732:24: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
> >   .xstats_reset       = hns3_dev_xstats_reset,
> >                         ^~~~~~~~~~~~~~~~~~~~~
> > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4732:24: note: (near initialization for ‘hns3_eth_dev_ops.xstats_reset’)
> > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4735:28: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
> >   .dev_infos_get          = hns3_dev_infos_get,
> >                             ^~~~~~~~~~~~~~~~~~
> > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4735:28: note: (near initialization for ‘hns3_eth_dev_ops.dev_infos_get’)
> > cc1: error: unrecognized command line option ‘-Wno-address-of-packed-member’ [-Werror]
> > cc1: all warnings being treated as errors
> > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/mk/internal/rte.compile-pre.mk:114: recipe for target 'hns3_ethdev.o' failed
> > make[6]: *** [hns3_ethdev.o] Error 1
> >
> >
> >   The detail information of the repository when making PATCH V3 on as follows:
> >
> > repo: http://dpdk.org/git/next/dpdk-next-net
> > branch: master
>
> Hi Xavier,
>
> Above repo and the branch is correct, also with a quick check your code seems
> correct too.
>
> CI is using wrong tree for the build test [1], @Ali, @Aaron and @Jeremy are on
> cc for long term investigation.
>

Hi, sorry, we changed which systems the patches build on recently.
They were missing some dependencies to check which branch to apply to,
and when the script failed, it didn't stop the pipeline from
continuing. Both issues should be fixed for future patches.

> Hopefully there will be a merge from next-net to main repo, that should fix the
> false positives in CI.
> Can you please follow the merge and ping us, so we can ask to Jeremy to re-run
> the test?
>
> Thanks,
> ferruh
>
>
> [1]
> Metadata from test:
> "
> Test-Label: Performance-Testing
> Test-Status: FAILURE
> http://dpdk.org/patch/59882
>
> _build patch failure_
>
> Submitter: Wei Hu (Xavier) <xavier.huwei at huawei.com>
> Date: Thursday, September 26 2019 14:01:47
> Applied on: CommitID:bd253daa7717835f88bbc58b09a94d0060380396
> Apply patch set 59882-59901 failed:
> "
>
> Commit is from the main tree, that is why causing the build error.
>
> >
> > git log --oneline
> > 3be6962 app/testpmd: fix unused variable compile error
> > 5453153 app/testpmd: fix crash on port reset
> > 944ee10 net/ipn3ke: setup MTU during HW init
> > 52e3ab3 net/ice: remove Rx legacy descriptor definition
> > d27982e net/ice: switch to Rx flexible descriptor in AVX path
> > 0973c28 net/ice: switch to flexible descriptor in SSE path
> > 98ed8c1 net/ice: add protocol extraction support for per Rx queue
> > 03ff0d1 net/ice: handle the Rx flex descriptor
> > 2962f75 net/ice: add Rx flex descriptor definition
> > a03e11f net/i40e: limit the number of VF messages
> > 644032b net/ice/base: remove unused code
> > c02031f net/ice/base: add switch support for IPv6 tc field
> > 05859a5 net/ice/base: fix PTYPE bitmap
> > 4f07dc0 net/ice/base: fix alignment
> > 9d1c626 net/ice/base: use bitmap copy where appropriate
> > 3efd0a4 net/ice/base: remove unnecessary error log
> > 82c1c29 net/ice/base: fix 4 bytes alignment for PPPoE dummy packet
> > 17db50c net/ice/base: search field vector indices for result slots
> > 9ef53fb net/ice/base: remove unused DDP package macros
> > 665293f net/ice/base: fix segment in remove existing RSS rule
> > 079ca8c net/ice/base: fix the bitmap for TCP in RSS
> > d3e1ebd net/ice/base: add FDIR support for GTPU QFI field
> >
> >
> >   Is there a way to reconstruct PATCH V3 in CI? Do we
> > resend PATCH V3 to trigger CI reconstruct them again?
> > Thanks for your suggestion.
> >
> >   Regards
> > Xavier
> >
> >
> > On 2019/9/26 22:01, Wei Hu (Xavier) wrote:
> >> The Hisilicon Network Subsystem is a long term evolution IP which is
> >> supposed to be used in Hisilicon ICT SoCs such as Kunpeng 920.
> >>
> >> This series add DPDK rte_ethdev poll mode driver for Hisilicon
> >> Network Subsystem 3(hns3) network engine.
> >>
> >> v2 -> v3:
> >>      1. Resolve the conflict problem when performing git operation
> >>         based on the current repository. The conflict occurs in
> >>         doc/guides/rel_notes/release_19_11.rst.
> >>
> >> v1 -> v2:
> >>      1. Address some comments from Jerin Jacob Kollanukkaran,
> >>         Stephen Hemminger and Ferruh Yigit.
> >>
> >> Wei Hu (Xavier) (22):
> >>   net/hns3: add build and doc infrastructure
> >>   net/hns3: add hardware registers definition
> >>   net/hns3: add some definitions for data structure and macro
> >>   net/hns3: register hns3 PMD driver and add the log interface
> >>     definition
> >>   net/hns3: add support for cmd of hns3 PMD driver
> >>   net/hns3: add the initialization of hns3 PMD driver
> >>   net/hns3: add support for MAC address related operations
> >>   net/hns3: add support for some misc operations
> >>   net/hns3: add support for link_update operation
> >>   net/hns3: add support for flow directory of hns3 PMD driver
> >>   net/hns3: add support for RSS of hns3 PMD driver
> >>   net/hns3: add support for flow control of hns3 PMD driver
> >>   net/hns3: add support for vlan of hns3 PMD driver
> >>   net/hns3: add support for mailbox of hns3 PMD driver
> >>   net/hns3: add support for hns3 VF PMD driver
> >>   net/hns3: add RX/TX package burst and queue related operation
> >>   net/hns3: add start stop configure promiscuous ops
> >>   net/hns3: add dump register ops for hns3 PMD driver
> >>   net/hns3: add abnormal interrupt process for hns3 PMD driver
> >>   net/hns3: add stats related ops for hns3 PMD driver
> >>   net/hns3: add reset related process for hns3 PMD driver
> >>   net/hns3: add multiple process support for hns3 PMD driver
> >>
> >>  MAINTAINERS                                  |    8 +
> >>  config/common_base                           |    5 +
> >>  config/common_linux                          |    5 +
> >>  config/defconfig_arm-armv7a-linuxapp-gcc     |    1 +
> >>  config/defconfig_i686-native-linuxapp-gcc    |    5 +
> >>  config/defconfig_i686-native-linuxapp-icc    |    5 +
> >>  config/defconfig_ppc_64-power8-linuxapp-gcc  |    1 +
> >>  config/defconfig_x86_64-native-linuxapp-icc  |    5 +
> >>  config/defconfig_x86_x32-native-linuxapp-gcc |    5 +
> >>  doc/guides/nics/features/hns3.ini            |   34 +
> >>  doc/guides/nics/features/hns3_vf.ini         |   29 +
> >>  doc/guides/nics/hns3.rst                     |   60 +
> >>  doc/guides/nics/index.rst                    |    1 +
> >>  doc/guides/rel_notes/release_19_11.rst       |    6 +
> >>  drivers/net/Makefile                         |    1 +
> >>  drivers/net/hns3/Makefile                    |   45 +
> >>  drivers/net/hns3/hns3_cmd.c                  |  565 +++
> >>  drivers/net/hns3/hns3_cmd.h                  |  761 ++++
> >>  drivers/net/hns3/hns3_dcb.c                  | 1642 +++++++++
> >>  drivers/net/hns3/hns3_dcb.h                  |  166 +
> >>  drivers/net/hns3/hns3_ethdev.c               | 4947 ++++++++++++++++++++++++++
> >>  drivers/net/hns3/hns3_ethdev.h               |  645 ++++
> >>  drivers/net/hns3/hns3_ethdev_vf.c            | 1725 +++++++++
> >>  drivers/net/hns3/hns3_fdir.c                 | 1059 ++++++
> >>  drivers/net/hns3/hns3_fdir.h                 |  205 ++
> >>  drivers/net/hns3/hns3_flow.c                 | 1903 ++++++++++
> >>  drivers/net/hns3/hns3_intr.c                 | 1166 ++++++
> >>  drivers/net/hns3/hns3_intr.h                 |   79 +
> >>  drivers/net/hns3/hns3_logs.h                 |   34 +
> >>  drivers/net/hns3/hns3_mbx.c                  |  353 ++
> >>  drivers/net/hns3/hns3_mbx.h                  |  136 +
> >>  drivers/net/hns3/hns3_mp.c                   |  214 ++
> >>  drivers/net/hns3/hns3_mp.h                   |   14 +
> >>  drivers/net/hns3/hns3_regs.c                 |  368 ++
> >>  drivers/net/hns3/hns3_regs.h                 |   99 +
> >>  drivers/net/hns3/hns3_rss.c                  |  584 +++
> >>  drivers/net/hns3/hns3_rss.h                  |  124 +
> >>  drivers/net/hns3/hns3_rxtx.c                 | 1676 +++++++++
> >>  drivers/net/hns3/hns3_rxtx.h                 |  317 ++
> >>  drivers/net/hns3/hns3_stats.c                |  975 +++++
> >>  drivers/net/hns3/hns3_stats.h                |  152 +
> >>  drivers/net/hns3/meson.build                 |   37 +
> >>  drivers/net/hns3/rte_pmd_hns3_version.map    |    3 +
> >>  drivers/net/meson.build                      |    1 +
> >>  mk/rte.app.mk                                |    1 +
> >>  45 files changed, 20167 insertions(+)
> >>  create mode 100644 doc/guides/nics/features/hns3.ini
> >>  create mode 100644 doc/guides/nics/features/hns3_vf.ini
> >>  create mode 100644 doc/guides/nics/hns3.rst
> >>  create mode 100644 drivers/net/hns3/Makefile
> >>  create mode 100644 drivers/net/hns3/hns3_cmd.c
> >>  create mode 100644 drivers/net/hns3/hns3_cmd.h
> >>  create mode 100644 drivers/net/hns3/hns3_dcb.c
> >>  create mode 100644 drivers/net/hns3/hns3_dcb.h
> >>  create mode 100644 drivers/net/hns3/hns3_ethdev.c
> >>  create mode 100644 drivers/net/hns3/hns3_ethdev.h
> >>  create mode 100644 drivers/net/hns3/hns3_ethdev_vf.c
> >>  create mode 100644 drivers/net/hns3/hns3_fdir.c
> >>  create mode 100644 drivers/net/hns3/hns3_fdir.h
> >>  create mode 100644 drivers/net/hns3/hns3_flow.c
> >>  create mode 100644 drivers/net/hns3/hns3_intr.c
> >>  create mode 100644 drivers/net/hns3/hns3_intr.h
> >>  create mode 100644 drivers/net/hns3/hns3_logs.h
> >>  create mode 100644 drivers/net/hns3/hns3_mbx.c
> >>  create mode 100644 drivers/net/hns3/hns3_mbx.h
> >>  create mode 100644 drivers/net/hns3/hns3_mp.c
> >>  create mode 100644 drivers/net/hns3/hns3_mp.h
> >>  create mode 100644 drivers/net/hns3/hns3_regs.c
> >>  create mode 100644 drivers/net/hns3/hns3_regs.h
> >>  create mode 100644 drivers/net/hns3/hns3_rss.c
> >>  create mode 100644 drivers/net/hns3/hns3_rss.h
> >>  create mode 100644 drivers/net/hns3/hns3_rxtx.c
> >>  create mode 100644 drivers/net/hns3/hns3_rxtx.h
> >>  create mode 100644 drivers/net/hns3/hns3_stats.c
> >>  create mode 100644 drivers/net/hns3/hns3_stats.h
> >>  create mode 100644 drivers/net/hns3/meson.build
> >>  create mode 100644 drivers/net/hns3/rte_pmd_hns3_version.map
> >>
> >
> >
>


--
Jeremy Plsek
UNH InterOperability Laboratory

Wei Hu (Xavier) Sept. 29, 2019, 12:12 p.m. UTC | #5

Hi, Ferruh Yigit


On 2019/9/28 2:30, Ferruh Yigit wrote:
> On 9/26/2019 3:01 PM, Wei Hu (Xavier) wrote:
>> The Hisilicon Network Subsystem is a long term evolution IP which is
>> supposed to be used in Hisilicon ICT SoCs such as Kunpeng 920.
>>
>> This series add DPDK rte_ethdev poll mode driver for Hisilicon
>> Network Subsystem 3(hns3) network engine.
>>
>> v2 -> v3:
>> 	1. Resolve the conflict problem when performing git operation
>> 	   based on the current repository. The conflict occurs in
>> 	   doc/guides/rel_notes/release_19_11.rst.
>>
>> v1 -> v2:
>> 	1. Address some comments from Jerin Jacob Kollanukkaran,
>> 	   Stephen Hemminger and Ferruh Yigit.
>>
>> Wei Hu (Xavier) (22):
>>   net/hns3: add build and doc infrastructure
>>   net/hns3: add hardware registers definition
>>   net/hns3: add some definitions for data structure and macro
>>   net/hns3: register hns3 PMD driver and add the log interface
>>     definition
>>   net/hns3: add support for cmd of hns3 PMD driver
>>   net/hns3: add the initialization of hns3 PMD driver
>>   net/hns3: add support for MAC address related operations
>>   net/hns3: add support for some misc operations
>>   net/hns3: add support for link_update operation
>>   net/hns3: add support for flow directory of hns3 PMD driver
>>   net/hns3: add support for RSS of hns3 PMD driver
>>   net/hns3: add support for flow control of hns3 PMD driver
>>   net/hns3: add support for vlan of hns3 PMD driver
>>   net/hns3: add support for mailbox of hns3 PMD driver
>>   net/hns3: add support for hns3 VF PMD driver
>>   net/hns3: add RX/TX package burst and queue related operation
>>   net/hns3: add start stop configure promiscuous ops
>>   net/hns3: add dump register ops for hns3 PMD driver
>>   net/hns3: add abnormal interrupt process for hns3 PMD driver
>>   net/hns3: add stats related ops for hns3 PMD driver
>>   net/hns3: add reset related process for hns3 PMD driver
>>   net/hns3: add multiple process support for hns3 PMD driver
> For series,
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Series applied to dpdk-next-net/master, thanks.
Thank you very much.
> Please send a web patch to document new device as supported:
> http://core.dpdk.org/supported/
> https://git.dpdk.org/tools/dpdk-web/
Ok, I sent the web patch.
https://patchwork.dpdk.org/patch/60100/
> (btw, 'hinic' is also missing there, can you please reach out correct people there)
I have called Xiaoyun wang, the hinic pmd driver's engineer , she will
follow up on hinic related submissions.
>
> (I did minor update for 32-bits build, please verify, more details on the patch)
Thank you for your revision.

  Regards
Xavier

Ferruh Yigit Sept. 30, 2019, 8:52 a.m. UTC | #6

On 9/29/2019 1:12 PM, Wei Hu (Xavier) wrote:
> Hi, Ferruh Yigit
> 
> 
> On 2019/9/28 2:30, Ferruh Yigit wrote:
>> On 9/26/2019 3:01 PM, Wei Hu (Xavier) wrote:
>>> The Hisilicon Network Subsystem is a long term evolution IP which is
>>> supposed to be used in Hisilicon ICT SoCs such as Kunpeng 920.
>>>
>>> This series add DPDK rte_ethdev poll mode driver for Hisilicon
>>> Network Subsystem 3(hns3) network engine.
>>>
>>> v2 -> v3:
>>> 	1. Resolve the conflict problem when performing git operation
>>> 	   based on the current repository. The conflict occurs in
>>> 	   doc/guides/rel_notes/release_19_11.rst.
>>>
>>> v1 -> v2:
>>> 	1. Address some comments from Jerin Jacob Kollanukkaran,
>>> 	   Stephen Hemminger and Ferruh Yigit.
>>>
>>> Wei Hu (Xavier) (22):
>>>   net/hns3: add build and doc infrastructure
>>>   net/hns3: add hardware registers definition
>>>   net/hns3: add some definitions for data structure and macro
>>>   net/hns3: register hns3 PMD driver and add the log interface
>>>     definition
>>>   net/hns3: add support for cmd of hns3 PMD driver
>>>   net/hns3: add the initialization of hns3 PMD driver
>>>   net/hns3: add support for MAC address related operations
>>>   net/hns3: add support for some misc operations
>>>   net/hns3: add support for link_update operation
>>>   net/hns3: add support for flow directory of hns3 PMD driver
>>>   net/hns3: add support for RSS of hns3 PMD driver
>>>   net/hns3: add support for flow control of hns3 PMD driver
>>>   net/hns3: add support for vlan of hns3 PMD driver
>>>   net/hns3: add support for mailbox of hns3 PMD driver
>>>   net/hns3: add support for hns3 VF PMD driver
>>>   net/hns3: add RX/TX package burst and queue related operation
>>>   net/hns3: add start stop configure promiscuous ops
>>>   net/hns3: add dump register ops for hns3 PMD driver
>>>   net/hns3: add abnormal interrupt process for hns3 PMD driver
>>>   net/hns3: add stats related ops for hns3 PMD driver
>>>   net/hns3: add reset related process for hns3 PMD driver
>>>   net/hns3: add multiple process support for hns3 PMD driver
>> For series,
>> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> Series applied to dpdk-next-net/master, thanks.
> Thank you very much.
>> Please send a web patch to document new device as supported:
>> http://core.dpdk.org/supported/
>> https://git.dpdk.org/tools/dpdk-web/
> Ok, I sent the web patch.
> https://patchwork.dpdk.org/patch/60100/

There is a separate mail list for web patches, web@dpdk.org, can you please send
the patch to there?

I will update the one in patchwork as not applicable.

>> (btw, 'hinic' is also missing there, can you please reach out correct people there)
> I have called Xiaoyun wang, the hinic pmd driver's engineer , she will
> follow up on hinic related submissions.
>>
>> (I did minor update for 32-bits build, please verify, more details on the patch)
> Thank you for your revision.
> 
>   Regards
> Xavier
> 
>

Ferruh Yigit Oct. 10, 2019, 5:10 p.m. UTC | #7

On 9/27/2019 7:30 PM, Ferruh Yigit wrote:
> On 9/26/2019 3:01 PM, Wei Hu (Xavier) wrote:
>> The Hisilicon Network Subsystem is a long term evolution IP which is
>> supposed to be used in Hisilicon ICT SoCs such as Kunpeng 920.
>>
>> This series add DPDK rte_ethdev poll mode driver for Hisilicon
>> Network Subsystem 3(hns3) network engine.
>>
>> v2 -> v3:
>> 	1. Resolve the conflict problem when performing git operation
>> 	   based on the current repository. The conflict occurs in
>> 	   doc/guides/rel_notes/release_19_11.rst.
>>
>> v1 -> v2:
>> 	1. Address some comments from Jerin Jacob Kollanukkaran,
>> 	   Stephen Hemminger and Ferruh Yigit.
>>
>> Wei Hu (Xavier) (22):
>>   net/hns3: add build and doc infrastructure
>>   net/hns3: add hardware registers definition
>>   net/hns3: add some definitions for data structure and macro
>>   net/hns3: register hns3 PMD driver and add the log interface
>>     definition
>>   net/hns3: add support for cmd of hns3 PMD driver
>>   net/hns3: add the initialization of hns3 PMD driver
>>   net/hns3: add support for MAC address related operations
>>   net/hns3: add support for some misc operations
>>   net/hns3: add support for link_update operation
>>   net/hns3: add support for flow directory of hns3 PMD driver
>>   net/hns3: add support for RSS of hns3 PMD driver
>>   net/hns3: add support for flow control of hns3 PMD driver
>>   net/hns3: add support for vlan of hns3 PMD driver
>>   net/hns3: add support for mailbox of hns3 PMD driver
>>   net/hns3: add support for hns3 VF PMD driver
>>   net/hns3: add RX/TX package burst and queue related operation
>>   net/hns3: add start stop configure promiscuous ops
>>   net/hns3: add dump register ops for hns3 PMD driver
>>   net/hns3: add abnormal interrupt process for hns3 PMD driver
>>   net/hns3: add stats related ops for hns3 PMD driver
>>   net/hns3: add reset related process for hns3 PMD driver
>>   net/hns3: add multiple process support for hns3 PMD driver
> 
> For series,
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Series applied to dpdk-next-net/master, thanks.
> 
> Please send a web patch to document new device as supported:
> http://core.dpdk.org/supported/
> https://git.dpdk.org/tools/dpdk-web/
> (btw, 'hinic' is also missing there, can you please reach out correct people there)
> 
> 
> (I did minor update for 32-bits build, please verify, more details on the patch)
> 

Hi Xavier,

Driver is giving some warnings while compiling the documentation [1], that is
because some deprecated features has been removed from the feature list [2], can
you please check it?



[1]
Warning generate_overview_table(): Unknown feature 'Flow director' in 'hns3.ini'
Warning generate_overview_table(): Unknown feature 'Flow director' in 'hns3_vf.ini'

[2]
Commit 030febb6642c ("doc: remove deprecated ethdev features")
https://patches.dpdk.org/patch/57282/

Wei Hu (Xavier) Oct. 11, 2019, 1:30 a.m. UTC | #8

On 2019/9/30 16:52, Ferruh Yigit wrote:
> On 9/29/2019 1:12 PM, Wei Hu (Xavier) wrote:
>> Hi, Ferruh Yigit
>>
>>
>> On 2019/9/28 2:30, Ferruh Yigit wrote:
>>> On 9/26/2019 3:01 PM, Wei Hu (Xavier) wrote:
>>>> The Hisilicon Network Subsystem is a long term evolution IP which is
>>>> supposed to be used in Hisilicon ICT SoCs such as Kunpeng 920.
>>>>
>>>> This series add DPDK rte_ethdev poll mode driver for Hisilicon
>>>> Network Subsystem 3(hns3) network engine.
>>>>
>>>> v2 -> v3:
>>>> 	1. Resolve the conflict problem when performing git operation
>>>> 	   based on the current repository. The conflict occurs in
>>>> 	   doc/guides/rel_notes/release_19_11.rst.
>>>>
>>>> v1 -> v2:
>>>> 	1. Address some comments from Jerin Jacob Kollanukkaran,
>>>> 	   Stephen Hemminger and Ferruh Yigit.
>>>>
>>>> Wei Hu (Xavier) (22):
>>>>   net/hns3: add build and doc infrastructure
>>>>   net/hns3: add hardware registers definition
>>>>   net/hns3: add some definitions for data structure and macro
>>>>   net/hns3: register hns3 PMD driver and add the log interface
>>>>     definition
>>>>   net/hns3: add support for cmd of hns3 PMD driver
>>>>   net/hns3: add the initialization of hns3 PMD driver
>>>>   net/hns3: add support for MAC address related operations
>>>>   net/hns3: add support for some misc operations
>>>>   net/hns3: add support for link_update operation
>>>>   net/hns3: add support for flow directory of hns3 PMD driver
>>>>   net/hns3: add support for RSS of hns3 PMD driver
>>>>   net/hns3: add support for flow control of hns3 PMD driver
>>>>   net/hns3: add support for vlan of hns3 PMD driver
>>>>   net/hns3: add support for mailbox of hns3 PMD driver
>>>>   net/hns3: add support for hns3 VF PMD driver
>>>>   net/hns3: add RX/TX package burst and queue related operation
>>>>   net/hns3: add start stop configure promiscuous ops
>>>>   net/hns3: add dump register ops for hns3 PMD driver
>>>>   net/hns3: add abnormal interrupt process for hns3 PMD driver
>>>>   net/hns3: add stats related ops for hns3 PMD driver
>>>>   net/hns3: add reset related process for hns3 PMD driver
>>>>   net/hns3: add multiple process support for hns3 PMD driver
>>> For series,
>>> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>> Series applied to dpdk-next-net/master, thanks.
>> Thank you very much.
>>> Please send a web patch to document new device as supported:
>>> http://core.dpdk.org/supported/
>>> https://git.dpdk.org/tools/dpdk-web/
>> Ok, I sent the web patch.
>> https://patchwork.dpdk.org/patch/60100/
> There is a separate mail list for web patches, web@dpdk.org, can you please send
> the patch to there?
>
> I will update the one in patchwork as not applicable.
Hi, Ferruh Yigit

    Thanks for your suggestion.
    I will send the patch to web@dpdk.org without cc dev@dpdk.org.   

    Regards
Xavier
>>> (btw, 'hinic' is also missing there, can you please reach out correct people there)
>> I have called Xiaoyun wang, the hinic pmd driver's engineer , she will
>> follow up on hinic related submissions.
>>> (I did minor update for 32-bits build, please verify, more details on the patch)
>> Thank you for your revision.
>>
>>   Regards
>> Xavier
>>
>>
>
>

Wei Hu (Xavier) Oct. 11, 2019, 1:39 a.m. UTC | #9

Hi, Ferruh Yigit


On 2019/10/11 1:10, Ferruh Yigit wrote:
> On 9/27/2019 7:30 PM, Ferruh Yigit wrote:
>> On 9/26/2019 3:01 PM, Wei Hu (Xavier) wrote:
>>> The Hisilicon Network Subsystem is a long term evolution IP which is
>>> supposed to be used in Hisilicon ICT SoCs such as Kunpeng 920.
>>>
>>> This series add DPDK rte_ethdev poll mode driver for Hisilicon
>>> Network Subsystem 3(hns3) network engine.
>>>
>>> v2 -> v3:
>>> 	1. Resolve the conflict problem when performing git operation
>>> 	   based on the current repository. The conflict occurs in
>>> 	   doc/guides/rel_notes/release_19_11.rst.
>>>
>>> v1 -> v2:
>>> 	1. Address some comments from Jerin Jacob Kollanukkaran,
>>> 	   Stephen Hemminger and Ferruh Yigit.
>>>
>>> Wei Hu (Xavier) (22):
>>>   net/hns3: add build and doc infrastructure
>>>   net/hns3: add hardware registers definition
>>>   net/hns3: add some definitions for data structure and macro
>>>   net/hns3: register hns3 PMD driver and add the log interface
>>>     definition
>>>   net/hns3: add support for cmd of hns3 PMD driver
>>>   net/hns3: add the initialization of hns3 PMD driver
>>>   net/hns3: add support for MAC address related operations
>>>   net/hns3: add support for some misc operations
>>>   net/hns3: add support for link_update operation
>>>   net/hns3: add support for flow directory of hns3 PMD driver
>>>   net/hns3: add support for RSS of hns3 PMD driver
>>>   net/hns3: add support for flow control of hns3 PMD driver
>>>   net/hns3: add support for vlan of hns3 PMD driver
>>>   net/hns3: add support for mailbox of hns3 PMD driver
>>>   net/hns3: add support for hns3 VF PMD driver
>>>   net/hns3: add RX/TX package burst and queue related operation
>>>   net/hns3: add start stop configure promiscuous ops
>>>   net/hns3: add dump register ops for hns3 PMD driver
>>>   net/hns3: add abnormal interrupt process for hns3 PMD driver
>>>   net/hns3: add stats related ops for hns3 PMD driver
>>>   net/hns3: add reset related process for hns3 PMD driver
>>>   net/hns3: add multiple process support for hns3 PMD driver
>> For series,
>> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> Series applied to dpdk-next-net/master, thanks.
>>
>> Please send a web patch to document new device as supported:
>> http://core.dpdk.org/supported/
>> https://git.dpdk.org/tools/dpdk-web/
>> (btw, 'hinic' is also missing there, can you please reach out correct people there)
>>
>>
>> (I did minor update for 32-bits build, please verify, more details on the patch)
>>
> Hi Xavier,
>
> Driver is giving some warnings while compiling the documentation [1], that is
> because some deprecated features has been removed from the feature list [2], can
> you please check it?
>
>
>
> [1]
> Warning generate_overview_table(): Unknown feature 'Flow director' in 'hns3.ini'
> Warning generate_overview_table(): Unknown feature 'Flow director' in 'hns3_vf.ini'
>
> [2]
> Commit 030febb6642c ("doc: remove deprecated ethdev features")
> https://patches.dpdk.org/patch/57282/
>
> .
  I will send a patch to delete 'Flow director' feature in hns3.ini and
hns3_vf.ini.
  Thanks for your comment.

  Regards
Xaiver

Wei Hu (Xavier) Oct. 11, 2019, 2:40 a.m. UTC | #10

Hi, Ferruh Yigit


On 2019/10/11 9:39, Wei Hu (Xavier) wrote:
> Hi, Ferruh Yigit
>
>
> On 2019/10/11 1:10, Ferruh Yigit wrote:
>> On 9/27/2019 7:30 PM, Ferruh Yigit wrote:
>>> On 9/26/2019 3:01 PM, Wei Hu (Xavier) wrote:
>>>> The Hisilicon Network Subsystem is a long term evolution IP which is
>>>> supposed to be used in Hisilicon ICT SoCs such as Kunpeng 920.
>>>>
>>>> This series add DPDK rte_ethdev poll mode driver for Hisilicon
>>>> Network Subsystem 3(hns3) network engine.
>>>>
>>>> v2 -> v3:
>>>> 	1. Resolve the conflict problem when performing git operation
>>>> 	   based on the current repository. The conflict occurs in
>>>> 	   doc/guides/rel_notes/release_19_11.rst.
>>>>
>>>> v1 -> v2:
>>>> 	1. Address some comments from Jerin Jacob Kollanukkaran,
>>>> 	   Stephen Hemminger and Ferruh Yigit.
>>>>
>>>> Wei Hu (Xavier) (22):
>>>>   net/hns3: add build and doc infrastructure
>>>>   net/hns3: add hardware registers definition
>>>>   net/hns3: add some definitions for data structure and macro
>>>>   net/hns3: register hns3 PMD driver and add the log interface
>>>>     definition
>>>>   net/hns3: add support for cmd of hns3 PMD driver
>>>>   net/hns3: add the initialization of hns3 PMD driver
>>>>   net/hns3: add support for MAC address related operations
>>>>   net/hns3: add support for some misc operations
>>>>   net/hns3: add support for link_update operation
>>>>   net/hns3: add support for flow directory of hns3 PMD driver
>>>>   net/hns3: add support for RSS of hns3 PMD driver
>>>>   net/hns3: add support for flow control of hns3 PMD driver
>>>>   net/hns3: add support for vlan of hns3 PMD driver
>>>>   net/hns3: add support for mailbox of hns3 PMD driver
>>>>   net/hns3: add support for hns3 VF PMD driver
>>>>   net/hns3: add RX/TX package burst and queue related operation
>>>>   net/hns3: add start stop configure promiscuous ops
>>>>   net/hns3: add dump register ops for hns3 PMD driver
>>>>   net/hns3: add abnormal interrupt process for hns3 PMD driver
>>>>   net/hns3: add stats related ops for hns3 PMD driver
>>>>   net/hns3: add reset related process for hns3 PMD driver
>>>>   net/hns3: add multiple process support for hns3 PMD driver
>>> For series,
>>> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>> Series applied to dpdk-next-net/master, thanks.
>>>
>>> Please send a web patch to document new device as supported:
>>> http://core.dpdk.org/supported/
>>> https://git.dpdk.org/tools/dpdk-web/
>>> (btw, 'hinic' is also missing there, can you please reach out correct people there)
>>>
>>>
>>> (I did minor update for 32-bits build, please verify, more details on the patch)
>>>
>> Hi Xavier,
>>
>> Driver is giving some warnings while compiling the documentation [1], that is
>> because some deprecated features has been removed from the feature list [2], can
>> you please check it?
>>
>>
>>
>> [1]
>> Warning generate_overview_table(): Unknown feature 'Flow director' in 'hns3.ini'
>> Warning generate_overview_table(): Unknown feature 'Flow director' in 'hns3_vf.ini'
>>
>> [2]
>> Commit 030febb6642c ("doc: remove deprecated ethdev features")
>> https://patches.dpdk.org/patch/57282/
>>
>> .
>   I will send a patch to delete 'Flow director' feature in hns3.ini and
> hns3_vf.ini.
The link of the patch:
https://patchwork.dpdk.org/patch/60918/
>   Thanks for your comment.
>
>   Regards
> Xaiver
  Regards
Xavier
>
> _______________________________________________
> Linuxarm mailing list
> Linuxarm@huawei.com
> http://hulk.huawei.com/mailman/listinfo/linuxarm
>
> .
>