diff mbox series

[v2] app/testpmd: fix unused variable compile error

Message ID 20190925180315.62339-1-taox.zhu@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series [v2] app/testpmd: fix unused variable compile error |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail apply issues

Commit Message

Zhu, TaoX Sept. 25, 2019, 6:03 p.m. UTC 
  From: Zhu Tao <taox.zhu@intel.com>

This minor patch fixes unused variable ‘ret’ compile error When
CONFIG_RTE_LIBRTE_I40E_16BYTE_RX_DESC was selected.

Fixes: f5267e485a2a ("app/testpmd: check status of getting ethdev info")

Signed-off-by: Zhu Tao <taox.zhu@intel.com>
---
 app/test-pmd/config.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Qi Zhang Sept. 26, 2019, 1:33 a.m. UTC | #1 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of taox.zhu@intel.com
> Sent: Thursday, September 26, 2019 2:03 AM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Iremonger, Bernard <bernard.iremonger@intel.com>
> Cc: dev@dpdk.org; ivan.ilchenko@oktetlabs.com; Zhu, TaoX
> <taox.zhu@intel.com>
> Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix unused variable compile error
> 
> From: Zhu Tao <taox.zhu@intel.com>
> 
> This minor patch fixes unused variable ‘ret’ compile error When
> CONFIG_RTE_LIBRTE_I40E_16BYTE_RX_DESC was selected.
> 
> Fixes: f5267e485a2a ("app/testpmd: check status of getting ethdev info")
> 
> Signed-off-by: Zhu Tao <taox.zhu@intel.com>

Reviewed-by: Qi Zhang <qi.z.zhang@intel.com>
Ferruh Yigit Sept. 26, 2019, 10:04 a.m. UTC | #2 
On 9/26/2019 2:33 AM, Zhang, Qi Z wrote:
> 
> 
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of taox.zhu@intel.com
>> Sent: Thursday, September 26, 2019 2:03 AM
>> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
>> <jingjing.wu@intel.com>; Iremonger, Bernard <bernard.iremonger@intel.com>
>> Cc: dev@dpdk.org; ivan.ilchenko@oktetlabs.com; Zhu, TaoX
>> <taox.zhu@intel.com>
>> Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix unused variable compile error
>>
>> From: Zhu Tao <taox.zhu@intel.com>
>>
>> This minor patch fixes unused variable ‘ret’ compile error When
>> CONFIG_RTE_LIBRTE_I40E_16BYTE_RX_DESC was selected.
>>
>> Fixes: f5267e485a2a ("app/testpmd: check status of getting ethdev info")
>>
>> Signed-off-by: Zhu Tao <taox.zhu@intel.com>
> 
> Reviewed-by: Qi Zhang <qi.z.zhang@intel.com>
> 

Applied to dpdk-next-net/master, thanks.
diff mbox series

Patch

diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 957c61fbe..a3b6cbd08 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -1649,10 +1649,10 @@  ring_rx_descriptor_display(const struct rte_memzone *ring_mz,
 #endif
 			   uint16_t desc_id)
 {
-	int ret;
 	struct igb_ring_desc_16_bytes *ring =
 		(struct igb_ring_desc_16_bytes *)ring_mz->addr;
 #ifndef RTE_LIBRTE_I40E_16BYTE_RX_DESC
+	int ret;
 	struct rte_eth_dev_info dev_info;
 
 	ret = eth_dev_info_get_print_err(port_id, &dev_info);