net/sfc: fix missing notification on link status change
Checks
Commit Message
rte_eth_linkstatus_set() returns 0 when link up status changes.
Fixes: 4abe903e5078 ("net/sfc: use link status helper functions")
Cc: stable@dpdk.org
Reported-by: Shuki Katzenelson <shuki@lightbitslabs.com>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
drivers/net/sfc/sfc_ev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 9/6/2019 11:49 AM, Andrew Rybchenko wrote:
> rte_eth_linkstatus_set() returns 0 when link up status changes.
>
> Fixes: 4abe903e5078 ("net/sfc: use link status helper functions")
> Cc: stable@dpdk.org
>
> Reported-by: Shuki Katzenelson <shuki@lightbitslabs.com>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
Applied to dpdk-next-net/master, thanks.
@@ -420,7 +420,7 @@ sfc_ev_link_change(void *arg, efx_link_mode_t link_mode)
struct rte_eth_link new_link;
sfc_port_link_mode_to_info(link_mode, &new_link);
- if (rte_eth_linkstatus_set(sa->eth_dev, &new_link))
+ if (rte_eth_linkstatus_set(sa->eth_dev, &new_link) == 0)
evq->sa->port.lsc_seq++;
return B_FALSE;