[dpdk-dev,RFC,1/3] eal/bsd: fix fd leak
Commit Message
Signed-off-by: David Marchand <david.marchand@6wind.com>
---
lib/librte_eal/bsdapp/eal/eal.c | 1 +
1 file changed, 1 insertion(+)
Comments
Hi,
Is there any BSD users available to test this patch?
I'd like to add this comment in the log:
----
"The initial implementation simply raised the IOPL of the current thread
when open(2) was called on the device. This behaviour is retained in the
current implementation as legacy support for both i386 and amd64."
http://www.freebsd.org/cgi/man.cgi?query=io&sektion=4
Nothing prevents from closing it just after.
----
But it should be tested with virtio to check iopl permissions.
Thanks
@@ -810,6 +810,7 @@ rte_eal_iopl_init(void)
fd = open("/dev/io", O_RDWR);
if (fd < 0)
return -1;
+ close(fd);
return 0;
}