[2/6] drivers: add some reasons for meson disabling

Message ID 20190812230358.988-3-thomas@monjalon.net (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series build system improvements |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Thomas Monjalon Aug. 12, 2019, 11:03 p.m. UTC
  Some drivers were missing reasons text for their disabling in meson.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 drivers/baseband/turbo_sw/meson.build | 1 +
 drivers/net/memif/meson.build         | 5 +++--
 drivers/raw/ioat/meson.build          | 1 +
 3 files changed, 5 insertions(+), 2 deletions(-)
  

Comments

Luca Boccassi Aug. 13, 2019, 9:38 a.m. UTC | #1
On Tue, 2019-08-13 at 01:03 +0200, Thomas Monjalon wrote:
> Some drivers were missing reasons text for their disabling in meson.
> 
> Signed-off-by: Thomas Monjalon <
> thomas@monjalon.net
> >
> ---
>  drivers/baseband/turbo_sw/meson.build | 1 +
>  drivers/net/memif/meson.build         | 5 +++--
>  drivers/raw/ioat/meson.build          | 1 +
>  3 files changed, 5 insertions(+), 2 deletions(-)
> 

Acked-by: Luca Boccassi <bluca@debian.org>
  

Patch

diff --git a/drivers/baseband/turbo_sw/meson.build b/drivers/baseband/turbo_sw/meson.build
index 33345aa01..1a1f7c9a9 100644
--- a/drivers/baseband/turbo_sw/meson.build
+++ b/drivers/baseband/turbo_sw/meson.build
@@ -7,6 +7,7 @@  if dpdk_conf.has('RTE_BBDEV_SDK_AVX2')
 	lib = cc.find_library('libturbo', dirs: [path + '/lib_turbo'], required: false)
 	if not lib.found()
 		build = false
+		reason = 'missing dependency, "libturbo"'
 	else
 		ext_deps += cc.find_library('libturbo', dirs: [path + '/lib_turbo'], required: true)
 		ext_deps += cc.find_library('libcrc', dirs: [path + '/lib_crc'], required: true)
diff --git a/drivers/net/memif/meson.build b/drivers/net/memif/meson.build
index bedc97311..a44d82535 100644
--- a/drivers/net/memif/meson.build
+++ b/drivers/net/memif/meson.build
@@ -1,8 +1,9 @@ 
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright 2018-2019 Cisco Systems, Inc.  All rights reserved.
 
-if host_machine.system() != 'linux'
-        build = false
+if not is_linux
+	build = false
+	reason = 'only supported on Linux'
 endif
 
 sources = files('rte_eth_memif.c',
diff --git a/drivers/raw/ioat/meson.build b/drivers/raw/ioat/meson.build
index 247ff88bf..0878418ae 100644
--- a/drivers/raw/ioat/meson.build
+++ b/drivers/raw/ioat/meson.build
@@ -2,6 +2,7 @@ 
 # Copyright 2019 Intel Corporation
 
 build = dpdk_conf.has('RTE_ARCH_X86')
+reason = 'only supported on x86'
 sources = files('ioat_rawdev.c',
 		'ioat_rawdev_test.c')
 deps += ['rawdev', 'bus_pci', 'mbuf']