Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/99910/?format=api
{ "id": 99910, "url": "http://patches.dpdk.org/api/patches/99910/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210928112912.785412-7-andrew.rybchenko@oktetlabs.ru/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210928112912.785412-7-andrew.rybchenko@oktetlabs.ru>", "list_archive_url": "https://inbox.dpdk.org/dev/20210928112912.785412-7-andrew.rybchenko@oktetlabs.ru", "date": "2021-09-28T11:29:07", "name": "[06/11] net/sfc: optimize getting number of SW stats", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "2eeccf14fd5a904281b44ea446dc03fb64c46d57", "submitter": { "id": 2013, "url": "http://patches.dpdk.org/api/people/2013/?format=api", "name": "Andrew Rybchenko", "email": "Andrew.Rybchenko@oktetlabs.ru" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210928112912.785412-7-andrew.rybchenko@oktetlabs.ru/mbox/", "series": [ { "id": 19227, "url": "http://patches.dpdk.org/api/series/19227/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=19227", "date": "2021-09-28T11:29:01", "name": "net/sfc: support per-queue stats on EF100", "version": 1, "mbox": "http://patches.dpdk.org/series/19227/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/99910/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/99910/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C81B0A0032;\n\tTue, 28 Sep 2021 13:30:15 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0BC1C41125;\n\tTue, 28 Sep 2021 13:29:46 +0200 (CEST)", "from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])\n by mails.dpdk.org (Postfix) with ESMTP id C8D314111E\n for <dev@dpdk.org>; Tue, 28 Sep 2021 13:29:43 +0200 (CEST)", "by shelob.oktetlabs.ru (Postfix, from userid 122)\n id 92B4F7F6D6; Tue, 28 Sep 2021 14:29:43 +0300 (MSK)", "from aros.oktetlabs.ru (aros.oktetlabs.ru [192.168.38.17])\n by shelob.oktetlabs.ru (Postfix) with ESMTP id B3DC77F6D8;\n Tue, 28 Sep 2021 14:29:31 +0300 (MSK)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on shelob.oktetlabs.ru", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.8 required=5.0 tests=ALL_TRUSTED,\n DKIM_ADSP_DISCARD,\n URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2", "DKIM-Filter": "OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru B3DC77F6D8", "Authentication-Results": "shelob.oktetlabs.ru/B3DC77F6D8; dkim=none;\n dkim-atps=neutral", "From": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "To": "dev@dpdk.org", "Cc": "Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>", "Date": "Tue, 28 Sep 2021 14:29:07 +0300", "Message-Id": "<20210928112912.785412-7-andrew.rybchenko@oktetlabs.ru>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210928112912.785412-1-andrew.rybchenko@oktetlabs.ru>", "References": "<20210928112912.785412-1-andrew.rybchenko@oktetlabs.ru>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 06/11] net/sfc: optimize getting number of SW\n stats", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>\n\nOptimize getting number of SW stats by caching the\nvalue during device configure since it's the only\nplace it may change.\n\nSigned-off-by: Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>\n---\n drivers/net/sfc/sfc.h | 2 ++\n drivers/net/sfc/sfc_sw_stats.c | 14 ++++----------\n 2 files changed, 6 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/sfc/sfc.h b/drivers/net/sfc/sfc.h\nindex 93d5202a24..b9ff8baed2 100644\n--- a/drivers/net/sfc/sfc.h\n+++ b/drivers/net/sfc/sfc.h\n@@ -218,6 +218,8 @@ struct sfc_counter_rxq {\n };\n \n struct sfc_sw_stats {\n+\t/* Number extended statistics provided by SW stats */\n+\tunsigned int\t\t\txstats_count;\n \tuint64_t\t\t\t*reset_vals;\n \n \trte_spinlock_t\t\t\tqueues_bitmap_lock;\ndiff --git a/drivers/net/sfc/sfc_sw_stats.c b/drivers/net/sfc/sfc_sw_stats.c\nindex de99e1cfaf..0f93091500 100644\n--- a/drivers/net/sfc/sfc_sw_stats.c\n+++ b/drivers/net/sfc/sfc_sw_stats.c\n@@ -329,17 +329,8 @@ sfc_sw_xstat_get_values_by_id(struct sfc_adapter *sa,\n unsigned int\n sfc_sw_xstats_get_nb_supported(struct sfc_adapter *sa)\n {\n-\tunsigned int nb_supported = 0;\n-\tunsigned int i;\n-\n \tSFC_ASSERT(sfc_adapter_is_locked(sa));\n-\n-\tfor (i = 0; i < RTE_DIM(sfc_sw_stats_descr); i++) {\n-\t\tnb_supported += sfc_sw_xstat_get_nb_supported(sa,\n-\t\t\t\t\t\t\t&sfc_sw_stats_descr[i]);\n-\t}\n-\n-\treturn nb_supported;\n+\treturn sa->sw_stats.xstats_count;\n }\n \n void\n@@ -506,6 +497,7 @@ sfc_sw_xstats_configure(struct sfc_adapter *sa)\n \tfor (i = 0; i < RTE_DIM(sfc_sw_stats_descr); i++)\n \t\tnb_supported += sfc_sw_xstat_get_nb_supported(sa,\n \t\t\t\t\t\t\t&sfc_sw_stats_descr[i]);\n+\tsa->sw_stats.xstats_count = nb_supported;\n \n \t*reset_vals = rte_realloc(*reset_vals,\n \t\t\t\t nb_supported * sizeof(**reset_vals), 0);\n@@ -559,6 +551,7 @@ sfc_sw_xstats_alloc_queues_bitmap(struct sfc_adapter *sa)\n int\n sfc_sw_xstats_init(struct sfc_adapter *sa)\n {\n+\tsa->sw_stats.xstats_count = 0;\n \tsa->sw_stats.reset_vals = NULL;\n \n \treturn sfc_sw_xstats_alloc_queues_bitmap(sa);\n@@ -570,4 +563,5 @@ sfc_sw_xstats_close(struct sfc_adapter *sa)\n \tsfc_sw_xstats_free_queues_bitmap(sa);\n \trte_free(sa->sw_stats.reset_vals);\n \tsa->sw_stats.reset_vals = NULL;\n+\tsa->sw_stats.xstats_count = 0;\n }\n", "prefixes": [ "06/11" ] }