Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/99813/?format=api
{ "id": 99813, "url": "http://patches.dpdk.org/api/patches/99813/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210927133450.10653-17-srikanth.k@oneconvergence.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210927133450.10653-17-srikanth.k@oneconvergence.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210927133450.10653-17-srikanth.k@oneconvergence.com", "date": "2021-09-27T13:34:47", "name": "[16/19] net/mlx5: making module DPDK callbacks invalid", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2131f06be53ffbfe960e8f64fe422043ff136053", "submitter": { "id": 2368, "url": "http://patches.dpdk.org/api/people/2368/?format=api", "name": "Srikanth Kaka", "email": "srikanth.k@oneconvergence.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210927133450.10653-17-srikanth.k@oneconvergence.com/mbox/", "series": [ { "id": 19193, "url": "http://patches.dpdk.org/api/series/19193/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=19193", "date": "2021-09-27T13:34:31", "name": "MLX5 FreeBSD support", "version": 1, "mbox": "http://patches.dpdk.org/series/19193/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/99813/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/99813/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E603FA0C46;\n\tMon, 27 Sep 2021 16:59:59 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 40C7541167;\n\tMon, 27 Sep 2021 16:58:26 +0200 (CEST)", "from mail-pf1-f174.google.com (mail-pf1-f174.google.com\n [209.85.210.174])\n by mails.dpdk.org (Postfix) with ESMTP id 140A840E3C\n for <dev@dpdk.org>; Mon, 27 Sep 2021 15:36:45 +0200 (CEST)", "by mail-pf1-f174.google.com with SMTP id c1so15828913pfp.10\n for <dev@dpdk.org>; Mon, 27 Sep 2021 06:36:44 -0700 (PDT)", "from srikanth-ThinkPad-T450.domain.name ([223.178.22.200])\n by smtp.gmail.com with ESMTPSA id t6sm17342274pfh.63.2021.09.27.06.36.41\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 27 Sep 2021 06:36:44 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oneconvergence.com; s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=uYXGv5KAGN81NBG+R6zTbbCyA5+WUJZdk0+ku+5DwrA=;\n b=NzBw0yYYgx0uI3p/429FJiHk/sPuJSlF/s3DvChu3sWOtIldiF+sfkvHmgdEHmpA59\n QpNtouo3laYQ9XmrrUwhF7aiKsUGDMgeL0Na1fYrZ0MuOxaenEeZzhxlJMPDBiAx+hYj\n 7Hk+mS4TbSotBfqEZWBPRxLx780a+YSw3STmk=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=uYXGv5KAGN81NBG+R6zTbbCyA5+WUJZdk0+ku+5DwrA=;\n b=6bL8XAUF8eqBDUBsuMGLq+tG1fCHKa7Vna7LP46bPgxKWYmDV0GimgZ8f3XP1k3gqz\n mWrfjomYMXDcBDQCngojaVgqGI9sz6V0K8BBoT8RzdBtm7jEDTDbdXpbHgtrH+wQbicH\n UBq3l9sv22luuSZeZLP5yEYxLjNPOSM4tPQfTIxgSrvVaChQZSEXHGvOvSmsaqqSxXQM\n Q3uS8Ylr1uVP+9Qdkur0bMUwVc2abrKJYSFNJDLb9ZYVKEnFbVzwSN4ZwHrCYVFXDJYp\n Qt8/bZ0vDPiKV4dWqp/1Ve7ZioCBFGpBFu06SwT+U5mY+FmkVXAwCb1SCrSwYaMhtUR8\n V0/A==", "X-Gm-Message-State": "AOAM5329mj11InsiomdH9/5K/+WFLmDYoPLrpEYkE/fhNEwd42UFJogv\n DwdWZ3xHxSoybabUbcnvVqb3kFRAY+gyvQ==", "X-Google-Smtp-Source": "\n ABdhPJyG6Jw/Bb/sSVHTOAqEm1eY0WcHfUZBa8kfuKsm0EIhekWMvc8YJkTEjoxF20rNyuO+fSf72A==", "X-Received": "by 2002:a63:e613:: with SMTP id g19mr16713400pgh.12.1632749804291;\n Mon, 27 Sep 2021 06:36:44 -0700 (PDT)", "From": "Srikanth Kaka <srikanth.k@oneconvergence.com>", "To": "Matan Azrad <matan@nvidia.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>", "Cc": "dev@dpdk.org, Vag Singh <vag.singh@oneconvergence.com>,\n Anand Thulasiram <avelu@juniper.net>,\n Srikanth Kaka <srikanth.k@oneconvergence.com>", "Date": "Mon, 27 Sep 2021 19:04:47 +0530", "Message-Id": "<20210927133450.10653-17-srikanth.k@oneconvergence.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210927133450.10653-1-srikanth.k@oneconvergence.com>", "References": "<20210927133450.10653-1-srikanth.k@oneconvergence.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Mon, 27 Sep 2021 16:58:07 +0200", "Subject": "[dpdk-dev] [PATCH 16/19] net/mlx5: making module DPDK callbacks\n invalid", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "At present, DPDK module callbacks are not supported\n\nSigned-off-by: Srikanth Kaka <srikanth.k@oneconvergence.com>\nSigned-off-by: Vag Singh <vag.singh@oneconvergence.com>\nSigned-off-by: Anand Thulasiram <avelu@juniper.net>\n---\n drivers/net/mlx5/freebsd/mlx5_ethdev_os.c | 60 +++--------------------\n 1 file changed, 6 insertions(+), 54 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/freebsd/mlx5_ethdev_os.c b/drivers/net/mlx5/freebsd/mlx5_ethdev_os.c\nindex a04bac8ed9..5940803cfc 100644\n--- a/drivers/net/mlx5/freebsd/mlx5_ethdev_os.c\n+++ b/drivers/net/mlx5/freebsd/mlx5_ethdev_os.c\n@@ -909,28 +909,9 @@ int\n mlx5_get_module_info(struct rte_eth_dev *dev,\n \t\t struct rte_eth_dev_module_info *modinfo)\n {\n-\tstruct ethtool_modinfo info = {\n-\t\t.cmd = ETHTOOL_GMODULEINFO,\n-\t};\n-\tstruct ifreq ifr = (struct ifreq) {\n-\t\t.ifr_data = (void *)&info,\n-\t};\n-\tint ret = 0;\n-\n-\tif (!dev) {\n-\t\tDRV_LOG(WARNING, \"missing argument, cannot get module info\");\n-\t\trte_errno = EINVAL;\n-\t\treturn -rte_errno;\n-\t}\n-\tret = mlx5_ifreq(dev, SIOCETHTOOL, &ifr);\n-\tif (ret) {\n-\t\tDRV_LOG(WARNING, \"port %u ioctl(SIOCETHTOOL) failed: %s\",\n-\t\t\tdev->data->port_id, strerror(rte_errno));\n-\t\treturn ret;\n-\t}\n-\tmodinfo->type = info.type;\n-\tmodinfo->eeprom_len = info.eeprom_len;\n-\treturn ret;\n+\tRTE_SET_USED(dev);\n+\tRTE_SET_USED(modinfo);\n+\treturn -ENOTSUP;\n }\n \n /**\n@@ -947,38 +928,9 @@ mlx5_get_module_info(struct rte_eth_dev *dev,\n int mlx5_get_module_eeprom(struct rte_eth_dev *dev,\n \t\t\t struct rte_dev_eeprom_info *info)\n {\n-\tstruct ethtool_eeprom *eeprom;\n-\tstruct ifreq ifr;\n-\tint ret = 0;\n-\n-\tif (!dev) {\n-\t\tDRV_LOG(WARNING, \"missing argument, cannot get module eeprom\");\n-\t\trte_errno = EINVAL;\n-\t\treturn -rte_errno;\n-\t}\n-\teeprom = mlx5_malloc(MLX5_MEM_ZERO,\n-\t\t\t (sizeof(struct ethtool_eeprom) + info->length), 0,\n-\t\t\t SOCKET_ID_ANY);\n-\tif (!eeprom) {\n-\t\tDRV_LOG(WARNING, \"port %u cannot allocate memory for \"\n-\t\t\t\"eeprom data\", dev->data->port_id);\n-\t\trte_errno = ENOMEM;\n-\t\treturn -rte_errno;\n-\t}\n-\teeprom->cmd = ETHTOOL_GMODULEEEPROM;\n-\teeprom->offset = info->offset;\n-\teeprom->len = info->length;\n-\tifr = (struct ifreq) {\n-\t\t.ifr_data = (void *)eeprom,\n-\t};\n-\tret = mlx5_ifreq(dev, SIOCETHTOOL, &ifr);\n-\tif (ret)\n-\t\tDRV_LOG(WARNING, \"port %u ioctl(SIOCETHTOOL) failed: %s\",\n-\t\t\tdev->data->port_id, strerror(rte_errno));\n-\telse\n-\t\trte_memcpy(info->data, eeprom->data, info->length);\n-\tmlx5_free(eeprom);\n-\treturn ret;\n+\tRTE_SET_USED(dev);\n+\tRTE_SET_USED(info);\n+\treturn -ENOTSUP;\n }\n \n /**\n", "prefixes": [ "16/19" ] }