Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/98953/?format=api
{ "id": 98953, "url": "http://patches.dpdk.org/api/patches/98953/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210915184448.92751-1-u9012063@gmail.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210915184448.92751-1-u9012063@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210915184448.92751-1-u9012063@gmail.com", "date": "2021-09-15T18:44:48", "name": "[v1] net/ixgbe: Add support for Windows", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "17b5a1984453370aa786405f0ab54d422203d960", "submitter": { "id": 1106, "url": "http://patches.dpdk.org/api/people/1106/?format=api", "name": "William Tu", "email": "u9012063@gmail.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210915184448.92751-1-u9012063@gmail.com/mbox/", "series": [ { "id": 18951, "url": "http://patches.dpdk.org/api/series/18951/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=18951", "date": "2021-09-15T18:44:48", "name": "[v1] net/ixgbe: Add support for Windows", "version": 1, "mbox": "http://patches.dpdk.org/series/18951/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/98953/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/98953/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 30135A0C41;\n\tWed, 15 Sep 2021 20:45:03 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id AB1344003F;\n\tWed, 15 Sep 2021 20:45:02 +0200 (CEST)", "from mail-pl1-f175.google.com (mail-pl1-f175.google.com\n [209.85.214.175])\n by mails.dpdk.org (Postfix) with ESMTP id 9AD164003C\n for <dev@dpdk.org>; Wed, 15 Sep 2021 20:45:00 +0200 (CEST)", "by mail-pl1-f175.google.com with SMTP id n4so2184332plh.9\n for <dev@dpdk.org>; Wed, 15 Sep 2021 11:45:00 -0700 (PDT)", "from localhost.localdomain (c-67-185-44-206.hsd1.wa.comcast.net.\n [67.185.44.206])\n by smtp.gmail.com with ESMTPSA id mm6sm374347pjb.33.2021.09.15.11.44.57\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 15 Sep 2021 11:44:58 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n h=from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=W5+IjMYWrMebjYwaVzMx0UKj7URDBryIlVIV0sIvMhg=;\n b=C206bhP+u5ZiVtDjLO7Fq+V7R7JpM3o0x10vqfxMc/G+qMe5rlnUGNn+g9KFtV+w/r\n gL+BUXLnc84InIl7KrnpOf7nBKpyHbiS0W2F9DcPjmNfmHLLUs1f+7LoDLhPlljED02m\n IFC27iYeArp27l3s01ci/8ATWdQ9FUieS6B5F52X47ke5l7fVgcj/Jbq/ocitNG7aTlj\n A/uIE6F3dBldW7xZTFEYegYdL2q3vedfrde6CwvhWvdm82EY8FfwNMTQQK5OYdMLwWLw\n PWvVTRZo+zAXFWZv0vXdwUtEF2CS42LlIKVBoPW/uf8xgjbYzv86K4EcjxOjwdlpymUg\n iNPA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=W5+IjMYWrMebjYwaVzMx0UKj7URDBryIlVIV0sIvMhg=;\n b=qWMGyIwHNZQf4m1uO4K1MHJk6HzTe/R2/BCdMNI5AFD4Jtxnm+CGBmNmgZH/Nb98OJ\n YE+4+QiAjOya4Z30kTeIV6pgwDODNPZnk071xgis8aWOoTLYKGBMJN2m44/oApK28AXo\n OySRdyV1qjzD/+USq0RmcBe4ZxISBSS+mhFtPfE377HXpEEfaIRnTT8hNG6kA/hxUcU3\n DBgqAXkylqag68NZoEOrHokQq++zDGHSbJ4r4dBr4rTkcH5POeWRHbqvmIObCHmJmmm8\n iwrJK59ATQpbii0XJlSiGjWafikk+9rcbcxJTT5ys38fRWmUUxvHP1WVeSMylk+YGBWD\n dG6A==", "X-Gm-Message-State": "AOAM533+FGlkyZdBNikFAcErb+7GBnfyw4NpxglPAwdfBuvzTeWPBNNq\n H7OczApDx+C/3uU4mwg/5903ZXkf5rASfw==", "X-Google-Smtp-Source": "\n ABdhPJxoZuLUZJfDsv1kCVkboZB2qPCzl/oaZyVxpmAPIppcMS4UIZs+3LXSajDhwx46TyFiwoh8wg==", "X-Received": "by 2002:a17:902:e848:b0:13b:7a10:2929 with SMTP id\n t8-20020a170902e84800b0013b7a102929mr1109727plg.14.1631731498846;\n Wed, 15 Sep 2021 11:44:58 -0700 (PDT)", "From": "William Tu <u9012063@gmail.com>", "To": "dev@dpdk.org", "Cc": "pallavi.kadam@intel.com, ranjit.menon@intel.com, dmitry.kozliuk@gmail.com", "Date": "Wed, 15 Sep 2021 18:44:48 +0000", "Message-Id": "<20210915184448.92751-1-u9012063@gmail.com>", "X-Mailer": "git-send-email 2.30.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v1] net/ixgbe: Add support for Windows", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch enables building the ixgbe driver for Windows.\nIt also enables its dependencies on security and cryptodev.\nI tested on AWS using ixgbe VF device, using dpdk-testpmd.\n\nSigned-off-by: William Tu <u9012063@gmail.com>\n---\n drivers/net/ixgbe/base/ixgbe_hv_vf.c | 1 +\n drivers/net/ixgbe/base/ixgbe_osdep.h | 10 ++++++++++\n drivers/net/ixgbe/ixgbe_ethdev.c | 2 +-\n drivers/net/ixgbe/ixgbe_flow.c | 2 +-\n drivers/net/ixgbe/ixgbe_tm.c | 2 +-\n drivers/net/ixgbe/meson.build | 6 ------\n lib/cryptodev/rte_cryptodev.c | 4 ++++\n lib/cryptodev/version.map | 2 --\n lib/meson.build | 2 ++\n lib/security/rte_security.h | 4 ++++\n lib/security/version.map | 1 -\n 11 files changed, 24 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/base/ixgbe_hv_vf.c b/drivers/net/ixgbe/base/ixgbe_hv_vf.c\nindex b7ad44ab8c..4572411d39 100644\n--- a/drivers/net/ixgbe/base/ixgbe_hv_vf.c\n+++ b/drivers/net/ixgbe/base/ixgbe_hv_vf.c\n@@ -4,6 +4,7 @@\n \n #include \"ixgbe_vf.h\"\n #include \"ixgbe_hv_vf.h\"\n+#include \"ixgbe_osdep.h\"\n \n /**\n * Hyper-V variant - just a stub.\ndiff --git a/drivers/net/ixgbe/base/ixgbe_osdep.h b/drivers/net/ixgbe/base/ixgbe_osdep.h\nindex cacf724198..fe28029ef7 100644\n--- a/drivers/net/ixgbe/base/ixgbe_osdep.h\n+++ b/drivers/net/ixgbe/base/ixgbe_osdep.h\n@@ -17,6 +17,12 @@\n #include <rte_byteorder.h>\n #include <rte_io.h>\n \n+#ifndef RTE_EXEC_ENV_WINDOWS\n+#include <netinet/in.h>\n+#else\n+#include <Ws2tcpip.h>\n+#endif\n+\n #include \"../ixgbe_logs.h\"\n #include \"../ixgbe_bypass_defines.h\"\n \n@@ -43,12 +49,16 @@\n \n #define false 0\n #define true 1\n+#ifndef RTE_EXEC_ENV_WINDOWS\n #define min(a,b)\tRTE_MIN(a,b) \n+#endif\n \n #define EWARN(hw, S, args...) DEBUGOUT1(S, ##args)\n \n /* Bunch of defines for shared code bogosity */\n+#ifndef UNREFERENCED_PARAMETER\n #define UNREFERENCED_PARAMETER(_p) \n+#endif\n #define UNREFERENCED_1PARAMETER(_p) \n #define UNREFERENCED_2PARAMETER(_p, _q)\n #define UNREFERENCED_3PARAMETER(_p, _q, _r) \ndiff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex 47693c0c47..8b33897ca1 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -10,7 +10,6 @@\n #include <unistd.h>\n #include <stdarg.h>\n #include <inttypes.h>\n-#include <netinet/in.h>\n #include <rte_string_fns.h>\n #include <rte_byteorder.h>\n #include <rte_common.h>\n@@ -46,6 +45,7 @@\n #include \"ixgbe_rxtx.h\"\n #include \"base/ixgbe_type.h\"\n #include \"base/ixgbe_phy.h\"\n+#include \"base/ixgbe_osdep.h\"\n #include \"ixgbe_regs.h\"\n \n /*\ndiff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c\nindex 511b612f7f..27322ab903 100644\n--- a/drivers/net/ixgbe/ixgbe_flow.c\n+++ b/drivers/net/ixgbe/ixgbe_flow.c\n@@ -10,7 +10,6 @@\n #include <unistd.h>\n #include <stdarg.h>\n #include <inttypes.h>\n-#include <netinet/in.h>\n #include <rte_byteorder.h>\n #include <rte_common.h>\n #include <rte_cycles.h>\n@@ -37,6 +36,7 @@\n #include \"base/ixgbe_api.h\"\n #include \"base/ixgbe_vf.h\"\n #include \"base/ixgbe_common.h\"\n+#include \"base/ixgbe_osdep.h\"\n #include \"ixgbe_ethdev.h\"\n #include \"ixgbe_bypass.h\"\n #include \"ixgbe_rxtx.h\"\ndiff --git a/drivers/net/ixgbe/ixgbe_tm.c b/drivers/net/ixgbe/ixgbe_tm.c\nindex a8407e742e..ae03ea6e9d 100644\n--- a/drivers/net/ixgbe/ixgbe_tm.c\n+++ b/drivers/net/ixgbe/ixgbe_tm.c\n@@ -665,7 +665,7 @@ ixgbe_node_add(struct rte_eth_dev *dev, uint32_t node_id,\n \t}\n \t/* check level */\n \tif (level_id != RTE_TM_NODE_LEVEL_ID_ANY &&\n-\t level_id != parent_node_type + 1) {\n+\t level_id != (uint32_t)parent_node_type + 1) {\n \t\terror->type = RTE_TM_ERROR_TYPE_NODE_PARAMS;\n \t\terror->message = \"Wrong level\";\n \t\treturn -EINVAL;\ndiff --git a/drivers/net/ixgbe/meson.build b/drivers/net/ixgbe/meson.build\nindex 55ac91fcd1..4b18e47273 100644\n--- a/drivers/net/ixgbe/meson.build\n+++ b/drivers/net/ixgbe/meson.build\n@@ -1,12 +1,6 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2017 Intel Corporation\n \n-if is_windows\n- build = false\n- reason = 'not supported on Windows'\n- subdir_done()\n-endif\n-\n cflags += ['-DRTE_LIBRTE_IXGBE_BYPASS']\n \n subdir('base')\ndiff --git a/lib/cryptodev/rte_cryptodev.c b/lib/cryptodev/rte_cryptodev.c\nindex 9fa3aff1d3..dd09e82240 100644\n--- a/lib/cryptodev/rte_cryptodev.c\n+++ b/lib/cryptodev/rte_cryptodev.c\n@@ -12,7 +12,11 @@\n #include <errno.h>\n #include <stdint.h>\n #include <inttypes.h>\n+#ifndef RTE_EXEC_ENV_WINDOWS\n #include <netinet/in.h>\n+#else\n+#include <Ws2tcpip.h>\n+#endif\n \n #include <rte_byteorder.h>\n #include <rte_log.h>\ndiff --git a/lib/cryptodev/version.map b/lib/cryptodev/version.map\nindex 8294c9f64f..43cf937e40 100644\n--- a/lib/cryptodev/version.map\n+++ b/lib/cryptodev/version.map\n@@ -93,10 +93,8 @@ EXPERIMENTAL {\n \t# added in 20.11\n \trte_cryptodev_configure_raw_dp_ctx;\n \trte_cryptodev_get_raw_dp_ctx_size;\n-\trte_cryptodev_raw_dequeue;\n \trte_cryptodev_raw_dequeue_burst;\n \trte_cryptodev_raw_dequeue_done;\n-\trte_cryptodev_raw_enqueue;\n \trte_cryptodev_raw_enqueue_burst;\n \trte_cryptodev_raw_enqueue_done;\n \ndiff --git a/lib/meson.build b/lib/meson.build\nindex 1673ca4323..c26641f217 100644\n--- a/lib/meson.build\n+++ b/lib/meson.build\n@@ -85,6 +85,8 @@ if is_windows\n 'gso',\n 'latencystats',\n 'pdump',\n+ 'cryptodev',\n+ 'security',\n ] # only supported libraries for windows\n endif\n \ndiff --git a/lib/security/rte_security.h b/lib/security/rte_security.h\nindex 2e136d7929..b8ae88f7bf 100644\n--- a/lib/security/rte_security.h\n+++ b/lib/security/rte_security.h\n@@ -19,9 +19,13 @@ extern \"C\" {\n \n #include <sys/types.h>\n \n+#ifndef RTE_EXEC_ENV_WINDOWS\n #include <netinet/in.h>\n #include <netinet/ip.h>\n #include <netinet/ip6.h>\n+#else\n+#include <Ws2tcpip.h>\n+#endif\n \n #include <rte_compat.h>\n #include <rte_common.h>\ndiff --git a/lib/security/version.map b/lib/security/version.map\nindex c44c7f5f60..6067051552 100644\n--- a/lib/security/version.map\n+++ b/lib/security/version.map\n@@ -1,7 +1,6 @@\n DPDK_22 {\n \tglobal:\n \n-\trte_security_attach_session;\n \trte_security_capabilities_get;\n \trte_security_capability_get;\n \trte_security_session_create;\n", "prefixes": [ "v1" ] }