Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/98826/?format=api
{ "id": 98826, "url": "http://patches.dpdk.org/api/patches/98826/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210914053833.7760-3-talshn@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210914053833.7760-3-talshn@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210914053833.7760-3-talshn@nvidia.com", "date": "2021-09-14T05:38:25", "name": "[RFC,02/10] common/mlx5: add an agnostic OS function to open device context", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "515f7239e7b8851c059977df3cbf1135b79c278f", "submitter": { "id": 1893, "url": "http://patches.dpdk.org/api/people/1893/?format=api", "name": "Tal Shnaiderman", "email": "talshn@nvidia.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210914053833.7760-3-talshn@nvidia.com/mbox/", "series": [ { "id": 18890, "url": "http://patches.dpdk.org/api/series/18890/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=18890", "date": "2021-09-14T05:38:23", "name": "Support MLX5 crypto driver on Windows", "version": 1, "mbox": "http://patches.dpdk.org/series/18890/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/98826/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/98826/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B05D7A0C47;\n\tTue, 14 Sep 2021 07:40:12 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 00814410ED;\n\tTue, 14 Sep 2021 07:40:03 +0200 (CEST)", "from NAM12-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam12on2076.outbound.protection.outlook.com [40.107.243.76])\n by mails.dpdk.org (Postfix) with ESMTP id 1ADAA410DC\n for <dev@dpdk.org>; Tue, 14 Sep 2021 07:40:00 +0200 (CEST)", "from DS7PR03CA0324.namprd03.prod.outlook.com (2603:10b6:8:2b::24) by\n BN6PR1201MB0100.namprd12.prod.outlook.com (2603:10b6:405:59::9) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.18; Tue, 14 Sep\n 2021 05:39:58 +0000", "from DM6NAM11FT026.eop-nam11.prod.protection.outlook.com\n (2603:10b6:8:2b:cafe::d) by DS7PR03CA0324.outlook.office365.com\n (2603:10b6:8:2b::24) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend\n Transport; Tue, 14 Sep 2021 05:39:58 +0000", "from mail.nvidia.com (216.228.112.36) by\n DM6NAM11FT026.mail.protection.outlook.com (10.13.172.161) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4500.14 via Frontend Transport; Tue, 14 Sep 2021 05:39:58 +0000", "from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL101.nvidia.com\n (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 14 Sep\n 2021 05:39:57 +0000", "from nvidia.com (172.20.187.6) by DRHQMAIL107.nvidia.com\n (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 14 Sep\n 2021 05:39:54 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=S7lCc3O2gH+O31KTNvzdLXPtN2d75TZgHE7dZSAL5dvADnE1AnYoIq+aArfZMIwDOwkhisXgjXvdqqJKOXHFuEjOJv8mvD3IwIQ2s2pggnc929t9AHWJzaI2iL+JN2E7BJYKq4bsftf/DoYKvsfvOvqxGZ8E7nKKeJoRfH7Dnz98uyRLA54rv3ASx4X1MdsmMNTDMjfawQ8jCEXg5S7ZYv8PHGgNXCZ9Vl2EVCduFQF6FuoV28aJIUuwLf+UutW1+WUEDbyWUC3jMdn2+e/1jfVQb2EIsnu43rwKxS78npe+nOfBmZPOnrpum7NlAnEy0AVarj5idsWlMgy7X0+r+g==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n bh=si7iQQ+p8RDpxCCZ/h4ulU3zZyd/9APYWx0YG/rfeRw=;\n b=a2ECDBN4yCzYcFZB4YCzfzNF2KE6DdOnfBvNwFjwqsUKoVaJ8wk4N/98LpRD5U6kXLNBp0UTYa3qnX1P2BBvQdbUB/ZR215t72lUGvA1/dOtTwDJrqC/yQSQyQ0SPhJTvm2xzNq6olwx+TLkeeRha7i9Hvq+LsXBaq3sG7UXKW7Peen6ggVFenpfUamB2KL+VhVKlxCNIhqF77MAModSJy31UAFxgSqJzPFclgrSMxpuKlUnVIgsJmpjV0rvQKrRBeLj2uTYyrrWeOaLxTVGra/qoDEffhcApAXwc2bz0IReBponwgeP4H7RmIG98bZFkX++CHKYthWl6R0IuRysqQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.36) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com;\n dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=si7iQQ+p8RDpxCCZ/h4ulU3zZyd/9APYWx0YG/rfeRw=;\n b=tauke9d+bAY1upKhQChLbbZHdeN99u8m2hYyma73axH0ngyObIm2dTwyDCFbDlZ64nAgPjcgq+s0qx2sHemJkQMycV717W3jC9rKaB7MGkpSmpW3YxYXUy36JPWRo3WVljnEDHKmS6725MqnygtLfsiw5g/XrzDVSV1XrtktAEmF7SxxsYLDLF/TuUyw7GjbVVUh1fWotBloIGG1crvSQ+pGOwSi7sg1L+UixNEj/BmsT1xUisMGvnmH6HsAVf0Xts5wu6Wb5d5Cw3cF6mEaKsKNRXqsj7A/uaYsGbYHraZCOc9Cvs3CtdZHNZPHA/9EuaOR9BDk9YlIVD3vrTiqOw==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.36)\n smtp.mailfrom=nvidia.com; monjalon.net; dkim=none (message not signed)\n header.d=none;monjalon.net; dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.36 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.36; helo=mail.nvidia.com;", "From": "Tal Shnaiderman <talshn@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "<thomas@monjalon.net>, <matan@nvidia.com>, <rasland@nvidia.com>,\n <asafp@nvidia.com>, <gakhil@marvell.com>, <declan.doherty@intel.com>,\n <viacheslavo@nvidia.com>, <eilong@nvidia.com>", "Date": "Tue, 14 Sep 2021 08:38:25 +0300", "Message-ID": "<20210914053833.7760-3-talshn@nvidia.com>", "X-Mailer": "git-send-email 2.16.1.windows.4", "In-Reply-To": "<20210914053833.7760-1-talshn@nvidia.com>", "References": "<20210914053833.7760-1-talshn@nvidia.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[172.20.187.6]", "X-ClientProxiedBy": "HQMAIL111.nvidia.com (172.20.187.18) To\n DRHQMAIL107.nvidia.com (10.27.9.16)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "340c7b75-e2cf-45f5-baa2-08d9774216bb", "X-MS-TrafficTypeDiagnostic": "BN6PR1201MB0100:", "X-LD-Processed": "43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr", "X-Microsoft-Antispam-PRVS": "\n <BN6PR1201MB0100BD7657BC5F3E1B3299B1A4DA9@BN6PR1201MB0100.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:8273;", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n 7wcJnCcubGHapS2xfJdDQlsIZmZsUnby9W+Ipa4Z9cl4PP0AI/7xLY3rHJVmEAM6M/kmjUkWEYsyh/OSbf6Q8/TL0DQZPRnPp2C/06FMdkSxyD8VOx9cOH/FUPB1UqSHrW6JVkNdEnJgJH+n6cMETeg9HaFniSwDqxj+LjqUVMFteMJF9RwJ3LnXtz976YeoC3NU+odsI6hxfajxmZaL4e9Dieov7IS4XrOqcmbIUSRRm+KunzLD6BIbr6/PjMAIGY7zD4pU12Ry82uqFK9t0yKqtRLxX42yMhg75RTOQ1ab1HNDdsQm26oqFi6g1Wqz1Syd6+lwRr0zB2pJT79J/P4GVyf0O8luvayfYLAdhrFWUryIFpJD4rA6Jny3x1D+4gSvfAp/+qYxRNH02i05sLyAMkwG6hizzZejmwgq/oH8HxZTbL1GlqukCC/mHU5zTUoymkna3dxbZFQsdREhHav4MYKNBew9fW4iblcaHf3s/vafrOIm9Lp38sErwb7hiZQBZnJnFIaECWmETfpB86NXtVCNBX9zVlrmIKC6yAeY+qDJ7D7pLJMZ4JnuSODj5Wvx8CfshQJeSr9BY2GPxJFX51Klq3VSUpJDLN66zIV5RrgD4q20h0+ch+RGa/EbhyS10VQDaDeryhgSQ7HphspPU79MN/kOv1Y6rju1xrfRhTj3am+h0Rsuhp1IJEeNVXp6IF1dbz8G0RCXyzAyNw==", "X-Forefront-Antispam-Report": "CIP:216.228.112.36; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid05.nvidia.com; CAT:NONE;\n SFS:(4636009)(46966006)(36840700001)(7696005)(2906002)(83380400001)(36860700001)(54906003)(86362001)(8676002)(6916009)(55016002)(16526019)(186003)(26005)(6286002)(426003)(107886003)(70586007)(70206006)(336012)(1076003)(2616005)(82310400003)(508600001)(8936002)(4326008)(6666004)(36906005)(356005)(5660300002)(316002)(7636003)(47076005)(36756003);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "14 Sep 2021 05:39:58.1055 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 340c7b75-e2cf-45f5-baa2-08d9774216bb", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.36];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n DM6NAM11FT026.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BN6PR1201MB0100", "Subject": "[dpdk-dev] [RFC PATCH 02/10] common/mlx5: add an agnostic OS\n function to open device context", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add a function to open device context from a rte_device.\n\nFunction mlx5_os_open_device_context can be used both on\nWindows and Linux OS.\n\nSigned-off-by: Tal Shnaiderman <talshn@nvidia.com>\n---\n drivers/common/mlx5/linux/mlx5_common_os.c | 28 +++++++\n drivers/common/mlx5/mlx5_common.h | 4 +\n drivers/common/mlx5/version.map | 2 +\n drivers/common/mlx5/windows/mlx5_common_os.c | 118 +++++++++++++++++++++++++++\n drivers/common/mlx5/windows/mlx5_common_os.h | 2 +\n drivers/net/mlx5/windows/mlx5_os.c | 64 +--------------\n 6 files changed, 155 insertions(+), 63 deletions(-)", "diff": "diff --git a/drivers/common/mlx5/linux/mlx5_common_os.c b/drivers/common/mlx5/linux/mlx5_common_os.c\nindex 9e0c823c97..3ef507944f 100644\n--- a/drivers/common/mlx5/linux/mlx5_common_os.c\n+++ b/drivers/common/mlx5/linux/mlx5_common_os.c\n@@ -428,3 +428,31 @@ mlx5_os_get_ibv_device(const struct rte_pci_addr *addr)\n \tmlx5_glue->free_device_list(ibv_list);\n \treturn ibv_match;\n }\n+\n+/**\n+ * Open device context from a rte_device.\n+ *\n+ * @param[in] dev\n+ * Pointer to an rte_device struct.\n+ * @return\n+ * Pointer to device context or NULL in case context cannot be found.\n+ */\n+void *\n+mlx5_os_open_device_context(struct rte_device *dev)\n+{\n+\tstruct ibv_device *ibv;\n+\tvoid *ctx;\n+\n+\tibv = mlx5_os_get_ibv_dev(dev);\n+\tif (ibv == NULL) {\n+\t\tDRV_LOG(ERR, \"Failed getting ibv_dev\");\n+\t\treturn NULL;\n+\t}\n+\tctx = mlx5_glue->dv_open_device(ibv);\n+\tif (ctx == NULL) {\n+\t\tDRV_LOG(ERR, \"Failed to open IB device \\\"%s\\\".\", ibv->name);\n+\t\trte_errno = ENODEV;\n+\t\treturn NULL;\n+\t}\n+\treturn ctx;\n+}\ndiff --git a/drivers/common/mlx5/mlx5_common.h b/drivers/common/mlx5/mlx5_common.h\nindex a772371200..249804b00c 100644\n--- a/drivers/common/mlx5/mlx5_common.h\n+++ b/drivers/common/mlx5/mlx5_common.h\n@@ -419,4 +419,8 @@ __rte_internal\n bool\n mlx5_dev_is_pci(const struct rte_device *dev);\n \n+__rte_internal\n+void *\n+mlx5_os_open_device_context(struct rte_device *dev);\n+\n #endif /* RTE_PMD_MLX5_COMMON_H_ */\ndiff --git a/drivers/common/mlx5/version.map b/drivers/common/mlx5/version.map\nindex e5cb6b7060..6d4258dd25 100644\n--- a/drivers/common/mlx5/version.map\n+++ b/drivers/common/mlx5/version.map\n@@ -141,6 +141,8 @@ INTERNAL {\n \tmlx5_os_alloc_pd;\n \tmlx5_os_dealloc_pd;\n \tmlx5_os_dereg_mr;\n+\tmlx5_os_match_devx_devices_to_addr;\n+\tmlx5_os_open_device_context;\n \tmlx5_os_get_ibv_dev; # WINDOWS_NO_EXPORT\n \tmlx5_os_reg_mr;\n \tmlx5_os_umem_dereg;\ndiff --git a/drivers/common/mlx5/windows/mlx5_common_os.c b/drivers/common/mlx5/windows/mlx5_common_os.c\nindex 5031bdca26..3b59e57e57 100644\n--- a/drivers/common/mlx5/windows/mlx5_common_os.c\n+++ b/drivers/common/mlx5/windows/mlx5_common_os.c\n@@ -6,6 +6,7 @@\n #include <string.h>\n #include <stdio.h>\n \n+#include <rte_bus_pci.h>\n #include <rte_mempool.h>\n #include <rte_malloc.h>\n #include <rte_errno.h>\n@@ -205,3 +206,120 @@ mlx5_os_dereg_mr(struct mlx5_pmd_mr *pmd_mr)\n \t\tclaim_zero(mlx5_os_umem_dereg(pmd_mr->obj));\n \tmemset(pmd_mr, 0, sizeof(*pmd_mr));\n }\n+\n+/**\n+ * Detect if a devx_device_bdf object has identical DBDF values to the\n+ * rte_pci_addr found in bus/pci probing\n+ *\n+ * @param[in] devx_bdf\n+ * Pointer to the devx_device_bdf structure.\n+ * @param[in] addr\n+ * Pointer to the rte_pci_addr structure.\n+ *\n+ * @return\n+ * 1 on Device match, 0 on mismatch.\n+ */\n+static int\n+mlx5_os_match_devx_bdf_to_addr(struct devx_device_bdf *devx_bdf,\n+\t\t\t struct rte_pci_addr *addr)\n+{\n+\tif (addr->domain != (devx_bdf->bus_id >> 8) ||\n+\t addr->bus != (devx_bdf->bus_id & 0xff) ||\n+\t addr->devid != devx_bdf->dev_id ||\n+\t addr->function != devx_bdf->fnc_id) {\n+\t\treturn 0;\n+\t}\n+\treturn 1;\n+}\n+\n+/**\n+ * Detect if a devx_device_bdf object matches the rte_pci_addr\n+ * found in bus/pci probing\n+ * Compare both the Native/PF BDF and the raw_bdf representing a VF BDF.\n+ *\n+ * @param[in] devx_bdf\n+ * Pointer to the devx_device_bdf structure.\n+ * @param[in] addr\n+ * Pointer to the rte_pci_addr structure.\n+ *\n+ * @return\n+ * 1 on Device match, 0 on mismatch, rte_errno code on failure.\n+ */\n+int\n+mlx5_os_match_devx_devices_to_addr(struct devx_device_bdf *devx_bdf,\n+\t\t\t\tstruct rte_pci_addr *addr)\n+{\n+\tint err;\n+\tstruct devx_device mlx5_dev;\n+\n+\tif (mlx5_os_match_devx_bdf_to_addr(devx_bdf, addr))\n+\t\treturn 1;\n+\t/**\n+\t * Didn't match on Native/PF BDF, could still\n+\t * Match a VF BDF, check it next\n+\t */\n+\terr = mlx5_glue->query_device(devx_bdf, &mlx5_dev);\n+\tif (err) {\n+\t\tDRV_LOG(ERR, \"query_device failed\");\n+\t\trte_errno = err;\n+\t\treturn rte_errno;\n+\t}\n+\tif (mlx5_os_match_devx_bdf_to_addr(&mlx5_dev.raw_bdf, addr))\n+\t\treturn 1;\n+\treturn 0;\n+}\n+\n+/**\n+ * Open device context from a rte_device.\n+ *\n+ * @param[in] dev\n+ * Pointer to an rte_device struct.\n+ * @return\n+ * Pointer to device context or NULL in case context cannot be found.\n+ */\n+void *\n+mlx5_os_open_device_context(struct rte_device *dev)\n+{\n+\tstruct devx_device_bdf *devx_bdf_devs, *orig_devx_bdf_devs;\n+\tstruct mlx5_context *devx_ctx_match = NULL;\n+\tint ret, err;\n+\tstruct rte_pci_device *pci_dev = RTE_DEV_TO_PCI(dev);\n+\n+\tdevx_bdf_devs = mlx5_glue->get_device_list(&ret);\n+\torig_devx_bdf_devs = devx_bdf_devs;\n+\tif (!devx_bdf_devs) {\n+\t\trte_errno = errno ? errno : ENOSYS;\n+\t\tDRV_LOG(ERR, \"cannot list devices, is DevX configured?\");\n+\t\treturn NULL;\n+\t}\n+\twhile (ret-- > 0) {\n+\t\terr = mlx5_os_match_devx_devices_to_addr(devx_bdf_devs,\n+\t\t &pci_dev->addr);\n+\t\tif (err == 1) {\n+\t\t\tdevx_ctx_match = mlx5_glue->open_device(devx_bdf_devs);\n+\t\t\tif (!devx_ctx_match) {\n+\t\t\t\tDRV_LOG(ERR, \"open_device failed\");\n+\t\t\t\terr = errno;\n+\t\t\t\tgoto exit;\n+\t\t\t}\n+\t\t\terr = mlx5_glue->query_device(devx_bdf_devs,\n+\t\t\t\t&devx_ctx_match->mlx5_dev);\n+\t\t\tif (err) {\n+\t\t\t\tDRV_LOG(ERR, \"query device context failed.\");\n+\t\t\t\trte_errno = errno ? errno : ENOSYS;\n+\t\t\t\tclaim_zero(mlx5_glue->close_device(\n+\t\t\t\t\tdevx_ctx_match));\n+\t\t\t\tgoto exit;\n+\t\t\t}\n+\t\t}\n+\t\tif (err != 0) {\n+\t\t\tDRV_LOG(ERR, \"failed to match addr to rte_device\");\n+\t\t\tret = -err;\n+\t\t\tgoto exit;\n+\t\t}\n+\t\tdevx_bdf_devs++;\n+\t}\n+exit:\n+\tmlx5_glue->free_device_list(orig_devx_bdf_devs);\n+\treturn devx_ctx_match;\n+}\ndiff --git a/drivers/common/mlx5/windows/mlx5_common_os.h b/drivers/common/mlx5/windows/mlx5_common_os.h\nindex 3756e1959b..c3d74d3b67 100644\n--- a/drivers/common/mlx5/windows/mlx5_common_os.h\n+++ b/drivers/common/mlx5/windows/mlx5_common_os.h\n@@ -261,4 +261,6 @@ int mlx5_os_reg_mr(void *pd,\n \t\t void *addr, size_t length, struct mlx5_pmd_mr *pmd_mr);\n __rte_internal\n void mlx5_os_dereg_mr(struct mlx5_pmd_mr *pmd_mr);\n+int mlx5_os_match_devx_devices_to_addr(struct devx_device_bdf *devx_bdf,\n+\t\t\t\tstruct rte_pci_addr *addr);\n #endif /* RTE_PMD_MLX5_COMMON_OS_H_ */\ndiff --git a/drivers/net/mlx5/windows/mlx5_os.c b/drivers/net/mlx5/windows/mlx5_os.c\nindex 26fa927039..9dea6d639e 100644\n--- a/drivers/net/mlx5/windows/mlx5_os.c\n+++ b/drivers/net/mlx5/windows/mlx5_os.c\n@@ -901,68 +901,6 @@ mlx5_os_set_allmulti(struct rte_eth_dev *dev, int enable)\n \treturn -ENOTSUP;\n }\n \n-/**\n- * Detect if a devx_device_bdf object has identical DBDF values to the\n- * rte_pci_addr found in bus/pci probing\n- *\n- * @param[in] devx_bdf\n- * Pointer to the devx_device_bdf structure.\n- * @param[in] addr\n- * Pointer to the rte_pci_addr structure.\n- *\n- * @return\n- * 1 on Device match, 0 on mismatch.\n- */\n-static int\n-mlx5_match_devx_bdf_to_addr(struct devx_device_bdf *devx_bdf,\n-\t\t\t struct rte_pci_addr *addr)\n-{\n-\tif (addr->domain != (devx_bdf->bus_id >> 8) ||\n-\t addr->bus != (devx_bdf->bus_id & 0xff) ||\n-\t addr->devid != devx_bdf->dev_id ||\n-\t addr->function != devx_bdf->fnc_id) {\n-\t\treturn 0;\n-\t}\n-\treturn 1;\n-}\n-\n-/**\n- * Detect if a devx_device_bdf object matches the rte_pci_addr\n- * found in bus/pci probing\n- * Compare both the Native/PF BDF and the raw_bdf representing a VF BDF.\n- *\n- * @param[in] devx_bdf\n- * Pointer to the devx_device_bdf structure.\n- * @param[in] addr\n- * Pointer to the rte_pci_addr structure.\n- *\n- * @return\n- * 1 on Device match, 0 on mismatch, rte_errno code on failure.\n- */\n-static int\n-mlx5_match_devx_devices_to_addr(struct devx_device_bdf *devx_bdf,\n-\t\t\t\tstruct rte_pci_addr *addr)\n-{\n-\tint err;\n-\tstruct devx_device mlx5_dev;\n-\n-\tif (mlx5_match_devx_bdf_to_addr(devx_bdf, addr))\n-\t\treturn 1;\n-\t/**\n-\t * Didn't match on Native/PF BDF, could still\n-\t * Match a VF BDF, check it next\n-\t */\n-\terr = mlx5_glue->query_device(devx_bdf, &mlx5_dev);\n-\tif (err) {\n-\t\tDRV_LOG(ERR, \"query_device failed\");\n-\t\trte_errno = err;\n-\t\treturn rte_errno;\n-\t}\n-\tif (mlx5_match_devx_bdf_to_addr(&mlx5_dev.raw_bdf, addr))\n-\t\treturn 1;\n-\treturn 0;\n-}\n-\n /**\n * DPDK callback to register a PCI device.\n *\n@@ -1036,7 +974,7 @@ mlx5_os_net_probe(struct rte_device *dev)\n \tstruct devx_device_bdf *devx_bdf_match[ret + 1];\n \n \twhile (ret-- > 0) {\n-\t\terr = mlx5_match_devx_devices_to_addr(devx_bdf_devs,\n+\t\terr = mlx5_os_match_devx_devices_to_addr(devx_bdf_devs,\n \t\t &pci_dev->addr);\n \t\tif (!err) {\n \t\t\tdevx_bdf_devs++;\n", "prefixes": [ "RFC", "02/10" ] }