Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/98801/?format=api
{ "id": 98801, "url": "http://patches.dpdk.org/api/patches/98801/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210913181510.46058-4-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210913181510.46058-4-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20210913181510.46058-4-stephen@networkplumber.org", "date": "2021-09-13T18:15:01", "name": "[v8,03/12] bpf: allow self-xor operation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "10482a78f3e642bdc902dcad292990338c8607eb", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210913181510.46058-4-stephen@networkplumber.org/mbox/", "series": [ { "id": 18882, "url": "http://patches.dpdk.org/api/series/18882/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=18882", "date": "2021-09-13T18:14:58", "name": "Packet capture framework enhancements", "version": 8, "mbox": "http://patches.dpdk.org/series/18882/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/98801/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/98801/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0CE33A0C45;\n\tMon, 13 Sep 2021 20:15:32 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8E67F4014F;\n\tMon, 13 Sep 2021 20:15:21 +0200 (CEST)", "from mail-pj1-f41.google.com (mail-pj1-f41.google.com\n [209.85.216.41]) by mails.dpdk.org (Postfix) with ESMTP id 461D9410EC\n for <dev@dpdk.org>; Mon, 13 Sep 2021 20:15:17 +0200 (CEST)", "by mail-pj1-f41.google.com with SMTP id\n lb1-20020a17090b4a4100b001993f863df2so655929pjb.5\n for <dev@dpdk.org>; Mon, 13 Sep 2021 11:15:17 -0700 (PDT)", "from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123])\n by smtp.gmail.com with ESMTPSA id b10sm7616888pfl.220.2021.09.13.11.15.15\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 13 Sep 2021 11:15:15 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=B2uAon4cvKoOj+QnKe/KWMgPSrjtWc91Ug3S5m+/n+k=;\n b=Btx666vU6QKoEMBocsQm4RbSnFxqP00cUNtL1xIwzqhOPVXQFGy2WjylJ2/PeABnl6\n YjMTIw6LlBtdjQ7cbxqmRrsHq8xsj7bYzF+fEhlD28r/m2U+exxJMsWIbsjjioMoJLHy\n RV3pZNpeb9Ta9wD5hziPq59dAT7RnVwfufVYy5ZTFeAiTCCopUBYCj88hsboBUDTe/WU\n W1si6RfV/yrK1QGRYi5GAahtjvfeGlSG9RWOXqp/CY+xFnoeGU3zQsHqVt5xyziWTXAC\n 8tUoYMSSr0gNh6ufRQ5Ipm3JRZl7OYYSeL/eWPiHtb3yIWYkUaB3D0aDqvuObGUQlwSi\n wm8w==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=B2uAon4cvKoOj+QnKe/KWMgPSrjtWc91Ug3S5m+/n+k=;\n b=wXbDT3wULYDyyUBPohPZ9LLNMFU2cBiV9DHg9TaYaxmTj9TX4ELuiycTYTRfKK4Ae3\n ytX/mihmZMw6iXHzdy5oz+QbQ7e4WHOLnv0JZSWdPEZ6qFRklLvHzQwPVNgWj1Nw/DKt\n auwr+/Uuve4upv87LDRf+Ja9XIkkmI1+91gIFnJOVpMPJx+SgrpkZ5l5Y3L93X+djCxC\n L6Weti7nRZspv3aWCmNTC3DgYQvzSAfw/Ej/z1fT47teIL+RWHg6Lq5Uhwdql1CALwOw\n Z2q8433B59wBPmhPIIhRauo6+JMDJvIbWZCa8w5A3B2gVHgV8LaLl1sshvn+d1gaS2gV\n ovkA==", "X-Gm-Message-State": "AOAM532FqjmFGRBpfCdmeJGRXqu7BL+pBg7hjPW4GN8wwczJ523R7rcU\n e82/9uTfpbxxWyxEq0VQahBc6IlNe22j/Q==", "X-Google-Smtp-Source": "\n ABdhPJzfXMlt9o4K1e/GTDZPd133hnKDJ8d7OAZxHrGYSnJlkQkmBnUNRWCLE58ZDKLT/MjmWkPLMQ==", "X-Received": "by 2002:a17:903:102:b0:13a:66a8:f28 with SMTP id\n y2-20020a170903010200b0013a66a80f28mr11573775plc.62.1631556916102;\n Mon, 13 Sep 2021 11:15:16 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Mon, 13 Sep 2021 11:15:01 -0700", "Message-Id": "<20210913181510.46058-4-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210913181510.46058-1-stephen@networkplumber.org>", "References": "<20210903004732.109023-1-stephen@networkplumber.org>\n <20210913181510.46058-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v8 03/12] bpf: allow self-xor operation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When doing BPF filter program conversion, a common way\nto zero a register in single instruction is:\n xor r7,r7\nThe BPF validator would not allow this because the value of\nr7 was undefined. But after this operation it always zero.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/bpf/bpf_validate.c | 8 ++++++--\n 1 file changed, 6 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/bpf/bpf_validate.c b/lib/bpf/bpf_validate.c\nindex 7b1291b382e9..7647a7454dc2 100644\n--- a/lib/bpf/bpf_validate.c\n+++ b/lib/bpf/bpf_validate.c\n@@ -661,8 +661,12 @@ eval_alu(struct bpf_verifier *bvf, const struct ebpf_insn *ins)\n \n \top = BPF_OP(ins->code);\n \n-\terr = eval_defined((op != EBPF_MOV) ? rd : NULL,\n-\t\t\t(op != BPF_NEG) ? &rs : NULL);\n+\t/* Allow self-xor as way to zero register */\n+\tif (op == BPF_XOR && ins->src_reg == ins->dst_reg)\n+\t\terr = NULL;\n+\telse\n+\t\terr = eval_defined((op != EBPF_MOV) ? rd : NULL,\n+\t\t\t\t (op != BPF_NEG) ? &rs : NULL);\n \tif (err != NULL)\n \t\treturn err;\n \n", "prefixes": [ "v8", "03/12" ] }