Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/98662/?format=api
{ "id": 98662, "url": "http://patches.dpdk.org/api/patches/98662/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210910165346.807715-1-pablo.de.lara.guarch@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210910165346.807715-1-pablo.de.lara.guarch@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210910165346.807715-1-pablo.de.lara.guarch@intel.com", "date": "2021-09-10T16:53:46", "name": "efd: change data type of parameter", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "47abb5d04a29abeed070875646fed5a149dc77dd", "submitter": { "id": 9, "url": "http://patches.dpdk.org/api/people/9/?format=api", "name": "De Lara Guarch, Pablo", "email": "pablo.de.lara.guarch@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210910165346.807715-1-pablo.de.lara.guarch@intel.com/mbox/", "series": [ { "id": 18844, "url": "http://patches.dpdk.org/api/series/18844/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=18844", "date": "2021-09-10T16:53:46", "name": "efd: change data type of parameter", "version": 1, "mbox": "http://patches.dpdk.org/series/18844/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/98662/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/98662/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E9760A0547;\n\tFri, 10 Sep 2021 18:53:58 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6C9EF4068C;\n\tFri, 10 Sep 2021 18:53:58 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by mails.dpdk.org (Postfix) with ESMTP id AC6F14067E\n for <dev@dpdk.org>; Fri, 10 Sep 2021 18:53:56 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Sep 2021 09:53:55 -0700", "from silpixa00401162.ir.intel.com ([10.55.128.50])\n by FMSMGA003.fm.intel.com with ESMTP; 10 Sep 2021 09:53:54 -0700" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10103\"; a=\"306686238\"", "E=Sophos;i=\"5.85,283,1624345200\"; d=\"scan'208\";a=\"306686238\"", "E=Sophos;i=\"5.85,283,1624345200\"; d=\"scan'208\";a=\"540691164\"" ], "X-ExtLoop1": "1", "From": "Pablo de Lara <pablo.de.lara.guarch@intel.com>", "To": "yipeng1.wang@intel.com,\n\tbyron.marohn@intel.com", "Cc": "dev@dpdk.org,\n\tPablo de Lara <pablo.de.lara.guarch@intel.com>", "Date": "Fri, 10 Sep 2021 16:53:46 +0000", "Message-Id": "<20210910165346.807715-1-pablo.de.lara.guarch@intel.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] efd: change data type of parameter", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "rte_efd_create() function was using uint8_t for a socket bitmask,\nfor one of its parameters.\nThis limits the maximum of NUMA sockets to be 8.\nChanging to to uint64_t increases it to 64, which should be\nmore future-proof.\n\nCoverity issue: 366390\nFixes: 56b6ef874f8 (\"efd: new Elastic Flow Distributor library\")\n\nSigned-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\n---\n\nThis fix requires an API breakage and therefore it is not\na good candidate for backporting (besides, it is a very low impact bug).\nHence, I am not CC'ing stable.\n\n---\n\n lib/efd/rte_efd.c | 2 +-\n lib/efd/rte_efd.h | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/efd/rte_efd.c b/lib/efd/rte_efd.c\nindex 77f46809f8..68a2378e88 100644\n--- a/lib/efd/rte_efd.c\n+++ b/lib/efd/rte_efd.c\n@@ -495,7 +495,7 @@ efd_search_hash(struct rte_efd_table * const table,\n \n struct rte_efd_table *\n rte_efd_create(const char *name, uint32_t max_num_rules, uint32_t key_len,\n-\t\tuint8_t online_cpu_socket_bitmask, uint8_t offline_cpu_socket)\n+\t\tuint64_t online_cpu_socket_bitmask, uint8_t offline_cpu_socket)\n {\n \tstruct rte_efd_table *table = NULL;\n \tuint8_t *key_array = NULL;\ndiff --git a/lib/efd/rte_efd.h b/lib/efd/rte_efd.h\nindex c2be4c09ae..d3d7befd0c 100644\n--- a/lib/efd/rte_efd.h\n+++ b/lib/efd/rte_efd.h\n@@ -139,7 +139,7 @@ typedef uint16_t efd_hashfunc_t;\n */\n struct rte_efd_table *\n rte_efd_create(const char *name, uint32_t max_num_rules, uint32_t key_len,\n-\tuint8_t online_cpu_socket_bitmask, uint8_t offline_cpu_socket);\n+\tuint64_t online_cpu_socket_bitmask, uint8_t offline_cpu_socket);\n \n /**\n * Releases the resources from an EFD table\n", "prefixes": [] }