Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/98372/?format=api
{ "id": 98372, "url": "http://patches.dpdk.org/api/patches/98372/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/5a95b25b81e7ee57edfdcea73b9266bc8dae8d77.1631120194.git.gmuthukrishn@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<5a95b25b81e7ee57edfdcea73b9266bc8dae8d77.1631120194.git.gmuthukrishn@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/5a95b25b81e7ee57edfdcea73b9266bc8dae8d77.1631120194.git.gmuthukrishn@marvell.com", "date": "2021-09-08T17:03:07", "name": "[v7,5/6] telemetry: fix json output buffer size", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "14ee20245a46be27e14df168b7966f301426c785", "submitter": { "id": 2301, "url": "http://patches.dpdk.org/api/people/2301/?format=api", "name": "Gowrishankar Muthukrishnan", "email": "gmuthukrishn@marvell.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/5a95b25b81e7ee57edfdcea73b9266bc8dae8d77.1631120194.git.gmuthukrishn@marvell.com/mbox/", "series": [ { "id": 18768, "url": "http://patches.dpdk.org/api/series/18768/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=18768", "date": "2021-09-08T17:03:03", "name": "cnxk: enable telemetry endpoints", "version": 7, "mbox": "http://patches.dpdk.org/series/18768/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/98372/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/98372/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1DB8BA0C5C;\n\tWed, 8 Sep 2021 19:04:02 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B106B4115F;\n\tWed, 8 Sep 2021 19:03:41 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 20CE440E25\n for <dev@dpdk.org>; Wed, 8 Sep 2021 19:03:39 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id\n 1889U311031640;\n Wed, 8 Sep 2021 10:03:39 -0700", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0a-0016f401.pphosted.com with ESMTP id 3axtka9vra-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Wed, 08 Sep 2021 10:03:39 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Wed, 8 Sep 2021 10:03:37 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.18 via Frontend\n Transport; Wed, 8 Sep 2021 10:03:37 -0700", "from localhost.localdomain (unknown [10.28.34.38])\n by maili.marvell.com (Postfix) with ESMTP id DD27E3F70C6;\n Wed, 8 Sep 2021 10:03:33 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=fjKTdMuNSupIJnNLPZj/CXfUFAFzqBcavyDQXWDdYAs=;\n b=DT7ras0CtKl7RWRcExTX6Mk+iDg7p1UdiZWdJuXtu8923QDRKP6oyItu1a+3dPj5QQ7f\n RJY3uP6AKDj51qF1Gb5kR68xkMyL+o0B6DujfLSvFPul5C/XOCgGPRVebTOV2kWgzHpg\n SORBR5y41xAjFBuNu4NY48ZT3NZ5dD9g8UoPGfRwcl0cI3FoZ42QrjVc8KqJ1weG1896\n UyNw6xFvI9NgGOQCSrd6NcXGEPBw7nGFVuxrGq5KcgCeUpk9lNatssU6DlAJino98uSh\n JYrqArxETJ74LOZDGwG/OF8wWBGhzdZKp1NaMV9oEPUY8XPl39/zhtODwm7TlQh+BLF7 TA==", "From": "Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>", "To": "<dev@dpdk.org>", "CC": "<bruce.richardson@intel.com>, <ciara.power@intel.com>,\n <jerinj@marvell.com>, <kirankumark@marvell.com>,\n <ndabilpuram@marvell.com>, <skori@marvell.com>,\n <skoteshwar@marvell.com>, <asekhar@marvell.com>,\n <pbhagavatula@marvell.com>, <anoobj@marvell.com>,\n <adwivedi@marvell.com>, <ktejasree@marvell.com>, Gowrishankar Muthukrishnan\n <gmuthukrishn@marvell.com>", "Date": "Wed, 8 Sep 2021 22:33:07 +0530", "Message-ID": "\n <5a95b25b81e7ee57edfdcea73b9266bc8dae8d77.1631120194.git.gmuthukrishn@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<cover.1631120194.git.gmuthukrishn@marvell.com>", "References": "<cover.1631120194.git.gmuthukrishn@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-GUID": "2LB2AGu8PySMZzZjsFurVzCw99t_RSVL", "X-Proofpoint-ORIG-GUID": "2LB2AGu8PySMZzZjsFurVzCw99t_RSVL", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475\n definitions=2021-09-08_06,2021-09-07_02,2020-04-07_01", "Subject": "[dpdk-dev] [v7, 5/6] telemetry: fix json output buffer size", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Fix json output buffer size for a single largest value.\n\nFixes: 52af6ccb2b39 (\"telemetry: add utility functions for creating JSON\")\n\nSigned-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>\nChange-Id: Ida314114b654b5085244a659eb08b22969339856\n---\n lib/telemetry/telemetry_json.h | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/telemetry/telemetry_json.h b/lib/telemetry/telemetry_json.h\nindex ad270b9b30..ba2fde34cb 100644\n--- a/lib/telemetry/telemetry_json.h\n+++ b/lib/telemetry/telemetry_json.h\n@@ -9,6 +9,7 @@\n #include <stdarg.h>\n #include <stdio.h>\n #include <rte_common.h>\n+#include <rte_telemetry.h>\n \n /**\n * @file\n@@ -23,13 +24,15 @@\n * @internal\n * Copies a value into a buffer if the buffer has enough available space.\n * Nothing written to buffer if an overflow ocurs.\n- * This function is not for use for values larger than 1k.\n+ * Size of buffer is (single largest value - 6), where at least 6 chars\n+ * would have been used for creating json dict i.e '{\"x\": ... }'.\n+ * This function is not for use for values larger than this buffer size.\n */\n __rte_format_printf(3, 4)\n static inline int\n __json_snprintf(char *buf, const int len, const char *format, ...)\n {\n-\tchar tmp[1024];\n+\tchar tmp[RTE_TEL_MAX_SINGLE_STRING_LEN - 6];\n \tva_list ap;\n \tint ret;\n \n", "prefixes": [ "v7", "5/6" ] }