Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/98324/?format=api
{ "id": 98324, "url": "http://patches.dpdk.org/api/patches/98324/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210908103016.1661914-10-kevin.laatz@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210908103016.1661914-10-kevin.laatz@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210908103016.1661914-10-kevin.laatz@intel.com", "date": "2021-09-08T10:30:08", "name": "[v3,09/17] dma/idxd: add start and stop functions for pci devices", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "34279b16eba9baa413c23af5c261bd7f39bf6f5e", "submitter": { "id": 921, "url": "http://patches.dpdk.org/api/people/921/?format=api", "name": "Kevin Laatz", "email": "kevin.laatz@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210908103016.1661914-10-kevin.laatz@intel.com/mbox/", "series": [ { "id": 18762, "url": "http://patches.dpdk.org/api/series/18762/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=18762", "date": "2021-09-08T10:29:59", "name": "add dmadev driver for idxd devices", "version": 3, "mbox": "http://patches.dpdk.org/series/18762/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/98324/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/98324/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E1CA7A0C56;\n\tWed, 8 Sep 2021 12:31:19 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E752B411CE;\n\tWed, 8 Sep 2021 12:30:40 +0200 (CEST)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n by mails.dpdk.org (Postfix) with ESMTP id 26AB7411BA\n for <dev@dpdk.org>; Wed, 8 Sep 2021 12:30:38 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 08 Sep 2021 03:30:37 -0700", "from silpixa00401122.ir.intel.com ([10.55.128.10])\n by orsmga001.jf.intel.com with ESMTP; 08 Sep 2021 03:30:36 -0700" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10100\"; a=\"281461961\"", "E=Sophos;i=\"5.85,277,1624345200\"; d=\"scan'208\";a=\"281461961\"", "E=Sophos;i=\"5.85,277,1624345200\"; d=\"scan'208\";a=\"513213883\"" ], "X-ExtLoop1": "1", "From": "Kevin Laatz <kevin.laatz@intel.com>", "To": "dev@dpdk.org", "Cc": "bruce.richardson@intel.com, fengchengwen@huawei.com, jerinj@marvell.com,\n conor.walsh@intel.com, Kevin Laatz <kevin.laatz@intel.com>", "Date": "Wed, 8 Sep 2021 10:30:08 +0000", "Message-Id": "<20210908103016.1661914-10-kevin.laatz@intel.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210908103016.1661914-1-kevin.laatz@intel.com>", "References": "<20210903105001.1179328-1-kevin.laatz@intel.com>\n <20210908103016.1661914-1-kevin.laatz@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 09/17] dma/idxd: add start and stop functions\n for pci devices", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add device start/stop functions for DSA devices bound to vfio. For devices\nbound to the IDXD kernel driver, these are not required since the IDXD\nkernel driver takes care of this.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nSigned-off-by: Kevin Laatz <kevin.laatz@intel.com>\n---\n drivers/dma/idxd/idxd_pci.c | 52 +++++++++++++++++++++++++++++++++++++\n 1 file changed, 52 insertions(+)", "diff": "diff --git a/drivers/dma/idxd/idxd_pci.c b/drivers/dma/idxd/idxd_pci.c\nindex 569df8d04c..3c0e3086f7 100644\n--- a/drivers/dma/idxd/idxd_pci.c\n+++ b/drivers/dma/idxd/idxd_pci.c\n@@ -59,11 +59,63 @@ idxd_is_wq_enabled(struct idxd_dmadev *idxd)\n \treturn ((state >> WQ_STATE_SHIFT) & WQ_STATE_MASK) == 0x1;\n }\n \n+static int\n+idxd_pci_dev_stop(struct rte_dmadev *dev)\n+{\n+\tstruct idxd_dmadev *idxd = dev->dev_private;\n+\tuint8_t err_code;\n+\n+\tif (!idxd_is_wq_enabled(idxd)) {\n+\t\tIDXD_PMD_ERR(\"Work queue %d already disabled\", idxd->qid);\n+\t\treturn -EALREADY;\n+\t}\n+\n+\terr_code = idxd_pci_dev_command(idxd, idxd_disable_wq);\n+\tif (err_code || idxd_is_wq_enabled(idxd)) {\n+\t\tIDXD_PMD_ERR(\"Failed disabling work queue %d, error code: %#x\",\n+\t\t\t\tidxd->qid, err_code);\n+\t\treturn -err_code;\n+\t}\n+\tIDXD_PMD_DEBUG(\"Work queue %d disabled OK\", idxd->qid);\n+\n+\treturn 0;\n+}\n+\n+static int\n+idxd_pci_dev_start(struct rte_dmadev *dev)\n+{\n+\tstruct idxd_dmadev *idxd = dev->dev_private;\n+\tuint8_t err_code;\n+\n+\tif (idxd_is_wq_enabled(idxd)) {\n+\t\tIDXD_PMD_WARN(\"WQ %d already enabled\", idxd->qid);\n+\t\treturn 0;\n+\t}\n+\n+\tif (idxd->desc_ring == NULL) {\n+\t\tIDXD_PMD_ERR(\"WQ %d has not been fully configured\", idxd->qid);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\terr_code = idxd_pci_dev_command(idxd, idxd_enable_wq);\n+\tif (err_code || !idxd_is_wq_enabled(idxd)) {\n+\t\tIDXD_PMD_ERR(\"Failed enabling work queue %d, error code: %#x\",\n+\t\t\t\tidxd->qid, err_code);\n+\t\treturn err_code == 0 ? -1 : err_code;\n+\t}\n+\n+\tIDXD_PMD_DEBUG(\"Work queue %d enabled OK\", idxd->qid);\n+\n+\treturn 0;\n+}\n+\n static const struct rte_dmadev_ops idxd_pci_ops = {\n \t.dev_dump = idxd_dump,\n \t.dev_configure = idxd_configure,\n \t.vchan_setup = idxd_vchan_setup,\n \t.dev_info_get = idxd_info_get,\n+\t.dev_start = idxd_pci_dev_start,\n+\t.dev_stop = idxd_pci_dev_stop,\n };\n \n /* each portal uses 4 x 4k pages */\n", "prefixes": [ "v3", "09/17" ] }