Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/98290/?format=api
{ "id": 98290, "url": "http://patches.dpdk.org/api/patches/98290/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210908083758.312055-11-jiawenwu@trustnetic.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210908083758.312055-11-jiawenwu@trustnetic.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210908083758.312055-11-jiawenwu@trustnetic.com", "date": "2021-09-08T08:37:36", "name": "[10/32] net/ngbe: support MTU set", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "9215ce9a4fe1a17d134f7bcf35c75dee5728bd86", "submitter": { "id": 1932, "url": "http://patches.dpdk.org/api/people/1932/?format=api", "name": "Jiawen Wu", "email": "jiawenwu@trustnetic.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210908083758.312055-11-jiawenwu@trustnetic.com/mbox/", "series": [ { "id": 18760, "url": "http://patches.dpdk.org/api/series/18760/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=18760", "date": "2021-09-08T08:37:26", "name": "net/ngbe: add many features", "version": 1, "mbox": "http://patches.dpdk.org/series/18760/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/98290/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/98290/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E09A3A0C56;\n\tWed, 8 Sep 2021 10:37:30 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C38CA411BA;\n\tWed, 8 Sep 2021 10:36:44 +0200 (CEST)", "from smtpbgsg2.qq.com (smtpbgsg2.qq.com [54.254.200.128])\n by mails.dpdk.org (Postfix) with ESMTP id 5B2E9411B0\n for <dev@dpdk.org>; Wed, 8 Sep 2021 10:36:43 +0200 (CEST)", "from wxdbg.localdomain.com (unknown [183.129.236.74])\n by esmtp6.qq.com (ESMTP) with\n id ; Wed, 08 Sep 2021 16:36:37 +0800 (CST)" ], "X-QQ-mid": "bizesmtp47t1631090198t5x4c5e6", "X-QQ-SSF": "01400000002000E0G000B00A0000000", "X-QQ-FEAT": "B65ZW1oC9L1yF7nMVSO/Di1REZbQFQor10MBC3iq0agOaBrAX61NamUMublA+\n xnJRDxvotlnxKpt7LJdM/4UMx1dTzycc7HoTRviO4oXC3UmY1WT2WLXx6NZ1fGnzo9MJYKJ\n d6fa4hOlZSshG0XB5917t0pwNVGbtWNS3gW5B9u3TQU6jgI9dbNsWEauCUKFRObThmH43iI\n LTyL6WFmxJq47AMlqZO8hcnJRjUzLSoQrXf8cLL2AeU2FpScsiGSNQA5IXhAFXoySMnL1W1\n 7TResPFFKQNeDUr/54S/VI+fYEc6goGMseyPNuaoFCh6PyFflSe3Dsk4l7htgED4WKmAbE7\n 9f8XsOI628JjpdhJj8c7eUFpNyo8uM76p9AR6ZX", "X-QQ-GoodBg": "2", "From": "Jiawen Wu <jiawenwu@trustnetic.com>", "To": "dev@dpdk.org", "Cc": "Jiawen Wu <jiawenwu@trustnetic.com>", "Date": "Wed, 8 Sep 2021 16:37:36 +0800", "Message-Id": "<20210908083758.312055-11-jiawenwu@trustnetic.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210908083758.312055-1-jiawenwu@trustnetic.com>", "References": "<20210908083758.312055-1-jiawenwu@trustnetic.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-QQ-SENDSIZE": "520", "Feedback-ID": "bizesmtp:trustnetic.com:qybgforeign:qybgforeign2", "X-QQ-Bgrelay": "1", "Subject": "[dpdk-dev] [PATCH 10/32] net/ngbe: support MTU set", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Support updating port MTU.\n\nSigned-off-by: Jiawen Wu <jiawenwu@trustnetic.com>\n---\n doc/guides/nics/features/ngbe.ini | 1 +\n drivers/net/ngbe/base/ngbe_type.h | 3 +++\n drivers/net/ngbe/ngbe_ethdev.c | 41 +++++++++++++++++++++++++++++++\n 3 files changed, 45 insertions(+)", "diff": "diff --git a/doc/guides/nics/features/ngbe.ini b/doc/guides/nics/features/ngbe.ini\nindex 42101020dd..bdb06916e1 100644\n--- a/doc/guides/nics/features/ngbe.ini\n+++ b/doc/guides/nics/features/ngbe.ini\n@@ -8,6 +8,7 @@ Speed capabilities = Y\n Link status = Y\n Link status event = Y\n Queue start/stop = Y\n+MTU update = Y\n Jumbo frame = Y\n Scattered Rx = Y\n TSO = Y\ndiff --git a/drivers/net/ngbe/base/ngbe_type.h b/drivers/net/ngbe/base/ngbe_type.h\nindex c13f0208fd..78fb0da7fa 100644\n--- a/drivers/net/ngbe/base/ngbe_type.h\n+++ b/drivers/net/ngbe/base/ngbe_type.h\n@@ -8,6 +8,7 @@\n \n #define NGBE_LINK_UP_TIME\t90 /* 9.0 Seconds */\n \n+#define NGBE_FRAME_SIZE_MAX (9728) /* Maximum frame size, +FCS */\n #define NGBE_FRAME_SIZE_DFT (1522) /* Default frame size, +FCS */\n #define NGBE_MAX_QP (8)\n \n@@ -316,6 +317,8 @@ struct ngbe_hw {\n \tu16 nb_rx_queues;\n \tu16 nb_tx_queues;\n \n+\tu32 mode;\n+\n \tu32 q_rx_regs[8 * 4];\n \tu32 q_tx_regs[8 * 4];\n \tbool offset_loaded;\ndiff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c\nindex 45d7c48011..29f35d9e8d 100644\n--- a/drivers/net/ngbe/ngbe_ethdev.c\n+++ b/drivers/net/ngbe/ngbe_ethdev.c\n@@ -1970,6 +1970,46 @@ ngbe_dev_interrupt_handler(void *param)\n \tngbe_dev_interrupt_action(dev);\n }\n \n+static int\n+ngbe_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)\n+{\n+\tstruct ngbe_hw *hw = ngbe_dev_hw(dev);\n+\tstruct rte_eth_dev_info dev_info;\n+\tuint32_t frame_size = mtu + RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN + 4;\n+\tstruct rte_eth_dev_data *dev_data = dev->data;\n+\tint ret;\n+\n+\tret = ngbe_dev_info_get(dev, &dev_info);\n+\tif (ret != 0)\n+\t\treturn ret;\n+\n+\t/* check that mtu is within the allowed range */\n+\tif (mtu < RTE_ETHER_MIN_MTU || frame_size > dev_info.max_rx_pktlen)\n+\t\treturn -EINVAL;\n+\n+\t/* If device is started, refuse mtu that requires the support of\n+\t * scattered packets when this feature has not been enabled before.\n+\t */\n+\tif (dev_data->dev_started && !dev_data->scattered_rx &&\n+\t (frame_size + 2 * NGBE_VLAN_TAG_SIZE >\n+\t dev->data->min_rx_buf_size - RTE_PKTMBUF_HEADROOM)) {\n+\t\tPMD_INIT_LOG(ERR, \"Stop port first.\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\t/* update max frame size */\n+\tdev->data->dev_conf.rxmode.max_rx_pkt_len = frame_size;\n+\n+\tif (hw->mode)\n+\t\twr32m(hw, NGBE_FRMSZ, NGBE_FRMSZ_MAX_MASK,\n+\t\t\tNGBE_FRAME_SIZE_MAX);\n+\telse\n+\t\twr32m(hw, NGBE_FRMSZ, NGBE_FRMSZ_MAX_MASK,\n+\t\t\tNGBE_FRMSZ_MAX(frame_size));\n+\n+\treturn 0;\n+}\n+\n /**\n * Set the IVAR registers, mapping interrupt causes to vectors\n * @param hw\n@@ -2078,6 +2118,7 @@ static const struct eth_dev_ops ngbe_eth_dev_ops = {\n \t.xstats_get_names = ngbe_dev_xstats_get_names,\n \t.xstats_get_names_by_id = ngbe_dev_xstats_get_names_by_id,\n \t.queue_stats_mapping_set = ngbe_dev_queue_stats_mapping_set,\n+\t.mtu_set = ngbe_dev_mtu_set,\n \t.vlan_offload_set = ngbe_vlan_offload_set,\n \t.rx_queue_start\t = ngbe_dev_rx_queue_start,\n \t.rx_queue_stop = ngbe_dev_rx_queue_stop,\n", "prefixes": [ "10/32" ] }