Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/98283/?format=api
{ "id": 98283, "url": "http://patches.dpdk.org/api/patches/98283/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210908083758.312055-4-jiawenwu@trustnetic.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210908083758.312055-4-jiawenwu@trustnetic.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210908083758.312055-4-jiawenwu@trustnetic.com", "date": "2021-09-08T08:37:29", "name": "[03/32] net/ngbe: support Rx checksum offload", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "f1a489458c365833ab191b4e6c49cb04213fa9c9", "submitter": { "id": 1932, "url": "http://patches.dpdk.org/api/people/1932/?format=api", "name": "Jiawen Wu", "email": "jiawenwu@trustnetic.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210908083758.312055-4-jiawenwu@trustnetic.com/mbox/", "series": [ { "id": 18760, "url": "http://patches.dpdk.org/api/series/18760/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=18760", "date": "2021-09-08T08:37:26", "name": "net/ngbe: add many features", "version": 1, "mbox": "http://patches.dpdk.org/series/18760/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/98283/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/98283/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 32D97A0C56;\n\tWed, 8 Sep 2021 10:36:40 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 43D8F41168;\n\tWed, 8 Sep 2021 10:36:33 +0200 (CEST)", "from smtpproxy21.qq.com (smtpbg704.qq.com [203.205.195.105])\n by mails.dpdk.org (Postfix) with ESMTP id 931654115A\n for <dev@dpdk.org>; Wed, 8 Sep 2021 10:36:29 +0200 (CEST)", "from wxdbg.localdomain.com (unknown [183.129.236.74])\n by esmtp6.qq.com (ESMTP) with\n id ; Wed, 08 Sep 2021 16:36:23 +0800 (CST)" ], "X-QQ-mid": "bizesmtp47t1631090184tpk0wdfu", "X-QQ-SSF": "01400000002000E0G000B00A0000000", "X-QQ-FEAT": "/+iK7ZpVlLSoN7ihk6pkb+oZSoDTTswnJJsJvw3v8sq2h2HchYtu6F/C+qigL\n LATScipOB23nOyQsyx7Nigxqe8xgBH6nQkrV9ql4PnuJyFa8Tv0SyYd66zHn+NANoed8aJ9\n fvGsOJB/KN+X9S/okbVWyllIa6mRzk2kkGF7Rlnc3uWjFpayz+Fuq+9OVvY6dT3C35FnNrS\n 8N9jQu6AiRbtdEN/fOewy46yQPCIG3Qfj3+AdxLcC2CFtQUV0gVOKXy5Zz0hEd0l95yKFCS\n C0AslkVPlEoX2GqoCvwmrYhN8wqKmgiAGzToZEkZAFsgA1wftwjcCSoVitfxC/e73XSePnD\n FyaPM2qjgBV4luu8gkQPGYfKb78HaFVdqod5GAK", "X-QQ-GoodBg": "2", "From": "Jiawen Wu <jiawenwu@trustnetic.com>", "To": "dev@dpdk.org", "Cc": "Jiawen Wu <jiawenwu@trustnetic.com>", "Date": "Wed, 8 Sep 2021 16:37:29 +0800", "Message-Id": "<20210908083758.312055-4-jiawenwu@trustnetic.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210908083758.312055-1-jiawenwu@trustnetic.com>", "References": "<20210908083758.312055-1-jiawenwu@trustnetic.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-QQ-SENDSIZE": "520", "Feedback-ID": "bizesmtp:trustnetic.com:qybgforeign:qybgforeign5", "X-QQ-Bgrelay": "1", "Subject": "[dpdk-dev] [PATCH 03/32] net/ngbe: support Rx checksum offload", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Support IP/L4 checksum on Rx, and convert it to mbuf flags.\n\nSigned-off-by: Jiawen Wu <jiawenwu@trustnetic.com>\n---\n doc/guides/nics/features/ngbe.ini | 2 +\n doc/guides/nics/ngbe.rst | 1 +\n drivers/net/ngbe/ngbe_rxtx.c | 75 +++++++++++++++++++++++++++++--\n 3 files changed, 75 insertions(+), 3 deletions(-)", "diff": "diff --git a/doc/guides/nics/features/ngbe.ini b/doc/guides/nics/features/ngbe.ini\nindex f85754eb7a..2777ed5a62 100644\n--- a/doc/guides/nics/features/ngbe.ini\n+++ b/doc/guides/nics/features/ngbe.ini\n@@ -9,6 +9,8 @@ Link status = Y\n Link status event = Y\n Queue start/stop = Y\n Scattered Rx = Y\n+L3 checksum offload = P\n+L4 checksum offload = P\n Packet type parsing = Y\n Multiprocess aware = Y\n Linux = Y\ndiff --git a/doc/guides/nics/ngbe.rst b/doc/guides/nics/ngbe.rst\nindex 463452ce8c..0a14252ff2 100644\n--- a/doc/guides/nics/ngbe.rst\n+++ b/doc/guides/nics/ngbe.rst\n@@ -12,6 +12,7 @@ Features\n --------\n \n - Packet type information\n+- Checksum offload\n - Link state information\n - Scattered for RX\n \ndiff --git a/drivers/net/ngbe/ngbe_rxtx.c b/drivers/net/ngbe/ngbe_rxtx.c\nindex 49fa978853..1661ecafa5 100644\n--- a/drivers/net/ngbe/ngbe_rxtx.c\n+++ b/drivers/net/ngbe/ngbe_rxtx.c\n@@ -263,6 +263,31 @@ ngbe_rxd_pkt_info_to_pkt_type(uint32_t pkt_info, uint16_t ptid_mask)\n \treturn ngbe_decode_ptype(ptid);\n }\n \n+static inline uint64_t\n+rx_desc_error_to_pkt_flags(uint32_t rx_status)\n+{\n+\tuint64_t pkt_flags = 0;\n+\n+\t/* checksum offload can't be disabled */\n+\tif (rx_status & NGBE_RXD_STAT_IPCS) {\n+\t\tpkt_flags |= (rx_status & NGBE_RXD_ERR_IPCS\n+\t\t\t\t? PKT_RX_IP_CKSUM_BAD : PKT_RX_IP_CKSUM_GOOD);\n+\t}\n+\n+\tif (rx_status & NGBE_RXD_STAT_L4CS) {\n+\t\tpkt_flags |= (rx_status & NGBE_RXD_ERR_L4CS\n+\t\t\t\t? PKT_RX_L4_CKSUM_BAD : PKT_RX_L4_CKSUM_GOOD);\n+\t}\n+\n+\tif (rx_status & NGBE_RXD_STAT_EIPCS &&\n+\t rx_status & NGBE_RXD_ERR_EIPCS) {\n+\t\tpkt_flags |= PKT_RX_OUTER_IP_CKSUM_BAD;\n+\t}\n+\n+\n+\treturn pkt_flags;\n+}\n+\n /*\n * LOOK_AHEAD defines how many desc statuses to check beyond the\n * current descriptor.\n@@ -281,6 +306,7 @@ ngbe_rx_scan_hw_ring(struct ngbe_rx_queue *rxq)\n \tstruct ngbe_rx_entry *rxep;\n \tstruct rte_mbuf *mb;\n \tuint16_t pkt_len;\n+\tuint64_t pkt_flags;\n \tint nb_dd;\n \tuint32_t s[LOOK_AHEAD];\n \tuint32_t pkt_info[LOOK_AHEAD];\n@@ -325,6 +351,9 @@ ngbe_rx_scan_hw_ring(struct ngbe_rx_queue *rxq)\n \t\t\tmb->data_len = pkt_len;\n \t\t\tmb->pkt_len = pkt_len;\n \n+\t\t\t/* convert descriptor fields to rte mbuf flags */\n+\t\t\tpkt_flags = rx_desc_error_to_pkt_flags(s[j]);\n+\t\t\tmb->ol_flags = pkt_flags;\n \t\t\tmb->packet_type =\n \t\t\t\tngbe_rxd_pkt_info_to_pkt_type(pkt_info[j],\n \t\t\t\trxq->pkt_type_mask);\n@@ -519,6 +548,7 @@ ngbe_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,\n \tuint16_t rx_id;\n \tuint16_t nb_rx;\n \tuint16_t nb_hold;\n+\tuint64_t pkt_flags;\n \n \tnb_rx = 0;\n \tnb_hold = 0;\n@@ -611,11 +641,14 @@ ngbe_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,\n \n \t\t/*\n \t\t * Initialize the returned mbuf.\n-\t\t * setup generic mbuf fields:\n+\t\t * 1) setup generic mbuf fields:\n \t\t * - number of segments,\n \t\t * - next segment,\n \t\t * - packet length,\n \t\t * - Rx port identifier.\n+\t\t * 2) integrate hardware offload data, if any:\n+\t\t * - IP checksum flag,\n+\t\t * - error flags.\n \t\t */\n \t\tpkt_len = (uint16_t)(rte_le_to_cpu_16(rxd.qw1.hi.len));\n \t\trxm->data_off = RTE_PKTMBUF_HEADROOM;\n@@ -627,6 +660,8 @@ ngbe_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,\n \t\trxm->port = rxq->port_id;\n \n \t\tpkt_info = rte_le_to_cpu_32(rxd.qw0.dw0);\n+\t\tpkt_flags = rx_desc_error_to_pkt_flags(staterr);\n+\t\trxm->ol_flags = pkt_flags;\n \t\trxm->packet_type = ngbe_rxd_pkt_info_to_pkt_type(pkt_info,\n \t\t\t\t\t\t rxq->pkt_type_mask);\n \n@@ -663,16 +698,30 @@ ngbe_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,\n \treturn nb_rx;\n }\n \n+/**\n+ * ngbe_fill_cluster_head_buf - fill the first mbuf of the returned packet\n+ *\n+ * Fill the following info in the HEAD buffer of the Rx cluster:\n+ * - RX port identifier\n+ * - hardware offload data, if any:\n+ * - IP checksum flag\n+ * - error flags\n+ * @head HEAD of the packet cluster\n+ * @desc HW descriptor to get data from\n+ * @rxq Pointer to the Rx queue\n+ */\n static inline void\n ngbe_fill_cluster_head_buf(struct rte_mbuf *head, struct ngbe_rx_desc *desc,\n \t\tstruct ngbe_rx_queue *rxq, uint32_t staterr)\n {\n \tuint32_t pkt_info;\n+\tuint64_t pkt_flags;\n \n-\tRTE_SET_USED(staterr);\n \thead->port = rxq->port_id;\n \n \tpkt_info = rte_le_to_cpu_32(desc->qw0.dw0);\n+\tpkt_flags = rx_desc_error_to_pkt_flags(staterr);\n+\thead->ol_flags = pkt_flags;\n \thead->packet_type = ngbe_rxd_pkt_info_to_pkt_type(pkt_info,\n \t\t\t\t\t\trxq->pkt_type_mask);\n }\n@@ -1257,7 +1306,14 @@ ngbe_reset_rx_queue(struct ngbe_adapter *adapter, struct ngbe_rx_queue *rxq)\n uint64_t\n ngbe_get_rx_port_offloads(struct rte_eth_dev *dev __rte_unused)\n {\n-\treturn DEV_RX_OFFLOAD_SCATTER;\n+\tuint64_t offloads;\n+\n+\toffloads = DEV_RX_OFFLOAD_IPV4_CKSUM |\n+\t\t DEV_RX_OFFLOAD_UDP_CKSUM |\n+\t\t DEV_RX_OFFLOAD_TCP_CKSUM |\n+\t\t DEV_RX_OFFLOAD_SCATTER;\n+\n+\treturn offloads;\n }\n \n int\n@@ -1525,6 +1581,7 @@ ngbe_dev_rx_init(struct rte_eth_dev *dev)\n \tuint32_t fctrl;\n \tuint32_t hlreg0;\n \tuint32_t srrctl;\n+\tuint32_t rxcsum;\n \tuint16_t buf_size;\n \tuint16_t i;\n \tstruct rte_eth_rxmode *rx_conf = &dev->data->dev_conf.rxmode;\n@@ -1586,6 +1643,18 @@ ngbe_dev_rx_init(struct rte_eth_dev *dev)\n \n \tif (rx_conf->offloads & DEV_RX_OFFLOAD_SCATTER)\n \t\tdev->data->scattered_rx = 1;\n+\t/*\n+\t * Setup the Checksum Register.\n+\t * Enable IP/L4 checksum computation by hardware if requested to do so.\n+\t */\n+\trxcsum = rd32(hw, NGBE_PSRCTL);\n+\trxcsum |= NGBE_PSRCTL_PCSD;\n+\tif (rx_conf->offloads & DEV_RX_OFFLOAD_CHECKSUM)\n+\t\trxcsum |= NGBE_PSRCTL_L4CSUM;\n+\telse\n+\t\trxcsum &= ~NGBE_PSRCTL_L4CSUM;\n+\n+\twr32(hw, NGBE_PSRCTL, rxcsum);\n \n \tngbe_set_rx_function(dev);\n \n", "prefixes": [ "03/32" ] }