Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 97877,
    "url": "http://patches.dpdk.org/api/patches/97877/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210903080203.2495559-1-fengli@smartx.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20210903080203.2495559-1-fengli@smartx.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20210903080203.2495559-1-fengli@smartx.com",
    "date": "2021-09-03T08:02:03",
    "name": "[v2] vhost: call destroy_device always in vhost_destroy_device_notify",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "7728e080000a768ccbd660dc153b177ea72c7de9",
    "submitter": {
        "id": 1528,
        "url": "http://patches.dpdk.org/api/people/1528/?format=api",
        "name": "Li Feng",
        "email": "fengli@smartx.com"
    },
    "delegate": {
        "id": 2642,
        "url": "http://patches.dpdk.org/api/users/2642/?format=api",
        "username": "mcoquelin",
        "first_name": "Maxime",
        "last_name": "Coquelin",
        "email": "maxime.coquelin@redhat.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210903080203.2495559-1-fengli@smartx.com/mbox/",
    "series": [
        {
            "id": 18654,
            "url": "http://patches.dpdk.org/api/series/18654/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=18654",
            "date": "2021-09-03T08:02:03",
            "name": "[v2] vhost: call destroy_device always in vhost_destroy_device_notify",
            "version": 2,
            "mbox": "http://patches.dpdk.org/series/18654/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/97877/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/97877/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E1EA1A0C53;\n\tFri,  3 Sep 2021 10:02:37 +0200 (CEST)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9E3B640DDE;\n\tFri,  3 Sep 2021 10:02:37 +0200 (CEST)",
            "from mail-pl1-f170.google.com (mail-pl1-f170.google.com\n [209.85.214.170])\n by mails.dpdk.org (Postfix) with ESMTP id 35020406B4\n for <dev@dpdk.org>; Fri,  3 Sep 2021 10:02:37 +0200 (CEST)",
            "by mail-pl1-f170.google.com with SMTP id v1so2828327plo.10\n for <dev@dpdk.org>; Fri, 03 Sep 2021 01:02:37 -0700 (PDT)",
            "from 64-217.smartx.com ([103.97.201.35])\n by smtp.gmail.com with ESMTPSA id m18sm4440185pjq.32.2021.09.03.01.02.34\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 03 Sep 2021 01:02:35 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=smartx-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=URjY6EGfy5vUH5isjj9TxyREO3N35SI0gOkkEPhfNk4=;\n b=xQlKvjpiAyf/7lz4+LXLFs9CmGpPl+vWngjWa4MYigcnUYXYEbDiBE+OUopw5djoUI\n mnpr2peF6BTSIY946/q29yX/82HPSKe5w3do7X+dkv4WVhx+JJD5KEiH+DmhTj4dweWp\n +CUtfxz7T0dQNbNPQ6Ro8EQfjubYiqQr0COUOJq7G8BWm0P2ksPa9mAcl6CIEbIN/E+N\n 8crDNKmtwEBRddwzRi4mbc7C6lN9D2UyWw1q6j88WM9YAQ6SFBDf1yh8pcjcyeroA721\n +9OH/d/vG4bHhy48EKZeCwlDhpLpnQ78pwpJJdOVCnooXi2dDK0gUm0g9foWCamlYWWN\n 1VIg==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=URjY6EGfy5vUH5isjj9TxyREO3N35SI0gOkkEPhfNk4=;\n b=jk1DeW1keKVxV70y2RaiCl2PxvK+qWTXrMsEVrcwDt5LCVyO0tjMK4FX8LfELIJ42g\n bO2cT0DYqGHGKghhbrJU9jT3+8yr2He81SIbyUkf0nkjpWoGl1Z/yBWsdmvQHve6PC31\n Yiw9Vn36UVdA8izpERm4Nj2xVLXiYlaA1tZ8wGg9aQAg75tlR91/DFwcMpyxzQXKC1+2\n +bK4h9CyT1e72cYZWVI4MfbghwjVyzPoIxC13sHsoE6P9RcQzJUEgqONtgLghEA4URMy\n iZn3bUPSDasmkQZbnhlV483HxR5cFX4W+FKlBzDkoinQ5QnEJXDbypXmaNc4gQlee8Sd\n aqBg==",
        "X-Gm-Message-State": "AOAM531pdtKr0TuvCJsQoueFZwHGxq1R5dfYwCeL/bguAMsSz1+VIzq0\n v0Y8PemfIXA20TzvMH8uygZTop8IdnnIW3WpJyA=",
        "X-Google-Smtp-Source": "\n ABdhPJyCJfpFcKd/EvDMijQMbTO5NX3R3s6Svi4UtZ2pknmcAYuxUTylENg48bHPLQLJ1+Mdy8Qj8Q==",
        "X-Received": "by 2002:a17:90a:a092:: with SMTP id\n r18mr8837340pjp.175.1630656156263;\n Fri, 03 Sep 2021 01:02:36 -0700 (PDT)",
        "From": "Li Feng <fengli@smartx.com>",
        "To": "Maxime Coquelin <maxime.coquelin@redhat.com>,\n Chenbo Xia <chenbo.xia@intel.com>",
        "Cc": "dev@dpdk.org,\n\tLi Feng <fengli@smartx.com>",
        "Date": "Fri,  3 Sep 2021 16:02:03 +0800",
        "Message-Id": "<20210903080203.2495559-1-fengli@smartx.com>",
        "X-Mailer": "git-send-email 2.31.1",
        "In-Reply-To": "<20210903075637.2201185-1-fengli@smartx.com>",
        "References": "<20210903075637.2201185-1-fengli@smartx.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH v2] vhost: call destroy_device always in\n vhost_destroy_device_notify",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Vhost-user client must send the mem table, kick fd, call fd on all\nvirtqueues, then the device will be VIRTIO_DEV_RUNNING.\n\nIf the vhost-user communication is initialized partly, e.g.\n- When initializing the vhost-user, try to restart the vhost-user\n    backend;\n- Seabios only initialized the vhost-scsi req vq.\nThe device is not with flags VIRTIO_DEV_RUNNING..\n\nRoot Cause:\nThe vhost session has been created, and added the scsi/blk requestq\npoller into reactor, but when destroying the device, the requestq is not\nunregistered.\n\nReproduce the crash on spdk vhost-user backend:\n1. Create a VM;\n2. Mount a ISO to a VM, start the VM, don't install the OS;\n3. Restart the spdk_tgt;\n\nAnother discusstion is in seabiso:\nhttps://patchew.org/Seabios/20210831122339.2591585-1-fengli@smartx.com/\n\nSigned-off-by: Li Feng <fengli@smartx.com>\n---\nv2:\nFix the commit msg typo: vas -> virtqueues.\n--\n lib/vhost/vhost.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)",
    "diff": "diff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c\nindex 355ff37651..191ba82c41 100644\n--- a/lib/vhost/vhost.c\n+++ b/lib/vhost/vhost.c\n@@ -710,8 +710,8 @@ vhost_destroy_device_notify(struct virtio_net *dev)\n \t\tif (vdpa_dev)\n \t\t\tvdpa_dev->ops->dev_close(dev->vid);\n \t\tdev->flags &= ~VIRTIO_DEV_RUNNING;\n-\t\tdev->notify_ops->destroy_device(dev->vid);\n \t}\n+\tdev->notify_ops->destroy_device(dev->vid);\n }\n \n /*\n",
    "prefixes": [
        "v2"
    ]
}