Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/9780/?format=api
{ "id": 9780, "url": "http://patches.dpdk.org/api/patches/9780/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1452263438-21634-3-git-send-email-lsun@ezchip.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1452263438-21634-3-git-send-email-lsun@ezchip.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1452263438-21634-3-git-send-email-lsun@ezchip.com", "date": "2016-01-08T14:30:38", "name": "[dpdk-dev,v2,3/3] driver/net/mpipe: fix a mpipe link initialization ordering issue", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c5d5f307ca561df5fd241f5e2821d3dc4c8e8cd0", "submitter": { "id": 399, "url": "http://patches.dpdk.org/api/people/399/?format=api", "name": "Liming Sun", "email": "lsun@ezchip.com" }, "delegate": { "id": 10, "url": "http://patches.dpdk.org/api/users/10/?format=api", "username": "bruce", "first_name": "Bruce", "last_name": "Richardson", "email": "bruce.richardson@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1452263438-21634-3-git-send-email-lsun@ezchip.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/9780/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/9780/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 2326A8E9E;\n\tFri, 8 Jan 2016 15:30:54 +0100 (CET)", "from EUR01-VE1-obe.outbound.protection.outlook.com\n\t(mail-ve1eur01on0055.outbound.protection.outlook.com [104.47.1.55])\n\tby dpdk.org (Postfix) with ESMTP id 6E4728E9E\n\tfor <dev@dpdk.org>; Fri, 8 Jan 2016 15:30:52 +0100 (CET)", "from HE1PR02CA0010.eurprd02.prod.outlook.com\n\t(2a01:111:e400:5149::20) by AM3PR02MB1137.eurprd02.prod.outlook.com\n\t(2a01:111:e400:c406::11) with Microsoft SMTP Server (TLS) id\n\t15.1.365.19; Fri, 8 Jan 2016 14:30:50 +0000", "from DB3FFO11FD019.protection.gbl (2a01:111:f400:7e04::104) by\n\tHE1PR02CA0010.outlook.office365.com (2a01:111:e400:5149::20) with\n\tMicrosoft SMTP Server (TLS) id 15.1.365.18 via Frontend Transport;\n\tFri, 8 Jan 2016 14:30:50 +0000", "from lab-14.internal.tilera.com (12.216.194.146) by\n\tDB3FFO11FD019.mail.protection.outlook.com (10.47.217.50) with\n\tMicrosoft SMTP Server (TLS) id 15.1.355.15 via Frontend Transport;\n\tFri, 8 Jan 2016 14:30:48 +0000", "(from lsun@localhost)\n\tby lab-14.internal.tilera.com (8.14.7/8.14.7/Submit) id\n\tu08EUl22021682; Fri, 8 Jan 2016 09:30:47 -0500" ], "Authentication-Results": "spf=fail (sender IP is 12.216.194.146)\n\tsmtp.mailfrom=ezchip.com; ezchip.com; dkim=none (message not signed)\n\theader.d=none; ezchip.com;\n\tdmarc=none action=none header.from=ezchip.com; ", "Received-SPF": "Fail (protection.outlook.com: domain of ezchip.com does not\n\tdesignate 12.216.194.146 as permitted sender)\n\treceiver=protection.outlook.com; client-ip=12.216.194.146;\n\thelo=lab-14.internal.tilera.com;", "From": "Liming Sun <lsun@ezchip.com>", "To": "<dev@dpdk.org>", "Date": "Fri, 8 Jan 2016 09:30:38 -0500", "Message-ID": "<1452263438-21634-3-git-send-email-lsun@ezchip.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1452263438-21634-1-git-send-email-lsun@ezchip.com>", "References": "<1450193851-9100-4-git-send-email-lsun@ezchip.com>\n\t<1452263438-21634-1-git-send-email-lsun@ezchip.com>", "X-EOPAttributedMessage": "0", "X-Microsoft-Exchange-Diagnostics": [ "1; DB3FFO11FD019;\n\t1:toR3Dv9S1wC+oxGQ8APd4gU+NFIdrA3ZWqCLVfGLV1BQ3REbe3dT+nzVQKeWp8HVslEc4QaD0kXl9vYp8JEXMflX+GRVcEZ3+cVLvLZK3kHhPoQCCV/EgOASIFECJGkxHu40MyR3X8ZSH7Z87mmga32REAkTd4nLsoTLAOzT1pbpObCEJkiQfG7r0yv1mKhjwhVGZjgYeWwWt4WRgNWOBLtjUJAe4ngE51lgYu19NlMWTRzGZftqtJqlPIndvE7lWmkA44VFV80aNOrN56kSi1VSPneex/8UT9R2fcHDONkgY3skIP8pQwaXdbyBLg9MP5coYoprxZHgB/smFkGxDp3E1XLj3uqzYp5ICmgQSxG1XKNUocGiMnwdvZBridwaKP9cSEaGQR/HkNzWK6BAWg==", "1; AM3PR02MB1137;\n\t2:bw79s8rX9oBisQYdbkPZZD9Pto848iMk8GOu2HuFt0mXLRUd4ytaWBtYOJb1Klx1NPqaL2huHWKoQokblLn+28CwghKwpih64hB8eMmZ9mf3RbCtt6FYehOqm+/NkqWB7aY5LQEdjT40rloiWeiOtQ==;\n\t3:If8h5vcom2+cFR3/gXBMToLr4CJDNznB6lxit2b3KA/WDC57XmrDBlp3KVJf5jJmyDphpg0mtVttahYsk58CLI3/5DIqGHMb39s2gStTBTDsEKkZigzq1FBhXPMegMrYJHIISuBOMoZK0FTf/f0Ihw6XWtuP1nevpWEiPrWypezoQYebhofqQYJlbqSZlF63Qt6qsh1S0swYh8z3GyPiFNdFaOXcL+D+IS71yQrLxrA=;\n\t25:D0HTe84YaWx1WfliIA3XMyottSKf9+xoPsySXvzdsybyVhJMfxR0iKV3ujMA6FjVSLqhPc+QHWptleKkd0Q10lymG8CMW39evG1cOjf9t9gjcH4wtVDb1fJ7dcYUAhi0XFs4rBM5/ZkYMMES+iS4XsXU5Shrc6jNr4NBjkur63IwhWxM8VrvNqWhwdD4k05vpeAlPmpI8Jn4f1BzV8Jph9laFccq8fOeh9mMpqgBEry/RLXKEeOAMrwsn/Hx4Huq;\n\t20:4iplQwFi3ke8+L7SrggPTWZGlPWFjv14fLJZu5pnpyyrMaZdcpvai5Qn0//ZKENzIihmtY9xcnwLcjlHGYdjcpAuSDpMU4uJBk6TmuL4emmF10xNxXi4V0EjujN4s2ULxPINRdiUEl2ZFy+WuAmJgfNhHwm1gVctgBKBiK7cYKU=", "1; AM3PR02MB1137;\n\t4:3ZXeKjlcPCU+jxRw+MIB+MpTLCuB6Mz+BAXBqlJhQyGiR4U9SZ9Is22Dw1R+OXO1LJmUTq1B92KBFnnoVdxCDTKunenLFJsoSz5vNBLtONJNaUvyD8DQMdg1AgeEphE5ZcrY/chgO2jRrelzYxq58OWRXYyJfar8+xzfT/gJhgcEr8XlvKoyvAzE4nK7baU2aiV+FSOguEW/NY49xrDfCDBkIOsQg67cLIbKr4qzkitDFmqj0pLquggPxD5hjiGZsn79/ow5SRmBc0AN41B9XWbtljkL4XJsi91At3mVi1SyPDnhuTM7yxUHw0Y6X3GIWT9WGT06cJSAqg6bMfAS82hpV9i4gi3B/RAV/D1dIdxMHXEiS7VjFuGM5NCWi2W8jkXOyZjaqnPU2V8YjcCKMN6M8UIx4UrS72FWOJgE4BYH3cV/Qk/Uch31EtecUGLez4wt8G3QdbIICxaAZ63sQoS6VRFG3k7bX0XlJcolcOM=", "=?us-ascii?Q?1; AM3PR02MB1137;\n\t23:LkHfiTJ4dqkrSTAI9uA/cGLjfSX+ovgfH7RYbXLDW?=\n\t=?us-ascii?Q?ZZYulyRaxLKiAMs4w+ESuHiwI4OClEfh/6PFVUeSmPbPCedjya0EK5Rc7/Lz?=\n\t=?us-ascii?Q?mj1gCnjEnj89zpmL+bjenR0+Qtf80Tz/5A+I7QkHbcAPcDQJopKjYyx+oy4B?=\n\t=?us-ascii?Q?ha+layayw24QkV/SEGzIo1EjjPR9aD6cHVH5hk0KbJMl2R87Pcc0hDElK36R?=\n\t=?us-ascii?Q?W4p9zFI4zHUfgpuutqIqWsjp9/SFvRxNMi56LvU8Nib0n5rHak5I0GW57sBq?=\n\t=?us-ascii?Q?hj8NbjhWu2uAk4eHoVTi2m4XOxxhVfqnbRrR1vN1UIuVB7tMBkrrC1gk2P6K?=\n\t=?us-ascii?Q?0qD+oRBO8jIBu3rjNo05Zv9OdpJ1dGY1iY+CDuoVt9LxgKreBlmdNLefBrla?=\n\t=?us-ascii?Q?U4MtGTOMemksEQHT+JIbvIfJkb075sPotpF/rJ0o2jZXEzQLkqsVZJEuoOx5?=\n\t=?us-ascii?Q?+cJRlyeBzz0GYIUkBFR8IyItPu8wPPPMma8u3ksVd+D0Y35W+EgMk1FYUAyU?=\n\t=?us-ascii?Q?BJedOU0w72h34OYDt09Ho7jPE3YoLdyNQ0Q38Ke/bq+hlumCvfeZDzegH0i8?=\n\t=?us-ascii?Q?n4egMdjqiQSMd8b0MK7fRkc5fCEWH0dQadorOsWigwzAWKrBVOWDJMwAhpkr?=\n\t=?us-ascii?Q?T3dH9/7rn4XbsIdDZPLL00UN/TjzpBV4eV2okBH9l+AC3RzeBALtQ9Kwuemi?=\n\t=?us-ascii?Q?BpuXAvD1nk7goMY8d21A3CgoXNbtXwbq92JkWK7Fej10urttNJmzD3SMxUbW?=\n\t=?us-ascii?Q?O365ERWMUpz4t3Tey5QIobKb9dJ7wKV4Iqgg17HbY6LIT7jKUFDnjq5TCnSc?=\n\t=?us-ascii?Q?s08rqzSvhw1GtNbktfSXrxvbgzzh7wJa5jftsK3nGBo981ebSLrY4IWzI+kr?=\n\t=?us-ascii?Q?P/Wn/16Ty/XcPEHNqf2PruPfzz9z8lQMcDX5QCbvTwdIWhjcDdJ3Hivw2o7w?=\n\t=?us-ascii?Q?cUWxbU0ED2rgI1DH9UQr1lVHv8PZl5/LJo0rJjAyR7ffaix7gdqj4u5/kYCk?=\n\t=?us-ascii?Q?G0/efZ1yj9KWYzfEF+viID+zAiGBRqc67MnLe33yjbhc2wAVBa9pFI9/6FZU?=\n\t=?us-ascii?Q?vTGUbdSHsuaf9wnNgCYPGBoaKQvwtw6hof+Iv5JxxYGzNcnxPGsOVhpUi61I?=\n\t=?us-ascii?Q?Db32FeMXnq/nPs3Oh5Cg7Ow1GVRAfiv?=", "1; AM3PR02MB1137;\n\t5:2ehHyEM6WsOOskIRtnlpCoX9SeIvRiEmfBra3R49oBz2bDnR9lkc2zpJIADd3mTE7rgTUB+cOFbVhAa8d3GUJrEZmY/f6JzaHsg/g+jZAt2lSkPGCe4cgJwyBfU/mSotCib3P3AlysX9ZFbZTgX+Gg==;\n\t24:avYs/0b+bgK0oQcQ9yLPoMkNbQ04cEU4ZFJ1ek7NOmuwzyySp14PbFafIBNi8iRFI2gtVlopnxnN5VE3WfFNgiTTiy5ucW0VQVGumapO4+o=" ], "X-Forefront-Antispam-Report": "CIP:12.216.194.146; CTRY:US; IPV:NLI; EFV:NLI; \n\tSFV:NSPM;\n\tSFS:(10009020)(6009001)(2980300002)(1109001)(1110001)(339900001)(189002)(199003)(19580405001)(87936001)(105606002)(110136002)(5001970100001)(36756003)(4001430100002)(189998001)(586003)(1220700001)(107886002)(33646002)(2950100001)(50226001)(106466001)(229853001)(2351001)(11100500001)(42186005)(86362001)(5003940100001)(450100001)(2906002)(85426001)(76176999)(1096002)(47776003)(48376002)(5008740100001)(6806005)(50986999)(104016004)(92566002)(4326007)(50466002)(19580395003);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:AM3PR02MB1137;\n\tH:lab-14.internal.tilera.com; \n\tFPR:; SPF:Fail; PTR:wb-fw1.tilera.com; MX:1; A:1; LANG:en; ", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Microsoft-Antispam": "UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM3PR02MB1137;", "X-MS-Office365-Filtering-Correlation-Id": "0c6db059-0197-446b-6459-08d318384e0d", "X-Microsoft-Antispam-PRVS": "<AM3PR02MB1137230044430A9F20D7D1C6BCF60@AM3PR02MB1137.eurprd02.prod.outlook.com>", "X-Exchange-Antispam-Report-Test": "UriScan:(121898900299872);", "X-Exchange-Antispam-Report-CFA-Test": "BCL:0; PCL:0;\n\tRULEID:(601004)(2401047)(13015025)(13017025)(5005006)(13018025)(8121501046)(520078)(10201501046)(3002001);\n\tSRVR:AM3PR02MB1137; BCL:0; PCL:0; RULEID:; SRVR:AM3PR02MB1137; ", "X-Forefront-PRVS": "0815F8251E", "SpamDiagnosticOutput": "1:23", "SpamDiagnosticMetadata": "NSPM", "X-OriginatorOrg": "ezchip.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "08 Jan 2016 14:30:48.9867\n\t(UTC)", "X-MS-Exchange-CrossTenant-Id": "0fc16e0a-3cd3-4092-8b2f-0a42cff122c3", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "TenantId=0fc16e0a-3cd3-4092-8b2f-0a42cff122c3;\n\tIp=[12.216.194.146]; \n\tHelo=[lab-14.internal.tilera.com]", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM3PR02MB1137", "Subject": "[dpdk-dev] [PATCH v2 3/3] driver/net/mpipe: fix a mpipe link\n\tinitialization ordering issue", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Mpipe link structure is initialized in function mpipe_link_init().\nCurrently it's only called from the eth_dev_ops.dev_start, which\ncaused crashes when link mgmt APIs (like promiscuous_enable)\nwas called before eth_dev_ops.dev_start(). This submit fixed it\nby calling mpipe_link_init() in rte_pmd_mpipe_devinit().\n\nSigned-off-by: Liming Sun <lsun@ezchip.com>\nAcked-by: Zhigang Lu <zlu@ezchip.com>\n---\n drivers/net/mpipe/mpipe_tilegx.c | 14 +++++++-------\n 1 file changed, 7 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/mpipe/mpipe_tilegx.c b/drivers/net/mpipe/mpipe_tilegx.c\nindex be7b6f2..5845511 100644\n--- a/drivers/net/mpipe/mpipe_tilegx.c\n+++ b/drivers/net/mpipe/mpipe_tilegx.c\n@@ -752,13 +752,6 @@ mpipe_init(struct mpipe_dev_priv *priv)\n \tif (priv->initialized)\n \t\treturn 0;\n \n-\trc = mpipe_link_init(priv);\n-\tif (rc < 0) {\n-\t\tRTE_LOG(ERR, PMD, \"%s: Failed to init link.\\n\",\n-\t\t\tmpipe_name(priv));\n-\t\treturn rc;\n-\t}\n-\n \trc = mpipe_recv_init(priv);\n \tif (rc < 0) {\n \t\tRTE_LOG(ERR, PMD, \"%s: Failed to init rx.\\n\",\n@@ -1633,6 +1626,13 @@ rte_pmd_mpipe_devinit(const char *ifname,\n \teth_dev->rx_pkt_burst = &mpipe_recv_pkts;\n \teth_dev->tx_pkt_burst = &mpipe_xmit_pkts;\n \n+\trc = mpipe_link_init(priv);\n+\tif (rc < 0) {\n+\t\tRTE_LOG(ERR, PMD, \"%s: Failed to init link.\\n\",\n+\t\t\tmpipe_name(priv));\n+\t\treturn rc;\n+\t}\n+\n \treturn 0;\n }\n \n", "prefixes": [ "dpdk-dev", "v2", "3/3" ] }