Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/97696/?format=api
{ "id": 97696, "url": "http://patches.dpdk.org/api/patches/97696/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210901142433.8444-12-venkatkumar.duvvuru@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210901142433.8444-12-venkatkumar.duvvuru@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210901142433.8444-12-venkatkumar.duvvuru@broadcom.com", "date": "2021-09-01T14:24:30", "name": "[11/14] net/bnxt: dynamically allocate space for EM defrag function", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a343c5f9c5952af294202d67c8489aeb924e4eab", "submitter": { "id": 1635, "url": "http://patches.dpdk.org/api/people/1635/?format=api", "name": "Venkat Duvvuru", "email": "venkatkumar.duvvuru@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210901142433.8444-12-venkatkumar.duvvuru@broadcom.com/mbox/", "series": [ { "id": 18604, "url": "http://patches.dpdk.org/api/series/18604/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=18604", "date": "2021-09-01T14:24:19", "name": "enhancements to host based flow table management", "version": 1, "mbox": "http://patches.dpdk.org/series/18604/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/97696/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/97696/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D2536A0C45;\n\tWed, 1 Sep 2021 16:26:04 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 279BA4118C;\n\tWed, 1 Sep 2021 16:25:07 +0200 (CEST)", "from relay.smtp-ext.broadcom.com (lpdvsmtp11.broadcom.com\n [192.19.166.231])\n by mails.dpdk.org (Postfix) with ESMTP id 8B3A34117D\n for <dev@dpdk.org>; Wed, 1 Sep 2021 16:25:05 +0200 (CEST)", "from S60.dhcp.broadcom.net (unknown [10.123.66.170])\n (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n (No client certificate requested)\n by relay.smtp-ext.broadcom.com (Postfix) with ESMTPS id 25FD32E5C7;\n Wed, 1 Sep 2021 07:25:03 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com 25FD32E5C7", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1630506305;\n bh=uKjCWByzVKWQwTJW0KxDbU/lq2rGU9u7xH9eNrKNpeA=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=ChvA1Ez75O0tttyZU2o7+EtROALAGh9hQqaOyd1j0Fxmt/SUmvacFMeSc1JKo9DvQ\n m7JK91m5ckmogXKCdwyFRwvJOImxdGo+N1hlMrRKnZkC6WXk+/2F8r/v8XKZBZoQQl\n ktsU1Dv8LcxpGfLBVUtx1yo7pw+oWakOVaheX6Vs=", "From": "Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>", "To": "dev@dpdk.org", "Cc": "Randy Schacher <stuart.schacher@broadcom.com>", "Date": "Wed, 1 Sep 2021 19:54:30 +0530", "Message-Id": "<20210901142433.8444-12-venkatkumar.duvvuru@broadcom.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20210901142433.8444-1-venkatkumar.duvvuru@broadcom.com>", "References": "<20210901142433.8444-1-venkatkumar.duvvuru@broadcom.com>", "Subject": "[dpdk-dev] [PATCH 11/14] net/bnxt: dynamically allocate space for\n EM defrag function", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Randy Schacher <stuart.schacher@broadcom.com>\n\nAlter defrag function to dynamically allocate and delete\nfree_list and adj_list buffers.\n\nSigned-off-by: Randy Schacher <stuart.schacher@broadcom.com>\nReviewed-by: Peter Spreadborough <peter.spreadborough@broadcom.com>\n---\n drivers/net/bnxt/tf_core/dpool.c | 38 +++++++++++++++++++++-----------\n 1 file changed, 25 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/tf_core/dpool.c b/drivers/net/bnxt/tf_core/dpool.c\nindex 145efa486f..5c03f775a5 100644\n--- a/drivers/net/bnxt/tf_core/dpool.c\n+++ b/drivers/net/bnxt/tf_core/dpool.c\n@@ -7,9 +7,6 @@\n #include <stdbool.h>\n #include <stdint.h>\n #include <errno.h>\n-\n-#include <rte_malloc.h>\n-\n #include \"tfp.h\"\n #include \"dpool.h\"\n \n@@ -84,13 +81,13 @@ static int dpool_move(struct dpool *dpool,\n \treturn 0;\n }\n \n-\n int dpool_defrag(struct dpool *dpool,\n \t\t uint32_t entry_size,\n \t\t uint8_t defrag)\n {\n \tstruct dpool_free_list *free_list;\n \tstruct dpool_adj_list *adj_list;\n+\tstruct tfp_calloc_parms parms;\n \tuint32_t count;\n \tuint32_t index;\n \tuint32_t used;\n@@ -103,15 +100,31 @@ int dpool_defrag(struct dpool *dpool,\n \tuint32_t max_size = 0;\n \tint rc;\n \n-\tfree_list = rte_zmalloc(\"dpool_free_list\",\n-\t\t\t\tsizeof(struct dpool_free_list), 0);\n+\tparms.nitems = 1;\n+\tparms.size = sizeof(struct dpool_free_list);\n+\tparms.alignment = 0;\n+\n+\trc = tfp_calloc(&parms);\n+\n+\tif (rc)\n+\t\treturn rc;\n+\n+\tfree_list = (struct dpool_free_list *)parms.mem_va;\n \tif (free_list == NULL) {\n \t\tTFP_DRV_LOG(ERR, \"dpool free list allocation failed\\n\");\n \t\treturn -ENOMEM;\n \t}\n \n-\tadj_list = rte_zmalloc(\"dpool_adjacent_list\",\n-\t\t\t\tsizeof(struct dpool_adj_list), 0);\n+\tparms.nitems = 1;\n+\tparms.size = sizeof(struct dpool_adj_list);\n+\tparms.alignment = 0;\n+\n+\trc = tfp_calloc(&parms);\n+\n+\tif (rc)\n+\t\treturn rc;\n+\n+\tadj_list = (struct dpool_adj_list *)parms.mem_va;\n \tif (adj_list == NULL) {\n \t\tTFP_DRV_LOG(ERR, \"dpool adjacent list allocation failed\\n\");\n \t\treturn -ENOMEM;\n@@ -239,8 +252,8 @@ int dpool_defrag(struct dpool *dpool,\n \t\t\t\t\tfree_list->entry[largest_free_index].index,\n \t\t\t\t\tmax_index);\n \t\t\tif (rc) {\n-\t\t\t\trte_free(free_list);\n-\t\t\t\trte_free(adj_list);\n+\t\t\t\ttfp_free(free_list);\n+\t\t\t\ttfp_free(adj_list);\n \t\t\t\treturn rc;\n \t\t\t}\n \t\t} else {\n@@ -249,12 +262,11 @@ int dpool_defrag(struct dpool *dpool,\n \t}\n \n done:\n-\trte_free(free_list);\n-\trte_free(adj_list);\n+\ttfp_free(free_list);\n+\ttfp_free(adj_list);\n \treturn largest_free_size;\n }\n \n-\n uint32_t dpool_alloc(struct dpool *dpool,\n \t\t uint32_t size,\n \t\t uint8_t defrag)\n", "prefixes": [ "11/14" ] }