Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/97451/?format=api
http://patches.dpdk.org/api/patches/97451/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210827065717.1838258-35-andrew.rybchenko@oktetlabs.ru/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210827065717.1838258-35-andrew.rybchenko@oktetlabs.ru>", "list_archive_url": "https://inbox.dpdk.org/dev/20210827065717.1838258-35-andrew.rybchenko@oktetlabs.ru", "date": "2021-08-27T06:57:13", "name": "[34/38] net/sfc: include controller and port in representor name", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "13ffadbb52a3c262f9ef3441eb57dd507d30ef53", "submitter": { "id": 2013, "url": "http://patches.dpdk.org/api/people/2013/?format=api", "name": "Andrew Rybchenko", "email": "Andrew.Rybchenko@oktetlabs.ru" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210827065717.1838258-35-andrew.rybchenko@oktetlabs.ru/mbox/", "series": [ { "id": 18492, "url": "http://patches.dpdk.org/api/series/18492/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=18492", "date": "2021-08-27T06:56:39", "name": "net/sfc: support port representors", "version": 1, "mbox": "http://patches.dpdk.org/series/18492/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/97451/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/97451/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D0A48A0C41;\n\tFri, 27 Aug 2021 09:01:18 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6824F412A2;\n\tFri, 27 Aug 2021 08:59:12 +0200 (CEST)", "from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])\n by mails.dpdk.org (Postfix) with ESMTP id 3845141269\n for <dev@dpdk.org>; Fri, 27 Aug 2021 08:59:11 +0200 (CEST)", "by shelob.oktetlabs.ru (Postfix, from userid 122)\n id 00D147F6E6; Fri, 27 Aug 2021 09:59:10 +0300 (MSK)", "from aros.oktetlabs.ru (aros.oktetlabs.ru [192.168.38.17])\n by shelob.oktetlabs.ru (Postfix) with ESMTP id 8FD887F6F5;\n Fri, 27 Aug 2021 09:57:36 +0300 (MSK)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on shelob.oktetlabs.ru", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.8 required=5.0 tests=ALL_TRUSTED,\n DKIM_ADSP_DISCARD,\n URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2", "DKIM-Filter": "OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 8FD887F6F5", "Authentication-Results": "shelob.oktetlabs.ru/8FD887F6F5; dkim=none;\n dkim-atps=neutral", "From": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "To": "dev@dpdk.org", "Cc": "Viacheslav Galaktionov <viacheslav.galaktionov@oktetlabs.ru>,\n Andy Moreton <amoreton@xilinx.com>", "Date": "Fri, 27 Aug 2021 09:57:13 +0300", "Message-Id": "<20210827065717.1838258-35-andrew.rybchenko@oktetlabs.ru>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210827065717.1838258-1-andrew.rybchenko@oktetlabs.ru>", "References": "<20210827065717.1838258-1-andrew.rybchenko@oktetlabs.ru>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 34/38] net/sfc: include controller and port in\n representor name", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Viacheslav Galaktionov <viacheslav.galaktionov@oktetlabs.ru>\n\nMake representor names unique on multi-host configurations.\n\nSigned-off-by: Viacheslav Galaktionov <viacheslav.galaktionov@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n drivers/net/sfc/sfc_repr.c | 28 ++++++++++++++++++++++++++--\n drivers/net/sfc/sfc_switch.c | 28 ++++++++++++++++++++++++++++\n drivers/net/sfc/sfc_switch.h | 4 ++++\n 3 files changed, 58 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/sfc/sfc_repr.c b/drivers/net/sfc/sfc_repr.c\nindex a42e70c92c..d50efe6562 100644\n--- a/drivers/net/sfc/sfc_repr.c\n+++ b/drivers/net/sfc/sfc_repr.c\n@@ -1050,11 +1050,35 @@ sfc_repr_create(struct rte_eth_dev *parent,\n {\n \tstruct sfc_repr_init_data repr_data;\n \tchar name[RTE_ETH_NAME_MAX_LEN];\n+\tint controller;\n \tint ret;\n+\tint rc;\n \tstruct rte_eth_dev *dev;\n \n-\tif (snprintf(name, sizeof(name), \"net_%s_representor_%u\",\n-\t\t parent->device->name, entity->vf) >= (int)sizeof(name)) {\n+\tcontroller = -1;\n+\trc = sfc_mae_switch_domain_get_controller(switch_domain_id,\n+\t\t\t\t\t\t entity->intf, &controller);\n+\tif (rc != 0) {\n+\t\tSFC_GENERIC_LOG(ERR, \"%s() failed to get DPDK controller for %d\",\n+\t\t\t\t__func__, entity->intf);\n+\t\treturn -rc;\n+\t}\n+\n+\tswitch (entity->type) {\n+\tcase RTE_ETH_REPRESENTOR_VF:\n+\t\tret = snprintf(name, sizeof(name), \"net_%s_representor_c%upf%uvf%u\",\n+\t\t\t parent->device->name, controller, entity->pf,\n+\t\t\t entity->vf);\n+\t\tbreak;\n+\tcase RTE_ETH_REPRESENTOR_PF:\n+\t\tret = snprintf(name, sizeof(name), \"net_%s_representor_c%upf%u\",\n+\t\t\t parent->device->name, controller, entity->pf);\n+\t\tbreak;\n+\tdefault:\n+\t\treturn -ENOTSUP;\n+\t}\n+\n+\tif (ret >= (int)sizeof(name)) {\n \t\tSFC_GENERIC_LOG(ERR, \"%s() failed name too long\", __func__);\n \t\treturn -ENAMETOOLONG;\n \t}\ndiff --git a/drivers/net/sfc/sfc_switch.c b/drivers/net/sfc/sfc_switch.c\nindex 7a0b332f33..225d07fa15 100644\n--- a/drivers/net/sfc/sfc_switch.c\n+++ b/drivers/net/sfc/sfc_switch.c\n@@ -279,6 +279,34 @@ sfc_mae_switch_domain_map_controllers(uint16_t switch_domain_id,\n \treturn 0;\n }\n \n+int\n+sfc_mae_switch_domain_get_controller(uint16_t switch_domain_id,\n+\t\t\t\t efx_pcie_interface_t intf,\n+\t\t\t\t int *controller)\n+{\n+\tconst efx_pcie_interface_t *controllers;\n+\tsize_t nb_controllers;\n+\tsize_t i;\n+\tint rc;\n+\n+\trc = sfc_mae_switch_domain_controllers(switch_domain_id, &controllers,\n+\t\t\t\t\t &nb_controllers);\n+\tif (rc != 0)\n+\t\treturn rc;\n+\n+\tif (controllers == NULL)\n+\t\treturn ENOENT;\n+\n+\tfor (i = 0; i < nb_controllers; i++) {\n+\t\tif (controllers[i] == intf) {\n+\t\t\t*controller = i;\n+\t\t\treturn 0;\n+\t\t}\n+\t}\n+\n+\treturn ENOENT;\n+}\n+\n /* This function expects to be called only when the lock is held */\n static struct sfc_mae_switch_port *\n sfc_mae_find_switch_port_by_entity(const struct sfc_mae_switch_domain *domain,\ndiff --git a/drivers/net/sfc/sfc_switch.h b/drivers/net/sfc/sfc_switch.h\nindex a072507375..294baae9a2 100644\n--- a/drivers/net/sfc/sfc_switch.h\n+++ b/drivers/net/sfc/sfc_switch.h\n@@ -63,6 +63,10 @@ int sfc_mae_switch_domain_map_controllers(uint16_t switch_domain_id,\n \t\t\t\t\t efx_pcie_interface_t *controllers,\n \t\t\t\t\t size_t nb_controllers);\n \n+int sfc_mae_switch_domain_get_controller(uint16_t switch_domain_id,\n+\t\t\t\t efx_pcie_interface_t intf,\n+\t\t\t\t int *controller);\n+\n int sfc_mae_assign_switch_port(uint16_t switch_domain_id,\n \t\t\t const struct sfc_mae_switch_port_request *req,\n \t\t\t uint16_t *switch_port_id);\n", "prefixes": [ "34/38" ] }{ "id": 97451, "url": "