Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/96821/?format=api
{ "id": 96821, "url": "http://patches.dpdk.org/api/patches/96821/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210812020020.12656-4-jiawenwu@trustnetic.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210812020020.12656-4-jiawenwu@trustnetic.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210812020020.12656-4-jiawenwu@trustnetic.com", "date": "2021-08-12T02:00:20", "name": "[3/3] net/txgbe: fix L4 port mask in FDIR", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3d31c396c1ae10dc6cb5c13ccc9eebe75e9cf5a8", "submitter": { "id": 1932, "url": "http://patches.dpdk.org/api/people/1932/?format=api", "name": "Jiawen Wu", "email": "jiawenwu@trustnetic.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210812020020.12656-4-jiawenwu@trustnetic.com/mbox/", "series": [ { "id": 18258, "url": "http://patches.dpdk.org/api/series/18258/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=18258", "date": "2021-08-12T02:00:17", "name": "Fixes for txgbe", "version": 1, "mbox": "http://patches.dpdk.org/series/18258/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/96821/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/96821/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 04ADAA0C4D;\n\tThu, 12 Aug 2021 04:00:55 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 24F324120B;\n\tThu, 12 Aug 2021 04:00:43 +0200 (CEST)", "from smtpproxy21.qq.com (smtpbg702.qq.com [203.205.195.102])\n by mails.dpdk.org (Postfix) with ESMTP id C8260411C0\n for <dev@dpdk.org>; Thu, 12 Aug 2021 04:00:39 +0200 (CEST)", "from jiawenwu.trustnetic.com (unknown [183.129.236.74])\n by esmtp6.qq.com (ESMTP) with\n id ; Thu, 12 Aug 2021 10:00:31 +0800 (CST)" ], "X-QQ-mid": "bizesmtp31t1628733631t27o1180", "X-QQ-SSF": "01400000002000E0F000B00A0000000", "X-QQ-FEAT": "a7KvnLxF6FfzKUbV6o6Mzc1p6Aq9WqcxVTh/y3z6rVrOqfN6UIdTl58ROL0tG\n YXZdss9nIias0qDo7D+BOxQ1fe11q+kFBr4vfxyb4TiNlZZhtKDWZQKVFn1q3KTZlLUDodD\n Ogc3leY+0x2J0VGczYIVKB9507+Ggavkyf3Jh8iep+qNl3AoSuyPPk40ibxI1lVmS9vH854\n Z5tB5mI9ITFsEdrHvK4rkPxCz/WO/SV688/EnVxcDlNBhZxq6Qc0KmvkbptDerdZjI17u7F\n t0ZzwtYQmUX5PxsDQ8YqDpsK1o4NqBgS3cY16RnNdfvPQhBH+mZ0NiOAIPBu+qDXb8gSC38\n 7Dzt5fYPbHr6afKJJQ=", "X-QQ-GoodBg": "2", "From": "Jiawen Wu <jiawenwu@trustnetic.com>", "To": "dev@dpdk.org", "Cc": "Jiawen Wu <jiawenwu@trustnetic.com>,\n\tstable@dpdk.org", "Date": "Thu, 12 Aug 2021 10:00:20 +0800", "Message-Id": "<20210812020020.12656-4-jiawenwu@trustnetic.com>", "X-Mailer": "git-send-email 2.21.0.windows.1", "In-Reply-To": "<20210812020020.12656-1-jiawenwu@trustnetic.com>", "References": "<20210812020020.12656-1-jiawenwu@trustnetic.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-QQ-SENDSIZE": "520", "Feedback-ID": "bizesmtp:trustnetic.com:qybgforeign:qybgforeign5", "X-QQ-Bgrelay": "1", "Subject": "[dpdk-dev] [PATCH 3/3] net/txgbe: fix L4 port mask in FDIR", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Remove bit reverse for TCP/UDP port mask, since it causes the flows with\nsome TCP/UDP ports to disobey the flow director rules.\n\nFixes: ea230dda16ad (\"net/txgbe: configure flow director filter\")\nCc: stable@dpdk.org\n\nSigned-off-by: Jiawen Wu <jiawenwu@trustnetic.com>\n---\n drivers/net/txgbe/txgbe_fdir.c | 18 +++---------------\n 1 file changed, 3 insertions(+), 15 deletions(-)", "diff": "diff --git a/drivers/net/txgbe/txgbe_fdir.c b/drivers/net/txgbe/txgbe_fdir.c\nindex c8ff4b142c..8abb862286 100644\n--- a/drivers/net/txgbe/txgbe_fdir.c\n+++ b/drivers/net/txgbe/txgbe_fdir.c\n@@ -165,18 +165,6 @@ configure_fdir_flags(const struct rte_fdir_conf *conf,\n \treturn 0;\n }\n \n-static inline uint32_t\n-reverse_fdir_bmks(uint16_t hi_dword, uint16_t lo_dword)\n-{\n-\tuint32_t mask = hi_dword << 16;\n-\n-\tmask |= lo_dword;\n-\tmask = ((mask & 0x55555555) << 1) | ((mask & 0xAAAAAAAA) >> 1);\n-\tmask = ((mask & 0x33333333) << 2) | ((mask & 0xCCCCCCCC) >> 2);\n-\tmask = ((mask & 0x0F0F0F0F) << 4) | ((mask & 0xF0F0F0F0) >> 4);\n-\treturn ((mask & 0x00FF00FF) << 8) | ((mask & 0xFF00FF00) >> 8);\n-}\n-\n int\n txgbe_fdir_set_input_mask(struct rte_eth_dev *dev)\n {\n@@ -213,9 +201,9 @@ txgbe_fdir_set_input_mask(struct rte_eth_dev *dev)\n \t/* TBD: don't support encapsulation yet */\n \twr32(hw, TXGBE_FDIRMSK, fdirm);\n \n-\t/* store the TCP/UDP port masks, bit reversed from port layout */\n-\tfdirtcpm = reverse_fdir_bmks(rte_be_to_cpu_16(info->mask.dst_port_mask),\n-\t\t\trte_be_to_cpu_16(info->mask.src_port_mask));\n+\t/* store the TCP/UDP port masks */\n+\tfdirtcpm = rte_be_to_cpu_16(info->mask.dst_port_mask) << 16;\n+\tfdirtcpm |= rte_be_to_cpu_16(info->mask.src_port_mask);\n \n \t/* write all the same so that UDP, TCP and SCTP use the same mask\n \t * (little-endian)\n", "prefixes": [ "3/3" ] }