Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/96749/?format=api
{ "id": 96749, "url": "http://patches.dpdk.org/api/patches/96749/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210810025140.1698163-11-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210810025140.1698163-11-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210810025140.1698163-11-qi.z.zhang@intel.com", "date": "2021-08-10T02:51:22", "name": "[10/28] net/ice/base: clarify comments on checking PFC mode", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "4c8447b2f6d4acfd5477f3028d71584306e8c9d9", "submitter": { "id": 504, "url": "http://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210810025140.1698163-11-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 18242, "url": "http://patches.dpdk.org/api/series/18242/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=18242", "date": "2021-08-10T02:51:12", "name": "ice: base code update", "version": 1, "mbox": "http://patches.dpdk.org/series/18242/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/96749/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/96749/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 00E67A0C55;\n\tTue, 10 Aug 2021 04:49:43 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 27F73411B5;\n\tTue, 10 Aug 2021 04:48:59 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by mails.dpdk.org (Postfix) with ESMTP id 8FEC441197\n for <dev@dpdk.org>; Tue, 10 Aug 2021 04:48:57 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 09 Aug 2021 19:48:57 -0700", "from dpdk51.sh.intel.com ([10.67.111.142])\n by fmsmga008.fm.intel.com with ESMTP; 09 Aug 2021 19:48:55 -0700" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10070\"; a=\"214808446\"", "E=Sophos;i=\"5.84,309,1620716400\"; d=\"scan'208\";a=\"214808446\"", "E=Sophos;i=\"5.84,309,1620716400\"; d=\"scan'208\";a=\"483823627\"" ], "X-ExtLoop1": "1", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "qiming.yang@intel.com", "Cc": "junfeng.guo@intel.com, dev@dpdk.org, Qi Zhang <qi.z.zhang@intel.com>,\n Tony Nguyen <anthony.l.nguyen@intel.com>", "Date": "Tue, 10 Aug 2021 10:51:22 +0800", "Message-Id": "<20210810025140.1698163-11-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.26.2", "In-Reply-To": "<20210810025140.1698163-1-qi.z.zhang@intel.com>", "References": "<20210810025140.1698163-1-qi.z.zhang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 10/28] net/ice/base: clarify comments on checking\n PFC mode", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Rework the comment around checking PFC mode to make it clear why we are\nchecking the mode after sending the command.\n\nSigned-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/ice/base/ice_dcb.c | 9 ++++-----\n 1 file changed, 4 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ice/base/ice_dcb.c b/drivers/net/ice/base/ice_dcb.c\nindex 9c9675f6ef..cb6c5ba182 100644\n--- a/drivers/net/ice/base/ice_dcb.c\n+++ b/drivers/net/ice/base/ice_dcb.c\n@@ -764,11 +764,10 @@ ice_aq_set_pfc_mode(struct ice_hw *hw, u8 pfc_mode, struct ice_sq_cd *cd)\n \tif (status)\n \t\treturn status;\n \n-\t/* The spec isn't clear about whether the FW will return an error code\n-\t * if the PFC mode requested by the driver was not set. The spec just\n-\t * says that the FW will write the PFC mode set back into cmd->pfc_mode,\n-\t * so after the AQ has been executed, check if cmd->pfc_mode is what was\n-\t * requested.\n+\t/* FW will write the PFC mode set back into cmd->pfc_mode, but if DCB is\n+\t * disabled, FW will write back 0 to cmd->pfc_mode. After the AQ has\n+\t * been executed, check if cmd->pfc_mode is what was requested. If not,\n+\t * return an error.\n \t */\n \tif (cmd->pfc_mode != pfc_mode)\n \t\treturn ICE_ERR_NOT_SUPPORTED;\n", "prefixes": [ "10/28" ] }