Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/96191/?format=api
{ "id": 96191, "url": "http://patches.dpdk.org/api/patches/96191/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210722074905.1838130-1-andrew.rybchenko@oktetlabs.ru/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210722074905.1838130-1-andrew.rybchenko@oktetlabs.ru>", "list_archive_url": "https://inbox.dpdk.org/dev/20210722074905.1838130-1-andrew.rybchenko@oktetlabs.ru", "date": "2021-07-22T07:49:05", "name": "[v2] net/sfc: fix broken build with clang 3.4.x", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3049ccfe67032fc24b032a9992bcea01c542474c", "submitter": { "id": 2013, "url": "http://patches.dpdk.org/api/people/2013/?format=api", "name": "Andrew Rybchenko", "email": "Andrew.Rybchenko@oktetlabs.ru" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210722074905.1838130-1-andrew.rybchenko@oktetlabs.ru/mbox/", "series": [ { "id": 17948, "url": "http://patches.dpdk.org/api/series/17948/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=17948", "date": "2021-07-22T07:49:05", "name": "[v2] net/sfc: fix broken build with clang 3.4.x", "version": 2, "mbox": "http://patches.dpdk.org/series/17948/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/96191/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/96191/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D531AA0C4E;\n\tThu, 22 Jul 2021 09:49:12 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7773F4014E;\n\tThu, 22 Jul 2021 09:49:12 +0200 (CEST)", "from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])\n by mails.dpdk.org (Postfix) with ESMTP id C6E634014D\n for <dev@dpdk.org>; Thu, 22 Jul 2021 09:49:10 +0200 (CEST)", "by shelob.oktetlabs.ru (Postfix, from userid 122)\n id 6C2177F596; Thu, 22 Jul 2021 10:49:10 +0300 (MSK)", "from aros.oktetlabs.ru (aros.oktetlabs.ru [192.168.38.17])\n by shelob.oktetlabs.ru (Postfix) with ESMTP id BFFAE7F52A;\n Thu, 22 Jul 2021 10:49:06 +0300 (MSK)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on shelob.oktetlabs.ru", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.8 required=5.0 tests=ALL_TRUSTED,\n DKIM_ADSP_DISCARD,\n URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2", "DKIM-Filter": "OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru BFFAE7F52A", "Authentication-Results": "shelob.oktetlabs.ru/BFFAE7F52A; dkim=none;\n dkim-atps=neutral", "From": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "To": "dev@dpdk.org", "Cc": "alialnu@nvidia.com, David Marchand <david.marchand@redhat.com>,\n Bruce Richardson <bruce.richardson@intel.com>", "Date": "Thu, 22 Jul 2021 10:49:05 +0300", "Message-Id": "<20210722074905.1838130-1-andrew.rybchenko@oktetlabs.ru>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210722074651.1837621-1-andrew.rybchenko@oktetlabs.ru>", "References": "<20210722074651.1837621-1-andrew.rybchenko@oktetlabs.ru>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2] net/sfc: fix broken build with clang 3.4.x", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Old clanng requires libatomic as well as gcc. Avoid compiler name and\nversion based checks. Add custom test for 16-byte atomic operations\nto find out if libatomic is required to build.\n\nFixes: 96fd2bd69b58 (\"net/sfc: support flow action count in transfer rules\")\nBugzilla ID: 760\n\nSigned-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>\n---\n drivers/net/sfc/meson.build | 22 +++++++++++++++-------\n 1 file changed, 15 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/sfc/meson.build b/drivers/net/sfc/meson.build\nindex 4625859077..a1ad792b80 100644\n--- a/drivers/net/sfc/meson.build\n+++ b/drivers/net/sfc/meson.build\n@@ -40,8 +40,20 @@ foreach flag: extra_flags\n endif\n endforeach\n \n-# for gcc compiles we need -latomic for 128-bit atomic ops\n-if cc.get_id() == 'gcc'\n+# for gcc and old Clang compiles we need -latomic for 128-bit atomic ops\n+atomic_check_code = '''\n+int main(void)\n+{\n+ __int128 a = 0;\n+ __int128 b;\n+\n+ b = __atomic_load_n(&a, __ATOMIC_RELAXED);\n+ __atomic_store(&b, &a, __ATOMIC_RELAXED);\n+ __atomic_store_n(&b, a, __ATOMIC_RELAXED);\n+ return 0;\n+}\n+'''\n+if not cc.links(atomic_check_code)\n libatomic_dep = cc.find_library('atomic', required: false)\n if not libatomic_dep.found()\n build = false\n@@ -51,11 +63,7 @@ if cc.get_id() == 'gcc'\n \n # libatomic could be half-installed when above check finds it but\n # linkage fails\n- atomic_link_code = '''\n- #include <stdio.h>\n- void main() { printf(\"libatomic link check\\n\"); }\n- '''\n- if not cc.links(atomic_link_code, dependencies: libatomic_dep)\n+ if not cc.links(atomic_check_code, dependencies: libatomic_dep)\n build = false\n reason = 'broken dependency, \"libatomic\"'\n subdir_done()\n", "prefixes": [ "v2" ] }