Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/95915/?format=api
{ "id": 95915, "url": "http://patches.dpdk.org/api/patches/95915/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210715164126.54073-10-shirik@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210715164126.54073-10-shirik@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210715164126.54073-10-shirik@nvidia.com", "date": "2021-07-15T16:41:19", "name": "[v8,09/16] crypto/mlx5: add keytag devarg", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "43ce6e80f8b310089b1b221e777dea723e87e8cb", "submitter": { "id": 1894, "url": "http://patches.dpdk.org/api/people/1894/?format=api", "name": "Shiri Kuzin", "email": "shirik@nvidia.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210715164126.54073-10-shirik@nvidia.com/mbox/", "series": [ { "id": 17843, "url": "http://patches.dpdk.org/api/series/17843/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=17843", "date": "2021-07-15T16:41:10", "name": "drivers: introduce mlx5 crypto PMD", "version": 8, "mbox": "http://patches.dpdk.org/series/17843/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/95915/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/95915/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C3C12A0C41;\n\tThu, 15 Jul 2021 18:43:10 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 744254131B;\n\tThu, 15 Jul 2021 18:42:25 +0200 (CEST)", "from NAM12-MW2-obe.outbound.protection.outlook.com\n (mail-mw2nam12on2069.outbound.protection.outlook.com [40.107.244.69])\n by mails.dpdk.org (Postfix) with ESMTP id 7685541327\n for <dev@dpdk.org>; Thu, 15 Jul 2021 18:42:20 +0200 (CEST)", "from MW4P221CA0003.NAMP221.PROD.OUTLOOK.COM (2603:10b6:303:8b::8) by\n MN2PR12MB3181.namprd12.prod.outlook.com (2603:10b6:208:ae::27) with\n Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.4308.23; Thu, 15 Jul 2021 16:42:18 +0000", "from CO1NAM11FT015.eop-nam11.prod.protection.outlook.com\n (2603:10b6:303:8b:cafe::fd) by MW4P221CA0003.outlook.office365.com\n (2603:10b6:303:8b::8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.22 via Frontend\n Transport; Thu, 15 Jul 2021 16:42:18 +0000", "from mail.nvidia.com (216.228.112.34) by\n CO1NAM11FT015.mail.protection.outlook.com (10.13.175.130) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4331.21 via Frontend Transport; Thu, 15 Jul 2021 16:42:18 +0000", "from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com\n (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 15 Jul\n 2021 16:42:14 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=LSUlP4GRYDeySIkVlhAz/wE3ByA7C6XvNQR+a77n9wJ7XdS3BYPQ09aadceHqwdSVkhmUKVGBDdq6VwLNIx9soeU9P0xES4VPK8Zr0Qbbuw4XJx4XHzAH+mFTY68ETS99sj2jGxVxNaEiZ1JghXMFc9f42LMZ8pq8I2QXS4CYn0oclsSecl1gnEo2V7JvT50gOzPqfKLNGct6n4oSxx/I+Ej9B4Hcb1DfFdMJatquIfVWB/0wnYc3J+WjNZQsFg+Dnw9m4pPx671DTzjTeuhd5e/rDB8d9ZawXYc3kWtPKxIyXKQ8RBHsmLOiBpjAQ4xzwQRX+zsmKaLkvByqi0R5Q==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=hZvn5bJ7Rk2g3jDa4qj0jnYqDhatdzrXjwl3ex3sXeI=;\n b=XwuPPLGvzJ/uZClI49Bp/BxLyvDL6K3H3EvcZIR7ReRbM4uG+Bywf0YLncbCmOy5VXRkWWygh03iCtyzdN9lg8KcYa8ApVGBQzpFe4SVoTfSwwzSUxT6lB6Drj1q72WbkveW/vHFttij6lo3uEjDR5/954i8zCowIBPcxJzOUO9J7WJ8AZhFM9lv1SXSxjk6DJbMwb46Omyr1RYHjyFOSNr/7kqfE4vXyD5tF0HY6kVz7Ew7/Rt4ZZs49HznbljHUmENkoMG4zhjHQKmBNC532LSHZS4ij7GhVvybaHvBQ4ExQyby40hVh8vgNxT4qf3LBOqVsyFJ9ahRXZvPISvMg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.34) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com;\n dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=hZvn5bJ7Rk2g3jDa4qj0jnYqDhatdzrXjwl3ex3sXeI=;\n b=Z+hrBobhwVip8Xfr/MyNrTisweWNx/DCFalK/yLshjQACKE9ScU1xamQAH+GMBhMaDsDfkoKGQk5hgGcpNybehZFIo9QxqQlzm4Ja6GGjyVDJ4zAQ8HmM9xAPeRt5ShgxMlkeUCRr1GYZpDXQCeZAZKox17j1q8rVtFs7NRlIg4VuhP6LdO21QMGyYWeA//VsQWjvd15wo8sGJO+pwGEkB2DLjbu9up/nnKNxOO22UAHWkOPFDGcGGJQy5DotBzBFNK8X2qXEU+60SuJJc0Be1hOAcOE7L9hphMG5j9V1oFAV89uR8tuXTTtBfgc1vmGOIVKCygahGxRjz8Nhp/NSg==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.34)\n smtp.mailfrom=nvidia.com; redhat.com; dkim=none (message not signed)\n header.d=none;redhat.com; dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.34 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.34; helo=mail.nvidia.com;", "From": "Shiri Kuzin <shirik@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "<matan@nvidia.com>, <gakhil@marvell.com>, <suanmingm@nvidia.com>,\n <david.marchand@redhat.com>", "Date": "Thu, 15 Jul 2021 19:41:19 +0300", "Message-ID": "<20210715164126.54073-10-shirik@nvidia.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210715164126.54073-1-shirik@nvidia.com>", "References": "<20210715150817.51485-1-shirik@nvidia.com>\n <20210715164126.54073-1-shirik@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[172.20.187.6]", "X-ClientProxiedBy": "HQMAIL105.nvidia.com (172.20.187.12) To\n HQMAIL107.nvidia.com (172.20.187.13)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "83bd2239-0260-46f8-c537-08d947af8285", "X-MS-TrafficTypeDiagnostic": "MN2PR12MB3181:", "X-Microsoft-Antispam-PRVS": "\n <MN2PR12MB3181A3DEEA256B982DBE405CAA129@MN2PR12MB3181.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:139;", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n vq+aJdRBax5D9ogLFkeJLqWHu9jwVmFtGTi3cxbX67a8Lo6xYr3DL/Fm/eEisPqpuOtxUzIxI8aEEbmJ9vnOnbWT72vYKCvQ39NNgaepYXU1YRj9m5v42OPn8p0KQK32PxCuu/szm6T4BDcBeAL7MMhkqX/PE8Yry6UC4Mz0lvPZ54QIJj76/obrQbV2qExKEe0puIk4+36dYyD+FOQ5RAmZAPjMHbR44zHf9np7wfJ8hUg2jyQrYHVEkg+e+2K0AdqWL/Rwdn+t9yYJO9w8sbMkJfjXg2r+VvvOiFLQokJTNR9SAnFBfgWXojCw2+22PlGuEMiqmytFEnDyyQXQ128noFfBvQYKyLpQ9YI4MBc5pMjeQa0E+EgaO7HGG9hCW2W5hRCgSS7VvXgwQyt95bEms4BDxYlh3e4t1+QwF88h0Y6wzV1SYmxoRQMlvCxYZtbcrDLHBjqmpaIO7FUb8/R8oNyFjRoaUjK8IEwidY5kYTOkJnjqJKfwrAimwVtMIJOC4a5c8hR3RXZlVxGFekpP+jdFgLycQ6drHOq8F8Hxzsh9leaMXNRlmpotcxWntBs2wd3jPFeISvbpwhCUio1hYIDqNvQOS1T4TWewHhqlJZG5LFdR1dtjNedsR1uUFBA+CGBy+o51oiJtwVKz5kpLUIJBKLHTC7dpPKC4hQ3iTnVo6307EqN1BNAV+EJmyBgC6Rj+kjBJ8tn2gLoDAe67Xxwe4Ik68qXHuUwqgM8=", "X-Forefront-Antispam-Report": "CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE;\n SFS:(4636009)(396003)(346002)(39860400002)(136003)(376002)(46966006)(36840700001)(82310400003)(86362001)(2616005)(26005)(36860700001)(426003)(6916009)(356005)(54906003)(478600001)(7636003)(34020700004)(82740400003)(316002)(55016002)(8676002)(47076005)(70586007)(186003)(1076003)(4326008)(70206006)(2906002)(36756003)(36906005)(16526019)(83380400001)(7696005)(336012)(5660300002)(6286002)(8936002);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "15 Jul 2021 16:42:18.2700 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 83bd2239-0260-46f8-c537-08d947af8285", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CO1NAM11FT015.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MN2PR12MB3181", "Subject": "[dpdk-dev] [PATCH v8 09/16] crypto/mlx5: add keytag devarg", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Suanming Mou <suanmingm@nvidia.com>\n\nA keytag is a piece of data encrypted together with a DEK.\n\nWhen a DEK is referenced by an MKEY.bsf through its index, the keytag is\nalso supplied in the BSF as plaintext. The HW will decrypt the DEK (and\nthe attached keytag) and will fail the operation if the keytags don't\nmatch.\n\nThis commit adds the configuration of the keytag with devargs.\n\nSigned-off-by: Suanming Mou <suanmingm@nvidia.com>\nSigned-off-by: Matan Azrad <matan@nvidia.com>\n---\n doc/guides/cryptodevs/mlx5.rst | 7 +++++\n drivers/crypto/mlx5/mlx5_crypto.c | 50 +++++++++++++++++--------------\n drivers/crypto/mlx5/mlx5_crypto.h | 3 +-\n 3 files changed, 37 insertions(+), 23 deletions(-)", "diff": "diff --git a/doc/guides/cryptodevs/mlx5.rst b/doc/guides/cryptodevs/mlx5.rst\nindex 6cae5affbd..c3632484a5 100644\n--- a/doc/guides/cryptodevs/mlx5.rst\n+++ b/doc/guides/cryptodevs/mlx5.rst\n@@ -52,6 +52,9 @@ wrapping.\n The credential and the AES-XTS keys should be provided to the hardware, as ciphertext\n encrypted by the KEK.\n \n+A keytag (64 bits) should be appended to the AES-XTS keys (before wrapping),\n+and will be validated when the hardware attempts to access it.\n+\n When crypto engines are defined to work in wrapped import method, they come out\n of the factory in Commissioning mode, and thus, cannot be used for crypto operations\n yet. A dedicated tool is used for changing the mode from Commissioning to\n@@ -113,6 +116,10 @@ Driver options\n The identifier of the credential, default value is 0 represents the operational\n register credential.\n \n+- ``keytag`` parameter [int]\n+\n+ The plaintext of the keytag appanded to the AES-XTS keys, default value is 0.\n+\n \n Supported NICs\n --------------\ndiff --git a/drivers/crypto/mlx5/mlx5_crypto.c b/drivers/crypto/mlx5/mlx5_crypto.c\nindex cbaa2e52ff..0f786ac4ca 100644\n--- a/drivers/crypto/mlx5/mlx5_crypto.c\n+++ b/drivers/crypto/mlx5/mlx5_crypto.c\n@@ -500,56 +500,52 @@ mlx5_crypto_args_check_handler(const char *key, const char *val, void *opaque)\n \t\tattr->session_import_kek_ptr = (uint32_t)tmp;\n \telse if (strcmp(key, \"credential_id\") == 0)\n \t\tattr->credential_pointer = (uint32_t)tmp;\n+\telse if (strcmp(key, \"keytag\") == 0)\n+\t\tdevarg_prms->keytag = tmp;\n \telse\n \t\tDRV_LOG(WARNING, \"Invalid key %s.\", key);\n \treturn 0;\n }\n \n-static struct mlx5_devx_obj *\n-mlx5_crypto_config_login(struct rte_devargs *devargs,\n-\t\t\t struct ibv_context *ctx)\n+static int\n+mlx5_crypto_parse_devargs(struct rte_devargs *devargs,\n+\t\t\t struct mlx5_crypto_devarg_params *devarg_prms)\n {\n-\t/*\n-\t * Set credential pointer and session import KEK pointer to a default\n-\t * value of 0.\n-\t */\n-\tstruct mlx5_crypto_devarg_params login = {\n-\t\t\t.login_devarg = false,\n-\t\t\t.login_attr = {\n-\t\t\t\t\t.credential_pointer = 0,\n-\t\t\t\t\t.session_import_kek_ptr = 0,\n-\t\t\t}\n-\t};\n+\tstruct mlx5_devx_crypto_login_attr *attr = &devarg_prms->login_attr;\n \tstruct rte_kvargs *kvlist;\n \n+\t/* Default values. */\n+\tattr->credential_pointer = 0;\n+\tattr->session_import_kek_ptr = 0;\n+\tdevarg_prms->keytag = 0;\n \tif (devargs == NULL) {\n \t\tDRV_LOG(ERR,\n \t\"No login devargs in order to enable crypto operations in the device.\");\n \t\trte_errno = EINVAL;\n-\t\treturn NULL;\n+\t\treturn -1;\n \t}\n \tkvlist = rte_kvargs_parse(devargs->args, NULL);\n \tif (kvlist == NULL) {\n \t\tDRV_LOG(ERR, \"Failed to parse devargs.\");\n \t\trte_errno = EINVAL;\n-\t\treturn NULL;\n+\t\treturn -1;\n \t}\n \tif (rte_kvargs_process(kvlist, NULL, mlx5_crypto_args_check_handler,\n-\t\t\t &login) != 0) {\n+\t\t\t devarg_prms) != 0) {\n \t\tDRV_LOG(ERR, \"Devargs handler function Failed.\");\n \t\trte_kvargs_free(kvlist);\n \t\trte_errno = EINVAL;\n-\t\treturn NULL;\n+\t\treturn -1;\n \t}\n \trte_kvargs_free(kvlist);\n-\tif (login.login_devarg == false) {\n+\tif (devarg_prms->login_devarg == false) {\n \t\tDRV_LOG(ERR,\n \t\"No login credential devarg in order to enable crypto operations \"\n \t\"in the device.\");\n \t\trte_errno = EINVAL;\n-\t\treturn NULL;\n+\t\treturn -1;\n \t}\n-\treturn mlx5_devx_cmd_create_crypto_login_obj(ctx, &login.login_attr);\n+\treturn 0;\n }\n \n /**\n@@ -609,6 +605,7 @@ mlx5_crypto_pci_probe(struct rte_pci_driver *pci_drv,\n \tstruct ibv_context *ctx;\n \tstruct mlx5_devx_obj *login;\n \tstruct mlx5_crypto_priv *priv;\n+\tstruct mlx5_crypto_devarg_params devarg_prms = { 0 };\n \tstruct mlx5_hca_attr attr = { 0 };\n \tstruct rte_cryptodev_pmd_init_params init_params = {\n \t\t.name = \"\",\n@@ -617,6 +614,8 @@ mlx5_crypto_pci_probe(struct rte_pci_driver *pci_drv,\n \t\t.max_nb_queue_pairs =\n \t\t\t\tRTE_CRYPTODEV_PMD_DEFAULT_MAX_NB_QUEUE_PAIRS,\n \t};\n+\tint ret;\n+\n \tRTE_SET_USED(pci_drv);\n \tif (rte_eal_process_type() != RTE_PROC_PRIMARY) {\n \t\tDRV_LOG(ERR, \"Non-primary process type is not supported.\");\n@@ -646,7 +645,13 @@ mlx5_crypto_pci_probe(struct rte_pci_driver *pci_drv,\n \t\trte_errno = ENOTSUP;\n \t\treturn -ENOTSUP;\n \t}\n-\tlogin = mlx5_crypto_config_login(pci_dev->device.devargs, ctx);\n+\tret = mlx5_crypto_parse_devargs(pci_dev->device.devargs, &devarg_prms);\n+\tif (ret) {\n+\t\tDRV_LOG(ERR, \"Failed to parse devargs.\");\n+\t\treturn -rte_errno;\n+\t}\n+\tlogin = mlx5_devx_cmd_create_crypto_login_obj(ctx,\n+\t\t\t\t\t\t &devarg_prms.login_attr);\n \tif (login == NULL) {\n \t\tDRV_LOG(ERR, \"Failed to configure login.\");\n \t\treturn -rte_errno;\n@@ -686,6 +691,7 @@ mlx5_crypto_pci_probe(struct rte_pci_driver *pci_drv,\n \t}\n \tpriv->mr_scache.reg_mr_cb = mlx5_common_verbs_reg_mr;\n \tpriv->mr_scache.dereg_mr_cb = mlx5_common_verbs_dereg_mr;\n+\tpriv->keytag = rte_cpu_to_be_64(devarg_prms.keytag);\n \t/* Register callback function for global shared MR cache management. */\n \tif (TAILQ_EMPTY(&mlx5_crypto_priv_list))\n \t\trte_mem_event_callback_register(\"MLX5_MEM_EVENT_CB\",\ndiff --git a/drivers/crypto/mlx5/mlx5_crypto.h b/drivers/crypto/mlx5/mlx5_crypto.h\nindex b98c621c23..d374d3c4e9 100644\n--- a/drivers/crypto/mlx5/mlx5_crypto.h\n+++ b/drivers/crypto/mlx5/mlx5_crypto.h\n@@ -30,6 +30,7 @@ struct mlx5_crypto_priv {\n \tstruct rte_cryptodev_config dev_config;\n \tstruct mlx5_mr_share_cache mr_scache; /* Global shared MR cache. */\n \tstruct mlx5_devx_obj *login_obj;\n+\tuint64_t keytag;\n };\n \n struct mlx5_crypto_qp {\n@@ -49,10 +50,10 @@ struct mlx5_crypto_dek {\n \tbool size_is_48; /* Whether the key\\data size is 48 bytes or not. */\n } __rte_cache_aligned;\n \n-\n struct mlx5_crypto_devarg_params {\n \tbool login_devarg;\n \tstruct mlx5_devx_crypto_login_attr login_attr;\n+\tuint64_t keytag;\n };\n \n int\n", "prefixes": [ "v8", "09/16" ] }