Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 95711,
    "url": "http://patches.dpdk.org/api/patches/95711/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210712181833.15293-2-cristian.dumitrescu@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20210712181833.15293-2-cristian.dumitrescu@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20210712181833.15293-2-cristian.dumitrescu@intel.com",
    "date": "2021-07-12T18:18:33",
    "name": "[2/2] examples/pipeline: fix incorrect array out of bounds check",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "d89a19beb85ac36ae5eefb77e09be8d542f1df0c",
    "submitter": {
        "id": 19,
        "url": "http://patches.dpdk.org/api/people/19/?format=api",
        "name": "Cristian Dumitrescu",
        "email": "cristian.dumitrescu@intel.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210712181833.15293-2-cristian.dumitrescu@intel.com/mbox/",
    "series": [
        {
            "id": 17777,
            "url": "http://patches.dpdk.org/api/series/17777/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=17777",
            "date": "2021-07-12T18:18:32",
            "name": "[1/2] pipeline: fix incorrect resource free function",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/17777/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/95711/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/95711/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2B760A0C4E;\n\tMon, 12 Jul 2021 20:18:47 +0200 (CEST)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id DF83E411B4;\n\tMon, 12 Jul 2021 20:18:42 +0200 (CEST)",
            "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by mails.dpdk.org (Postfix) with ESMTP id D80794069D\n for <dev@dpdk.org>; Mon, 12 Jul 2021 20:18:40 +0200 (CEST)",
            "from fmsmga004.fm.intel.com ([10.253.24.48])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 12 Jul 2021 11:18:36 -0700",
            "from silpixa00400573.ir.intel.com (HELO\n silpixa00400573.ger.corp.intel.com) ([10.237.223.107])\n by fmsmga004.fm.intel.com with ESMTP; 12 Jul 2021 11:18:36 -0700"
        ],
        "X-IronPort-AV": [
            "E=McAfee;i=\"6200,9189,10043\"; a=\"190412570\"",
            "E=Sophos;i=\"5.84,234,1620716400\"; d=\"scan'208\";a=\"190412570\"",
            "E=Sophos;i=\"5.84,234,1620716400\"; d=\"scan'208\";a=\"486739491\""
        ],
        "X-ExtLoop1": "1",
        "From": "Cristian Dumitrescu <cristian.dumitrescu@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Mon, 12 Jul 2021 19:18:33 +0100",
        "Message-Id": "<20210712181833.15293-2-cristian.dumitrescu@intel.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "In-Reply-To": "<20210712181833.15293-1-cristian.dumitrescu@intel.com>",
        "References": "<20210712181833.15293-1-cristian.dumitrescu@intel.com>",
        "Subject": "[dpdk-dev] [PATCH 2/2] examples/pipeline: fix incorrect array out\n of bounds check",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Fix the incorrect array out of bounds check within the function\npipeline_selector_group_member_read().\n\nCoverity issue: 371911\nFixes: 598fe0dd0d8e3 (\"examples/pipeline: support selector table\")\n\nSigned-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>\n---\n examples/pipeline/cli.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)",
    "diff": "diff --git a/examples/pipeline/cli.c b/examples/pipeline/cli.c\nindex f67783c8fa..a29be05ef4 100644\n--- a/examples/pipeline/cli.c\n+++ b/examples/pipeline/cli.c\n@@ -1511,7 +1511,7 @@ pipeline_selector_group_member_read(const char *string,\n \t\tif (!token || token_is_comment(token))\n \t\t\tbreak;\n \n-\t\tif (n_tokens > GROUP_MEMBER_INFO_TOKENS_MAX)\n+\t\tif (n_tokens >= GROUP_MEMBER_INFO_TOKENS_MAX)\n \t\t\tgoto error;\n \n \t\ttoken_array[n_tokens] = token;\n",
    "prefixes": [
        "2/2"
    ]
}